New Review Requests feature
Hello, I just upgraded from 1.7 to 2.0.5, and I like the updates a lot. One feature I was already hoping for for quite a while was the automatic generation of review requests directly from a repository, and that works quite well. I would like to see some additions to this feature, to make it even more useful. We are using post-commit review, and we are also encouraging people to check-in often. This means that or reviews often span a number of check-ins. Would it be possible to have people select two revisions, and have the diff between these two? For example by adding a checkbox in front of the check-ins so people can select 2 versions that they would like to generate a review of, and not only of the selected version with the previous one. Another feature would be to have a file-selection, where you can select which files should be part of the review and which should be ignored, for example configuration files or project files can be ignored. This can also be useful if you upload a diff file. Until now I am always manually updating the diff files before uploading, removing the files I do not need from the diff file. Thank you for this great tool! Regards, Johan Borkhuis -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: New user of review board here, I'm having trouble attaching diffs
I just found out that we don't have a local clone on the Reviewboard server. The diff is being created from comparing the branch to my master. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Issue Migrating Database from 1.5.5 to 2.0.5 (model updates fail)
I'm trying to rb-site upgrade an old 1.5.5 database to 2.0.5.
*This fails with:*
Rebuilding directory structure
Updating database. This may take a while.
The log output below, including warnings and errors,
can be ignored unless upgrade fails.
-- begin log output --
Creating tables ...
There are unapplied evolutions for auth.
There are unapplied evolutions for contenttypes.
There are unapplied evolutions for sessions.
There are unapplied evolutions for accounts.
There are unapplied evolutions for changedescs.
There are unapplied evolutions for diffviewer.
There are unapplied evolutions for reviews.
There are unapplied evolutions for scmtools.
Project signature has changed - an evolution is required
Installing custom SQL ...
Installing indexes ...
Installed 0 object(s) from 0 fixture(s)
The stored evolutions do not completely resolve all model changes.
Run `./manage.py evolve --hint` to see a suggestion for the changes
required.
The following are the changes that could not be resolved:
The application markup has been deleted
In model reviews.DefaultReviewer:
In field 'repository':
Property 'null' has changed
In model reviews.ReviewRequest:
In field 'repository':
Property 'null' has changed
CommandError: Your models contain changes that Django Evolution cannot
resolve automatically.
*The suggested --hint's are:*
#- Evolution for auth
from django_evolution.mutations import ChangeMeta, DeleteModel
MUTATIONS = [
ChangeMeta('Permission', 'unique_together', ((u'content_type',
u'codename'),)),
DeleteModel('Message')
]
#--
#- Evolution for contenttypes
from django_evolution.mutations import ChangeMeta
MUTATIONS = [
ChangeMeta('ContentType', 'unique_together', (('app_label', 'model'),))
]
#--
#- Evolution for sessions
from django_evolution.mutations import ChangeField
MUTATIONS = [
ChangeField('Session', 'expire_date', initial=None, db_index=True)
]
#--
#- Evolution for accounts
from django_evolution.mutations import AddField, ChangeMeta, DeleteField
from django.db import models
from djblets.db.fields import JSONField
MUTATIONS = [
AddField('Profile', 'should_send_email', models.BooleanField,
initial=True),
AddField('Profile', 'timezone', models.CharField, initial=u'UTC',
max_length=30),
AddField('Profile', 'open_an_issue', models.BooleanField, initial=True),
AddField('Profile', 'extra_data', JSONField, null=True),
AddField('Profile', 'show_closed', models.BooleanField, initial=True),
AddField('Profile', 'is_private', models.BooleanField, initial=False),
DeleteField('Profile', 'show_submitted'),
ChangeMeta('ReviewRequestVisit', 'unique_together', ((u'user',
u'review_request'),))
]
#--
#- Evolution for changedescs
from django_evolution.mutations import AddField
from django.db import models
MUTATIONS = [
AddField('ChangeDescription', 'rich_text', models.BooleanField,
initial=True)
]
#--
CommandError: Cannot use hinted evolution: AddField or ChangeField mutation
for 'FileDiff.status' in 'diffviewer' requires user-specified initial value.
*The completed evolutions are:*
reviewboard= select * from django_evolution;
id | version_id | app_label |label
++-+-
1 | 4 | diffviewer | add_parent_diffs
2 | 4 | reviews | change_descriptions
3 | 4 | scmtools| bugzilla_url_charfield
4 | 5 | attachments | file_attachment_orig_filename
5 | 5 | attachments | file_attachment_file_max_length_512
6 | 5 | attachments | file_attachment_repo_info
7 | 5 | attachments | file_attachment_repo_path_no_index
8 | 5 | attachments | file_attachment_repo_revision_max_length_64
9 | 5 | site| localsite_public
10 | 5 | hostingsvcs | account_hosting_url
11 | 5 | hostingsvcs | account_hosting_url_max_length_255
12 | 5 | hostingsvcs | account_unique_together_baseline
(12 rows)
reviewboard= \d django_evolution
Table public.django_evolution
Column | Type | Modifiers
++---
id | integer| not null default
nextval('django_evolution_id_seq'::regclass)
version_id | integer| not null
app_label | character varying(200) | not null
label | character varying(100) | not null
Indexes:
django_evolution_pkey PRIMARY KEY, btree (id)
django_evolution_version_id btree (version_id)
Foreign-key constraints:
django_evolution_version_id_fkey FOREIGN KEY (version_id) REFERENCES
django_project_version(id) DEFERRABLE INITIALLY DEFERRED
reviewboard=
*...
Re: Issue Migrating Database from 1.5.5 to 2.0.5 (model updates fail)
Hmm, that shouldn’t be happening. Can you run this and show me what you see:
$ rb-site manage /path/to/site list-evolutions
Also, can you dump the schema of your database and attach it?
- Christian
--
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com
On August 15, 2014 at 12:11:45 PM, Zach (zach...@gmail.com) wrote:
I'm trying to rb-site upgrade an old 1.5.5 database to 2.0.5.
This fails with:
Rebuilding directory structure
Updating database. This may take a while.
The log output below, including warnings and errors,
can be ignored unless upgrade fails.
-- begin log output --
Creating tables ...
There are unapplied evolutions for auth.
There are unapplied evolutions for contenttypes.
There are unapplied evolutions for sessions.
There are unapplied evolutions for accounts.
There are unapplied evolutions for changedescs.
There are unapplied evolutions for diffviewer.
There are unapplied evolutions for reviews.
There are unapplied evolutions for scmtools.
Project signature has changed - an evolution is required
Installing custom SQL ...
Installing indexes ...
Installed 0 object(s) from 0 fixture(s)
The stored evolutions do not completely resolve all model changes.
Run `./manage.py evolve --hint` to see a suggestion for the changes required.
The following are the changes that could not be resolved:
The application markup has been deleted
In model reviews.DefaultReviewer:
In field 'repository':
Property 'null' has changed
In model reviews.ReviewRequest:
In field 'repository':
Property 'null' has changed
CommandError: Your models contain changes that Django Evolution cannot resolve
automatically.
The suggested --hint's are:
#- Evolution for auth
from django_evolution.mutations import ChangeMeta, DeleteModel
MUTATIONS = [
ChangeMeta('Permission', 'unique_together', ((u'content_type',
u'codename'),)),
DeleteModel('Message')
]
#--
#- Evolution for contenttypes
from django_evolution.mutations import ChangeMeta
MUTATIONS = [
ChangeMeta('ContentType', 'unique_together', (('app_label', 'model'),))
]
#--
#- Evolution for sessions
from django_evolution.mutations import ChangeField
MUTATIONS = [
ChangeField('Session', 'expire_date', initial=None, db_index=True)
]
#--
#- Evolution for accounts
from django_evolution.mutations import AddField, ChangeMeta, DeleteField
from django.db import models
from djblets.db.fields import JSONField
MUTATIONS = [
AddField('Profile', 'should_send_email', models.BooleanField, initial=True),
AddField('Profile', 'timezone', models.CharField, initial=u'UTC',
max_length=30),
AddField('Profile', 'open_an_issue', models.BooleanField, initial=True),
AddField('Profile', 'extra_data', JSONField, null=True),
AddField('Profile', 'show_closed', models.BooleanField, initial=True),
AddField('Profile', 'is_private', models.BooleanField, initial=False),
DeleteField('Profile', 'show_submitted'),
ChangeMeta('ReviewRequestVisit', 'unique_together', ((u'user',
u'review_request'),))
]
#--
#- Evolution for changedescs
from django_evolution.mutations import AddField
from django.db import models
MUTATIONS = [
AddField('ChangeDescription', 'rich_text', models.BooleanField,
initial=True)
]
#--
CommandError: Cannot use hinted evolution: AddField or ChangeField mutation for
'FileDiff.status' in 'diffviewer' requires user-specified initial value.
The completed evolutions are:
reviewboard= select * from django_evolution;
id | version_id | app_label | label
++-+-
1 | 4 | diffviewer | add_parent_diffs
2 | 4 | reviews | change_descriptions
3 | 4 | scmtools | bugzilla_url_charfield
4 | 5 | attachments | file_attachment_orig_filename
5 | 5 | attachments | file_attachment_file_max_length_512
6 | 5 | attachments | file_attachment_repo_info
7 | 5 | attachments | file_attachment_repo_path_no_index
8 | 5 | attachments | file_attachment_repo_revision_max_length_64
9 | 5 | site | localsite_public
10 | 5 | hostingsvcs | account_hosting_url
11 | 5 | hostingsvcs | account_hosting_url_max_length_255
12 | 5 | hostingsvcs | account_unique_together_baseline
(12 rows)
reviewboard= \d django_evolution
Table public.django_evolution
Column | Type | Modifiers
++---
id | integer | not null default
nextval('django_evolution_id_seq'::regclass)
version_id | integer
Re: New user of review board here, I'm having trouble attaching diffs
Can you get more information on how the repository is configured on Review Board? The error makes it appear as if it’s using a clone. For your local setup, can you answer the following: 1) Does ‘origin’ point to your central server? `git remote show origin` 2) Are you developing off of master as a parent, or another branch? 3) Is origin/master (or whatever the upstream branch is) merged into your development branch? Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On August 15, 2014 at 6:33:02 AM, Usama Ahmed (usama.ahme...@gmail.com) wrote: I just found out that we don't have a local clone on the Reviewboard server. The diff is being created from comparing the branch to my master. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: New user of review board here, I'm having trouble attaching diffs
1) Yes, origin points to my central server. 'http://vm:8080' 2) I am developing on a child branch of my master 3) Previously, upon finishing work in a branch I would commit to it and then merge it straightaway into master. I wasn't doing the reverse -- merging master into the development branch. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: New user of review board here, I'm having trouble attaching diffs
In response to your question about the set-up of the repository, I was told that a repository is not configured on Reviewboard. My clone of the central repository is on my computer. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Issue 2980 in reviewboard: Diff viewer has problems with control characters
Comment #3 on issue 2980 by bart...@gmail.com: Diff viewer has problems with control characters http://code.google.com/p/reviewboard/issues/detail?id=2980 The cause is that splitlines() behaves differently for unicode vs regular strings. For unicode, it considers form-feed a line breaking character and splits on that. But for regular strings it does not. For example: 41 zara:~/ python -c 'print A\n\f\nB\n.splitlines()' ['A', '\x0c', 'B'] # good 42 zara:~/ python -c 'print uA\n\f\nB\n.splitlines()' [u'A', u'', u'', u'B'] # ate \f and added extra empty elem References: http://bugs.python.org/issue12855 http://stackoverflow.com/questions/24453713/python-string-splitlines-removes-certain-unicode-control-characters This means the lines will be off by the number of ^L chars above it in the diff and won't match the diff. The diff ends up getting stored in the DB w/o the ^L chars. Sometimes it won't patch, and sometimes it does but renders incorrectly. There are a few places where splitlines() is used on the diff. As an experiment I modified DiffParser, DiffChunkGenerator, TextBasedReviewUI, and filter_interdiff_opcodes to use a hacked splitlines() routine that first swaps ^L with NUL, splits, then swaps back and that makes things work (attached). Not sure that is the best strategy, but it ends up being a simple change. A similar approach would be to cons together a random number or UUID along with reviewboard and use that as the swap string, or use some other non-printable. It would be nice to see this fixed, but I'm aware that the group of Lisp-influenced Emacs-lovers who employ ^L in this manner might not be a growing population. However, if the RB developers think this is worth persuing I can spend more time on a fix. Attachments: 0001-diffviewer-handle-L-characters-in-diffs.patch 4.6 KB -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3528 in reviewboard: UnicodeDecodeError while LDAP-authenticating
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 3528 by egilwi...@gmail.com: UnicodeDecodeError while
LDAP-authenticating
http://code.google.com/p/reviewboard/issues/detail?id=3528
What version are you running?
ReviewBoard 2.0.5
What's the URL of the page containing the problem?
/account/login/
What steps will reproduce the problem?
1. Set up new RB using LDAP-authentication, using Full Name Attribute
= displayName.
2. Try to log in for the first time as a user with displayName
containing, for example, ö (0xC3 0xB6)
3. Log in fails.
What is the expected output? What do you see instead?
Expected successful login.
Seeing (in Apache error.log):
An error while LDAP-authenticating: UnicodeDecodeError('ascii', 'Tobias
Emitsl\\xc3\\xb6f', 13, 14, 'ordinal not in range(128)')
What operating system are you using? What browser?
Server: Debian GNU/Linux (wheezy), Apache Prefork, mod_wsgi, python2.7.
Client/Browser: Windows 7, Chrome
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
Issue 3529 in reviewboard: Incorrect escaping sequence with markdown
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3529 by philippe...@gmail.com: Incorrect escaping sequence with markdown http://code.google.com/p/reviewboard/issues/detail?id=3529 What version are you running? 2.0.5 What's the URL of the page containing the problem? http://rb.freedroid.org/r/1942/ What steps will reproduce the problem? 1. Write a review with *\*text\** 2. The markdown are not correctly handled 3. Display \text** What is the expected output? What do you see instead? *text* in italic What operating system are you using? What browser? Version 34.0.1847.116 Ubuntu 12.04 (260972) Please provide any additional information below. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3530 in reviewboard: Allow user to select 2 SVN revisions of which to create a review
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 3530 by borkh...@gmail.com: Allow user to select 2 SVN revisions of which to create a review http://code.google.com/p/reviewboard/issues/detail?id=3530 What version are you running? 2.0.5 What's the URL of the page this enhancement relates to, if any? http://../r/new/ Describe the enhancement and the motivation for it. We are using post-commit review, and we are also encouraging people to check-in often. This means that or reviews often span a number of check-ins. It would be nice to have the option to create a review based on changes of multiple checkins instead of only one. For example by adding a check-box in front of the check-ins so people can select 2 versions that they would like to generate a review of, and not only of the selected version with the previous one. What operating system are you using? What browser? RB: Debian, browser: any Please provide any additional information below. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3531 in reviewboard: Select which files in a diff should be reviewed
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 3531 by borkh...@gmail.com: Select which files in a diff should be reviewed http://code.google.com/p/reviewboard/issues/detail?id=3531 What version are you running? 2.0.5 What's the URL of the page this enhancement relates to, if any? http://../r/new/ Describe the enhancement and the motivation for it. Something that would be nice is to be able to select the files that are part of the review after uploading or generating a diff. When generating a diff all files are part of that diff, including project files and configuration files that do not need to be reviewed. It would be nice to be able to select the files that should be reviewed after a diff is uploaded or created, so the size of the review is reduced and unneeded files are not reviewed. What operating system are you using? What browser? RB: Debian Please provide any additional information below. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3521 in reviewboard: RBTools Python API - can't pass interdiff_revision in /api/review-requests/{review_request_id}/diff-context/
Updates:
Labels: Project-RBTools Component-RBTools
Comment #1 on issue 3521 by trowb...@gmail.com: RBTools Python API - can't
pass interdiff_revision in
/api/review-requests/{review_request_id}/diff-context/
http://code.google.com/p/reviewboard/issues/detail?id=3521
(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
Issue 3532 in reviewboard: Linking to a collapsed review does not expand the review
Status: Accepted Owner: Labels: Type-Defect Priority-Medium EasyFix Component-Reviews New issue 3532 by ste...@smacleod.ca: Linking to a collapsed review does not expand the review http://code.google.com/p/reviewboard/issues/detail?id=3532 What version are you running? 2.1alpha0 What's the URL of the page containing the problem? https://reviews.reviewboard.org/r/6106/#review11755 What steps will reproduce the problem? 1. Open the link to a collapsed review ( https://reviews.reviewboard.org/r/6106/#review11755 ) What is the expected output? What do you see instead? The linked review should automatically expand. Currently if the review is loaded as collapsed by default (due to having been read, or updates to the review request existing after it) it will stay collapsed even when being linked to directly. Please provide any additional information below. This problem was previously fixed when linking to issues inside collapsed reviews, so investigating the fix used in that case would be highly informative. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3532 in reviewboard: Linking to a collapsed review does not expand the review
Updates: Status: Confirmed Comment #1 on issue 3532 by trowb...@gmail.com: Linking to a collapsed review does not expand the review http://code.google.com/p/reviewboard/issues/detail?id=3532 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
