Re: RBTools: Is this a bug in the way 'rbt --username' handles authentication?
Hi Steve, This does seem to be a bug. I think it's worth filing a bug report. Thanks for pointing it out! :) - Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Tue, Apr 28, 2015 at 4:07 PM, Steve seide.al...@gmail.com wrote: I'm testing out RB 2.0.15 RBTools 0.7.2 and I've noticed something about how the --username option is handled that I think is a bug, but I wanted to run it by you all before filing a bug report. What I've found is that when I do rbt post --username me 1234 I always get prompted for a password. If I already have a valid cookie in .rbtools-cookies file, then I can type anything and the review will go through. If however I delete my .rbtools-cookie file, try again then the authentication is done correctly. Does that make sense? It seems somehow wrong to me. This example may make it clearer. $ rm ~/.rbtools-cookies $ rbt post --username sallan 824 Please log in to the Review Board server at localhost. Password: *bogus_password* ERROR: Unexpected API Error: The username or password was not correct (HTTP 401, API Error 104) $ rbt post --username sallan 824 Please log in to the Review Board server at localhost. Password: *correct_password* Generating diff for pending changeset 824 Review request #10 posted. http://localhost/r/10/ http://localhost/r/10/diff/ $ rbt post --username sallan 824 Please log in to the Review Board server at localhost. Password: *bogus_password* Generating diff for pending changeset 824 Review request #10 posted. http://localhost/r/10/ http://localhost/r/10/diff/ Notice the second time the bogus_password is accepted because I now have a cookie. If that's the case, why prompt? Is this a bug? Would you like me to file a report? --Steve -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
RBTools: Is this a bug in the way 'rbt --username' handles authentication?
I'm testing out RB 2.0.15 RBTools 0.7.2 and I've noticed something about how the --username option is handled that I think is a bug, but I wanted to run it by you all before filing a bug report. What I've found is that when I do rbt post --username me 1234 I always get prompted for a password. If I already have a valid cookie in .rbtools-cookies file, then I can type anything and the review will go through. If however I delete my .rbtools-cookie file, try again then the authentication is done correctly. Does that make sense? It seems somehow wrong to me. This example may make it clearer. $ rm ~/.rbtools-cookies $ rbt post --username sallan 824 Please log in to the Review Board server at localhost. Password: *bogus_password* ERROR: Unexpected API Error: The username or password was not correct (HTTP 401, API Error 104) $ rbt post --username sallan 824 Please log in to the Review Board server at localhost. Password: *correct_password* Generating diff for pending changeset 824 Review request #10 posted. http://localhost/r/10/ http://localhost/r/10/diff/ $ rbt post --username sallan 824 Please log in to the Review Board server at localhost. Password: *bogus_password* Generating diff for pending changeset 824 Review request #10 posted. http://localhost/r/10/ http://localhost/r/10/diff/ Notice the second time the bogus_password is accepted because I now have a cookie. If that's the case, why prompt? Is this a bug? Would you like me to file a report? --Steve -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Unable to post review (Windows RBtools 0.7.2 + RB 2.0.15)
Well seems like I found the issue. We had the ip address of our git repo
instead of the actual name. The strange thing about this is that *diff* was
did not complain about it but *post* did. I am all set :-).
Cheers guys
On Wednesday, April 29, 2015 at 1:16:06 PM UTC+10, MoonWalker wrote:
I have some issues trying to post a review. Everything seems okay if I run
the following command in my Git workspace. The diff gets generated
W:\Jenkins\jobs\Build_Branch\workspaceC:\Program Files\RBTools\bin\rbt
diff--server http://reviewboard.dev.local/ --username superman --password
superman --disable-proxy --parent origin/201021 --tracking-branch
origin/201021 -d
If I run the same command but instead of *diff* I change it to *post*. I
endup with the following debug messages:
W:\Jenkins\jobs\Build_Branch\workspaceC:\Program Files\RBTools\bin\rbt
post--server http://reviewboard.dev.local/ --username superman --password
superman --disable-proxy --parent origin/201021 --tracking-branch
origin/201021 -d
RBTools 0.7.2
Python 2.7.6 (default, Nov 10 2013, 19:24:18) [MSC v.1500 32 bit
(Intel)]
Running on Windows-XP-5.1.2600-SP3
Home = C:\Documents and Settings\devadmin\Application Data
Current directory = W:\Jenkins\jobs\Build_Branch\workspace
Checking for a Subversion repository...
Running: svn info --non-interactive
Command exited with rc 1: ['svn', 'info', '--non-interactive']
svn: E155007: 'W:\Jenkins\jobs\Build_Branch\workspace' is not a working
copy
---
Checking for a Git repository...
Running: git rev-parse --git-dir
Running: git config core.bare
Running: git rev-parse --show-toplevel
Running: git symbolic-ref -q HEAD
Running: git config --get branch.R-2173.merge
Running: git config --get branch.R-2173.remote
Running: git config --get remote.origin.url
repository info: Path: g...@gitlab.dev.local:floor/b.git, Bas
e path: , Supports changesets: False
Making HTTP GET request to http://reviewboard.dev.local/api/
Running: git rev-parse refs/heads/R-2173
Running: git merge-base cd2631bc7109a546d6b552f63781776c6754e653
origin/2010
21
Running: git rev-parse e4e572c9fb8c6af6b8c3b23c25d364d91faa709e
Running: git rev-parse origin/201021
Running: git status --porcelain --untracked-files=no
Running: git rev-parse --git-dir
Running: git -c core.quotepath=false -c diff.noprefix=false diff
--no-color
--full-index --ignore-submodules -M --no-ext-diff
e4e572c9fb8c6af6b8c3b23c25d364
d91faa709e..cd2631bc7109a546d6b552f63781776c6754e653
Running: git -c core.quotepath=false -c diff.noprefix=false diff
--no-color
--full-index --ignore-submodules -M --no-ext-diff
e4e572c9fb8c6af6b8c3b23c25d364
d91faa709e..e4e572c9fb8c6af6b8c3b23c25d364d91faa709e
Making HTTP GET request to
http://reviewboard.dev.local/api/validation/d
iffs/
Cached response for HTTP GET
http://reviewboard.dev.local/api/validation
/diffs/ expired and was modified
Making HTTP POST request to
http://reviewboard.dev.local/api/validation/
diffs/
Got API Error 206 (HTTP code 400): The repository path specified is
not in t
he list of known repositories.
Error data: {u'stat': u'fail', u'repository':
u'g...@gitlab.dev.local:transformers/b.git', u'err': {u'msg': u'The
repository path specified is not i
n the list of known repositories.', u'code': 206}}
Traceback (most recent call last):
File C:\Program Files\RBTools\bin\..\Python27\Scripts\rbt-script.py,
line 8,
in module
load_entry_point('RBTools==0.7.2', 'console_scripts', 'rbt')()
File C:\Program
Files\RBTools\Python27\lib\site-packages\rbtools-0.7.2-py2.7.
egg\rbtools\commands\main.py, line 133, in main
command.run_from_argv([RB_MAIN, command_name] + args)
File C:\Program
Files\RBTools\Python27\lib\site-packages\rbtools-0.7.2-py2.7.
egg\rbtools\commands\__init__.py, line 555, in run_from_argv
exit_code = self.main(*args) or 0
File C:\Program
Files\RBTools\Python27\lib\site-packages\rbtools-0.7.2-py2.7.
egg\rbtools\commands\post.py, line 698, in main
(msg_prefix, e))
rbtools.commands.CommandError: Error validating diff
The repository path specified is not in the list of known repositories.
(HTTP 40
0, API Error 206)
W:\Jenkins\jobs\Build_Branch\workspace
NOTE: The repository is valid and *diff* wont complain about it
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: Best Approach to Reconstruct Repo with Changes
Hi, Internally, in the case of an unpushed branch, Review Board does store a parent diff between the parent revision and the posted diff. However, this is not exposed to the user. Typically what will happen in this case is that the parent changes will have their own review requests, in which case they can be applied in order (the Depends On field is useful to indicate to others the relationship). Sometimes I'll ask someone to update the review request with a change that applies cleanly to a specific branch. We're working on dramatically improving our DVCS capabilities, specifically with regards to posting entire branches at once. This will make it so every commit on the branch will be included, and `rbt patch` will be able to apply the entire branch at once, reproducing the commits exactly. -David On Thu, Apr 23, 2015 at 4:09 PM jameslam91...@gmail.com wrote: Hello Review Board users / developers, What is the recommended approach for reconstructing a work copy of the changes in a review request? I am most specifically interested in Git where branching may occur. It seems that an approach would be to 1. Checkout the repo with the base revision which I can get from the Review Board API. 2. rbt patch to apply the changes However, it seems that I can't always just checkout from the base revision as that revision may be in a unpushed branch. How can I reconstruct the repo up to the point where the base revision is if I can't directly check out the changes. Does Review Board store all the diffs leading up to the uploaded diff for branches? Is this information exposed to the user? Thanks! -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Incorrect Permission Problems
After installing ReviewBoard on a fedora 21 vm, I get permission problems saying I need to change the owner to apahce for my data and ext directories -- the odd thing is that these changes have already been made. I'm a bit at a loss. Any help would be much appreciated. Thanks -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3698 in reviewboard: Condensediff warning in 2.0.11
Updates: Status: Fixed Comment #4 on issue 3698 by trowb...@gmail.com: Condensediff warning in 2.0.11 https://code.google.com/p/reviewboard/issues/detail?id=3698 This warning was harmless, and upgrades can proceed even without the fix. Fixed in release-2.0.x (3fae350). Thanks! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Modify other user's summary post - Email received
Hi, This is something we aim to do, but the current ability to modify another user's review request is a bit of a hack. We currently don't track info on what user made a change, assuming instead that it's the original poster of the review request. That's why a special permission or admin abilities are required to modify other people's review requests. Down the road, we'd like to track this better, so that the changes in the UI, email, and API will all reflect the actual person who made the change. That would be 3.0 at the very earliest, though. Christian On Tuesday, April 28, 2015, Fernando Martin nan...@gmail.com wrote: Hi all, 1. User A is posting a review: post #1. 2. All the users receive an email from User A about this post #1. 3. User B is modifying the summary of this post #1. 4. All the users receive an email again from* User A *about this change in post #1. I'd like to change point #4 so all the users receive the email from *User B* as he's the one who made the modification on that post. Is this possible? Thanks! -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com javascript:_e(%7B%7D,'cvml','reviewboard%2bunsubscr...@googlegroups.com'); . For more options, visit https://groups.google.com/d/optout. -- -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Issue 3856 in reviewboard: Enable configuring trusted certificates for Active Directory setup
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 3856 by rasp...@gmail.com: Enable configuring trusted certificates for Active Directory setup https://code.google.com/p/reviewboard/issues/detail?id=3856 *** For customer support, please post to reviewbo...@googlegroups.com *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** Do not post confidential information in this enhancement request! What version are you running? 2.0.15 What's the URL of the page this enhancement relates to, if any? /admin/settings/authentication/ Describe the enhancement and the motivation for it. Active Directory can be connected via TLS, which increases security. This is already supported, but our organization uses custom intenal CA to issue certificate for AD domain controllers. This CA is not trusted by default, so after enabling TLS, all authentication attempts fail with the following message in the server log: 'Active Directory: Could not connect to domain controller dc.name:389 for domain domain, possibly the certificate wasn't verifiable'. Please allow setting up custom trusted certificates for the purpose of TLS use. What operating system are you using? What browser? Windows 8.1, Firefox DeveloperEdition 39.0a2 Please provide any additional information below. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
