date:20150909

Re: RB 2.0.19 and Django 1.6.11.1 = No email

2015-09-09 Thread Christian Hammond

I just realized, you're probably being bit by a bug where certain headers
containing Unicode characters would be injected improperly and break some
e-mails. If, for instance, a sender or recipient's name has an accent mark,
you're probably hitting this.

We've fixed this in Git (SHA a22600574e26571f0ee31eba46322e73995531cd), and
will be releasing a 2.0.20 release probably in the next few days.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com

On Tue, Sep 8, 2015 at 6:40 PM, Christian Hammond 
wrote:

> What are you using for a mail server?
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board - https://www.reviewboard.org
> Beanbag, Inc. - https://www.beanbaginc.com
>
> On Tue, Sep 8, 2015 at 5:42 PM, MoonWalker 
> wrote:
>
>> hi,
>>
>> I updated both RB 2.0.19 and Django 1.6.11.1 on my Ubuntu Server and
>> endup with no emails.
>>
>> I did this to try to understand if Django is reporting any issue:
>>
>> 1) sudo rb-site manage /var/www/reviewboard shell
>> 2) >>> from django.core.mail import send_mail
>> send_mail('Subject here', 'Here is the message.', 'f...@example.com', ['
>> t...@example.com'], fail_silently=False)
>>
>> and the result is = 1
>>
>> 3) I do not get any email
>>
>>
>> Is there anything else that I shall try to understand the issue?
>>
>>
>>
>>
>>
>>
>>
>> --
>> Supercharge your Review Board with Power Pack:
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons:
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to reviewboard+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Issue 3747 in reviewboard: Review images is broken

2015-09-09 Thread reviewboard



Comment #3 on issue 3747 by nano...@gmail.com: Review images is broken
https://code.google.com/p/reviewboard/issues/detail?id=3747

@david,

Is there a chance this issue also affect document (a .docx)?

on our side we've got a 500 error when displaying review request containing  
an attachement (.docx) after migration from 2.0.15 to 2.0.19, see call  
stack:


   
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.19-py2.7.egg/reviewboard/reviews/templatetags/reviewtags.py",  
line 91, in file_attachment_comments

file_attachment.get_comments()))

  File "/usr/lib/python2.7/json/__init__.py", line 231, in dumps
return _default_encoder.encode(obj)

  File "/usr/lib/python2.7/json/encoder.py", line 201, in encode
chunks = self.iterencode(o, _one_shot=True)

  File "/usr/lib/python2.7/json/encoder.py", line 264, in iterencode
return _iterencode(o, 0)

  File "/usr/lib/python2.7/json/encoder.py", line 178, in default
raise TypeError(repr(o) + " is not JSON serializable")

TypeError:  is not  
JSON serializable


if confirmed, I can open another issue.

Regards,

Nicolas

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Issue 3935 in reviewboard: Auto populate branch name when creating new Review Request

2015-09-09 Thread reviewboard



Comment #2 on issue 3935 by anthonyh...@gmail.com: Auto populate branch  
name when creating new Review Request

https://code.google.com/p/reviewboard/issues/detail?id=3935

Will be working on this as my first easy fix bug.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Issue 3747 in reviewboard: Review images is broken

2015-09-09 Thread reviewboard



Comment #4 on issue 3747 by nano...@gmail.com: Review images is broken
https://code.google.com/p/reviewboard/issues/detail?id=3747

I confirm it is the same issue, and David's fix works on any kind of file  
attachment. It has solved our issue with .docx


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Issue 3809 in reviewboard: Broken .kt style in rb/css/syntax.css

2015-09-09 Thread reviewboard



Comment #1 on issue 3809 by justin.h...@gmail.com: Broken .kt style in  
rb/css/syntax.css

https://code.google.com/p/reviewboard/issues/detail?id=3809

Was able to replicate the problem and looking into it now.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Support for HTTP Basic Authentication in RBTools

2015-09-09 Thread Zach

Hey Christian,

Do you have any other suggestions?

Thanks,

-Zach

On Thursday, September 3, 2015 at 9:46:41 AM UTC-4, Zach wrote:
>
> Our Apache server runs reviewboard as a wsgi daemon process. Its other 
> function is to authenticate the user against active directory and then pass 
> the REMOTE_USER header to reviewboard, which we then handle in a custom 
> django remote user middleware.
>
> I tried the --disable-proxy switch and still received the same error for 
> both commands (`post` and `status`).
>
> If i try to do a get on the site directly, it works (meaning the 
> credentials are likely not being sent correctly):
>
> $ curl -usvc-reviewboard:`cat ~/.svc-reviewboard` 
> http://reviewboard.company.com/api/validation/diffs/; echo
> {"stat": "ok", "links": {"self": {"href": "
> http://reviewboard.company.com/api/validation/diffs/;, "method": "GET"}, 
> "create": {"href": "http://reviewboard.company.com/api/validation/diffs/;, 
> "method": "POST"}}}
>
>
> On Wednesday, September 2, 2015 at 5:41:53 PM UTC-4, Christian Hammond 
> wrote:
>>
>> What this looks like to me is that our attempts at pre-filling the 
>> Authorization header isn't working. Looks like the proxy is getting in the 
>> way and eating it. Review Board then sends a 401, which is supposed to have 
>> an API payload, but the proxy is messing with that.
>>
>> Is this a proxy server for internal usage, or is it meant to be used to 
>> reach the outside Internet? Assuming the server is within the network, can 
>> you just use --disable-proxy (or DISABLE_PROXY = True in ~/.reviewboardrc) ?
>>
>> Christian
>>
>> -- 
>> Christian Hammond - chi...@chipx86.com
>> Review Board - https://www.reviewboard.org
>> Beanbag, Inc. - https://www.beanbaginc.com
>>
>> On Tue, Sep 1, 2015 at 6:55 AM, Zach  wrote:
>>
>>> I realized it's getting a 401 on api/validation/diffs for `post` and an 
>>> error on api/session/?expand=user for `status`:
>>>
>>> $ ~/rbtools0.7.4/bin/rbt post --username=svc-reviewboard 
>>> --password=`cat ~/.svc-reviewboard` --debug
>>> >>> RBTools 0.7.4
>>> >>> Python 2.6.6 (r266:84292, Nov 21 2013, 10:50:32)
>>> [GCC 4.4.7 20120313 (Red Hat 4.4.7-4)]
>>> >>> Running on 
>>> Linux-2.6.32-504.23.4.el6.x86_64-x86_64-with-redhat-6.6-Santiago
>>> >>> Home = /home/
>>> >>> Current directory = /home//rb_test
>>> >>> Running: git version
>>> >>> Checking for a Subversion repository...
>>> >>> Running: svn --non-interactive info
>>> >>> Command exited with rc 1: ['svn', '--non-interactive', u'info']
>>> svn: '.' is not a working copy
>>> ---
>>> >>> Checking for a Git repository...
>>> >>> Running: git rev-parse --git-dir
>>> >>> Running: git config core.bare
>>> >>> Running: git rev-parse --show-toplevel
>>> >>> Running: git symbolic-ref -q HEAD
>>> >>> Running: git config --get branch._rb_test.merge
>>> >>> Command exited with rc 1: ['git', 'config', '--get', u'branch.
>>> _rb_test.merge']
>>> ---
>>> >>> Running: git config --get branch._rb_test.remote
>>> >>> Command exited with rc 1: ['git', 'config', '--get', u'branch.
>>> _rb_test.remote']
>>> ---
>>> >>> Running: git config --get remote.origin.url
>>> >>> repository info: Path: https://:@
>>> gitlab.company.com//.git, Base path: , Supports 
>>> changesets: False
>>> >>> Making HTTP GET request to http://reviewboard.company.com/api/
>>> >>> Running: git rev-parse refs/heads/t_new_rb_test
>>> >>> Running: git merge-base 0acfafe86d9f898ae5eebfdd23a1fc26643c71ab 
>>> origin/_rb_test
>>> >>> Running: git rev-parse e574f4d22b67539c7e192e08462fb260807e6ecd
>>> >>> Running: git status --porcelain --untracked-files=no
>>> >>> Running: git rev-parse --git-dir
>>> >>> Running: git -c core.quotepath=false -c diff.noprefix=false diff 
>>> --no-color --full-index --ignore-submodules -M --no-ext-diff 
>>> e574f4d22b67539c7e192e08462fb260807e6ecd..0acfafe86d9f898ae5eebfdd23a1fc26643c71ab
>>> >>> Making HTTP GET request to 
>>> http://reviewboard.company.com/api/validation/diffs/
>>> >>> Got HTTP error: 401: >> 2.0//EN">
>>> 
>>> 401 Authorization Required
>>> 
>>> Authorization Required
>>> This server could not verify that you
>>> are authorized to access the document
>>> requested.  Either you supplied the wrong
>>> credentials (e.g., bad password), or your
>>> browser doesn't understand how to supply
>>> the credentials required.
>>> 
>>>
>>> Traceback (most recent call last):
>>>   File "/home//rbtools0.7.4/bin/rbt", line 9, in 
>>> load_entry_point('RBTools==0.7.4', 'console_scripts', 'rbt')()
>>>   File 
>>> "/home//rbtools0.7.4/lib/python2.6/site-packages/RBTools-0.7.4-py2.6.egg/rbtools/commands/main.py",
>>>  
>>> line 133, in main
>>> command.run_from_argv([RB_MAIN, command_name] + args)
>>>   File 
>>> "/home//rbtools0.7.4/lib/python2.6/site-packages/RBTools-0.7.4-py2.6.egg/rbtools/commands/__init__.py",
>>>  
>>> line 612, in run_from_argv
>>> exit_code = self.main(*args) or 0
>>>   File 
>>>

Issue 3962 in reviewboard: Mercurial repositories not usable on Windows Reviewboard install when hg is installed with 'pip'

2015-09-09 Thread reviewboard


Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3962 by phil...@gmail.com: Mercurial repositories not usable on  
Windows Reviewboard install when hg is installed with 'pip'

https://code.google.com/p/reviewboard/issues/detail?id=3962

What version are you running?
  2.0.19

What's the URL of the page containing the problem?
  /reviewboard/r/new/

What steps will reproduce the problem?
1. Install Reviewboard on a Windows server
2. Add a Mercurial repository to Reviewboard
3. Note that the Mercurial repository does not appear in the "New Review  
Request" screen.


What is the expected output? What do you see instead?
  I expect that it be possible to create review requests against the  
repository, but the repository does not appear in the request list.


Additionally, I get this error in my Apache log:

[Wed Sep 09 15:01:14.473213 2015] [wsgi:error] [pid 1752:tid 952]  
ERROR:root:Error loading SCMTool for repository "Test Repository" (ID 2)
[Wed Sep 09 15:01:14.473213 2015] [wsgi:error] [pid 1752:tid 952] Traceback  
(most recent call last):
[Wed Sep 09 15:01:14.473213 2015] [wsgi:error] [pid 1752:tid 952]
File "c:\\reviewboard\\env\\Lib\\site-packages\\reviewboard-2.0.19-py2.7.egg\\reviewboard\\reviews\\views.py",  
line 249, in new_review_request
[Wed Sep 09 15:01:14.473213 2015] [wsgi:error] [pid 1752:tid 952]  
scmtool = repo.get_scmtool()
[Wed Sep 09 15:01:14.473213 2015] [wsgi:error] [pid 1752:tid 952]
File "c:\\reviewboard\\env\\Lib\\site-packages\\reviewboard-2.0.19-py2.7.egg\\reviewboard\\scmtools\\models.py",  
line 231, in get_scmtool
[Wed Sep 09 15:01:14.473213 2015] [wsgi:error] [pid 1752:tid 952]  
return cls(self)
[Wed Sep 09 15:01:14.473213 2015] [wsgi:error] [pid 1752:tid 952]
File "c:\\reviewboard\\env\\Lib\\site-packages\\reviewboard-2.0.19-py2.7.egg\\reviewboard\\scmtools\\hg.py",  
line 28, in __init__
[Wed Sep 09 15:01:14.473213 2015] [wsgi:error] [pid 1752:tid 952] raise  
ImportError
[Wed Sep 09 15:01:14.473213 2015] [wsgi:error] [pid 1752:tid 952]  
ImportError



What operating system are you using? What browser?
  Windows Server 2008 RC2 server, Windows 7 client, latest Google Chrome

Please provide any additional information below.

  On my server system, Mercurial was installed in the virtualenv which  
hosts Reviewboard. Line 25 of scmtools/hg.py attempts to check whether  
Mercurial is installed:


if not is_exe_in_path('hg'):
# This is technically not the right kind of error, but it's the
# pattern we use with all the other tools.
raise ImportError

And djblets.util.filesystem.py : is_exe_in_path(name) implements this thus:

if sys.platform == 'win32' and not name.endswith('.exe'):
name += ".exe"

for dir in os.environ['PATH'].split(os.pathsep):
if os.path.exists(os.path.join(dir, name)):
return True

return False

Clearly this will only work on Windows if the Mercurial executable is a  
true Windows executable and not a batch file or similar.


The problem is that in my virtualenv (where Mercurial was installed  
with "pip install mercurial"), the Mercurial binary *is* a batch file (in  
C:\ReviewBoard\Scripts\hg.bat).


This is not an issue if a Windows Mercurial distribution e.g. TortoiseHg is  
installed, as this includes a compiled executable to invoke Mercurial.



--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Could ReviewBoard be installed offline?

2015-09-09 Thread rjluo

Since I need to build a ReviewBoard system in a close net environment , 
could anybody tell me if I could do that? Thanks very much

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Could ReviewBoard be installed offline?

2015-09-09 Thread Christian Hammond

Hi,

If you're referring to using the website without any Internet/network
access, like gmail's offline mode, then no. The client requires access to
the API, which often needs to communicate with repositories. We've looked
into building offline access in the past, but it would have massively
increased the complexity of the program for very little benefit.

Now if you mean can it be used within a network that doesn't have access to
the Internet, then yes, so long as your repositories are accessible by the
server within the network. You'll need to turn off Gravatars, though.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com

On Wed, Sep 9, 2015 at 6:24 PM, rjluo  wrote:

> Since I need to build a ReviewBoard system in a close net environment ,
> could anybody tell me if I could do that? Thanks very much
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Crash while viewing review request

2015-09-09 Thread David Trowbridge

Looks like a fine fix. Can you post this on reviews.reviewboard.org?

Thanks!
-David
On Wed, Sep 9, 2015 at 10:33 AM Alexey Neyman 
wrote:

> FWIW, converting an iterator to list explicitly seems to help. Changed
> this line:
>
> return json.dumps(review_ui.serialize_comments(
> file_attachment.get_comments()))
>
> to this
>
> return json.dumps(list(review_ui.serialize_comments(
> file_attachment.get_comments(
>
> no crash observed. Don't know if it is the right fix, though.
>
> Regards,
> Alexey.
>
>
> On Friday, September 4, 2015 at 10:23:45 AM UTC-7, Alexey Neyman wrote:
>>
>> Hi all,
>>
>> We have a "Something broke (Error 500)" while trying to access one of the
>> review requests. I am pretty sure it was displayed fine previously at some
>> point, but at some point stopped working. I suspect the 2.0.19 update is
>> the culprit, as this last call in the stack trace
>> (file_attachment_comments) has changed substantially from 2.0.18.
>>
>> The stack trace is:
>>
>>   File 
>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/core/handlers/base.py",
>>  line 112, in get_response
>> response = wrapped_callback(request, *callback_args, **callback_kwargs)
>>   File 
>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.19-py2.6.egg/reviewboard/accounts/decorators.py",
>>  line 21, in _check
>> return login_required(view_func)(*args, **kwargs)
>>   File 
>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/contrib/auth/decorators.py",
>>  line 22, in _wrapped_view
>> return view_func(request, *args, **kwargs)
>>   File 
>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.19-py2.6.egg/reviewboard/site/decorators.py",
>>  line 35, in _check
>> return view_func(request, local_site=local_site, *args, **kwargs)
>>   File 
>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.19-py2.6.egg/reviewboard/reviews/views.py",
>>  line 721, in review_detail
>> RequestContext(request, context_data))
>>   File 
>> "*/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/shortcuts/*__init__.py",
>>  line 29, in render_to_response
>> return HttpResponse(loader.render_to_string(*args, **kwargs), 
>> **httpresponse_kwargs)
>>   File 
>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/loader.py",
>>  line 164, in render_to_string
>> return t.render(Context(dictionary))
>>   File 
>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>>  line 140, in render
>> return self._render(context)
>>   File 
>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>>  line 134, in _render
>> return self.nodelist.render(context)
>>   File 
>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>>  line 840, in render
>> bit = self.render_node(node, context)
>>   File 
>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>>  line 854, in render_node
>> return node.render(context)
>>   File 
>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/loader_tags.py",
>>  line 123, in render
>> return compiled_parent._render(context)
>>   File 
>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>>  line 134, in _render
>> return self.nodelist.render(context)
>>   File 
>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>>  line 840, in render
>> bit = self.render_node(node, context)
>>   File 
>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>>  line 854, in render_node
>> return node.render(context)
>>   File 
>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/loader_tags.py",
>>  line 123, in render
>> return compiled_parent._render(context)
>>   File 
>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>>  line 134, in _render
>> return self.nodelist.render(context)
>>   File 
>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>>  line 840, in render
>> bit = self.render_node(node, context)
>>   File 
>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>>  line 854, in render_node
>> return node.render(context)
>>   File 
>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/loader_tags.py",
>>  line 62, in render
>> result = block.nodelist.render(context)
>>   File 
>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>>  line 840, in render
>> bit = self.render_node(node, context)
>>   File 
>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>>  line 854, in render_node
>> return node.render(context)
>>   File 
>>

Re: Issue 3954 in reviewboard: Error 500 to some tickets

2015-09-09 Thread reviewboard



Comment #4 on issue 3954 by alder...@gmail.com: Error 500 to some tickets
https://code.google.com/p/reviewboard/issues/detail?id=3954

I,ve been hitting the same bug with CSV  files attachments (pure csv from  
php csv writter) as well as doc and docx.

it blocks the whole review when it happens, no one can look at it

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Issue 3954 in reviewboard: Error 500 to some tickets

2015-09-09 Thread reviewboard



Comment #5 on issue 3954 by alder...@gmail.com: Error 500 to some tickets
https://code.google.com/p/reviewboard/issues/detail?id=3954

(FYI 2.0.19 as well, and everything was working before)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Issue 3963 in reviewboard: markdown in the field Note to Reviewers gets quoted with backslashes after editing

2015-09-09 Thread reviewboard


Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3963 by paul.man...@alcatel-lucent.com: markdown in the field  
Note to Reviewers gets quoted with backslashes after editing

https://code.google.com/p/reviewboard/issues/detail?id=3963

What version are you running?

2.0.15


What's the URL of the page containing the problem?

http://reviewboard.example.com/r/2/

What steps will reproduce the problem?
1. edit the review, putting text into the "Note to reviewers" box, using  
markdown e.g.

#this is a highlighted comment

2. edit the review, changing the text in the note to reviewers box, perhaps  
adding something new


3.submit as normal

What is the expected output?

some highlighted text "this is a highlighted comment"

What do you see instead?

plain text reading "#this is a highlighted comment"

What operating system are you using?

Hosted on linux.


What browser?

Chrome on Linux (ubuntu desktop 15.04 x86-64)


Please provide any additional information below.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Crash while viewing review request

2015-09-09 Thread Alexey Neyman

FWIW, converting an iterator to list explicitly seems to help. Changed this 
line:

return json.dumps(review_ui.serialize_comments(
file_attachment.get_comments()))

to this

return json.dumps(list(review_ui.serialize_comments(
file_attachment.get_comments(

no crash observed. Don't know if it is the right fix, though.

Regards,
Alexey.

On Friday, September 4, 2015 at 10:23:45 AM UTC-7, Alexey Neyman wrote:
>
> Hi all,
>
> We have a "Something broke (Error 500)" while trying to access one of the 
> review requests. I am pretty sure it was displayed fine previously at some 
> point, but at some point stopped working. I suspect the 2.0.19 update is 
> the culprit, as this last call in the stack trace 
> (file_attachment_comments) has changed substantially from 2.0.18.
>
> The stack trace is:
>
>   File 
> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/core/handlers/base.py",
>  line 112, in get_response
> response = wrapped_callback(request, *callback_args, **callback_kwargs)
>   File 
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.19-py2.6.egg/reviewboard/accounts/decorators.py",
>  line 21, in _check
> return login_required(view_func)(*args, **kwargs)
>   File 
> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/contrib/auth/decorators.py",
>  line 22, in _wrapped_view
> return view_func(request, *args, **kwargs)
>   File 
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.19-py2.6.egg/reviewboard/site/decorators.py",
>  line 35, in _check
> return view_func(request, local_site=local_site, *args, **kwargs)
>   File 
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.19-py2.6.egg/reviewboard/reviews/views.py",
>  line 721, in review_detail
> RequestContext(request, context_data))
>   File 
> "*/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/shortcuts/*__init__.py",
>  line 29, in render_to_response
> return HttpResponse(loader.render_to_string(*args, **kwargs), 
> **httpresponse_kwargs)
>   File 
> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/loader.py",
>  line 164, in render_to_string
> return t.render(Context(dictionary))
>   File 
> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>  line 140, in render
> return self._render(context)
>   File 
> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>  line 134, in _render
> return self.nodelist.render(context)
>   File 
> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>  line 840, in render
> bit = self.render_node(node, context)
>   File 
> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>  line 854, in render_node
> return node.render(context)
>   File 
> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/loader_tags.py",
>  line 123, in render
> return compiled_parent._render(context)
>   File 
> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>  line 134, in _render
> return self.nodelist.render(context)
>   File 
> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>  line 840, in render
> bit = self.render_node(node, context)
>   File 
> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>  line 854, in render_node
> return node.render(context)
>   File 
> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/loader_tags.py",
>  line 123, in render
> return compiled_parent._render(context)
>   File 
> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>  line 134, in _render
> return self.nodelist.render(context)
>   File 
> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>  line 840, in render
> bit = self.render_node(node, context)
>   File 
> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>  line 854, in render_node
> return node.render(context)
>   File 
> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/loader_tags.py",
>  line 62, in render
> result = block.nodelist.render(context)
>   File 
> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>  line 840, in render
> bit = self.render_node(node, context)
>   File 
> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>  line 854, in render_node
> return node.render(context)
>   File 
> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/loader_tags.py",
>  line 155, in render
> return self.render_template(self.template, context)
>   File 
> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/loader_tags.py",
>  line 137, in

Re: Issue 3963 in reviewboard: markdown in the field Note to Reviewers gets quoted with backslashes after editing

2015-09-09 Thread reviewboard



Comment #2 on issue 3963 by chip...@gmail.com: markdown in the field Note  
to Reviewers gets quoted with backslashes after editing

https://code.google.com/p/reviewboard/issues/detail?id=3963

Also, did you publish between steps 1 and 2? If so, I'd be interested in  
seeing API data from both stages.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Issue 3964 in reviewboard: Text Overflow in Search Auto-Complete for Long Usernames / Long Review Titles

2015-09-09 Thread reviewboard


Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3964 by zach...@gmail.com: Text Overflow in Search Auto-Complete  
for Long Usernames / Long Review Titles

https://code.google.com/p/reviewboard/issues/detail?id=3964

What version are you running?
2.0.18

What's the URL of the page containing the problem?
Any page that search is visible on (eg: dashboard)

What steps will reproduce the problem?
1. have existing reviews that have titles > 30 characters which have been  
indexed for search

2. type in search box to match any of those review titles
3. view text overflow

What is the expected output? What do you see instead?
I would expect that the search box should truncate the text. Along with  
this, since search box is pretty small, it should probably be enlarged.
I have also noticed that this overflow occurs when users that are matched  
have long usernames.


What operating system are you using? What browser?
Windows 7 / Chrome

Please provide any additional information below.
I have attached a screenshot of the issue.

Attachments:
text-overflow-reviewboard-2_0_18.png  2.9 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Crash while viewing review request

2015-09-09 Thread Christian Hammond

This is actually already fixed for 2.0.20, unless I missed something big.
Planning a release in the next few days.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com

On Wed, Sep 9, 2015 at 11:58 AM, David Trowbridge 
wrote:

> Looks like a fine fix. Can you post this on reviews.reviewboard.org?
>
> Thanks!
> -David
>
> On Wed, Sep 9, 2015 at 10:33 AM Alexey Neyman 
> wrote:
>
>> FWIW, converting an iterator to list explicitly seems to help. Changed
>> this line:
>>
>> return json.dumps(review_ui.serialize_comments(
>> file_attachment.get_comments()))
>>
>> to this
>>
>> return json.dumps(list(review_ui.serialize_comments(
>> file_attachment.get_comments(
>>
>> no crash observed. Don't know if it is the right fix, though.
>>
>> Regards,
>> Alexey.
>>
>>
>> On Friday, September 4, 2015 at 10:23:45 AM UTC-7, Alexey Neyman wrote:
>>>
>>> Hi all,
>>>
>>> We have a "Something broke (Error 500)" while trying to access one of
>>> the review requests. I am pretty sure it was displayed fine previously at
>>> some point, but at some point stopped working. I suspect the 2.0.19 update
>>> is the culprit, as this last call in the stack trace
>>> (file_attachment_comments) has changed substantially from 2.0.18.
>>>
>>> The stack trace is:
>>>
>>>   File 
>>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/core/handlers/base.py",
>>>  line 112, in get_response
>>> response = wrapped_callback(request, *callback_args, **callback_kwargs)
>>>   File 
>>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.19-py2.6.egg/reviewboard/accounts/decorators.py",
>>>  line 21, in _check
>>> return login_required(view_func)(*args, **kwargs)
>>>   File 
>>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/contrib/auth/decorators.py",
>>>  line 22, in _wrapped_view
>>> return view_func(request, *args, **kwargs)
>>>   File 
>>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.19-py2.6.egg/reviewboard/site/decorators.py",
>>>  line 35, in _check
>>> return view_func(request, local_site=local_site, *args, **kwargs)
>>>   File 
>>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.19-py2.6.egg/reviewboard/reviews/views.py",
>>>  line 721, in review_detail
>>> RequestContext(request, context_data))
>>>   File 
>>> "*/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/shortcuts/*__init__.py",
>>>  line 29, in render_to_response
>>> return HttpResponse(loader.render_to_string(*args, **kwargs), 
>>> **httpresponse_kwargs)
>>>   File 
>>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/loader.py",
>>>  line 164, in render_to_string
>>> return t.render(Context(dictionary))
>>>   File 
>>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>>>  line 140, in render
>>> return self._render(context)
>>>   File 
>>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>>>  line 134, in _render
>>> return self.nodelist.render(context)
>>>   File 
>>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>>>  line 840, in render
>>> bit = self.render_node(node, context)
>>>   File 
>>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>>>  line 854, in render_node
>>> return node.render(context)
>>>   File 
>>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/loader_tags.py",
>>>  line 123, in render
>>> return compiled_parent._render(context)
>>>   File 
>>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>>>  line 134, in _render
>>> return self.nodelist.render(context)
>>>   File 
>>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>>>  line 840, in render
>>> bit = self.render_node(node, context)
>>>   File 
>>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>>>  line 854, in render_node
>>> return node.render(context)
>>>   File 
>>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/loader_tags.py",
>>>  line 123, in render
>>> return compiled_parent._render(context)
>>>   File 
>>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>>>  line 134, in _render
>>> return self.nodelist.render(context)
>>>   File 
>>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>>>  line 840, in render
>>> bit = self.render_node(node, context)
>>>   File 
>>> "/usr/lib/python2.6/site-packages/Django-1.6.11.1-py2.6.egg/django/template/base.py",
>>>  line 854, in render_node
>>> return node.render(context)
>>>   File 
>>>

Re: Issue 3963 in reviewboard: markdown in the field Note to Reviewers gets quoted with backslashes after editing

2015-09-09 Thread reviewboard


Updates:
Status: NeedInfo
Labels: Project-ReviewBoard Component-Markdown

Comment #1 on issue 3963 by chip...@gmail.com: markdown in the field Note  
to Reviewers gets quoted with backslashes after editing

https://code.google.com/p/reviewboard/issues/detail?id=3963

Interesting. We got a similar comment from someone developing a custom  
extension just a week or two ago, but we could not reproduce it with the  
same extension or with Note to Reviewers. I'm unsure what the difference  
is...


Can you get the full payload of that review request from the API and send  
it here? (/api/review-requests//)


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Issue 3954 in reviewboard: Error 500 to some tickets

2015-09-09 Thread reviewboard



Comment #6 on issue 3954 by chip...@gmail.com: Error 500 to some tickets
https://code.google.com/p/reviewboard/issues/detail?id=3954

We'll have 2.0.20 out in just a couple days with this fix.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: RB 2.0.19 and Django 1.6.11.1 = No email

Re: Issue 3747 in reviewboard: Review images is broken

Re: Issue 3935 in reviewboard: Auto populate branch name when creating new Review Request

Re: Issue 3747 in reviewboard: Review images is broken

Re: Issue 3809 in reviewboard: Broken .kt style in rb/css/syntax.css

Re: Support for HTTP Basic Authentication in RBTools

Issue 3962 in reviewboard: Mercurial repositories not usable on Windows Reviewboard install when hg is installed with 'pip'

Could ReviewBoard be installed offline?

Re: Could ReviewBoard be installed offline?

Re: Crash while viewing review request

Re: Issue 3954 in reviewboard: Error 500 to some tickets

Re: Issue 3954 in reviewboard: Error 500 to some tickets

Issue 3963 in reviewboard: markdown in the field Note to Reviewers gets quoted with backslashes after editing

Re: Crash while viewing review request

Re: Issue 3963 in reviewboard: markdown in the field Note to Reviewers gets quoted with backslashes after editing

Issue 3964 in reviewboard: Text Overflow in Search Auto-Complete for Long Usernames / Long Review Titles

Re: Crash while viewing review request

Re: Issue 3963 in reviewboard: markdown in the field Note to Reviewers gets quoted with backslashes after editing

Re: Issue 3954 in reviewboard: Error 500 to some tickets

19 matches

Site Navigation

Mail list logo

Footer information