Re: Djblets Ticket #4635: AvatarService requires get_avatar_urls_uncached
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4635/ -- New update by Misery For Beanbag, Inc. > Djblets > Ticket #4635 Status: - New + Confirmed Milestones: + Release-3.0.x Tags: - Project:RBTools + EasyFix + Project:ReviewBoard -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Djblets Ticket #4634: AvatarService requires get_etag_data
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4634/ -- New update by Misery For Beanbag, Inc. > Djblets > Ticket #4634 Status: - New + Confirmed Milestones: + Release-3.0.x Tags: - Project:RBTools + EasyFix + Project:ReviewBoard -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
RBTools 0.7.11 is released
Hi everyone, It's been a while since we've last had a new RBTools release, as we've focused on Review Board 3.0 and RBCommons development as of late, but we've finally put out a new release today. RBTools 0.7.11 has a bunch of fixes for Git, Mercurial, Subversion, and Team Foundation services, and overall improvements for some command line options and compatibility. Our news post goes into some detail, and has links for downloads and the release notes: https://www.reviewboard.org/news/2018/01/18/rbtools-0-7-11-now-out/ I'd like to thank André Klitzing and Graham Seaman for their contributions to this release! We're working toward RBTools 1.0, with some quality-of-life improvements. No ETA yet, but we're hoping to make a push on it after we wrap up some other projects on our plates. Thanks, and let us know if you hit any problems. Christian -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4631: Dashboard isn't properly redirecting behind a proxy
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4631/ -- New update by kbjerke For Beanbag, Inc. > Review Board > Ticket #4631 Reply: You can continue to serve Review Board out of `/rb/`. The trick is the links, and fortunately Review Board has you covered here. There's a `SITE_ROOT` variable that specifies what the prefix should be to the URL. This is normally asked during `rb-site install`, but you can set it manually in `$sitedir/conf/settings_local.py` by setting: ``` SITE_ROOT = '/rb/' ``` You should see it already in there as `SITE_ROOT = ''`, meaning no prefix. Give that a try, it should take care of the URLs. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Can't add Perforce Repository with SSL Support
Hi Pete, That's not a very good error... It's trying to use the p4 command line tool to accept the SSL certificate. It's not finding it in Apache's path. You'll need to place a copy of p4 in /usr/bin. We'll work on improving that error. Christian On Tue, Jan 16, 2018 at 9:59 AM, Peter Storkey <wonk...@gmail.com> wrote: > Hi all, > > I'm installing a new ReviewBoard 3.0.2 server on a CentOS 7 VM. We have > two Perforce repositories, one that uses SSL and one that does not. > > I have successfully added the non-SSL repository, but when I try to add > the SSL repository I get a 500 error when accepting the SSL fingerprint > (clicking the "I trust this host" button). The traceback from the error is > as follows: > > 2018-01-16 17:42:37,946 - ERROR - None - admin - > /admin/db/scmtools/repository/add/ - djblets.log.middleware - Exception > thrown for user admin at http://review.mydomain.com/ > admin/db/scmtools/repository/add/ > > [Errno 2] No such file or directory > Traceback (most recent call last): > File "/usr/lib/python2.7/site-packages/django/core/handlers/base.py", > line 112, in get_response > response = wrapped_callback(request, *callback_args, **callback_kwargs) > File "/usr/lib/python2.7/site-packages/django/contrib/admin/options.py", > line 465, in wrapper > return self.admin_site.admin_view(view)(*args, **kwargs) > File "/usr/lib/python2.7/site-packages/django/utils/decorators.py", > line 99, in _wrapped_view > response = view_func(request, *args, **kwargs) > File "/usr/lib/python2.7/site-packages/django/views/decorators/cache.py", > line 52, in _wrapped_view_func > response = view_func(request, *args, **kwargs) > File "/usr/lib/python2.7/site-packages/django/contrib/admin/sites.py", > line 198, in inner > return view(request, *args, **kwargs) > File "/usr/lib/python2.7/site-packages/django/utils/decorators.py", > line 29, in _wrapper > return bound_func(*args, **kwargs) > File "/usr/lib/python2.7/site-packages/django/utils/decorators.py", > line 99, in _wrapped_view > response = view_func(request, *args, **kwargs) > File "/usr/lib/python2.7/site-packages/django/utils/decorators.py", > line 25, in bound_func > return func(self, *args2, **kwargs2) > File "/usr/lib/python2.7/site-packages/django/db/transaction.py", line > 371, in inner > return func(*args, **kwargs) > File "/usr/lib/python2.7/site-packages/django/contrib/admin/options.py", > line 1146, in add_view > if form.is_valid(): > File "/usr/lib/python2.7/site-packages/reviewboard/scmtools/forms.py", > line 1139, in is_valid > if not super(RepositoryForm, self).is_valid(): > File "/usr/lib/python2.7/site-packages/django/forms/forms.py", line > 129, in is_valid > return self.is_bound and not bool(self.errors) > File "/usr/lib/python2.7/site-packages/django/forms/forms.py", line > 121, in errors > self.full_clean() > File "/usr/lib/python2.7/site-packages/reviewboard/scmtools/forms.py", > line 921, in full_clean > super(RepositoryForm, self).full_clean(*args, **kwargs) > File "/usr/lib/python2.7/site-packages/django/forms/forms.py", line > 274, in full_clean > self._clean_form() > File "/usr/lib/python2.7/site-packages/django/forms/forms.py", line > 300, in _clean_form > self.cleaned_data = self.clean() > File "/usr/lib/python2.7/site-packages/reviewboard/scmtools/forms.py", > line 970, in clean > self._verify_repository_path() > File "/usr/lib/python2.7/site-packages/reviewboard/scmtools/forms.py", > line 1320, in _verify_repository_path > certificate=e.certificate) > File "/usr/lib/python2.7/site-packages/reviewboard/scmtools/perforce.py", > line 912, in accept_certificate > stderr=subprocess.PIPE) > File "/usr/lib64/python2.7/subprocess.py", line 711, in __init__ > errread, errwrite) > File "/usr/lib64/python2.7/subprocess.py", line 1327, in _execute_child > raise child_exception > OSError: [Errno 2] No such file or directory > > Any thoughts? > > Thanks, > Pete > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "Review Board Community" group. > To unsubscribe from this group and stop receiving emails from it, send an > em
Re: Review Board Ticket #4631: Dashboard isn't properly redirecting behind a proxy
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4631/ -- New update by kbjerke For Beanbag, Inc. > Review Board > Ticket #4631 Reply: Reason for that is that we have links that we build dynamically in JavaScript, and in payloads unparseable by the module, so you're going to have links coming from different places that will be in the other format. What are you needing the module for? -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4631: Dashboard isn't properly redirecting behind a proxy
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4631/ -- New update by kbjerke For Beanbag, Inc. > Review Board > Ticket #4631 Reply: Ah, mod_proxy_html. That would explain it. We do not support any modules that rewrite our HTML, unfortunately. They cannot get it right for all our uses, and _will_ fail. You'll have to disable that to properly use Review Board. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: "You are not logged in (HTTP 401, API Error 103)"
Ahh, that would do it, indeed. Sorry, I didn't check for that. Christian On Tue, Jan 16, 2018 at 11:14 AM, Vince Thyng <vth...@gmail.com> wrote: > I think this all came down to not having 'WSGIPassAuthorization On' in my > apache config. > > Vince > > > On Tuesday, January 16, 2018 at 8:56:54 AM UTC-8, Vince Thyng wrote: >> >> Hello Christian, >> >>I was hoping that would be it, but I get the same problem. I am >> pretty sure my apache config is the problem. I replaced my apache >> customizations with the /var/www/reviewboard/conf/apache-wsgi.conf file >> and it wrote the session to the .rbtools-cookies file. Still errored, but >> it was about ssl which isn't included in that basic file. So I think I am >> on the right track. >> >> Thank you very much for your help! >> >> Vince >> >> >> On Monday, January 15, 2018 at 7:58:40 PM UTC-8, Christian Hammond wrote: >>> >>> Hi Vince, >>> >>> The debug log shows an immediate failure after providing a >>> login/password, and it's not the one I'd expect if there was an issue with >>> the credentials (you'd see "The username or password was not correct."), >>> which makes me wonder if there's an issue with the credentials even >>> reaching the server. >>> >>> I've seen this happen when going through an outbound HTTP(S) proxy for a >>> company. If the company has one set up at all, and your system is >>> configured to go through it, then it's likely going to interfere with the >>> requests. Just to sanity-check, can you try passing --no-proxy to RBTools >>> in your test? >>> >>> LDAP errors will show up as warnings/errors, without the need to enable >>> debug logging. You should see a debug message for "Attempting to >>> authenticate user ..." >>> >>> If you aren't seeing anything from LDAP, then it sounds like it's not >>> going through LDAP. Can you confirm LDAP is showing up as the auth backend >>> in Authentication Settings? >>> >>> Christian >>> >>> On Mon, Jan 15, 2018 at 3:34 PM, Vince Thyng <vth...@gmail.com> wrote: >>> >>>> >>>> Confirmed, the domain matches exactly. >>>> >>>> We have restarted apache many times while troubleshooting this, but >>>> tried a restart again just now. We wanted to try `sudo python -m ipdb >>>> $(which rb-site) manage /var/www/reviewboard runserver 0.0.0.0:80`, >>>> but ran in to trouble with https not being available. >>>> >>>> Sorry, that .rbtools-cookies file post was confusing. It shows our >>>> production server in there as otherserver.com (which I can still post >>>> to just fine even after removing the session for it from .rbtools-cookies), >>>> and this new one that will replace it as localserver.com. I think >>>> what is noteable about my testing is that when I remove the cookies file, >>>> it is not getting populated again, yet if I put a session in there manually >>>> that I can see in the database, it works. >>>> >>>> Logins via webui work, while new sessions via rbt do not. >>>> >>>> We are using apache 2.4.6 without a proxy in front, on centos 7.3 >>>> >>>> I think it is a pretty basic config, but I removed the 80->443 redirect >>>> and tested again just now in case that has introduced a problem. Still no >>>> love. >>>> >>>> >>>> ServerName reviewboard.localserver.com >>>> >>>> ## Vhost docroot >>>> DocumentRoot "/var/www/reviewboard/" >>>> ## Alias declarations for resources outside the DocumentRoot >>>> Alias /static "/var/www/reviewboard/htdocs/static" >>>> >>>> ## Directories, there should at least be a declaration for >>>> /var/www/reviewboard/ >>>> >>>> >>>> Options -Indexes +FollowSymLinks >>>> AllowOverride None >>>> Require all granted >>>> >>>> >>>> ## Logging >>>> ErrorLog "/var/log/httpd/reviewboard.localserver.com_error_ssl.log" >>>> ServerSignature Off >>>> CustomLog "/var/log/httpd/reviewboard.localserver.com_access_ssl.log" >>>> combined >>>> >>>> ## SSL directives >>>> SSLEngine on >>>> SSLCertificateFile "/etc/pki
Re: using perforce repository: unable to parse diff revision header
Hi,
Off-hand, I don't see anything wrong with that header. It looks fine for a
Perforce diff. Is there any chance you have a repository added that is not
a Perforce repository, and it's using that one? I saw the other post about
having trouble adding a Perforce repository, and am wondering if it's
really configured right.
To verify this by hand, I'm actually going to need a non-redacted copy of
the diff attached in a zip file (to prevent re-encoding issues over
e-mail). It's fine to change the depot, but it's absolutely vital that
characters are not removed and that you only change alphanumeric characters
to other alphanumeric characters, but anything like whitespace would need
to be preserved.
Christian
On Tue, Jan 16, 2018 at 3:35 AM, Giuseppe Salvatore <
giuseppe.salvat...@gmail.com> wrote:
> Hi,
>
> I think I hit another nasty one:
>
> rbt post -d 379808
>
> >>> RBTools 0.7.10
> >>> Python 2.7.13 (v2.7.13:a06454b1afa1, Dec 17 2016, 20:42:59) [MSC
> v.1500 32 bit (Intel)]
> >>> Running on Windows-10-10.0.16299
> >>> Home = C:\Users\
> >>> Current directory = C:\Users\
> >>> Command line: rbt post -d 379808
> >>> Running: tf vc help
> >>> Checking for a Perforce repository...
> >>> Running: p4 info
> >>> Running: diff --version
> >>> repository info: Path: SERVER3.:1666, Base
> path: None, Supports changesets: True
> >>> Making HTTP GET request to http://.com/api/
> >>> Running: p4 info
> Generating diff for pending changeset 379808
> >>> Processing add of //depot
> /Test/reviewboard_test.txt
> >>> Running: diff -urNp c:\users\temp\tmpvu_9y8 C
> \Test\reviewboard_test.txt
> >>> Command exited with rc 1: [u'diff', u'-urNp',
> 'c:\\users\\gbsalv~1\\appdata\\local\\temp\\tmpvu_9y8', 'C:\\Users\\
> \\Test\\reviewboard_test.txt']
> >>> Making HTTP GET request to http://
> .com/api/validation/diffs/
> >>> Cached response for HTTP GET
> >>> http://.com/api/validation/diffs/
> expired and was modified
> >>> Making HTTP POST request to http://
> .com/api/validation/diffs/
> >>> Got API Error 224 (HTTP code 400): Unable to parse diff revision
> header '//depot/Test/reviewboard_test.txt#0'
> >>> Error data: {u'stat': u'fail', u'err': {u'msg': u"Unable to parse diff
> revision header '//depot
> /Test/reviewboard_test.txt#0'", u'code': 224}}
> Traceback (most recent call last):
> File "C:\Program Files (x86)\RBTools\bin\..\Python27\Scripts\rbt-script.py",
> line 11, in
> load_entry_point('RBTools==0.7.10', 'console_scripts', 'rbt')()
> File "C:\Program Files (x86)\RBTools\Python27\lib\
> site-packages\rbtools-0.7.10-py2.7.egg\rbtools\commands\main.py", line
> 133, in main
> command.run_from_argv([RB_MAIN, command_name] + args)
> File "C:\Program Files (x86)\RBTools\Python27\lib\
> site-packages\rbtools-0.7.10-py2.7.egg\rbtools\commands\__init__.py",
> line 663, in run_from_argv
> exit_code = self.main(*args) or 0
> File "C:\Program Files (x86)\RBTools\Python27\lib\
> site-packages\rbtools-0.7.10-py2.7.egg\rbtools\commands\post.py", line
> 812, in main
> (msg_prefix, e))
> rbtools.commands.CommandError: Error validating diff
>
> Unable to parse diff revision header
> '///Test/reviewboard_test.txt#0'
> (HTTP 400, API Error 224)
>
> Sorry I needed to black some fields because of confidentiality, hope you
> don't mind it.
> From what I can see it seems to be the format of the diff, rbt doesn't
> like it. This is the diff file
>
> rbt diff 379808
> Generating diff for pending changeset 379808
> --- //depot/Test/reviewboard_test.txt//depot
> /Test/reviewboard_test.txt#0
> +++ //depot/Test/reviewboard_test.txt
> 2018-01-15 17:39:10
> @@ -0,0 +1 @@
> +This is a dummy test file used to check that reviewboard works correctly
> \ No newline at end of file
>
> I am using rbt 0.7.10 and reviewboard 2.5.15 GNU diff tools 2.8.7. Is
> there any particular configuration to apply to make rbt happy?
>
> Thanks
>
> Giuseppe
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> h
Re: Disabled users in Review Groups
Hi Jeff, It should exclude any users who are disabled from receiving an e-mail. Our queries for the users check for that flag. However, if you do find that they are receiving e-mails, please let us know and we'll get a fix together. Christian On Tue, Jan 16, 2018 at 7:53 AM, Jeff Domogala <jeffdomog...@gmail.com> wrote: > Something I have not found an answer for in the documentation > > If a user is part of a review group that is mailing to all of the users in > the group (instead of using the mail alias), what happens when the user is > disabled? Is the user excluded when mail is generated for the group? > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "Review Board Community" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: "You are not logged in (HTTP 401, API Error 103)"
Hi Vince, The debug log shows an immediate failure after providing a login/password, and it's not the one I'd expect if there was an issue with the credentials (you'd see "The username or password was not correct."), which makes me wonder if there's an issue with the credentials even reaching the server. I've seen this happen when going through an outbound HTTP(S) proxy for a company. If the company has one set up at all, and your system is configured to go through it, then it's likely going to interfere with the requests. Just to sanity-check, can you try passing --no-proxy to RBTools in your test? LDAP errors will show up as warnings/errors, without the need to enable debug logging. You should see a debug message for "Attempting to authenticate user ..." If you aren't seeing anything from LDAP, then it sounds like it's not going through LDAP. Can you confirm LDAP is showing up as the auth backend in Authentication Settings? Christian On Mon, Jan 15, 2018 at 3:34 PM, Vince Thyng <vth...@gmail.com> wrote: > > Confirmed, the domain matches exactly. > > We have restarted apache many times while troubleshooting this, but tried > a restart again just now. We wanted to try `sudo python -m ipdb $(which > rb-site) manage /var/www/reviewboard runserver 0.0.0.0:80`, but ran in to > trouble with https not being available. > > Sorry, that .rbtools-cookies file post was confusing. It shows our > production server in there as otherserver.com (which I can still post to > just fine even after removing the session for it from .rbtools-cookies), > and this new one that will replace it as localserver.com. I think what > is noteable about my testing is that when I remove the cookies file, it is > not getting populated again, yet if I put a session in there manually that > I can see in the database, it works. > > Logins via webui work, while new sessions via rbt do not. > > We are using apache 2.4.6 without a proxy in front, on centos 7.3 > > I think it is a pretty basic config, but I removed the 80->443 redirect > and tested again just now in case that has introduced a problem. Still no > love. > > > ServerName reviewboard.localserver.com > > ## Vhost docroot > DocumentRoot "/var/www/reviewboard/" > ## Alias declarations for resources outside the DocumentRoot > Alias /static "/var/www/reviewboard/htdocs/static" > > ## Directories, there should at least be a declaration for > /var/www/reviewboard/ > > > Options -Indexes +FollowSymLinks > AllowOverride None > Require all granted > > > ## Logging > ErrorLog "/var/log/httpd/reviewboard.localserver.com_error_ssl.log" > ServerSignature Off > CustomLog "/var/log/httpd/reviewboard.localserver.com_access_ssl.log" > combined > > ## SSL directives > SSLEngine on > SSLCertificateFile "/etc/pki/tls/certs/_.west.isilon.com.crt" > SSLCertificateKeyFile "/etc/pki/tls/private/_.west.isilon.com.key" > SSLCertificateChainFile "/etc/pki/tls/certs/_.west.isilon.com.chain.crt" > SSLCACertificatePath"/etc/pki/tls/certs" > WSGIScriptAlias / "/var/www/reviewboard/htdocs/reviewboard.wsgi" > > > > Something else I have noticed is that even with reviewboard in debug mode > (set in System Settings->Logging log level = DEBUG, I don't see anything in > the reviewboard.log file except > 2018-01-15 20:05:00,809 - INFO - - root - Reloading logging settings > Is there a way to get it to report ldap failures there? > > Vince > > > On Monday, January 15, 2018 at 2:59:23 PM UTC-8, Christian Hammond wrote: >> >> Hi Vince, >> >> Is Review Board configured to use the same domain in General Settings as >> you have specified in .reviewboardrc? Can you confirm that for me, and also >> confirm that restarting Apache doesn't fix anything? I'm wondering because >> it sounds like the cookie is being generated for the wrong domain, which >> would mean that upon initial authentication, you're getting a cookie and >> then trying to use it again for the wrong server. Since the RBTools debug >> output has been modified to mask the domain, I can't verify any of this >> myself. >> >> What is your web server configuration like? Is Apache handling all >> requests itself, or are you going through Nginx or another proxy? >> >> Christian >> >> On Mon, Jan 15, 2018 at 2:51 PM, Vince Thyng <vth...@gmail.com> wrote: >> >>> Adding to my previous post, we are seeing django_session table records >>> getting created when the webui is used, and I wasn able to use a sessionid >>> created there wi
Re: How to mark single reviewed file as approved
Hi Michał, Sorry, that's not currently a feature we offer. Perhaps down the road, but per-file approval is not on the road map at this time. It could be built as an extension to Review Board, if you wanted it bad enough. Christian On Fri, Jan 12, 2018 at 10:17 AM, Michał Grochowina <gros...@gmail.com> wrote: > > The functionality is shown here - Eric Brown accepted some files here: > > http://support.smartbear.com/support/media/images/support/ > kb/data/2012/6/26/ws-review-overview-materials.zoom85.png > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "Review Board Community" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Full database schema or conceptual design available for the Review Board database?
Hi Christian, There's not, I'm afraid. It's not something we've ever needed, and directly working with the database is not a common thing (and not something we generally recommend). I'm curious what you're looking to do with the database? For most situations, our recommendation is to either work with the REST API or the Review Board database models (which are in Python) to perform the queries you need. We don't guarantee that the database schema will remain the same each release (we try to keep the Python models compatible, but the schema is considered an implementation detail) or that it's in a form that's easy to get to (diff data, for instance, is compressed and de-duplicated). Christian On Mon, Jan 15, 2018 at 10:48 AM, Christian Kolb <christian.k...@reflex.at> wrote: > Hello! > > I finally managed to query from the MySQL database of my reviewboard > installation (yeah! :-D ). > However for an easier orientation through this table jungle, is there any > database schema or > a conceptual ddatabase design available online for the MySQL database of a > Review Boar installation? > > To give you an example that illustrates what I mean, here is the full > database schema of the Polarion ALM software: > https://almdemo.polarion.com/polarion/sdk/doc/database/FullDBSchema.pdf > > Thanks in advance! > > Best regards, Christian > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "Review Board Community" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Having issue with setting LDAP authentication.
Hi Sami, (Moving this to community support.) I'd need to know more about your setup. Would you be able to share the exact LDAP configuration you have configured, and tell me more about the LDAP server you're running? Are there any errors in reviewboard.log? Do you have other software successfully connecting to this LDAP server? What does their configuration look like? Christian On Mon, Jan 15, 2018 at 1:08 PM, Sami <mojgan.samifa...@gmail.com> wrote: > Hello, > > I am trying to setup LDAP authentication but seems cannot get it to work. > I have the LDAP server and for LDAP base DN I have dc=example,dc=com but > the login does not work. The OS is RHEL 7.4 and reviewboard 3. > > Can you please let me know what am I missing. > > -- > > --- > You received this message because you are subscribed to the Google Groups > "Review Board Development" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: "You are not logged in (HTTP 401, API Error 103)"
e 9, in
>> > load_entry_point('RBTools==0.6.3', 'console_scripts', 'rbt')()
>> > File "/opt/local/Library/Frameworks/Python.framework/Versions/2.
>> 7/lib/python2.7/site-packages/RBTools-0.6.3-py2.7.egg/rbtools/commands/main.py",
>> line 134, in main
>> > command.run_from_argv([RB_MAIN, command_name] + args)
>> > File "/opt/local/Library/Frameworks/Python.framework/Versions/2.
>> 7/lib/python2.7/site-packages/RBTools-0.6.3-py2.7.egg/rbtools/commands/__init__.py",
>> line 416, in run_from_argv
>> > exit_code = self.main(*args) or 0
>> > File "/opt/local/Library/Frameworks/Python.framework/Versions/2.
>> 7/lib/python2.7/site-packages/RBTools-0.6.3-py2.7.egg/rbtools/commands/post.py",
>> line 791, in main
>> > submit_as=self.options.submit_as)
>> > File "/opt/local/Library/Frameworks/Python.framework/Versions/2.
>> 7/lib/python2.7/site-packages/RBTools-0.6.3-py2.7.egg/rbtools/commands/post.py",
>> line 507, in post_request
>> > raise CommandError("Error creating review request: %s" % e)
>> > rbtools.commands.CommandError: Error creating review request: You are
>> not logged in (HTTP 401, API Error 103)
>>
>>
>> I've tried removing ~/.rbtools-cookies, as well as specifying --username
>> and --password on the command line, to no avail. I've tried both posting to
>> https://reviews.reviewboard.org and my company's internal Review Board
>> server (running RB 1.7.19. I'm running Python 2.7.9 on Mac OS X 10.10.1.
>>
>> I'm not sure what triggered this. How should I go about debugging this?
>>
>> -Julian
>>
>> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
--
Christian Hammond
President/CEO of Beanbag <https://www.beanbaginc.com/>
Makers of Review Board <https://www.reviewboard.org/>
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: migrate reviewboard on a new server
Hi Sharon, Most likely, your old database contains some tables in MySQL's MyISAM format. The default for tables these days is InnoDB. You'd probably encounter this error even if you were just upgrading on the same server. The solution is really easy. Take your database backup (which should just be a .sql file) and edit it. Change all occurrences of ENGINE=MyISAM to ENGINE=InnoDB. (Check for case sensitivity issues in here). Then restore the backup and try the upgrade again. It should work this time. You'll probably want to recreate the database on the new server first, just to ensure you're restoring into an empty database. Christian On Fri, Jan 12, 2018 at 2:37 PM, sharon chen <sharon...@gmail.com> wrote: > I tried to migrate reviewboard from an old server to a VM. > > The older server: > OS: SUSE 11.4 > reviewboard: 1.6.3 > > The new server: > centos 7 or ubuntu 16.04 > reviewboard: Review Board 2.5.16 > > > What is the best approach to achieve this? > > > I have tested the following approach: > > 1. create the db backup on the old server (ok) > 2. cp the db backup and restore the db on the new server (ok) > 3. cp the rb site data /var/www/mysite on the new server (ok) > 4. run "rb-site upgrade /var/www/mysite" > > I failed at this step with the following error on both centos and ubuntu > 16.04: > > Applying database evolutions for auth... > Applying database evolutions for contenttypes... > Applying database evolutions for accounts... > Applying database evolutions for attachments... > Applying database evolutions for changedescs... > Applying database evolutions for diffviewer... > Applying database evolutions for reviews... > Database evolutions for reviews failed! > The SQL statement was: ALTER TABLE `reviews_reviewrequest_depends_on` ADD > CONSTRAINT `from_reviewrequest_id_refs_id_623cfa96` FOREIGN KEY > (`from_reviewrequest_id`) REFERENCES `reviews_reviewrequest` (`id`); > The database error was: (1005, 'Can\'t create table > `reviewboard`.`#sql-48c6_5e` (errno: 150 "Foreign key constraint is > incorrectly formed")') > > CommandError: Error applying evolution for reviews: (1005, 'Can\'t create > table `reviewboard`.`#sql-48c6_5e` (errno: 150 "Foreign key constraint is > incorrectly formed")') > > > Could you advice what I missed and how to resolve the issue? Will it be > better when doing "rb-site upgrade" on the old server first, then migrate? > > > Thanks, > Sharon Chen > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "Review Board Community" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Comment Categorization Extension
Hi Lokesh,
Is the server disconnected fully from the Internet, then? How do you
maintain Review Board upgrades?
You can install the extension packages manually. If you downloaded the
*.egg file, you can do:
easy_install .egg
If you downloaded the *.whl, you can do:
pip install .whl
You may need to run those as root, depending on your setup. Note that while
these are simple extensions, more complex ones may require additional
packages as dependencies, which you'd also have to get by hand. Those could
in turn require others.
Christian
On Thu, Jan 11, 2018 at 9:22 PM, Lokesh Rajoria <lokesh.rajo...@gmail.com>
wrote:
> Hi Christian,
>
> we are not behind an HTTP(S) proxy server on the computer due to some
> constraint. is there any way do it offline. I mean we have download all the
> packages from https://pypi.python.org/simple/rbcommenttype/ manually. can
> we do it locally?
>
> Thanks & Regards,
> Lokesh
>
>
> On Friday, 12 January 2018 02:42:53 UTC+5:30, Christian Hammond wrote:
>
>> Hi Lokesh,
>>
>> Looks like you’re having trouble connecting to PyPI itself. Are you
>> behind an HTTP(S) proxy server on that computer? If so, you may need to set
>> the http_proxy and https_proxy environment variables.
>>
>> Christian
>>
>>
>> On Thu, Jan 11, 2018 at 02:44 Lokesh Rajoria <lokesh@gmail.com>
>> wrote:
>>
>>> Hi Reviewboard,
>>>
>>> I am trying to install comment category extension on my fedora21 release.
>>>
>>> $> sudo easy_install -U rbcommenttype
>>> Searching for rbcommenttype
>>> Reading https://pypi.python.org/simple/rbcommenttype/
>>> Download error on https://pypi.python.org/simple/rbcommenttype/: [Errno
>>> -2] Name or service not known -- Some packages may not be found!
>>> Couldn't find index page for 'rbcommenttype' (maybe misspelled?)
>>> Scanning index of all packages (this may take a while)
>>> Reading https://pypi.python.org/simple/
>>> Download error on https://pypi.python.org/simple/: [Errno -2] Name or
>>> service not known -- Some packages may not be found!
>>> No local packages or download links found for rbcommenttype
>>> error: Could not find suitable distribution for
>>> Requirement.parse('rbcommenttype')
>>>
>>> could you please help me on this.
>>>
>>> Thanks & Regards,
>>> Lokesh
>>>
>>>
>>> --
>>> Supercharge your Review Board with Power Pack:
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons:
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "Review Board Community" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to reviewboard...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>> --
>> --
>> Christian Hammond
>> President/CEO of Beanbag
>> Makers of Review Board
>>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
--
Christian Hammond
President/CEO of Beanbag <https://www.beanbaginc.com/>
Makers of Review Board <https://www.reviewboard.org/>
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: Comment Categorization Extension
Hi Lokesh,
Looks like you’re having trouble connecting to PyPI itself. Are you behind
an HTTP(S) proxy server on that computer? If so, you may need to set the
http_proxy and https_proxy environment variables.
Christian
On Thu, Jan 11, 2018 at 02:44 Lokesh Rajoria <lokesh.rajo...@gmail.com>
wrote:
> Hi Reviewboard,
>
> I am trying to install comment category extension on my fedora21 release.
>
> $> sudo easy_install -U rbcommenttype
> Searching for rbcommenttype
> Reading https://pypi.python.org/simple/rbcommenttype/
> Download error on https://pypi.python.org/simple/rbcommenttype/: [Errno
> -2] Name or service not known -- Some packages may not be found!
> Couldn't find index page for 'rbcommenttype' (maybe misspelled?)
> Scanning index of all packages (this may take a while)
> Reading https://pypi.python.org/simple/
> Download error on https://pypi.python.org/simple/: [Errno -2] Name or
> service not known -- Some packages may not be found!
> No local packages or download links found for rbcommenttype
> error: Could not find suitable distribution for
> Requirement.parse('rbcommenttype')
>
> could you please help me on this.
>
> Thanks & Regards,
> Lokesh
>
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
--
--
Christian Hammond
President/CEO of Beanbag
Makers of Review Board
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4627: Diff fragments do not load.
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4627/ -- New update by jhominal For Beanbag, Inc. > Review Board > Ticket #4627 Reply: Fix pushed to release-3.0.x (e6d11ca70537c820081ce0afe58268cd781fa452). Status: - PendingReview + Fixed -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4627: Diff fragments do not load.
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4627/ -- New update by jhominal For Beanbag, Inc. > Review Board > Ticket #4627 Reply: Fix up for review: https://reviews.reviewboard.org/r/9476/ Status: - New + PendingReview Milestones: + Release-3.0.x Tags: - Priority:Medium + Component:Reviews + Priority:High Assigned to: + chipx86 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4627: Diff fragments do not load.
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4627/ -- New update by jhominal For Beanbag, Inc. > Review Board > Ticket #4627 Reply: Turns out this is a Python compatibility issue. As of Python 2.7.7, Unicode strings are allowed. We'll get a patch out for the next release, but for now I'd go with your patch. I'll post our version of it here. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Review Board 3.0.2 is released
Hi everyone, We released Review Board 3.0.2 this morning. It's a large bug fix release that covered the major issues brought to our attention since the release of Review Board 3.0. See https://www.reviewboard.org/news/2018/01/09/review-board-3-0-2-is-out-now/ for the highlights of the release. Christian -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4626: Adding Gitlab Hosting account fails since Gitlab 10.2.0 (2017-11-22)
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4626/ -- New update by hboomsma For Beanbag, Inc. > Review Board > Ticket #4626 Reply: Hrm, removing long-existing API without bumping the version number is pretty bad practice and makes things very difficult. APIs simply shouldn't do that. We're pushing out Review Board 3.0.2 tonight, but the plan is to get the new GitLab API v4 support in for 3.0.3, which will resolve this. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4626: Adding Gitlab Hosting account fails since Gitlab 10.2.0 (2017-11-22)
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4626/ -- New update by hboomsma For Beanbag, Inc. > Review Board > Ticket #4626 Status: - New + Confirmed Milestones: + Release-2.5.x + Release-3.0.x Tags: - Priority:Medium + Component:HostingServices + Priority:High Assigned to: + brennie -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4626: Adding Gitlab Hosting account fails since Gitlab 10.2.0 (2017-11-22)
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4626/ -- New update by hboomsma For Beanbag, Inc. > Review Board > Ticket #4626 Reply: We make use of /api/v3/session, not /api/v4/session. That URL, last we saw, _should_ be there still. We are working on API v4 support, and have an initial change up for review at the moment that will conditionally use the API, but I want to figure out first what you're seeing exactly. Does /api/v3/session show anything on your install? -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: rbt post fails with git cat-file: could not get object info
Hi Caroline, I'd be interested in seeing how you're handling keeping the clone active. I'm not sure what command he ran exactly, so I don't want to give the wrong advice for your setup. Does the clone exist solely for Review Board? Where does the main repository live? Christian On Mon, Jan 8, 2018 at 12:33 PM, Caroline <binpang0...@gmail.com> wrote: > Hi, > > I have same issue here. > > Could you post your command of how to do reset here? > > Thanks > > C > > > On Monday, March 6, 2017 at 7:04:02 AM UTC-8, Greg Burcher wrote: >> >> Thanks Christian. Our RB server keeps a local repository, and pulls via >> cron job to stay current. When we checked that local repository, there were >> merge conflicts, so all the pulls had been failing for a few days. I have >> no idea why that repository would have merge conflicts, but we reset and >> now all is well. Thanks again for your reply. That was the clue that set us >> on the right track to resolve the issue. >> >> On Friday, March 3, 2017 at 4:01:22 PM UTC-5, Christian Hammond wrote: >>> >>> Hi Greg, >>> >>> Are older diffs in Review Board able to load? (Ones that would have >>> fallen out of cache). I'm curious if this is something affecting only newer >>> diffs. >>> >>> This is often due to changes on the Git repository. Mirroring may be >>> failing, for instance, if this is a clone of the main repository. >>> >>> Might want to also manually run some commands on that Git repository and >>> see if the state of the tree looks correct. >>> >>> Christian >>> >>> >>> On Fri, Mar 3, 2017 at 09:15 Greg Burcher <gregb...@gmail.com> wrote: >>> >>>> Not sure what has changed in our configuration or repository that could >>>> be the problem. We have been using reviewboard for a couple of years. In >>>> the past couple of days, "rbt post" is failing for multiple users with: >>>> >>>> rbtools.commands.CommandError: Error validating diff >>>> >>>> The specified diff file could not be parsed. (HTTP 400, API Error 224) >>>> >>>> I used --debug and got this detail, with certain fields obfuscated: >>>> >>>> $ rbt post --debug --tracking-branch=origin/myTrackingBranch >>>> >>> RBTools 0.7.4 >>>> >>> Python 2.7.6 (default, Nov 10 2013, 19:24:18) [MSC v.1500 32 bit >>>> (Intel)] >>>> >>> Running on Windows-7-6.1.7601-SP1 >>>> >>> Home = C:\Users\myUserName\AppData\Roaming >>>> >>> Current directory = C:\myDirectory >>>> >>> Running: git version >>>> >>> Checking for a Subversion repository... >>>> >>> Unable to execute "svn help": skipping SVN >>>> >>> Checking for a Git repository... >>>> >>> Running: git rev-parse --git-dir >>>> >>> Running: git config core.bare >>>> >>> Running: git rev-parse --show-toplevel >>>> >>> Running: git symbolic-ref -q HEAD >>>> >>> Running: git config --get branch.myBranchName.merge >>>> >>> Command exited with rc 1: ['git', 'config', '--get', >>>> u'branch.myBranchName.merge'] >>>> --- >>>> >>> Running: git config --get branch.myBranchName.remote >>>> >>> Command exited with rc 1: ['git', 'config', '--get', >>>> u'branch.myBranchName.remote'] >>>> --- >>>> >>> Running: git config --get remote.origin.url >>>> >>> repository info: Path: https://myUserName@myGitServer >>>> /bitbucket/scm/myRepository.git, Base path: , Supports changesets: >>>> False >>>> >>> Making HTTP GET request to http://myReviewBoardServer/api/ >>>> >>> Running: git rev-parse refs/heads/myBranchName >>>> >>> Running: git merge-base 71f1767180902f1cf6b3defbc8d5a9869576bf25 >>>> origin/myTrackingBranch >>>> >>> Running: git rev-parse 2250f117eedb858afeaf824e2c45b22246a1d2fa >>>> >>> Running: git status --porcelain --untracked-files=no >>>> >>> Running: git rev-parse --git-dir >>>> >>> Running: git -c core.quotepath=false -c diff.noprefix=false diff >>>> --no-color --full-index --ignore-submodules -M --no-ext-diff >>>> 2250f117eedb858afeaf824e2c45b22246a1d2fa..71f1767180902f1cf6 >>>> b3defbc8d5a98695
This week's reviewboard@googlegroups.com outage
Hi everyone, Some of you have encountered problems trying to post to or view this list/Google Group. It's working again, and I wanted to share what little we know about what happened. On Friday, we attempted to post to the group and got a bounce back stating that it may no longer be valid. That sure caught us by surprise, so I went to the URL for the group and saw that it was "banned" or "malicious content, spam, or illegal activity." Now, we aggressively moderate the list, so we were surprised to see this, and an investigation didn't reveal any new content that should have been a problem. We were not informed that the group was banned, and with the holidays being largely responsible for some pretty low traffic, we're not sure how long the group was down. If anyone can help pinpoint this, that would be great. We only found out Friday. We immediately filed an appeal. This process is opaque. We have a button to press, a confirmation button, and nothing else, so we followed that up by reaching out to anyone we could at Google. At 2AM PST on Saturday, the group was brought back to life, but again without any notification sent to us. We're not sure if the ban was the result of an algorithm finding something it believed was concerning in a post (perhaps in a log file or source code), or if someone for some reason decided to report the group for abuse. We're aware of this having happened to other development-related groups over the year, for what that's worth. Unfortunately, there's no word from Google about any of this, so we're in the dark for now. We're asking who we can within Google to help determine the cause. Paid support users were unaffected by this outage, as we use a separate service that's more under our control for any private support requests for those under a contract. For now, everything is back up and I'm monitoring all our groups closely. Going forward, we're evaluating a successor to this group. That might be another Google Group backed by our domain (meaning reviewboard@googlegroups.com could become something like community-l...@reviewboard.org, for example), or moving to a service like Discourse. There are tradeoffs with the different options, so we want to think about it closely before impacting everyone here. If you were impacted by the outage, please accept my apologies for that. If you ever have issues reaching out here, the reviewboard-dev group can work as a substitute, and we have a Subreddit at https://www.reddit.com/r/reviewboard/ that can work well for some questions and discussion. Thanks, Christian -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: We are facing a 505 error while accessing any past reviews requests
Hi Imad, Looks like this was sent to the wrong list. This is the notification list for our issue tracker, not the community support list. You'll need to post to reviewbo...@googlegroups.com. Christian On Fri, Jan 5, 2018 at 3:44 AM, Imad Khalid <imadkha...@gmail.com> wrote: > Suddenly from few days we are facing an error while accessing any past > review requests. If we access new created requests then its coming fine. > The error is this. > > > Something broke! (Error 500) > It appears something broke when you tried to go to here. This is either a > bug in Review Board or a server configuration error. Please report this to > your administrator. > > -- > You received this message because you are subscribed to the Google Groups > "reviewboard-issues" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard-issues+unsubscr...@googlegroups.com. > To post to this group, send email to reviewboard-issues@googlegroups.com. > Visit this group at https://groups.google.com/group/reviewboard-issues. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Server error - server 10.203.252.13 is unreachable at this moment.
Hi Lokesh,
Looks like your requests are going through the Zscaler HTTP proxy, which
isn't able to access your server's IP. You can override this with the
--disable-proxy argument to any RBTools commands (which you can also set in
your ~/.reviewboardrc as: ENABLE_PROXY = False)
Christian
On Wed, Dec 27, 2017 at 6:40 AM, Lokesh Rajoria <lokesh.rajo...@gmail.com>
wrote:
> Hi ReviewBoard,
>
> I have added two svn and git repo in reviewboard admin page
> for svn:
> added successful and .reviewboardrc file generated
>
> for GIT:
> Path: /var/www/reviews.tilte.com/TILTE_GIT.git
> Mirror Path: /var/www/reviews.tilte.com/TILTE_GIT.git
>
> TILTE_GIT.git config:
> $ $ vi config
> [core]
> repositoryformatversion = 0
> filemode = true
> bare = true
> [remote "origin"]
> url = ssh://root@10.203.252.13/home/tilte/git_checkout/TILTE
> fetch = +refs/*:refs/*
> mirror = true
>
> repository Path: /home/tilte/git_checkout/TILTE
> running command
> $rbt setup-repo -d
>
> [root@localhost TILTE]# rbt setup-repo -d
> >>> RBTools 0.7.4
> >>> Python 2.7.8 (default, Sep 24 2015, 18:25:44)
> [GCC 4.9.2 20150212 (Red Hat 4.9.2-6)]
> >>> Running on Linux-4.1.13-100.fc21.i686-i686-with-fedora-21-Twenty_One
> >>> Home = /root
> >>> Current directory = /home/tilte/git_checkout/TILTE
> Enter the Review Board server URL: 10.203.252.13
> >>> Running: git version
> >>> Checking for a Subversion repository...
> >>> Running: svn --non-interactive info
> >>> Command exited with rc 1: ['svn', '--non-interactive', u'info']
> svn: E155007: '/home/tilte/git_checkout/TILTE' is not a working copy
> ---
> >>> Checking for a Git repository...
> >>> Running: git rev-parse --git-dir
> >>> Running: git config core.bare
> >>> Running: git symbolic-ref -q HEAD
> >>> Running: git config --get branch.master.merge
> >>> Command exited with rc 1: ['git', 'config', '--get',
> u'branch.master.merge']
> ---
> >>> Running: git config --get branch.master.remote
> >>> Command exited with rc 1: ['git', 'config', '--get',
> u'branch.master.remote']
> ---
> >>> Running: git config --get remote.origin.url
> >>> repository info: Path: ssh://root@10.203.252.13/home/
> tilte/git_checkout/TILTE, Base path: , Supports changesets: False
> >>> Making HTTP GET request to http://10.203.252.13/api/
> >>> Got HTTP error: 504: 504 Gateway
> Timeout
> Gateway Timeout
> Server error - server 10.203.252.13 is unreachable at this
> moment.Please retry the request or contact your
> administrator.
>
> Traceback (most recent call last):
> File "/bin/rbt", line 9, in
> load_entry_point('RBTools==0.7.4', 'console_scripts', 'rbt')()
> File "/usr/lib/python2.7/site-packages/rbtools/commands/main.py", line
> 133, in main
> command.run_from_argv([RB_MAIN, command_name] + args)
> File "/usr/lib/python2.7/site-packages/rbtools/commands/__init__.py",
> line 612, in run_from_argv
> exit_code = self.main(*args) or 0
> File "/usr/lib/python2.7/site-packages/rbtools/commands/setup_repo.py",
> line 110, in main
> api_client, api_root = self.get_api(server)
> File "/usr/lib/python2.7/site-packages/rbtools/commands/__init__.py",
> line 768, in get_api
> raise CommandError('Unexpected API Error: %s' % e)
> rbtools.commands.CommandError: Unexpected API Error: HTTP 504
>
> .reviewboardrc will generates if command get successful
>
> Please help me to solve this issue. There is no issue to adding svn repo
> but git repo facing issue.
>
> Thanks & Regards,
> Lokesh
>
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
--
Christian Hammond
President/CEO of Beanbag <https://www.beanbaginc.com/>
Makers of Review Board <https://www.reviewboard.org/>
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: Going to Reviewboard Repositories with error by admin user
Hi, Can you provide more info about your install? What version of Review Board are you using? Did you just recently upgrade? What’s the repro case? Christian On Thu, Dec 21, 2017 at 08:19 Jianchun Lu <yourfor...@gmail.com> wrote: > Hi Sir, > > > 2017-12-21 09:39:58,086 - ERROR - None - admin - > /admin/db/scmtools/repository/227/ - Exception thrown for user admin at > http://reviewboard.***.com/admin/db/scmtools/repository/227/ > > argument of type 'NoneType' is not iterable > Traceback (most recent call last): > File > "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line > 112, in get_response > response = wrapped_callback(request, *callback_args, **callback_kwargs) > File > "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/options.py", > line 465, in wrapper > return self.admin_site.admin_view(view)(*args, **kwargs) > File > "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py", line > 99, in _wrapped_view > response = view_func(request, *args, **kwargs) > File > "/usr/local/lib/python2.7/dist-packages/django/views/decorators/cache.py", > line 52, in _wrapped_view_func > response = view_func(request, *args, **kwargs) > File > "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/sites.py", > line 198, in inner > return view(request, *args, **kwargs) > File > "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py", line > 29, in _wrapper > return bound_func(*args, **kwargs) > File > "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py", line > 99, in _wrapped_view > response = view_func(request, *args, **kwargs) > File > "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py", line > 25, in bound_func > return func(self, *args2, **kwargs2) > File "/usr/local/lib/python2.7/dist-packages/django/db/transaction.py", > line 371, in inner > return func(*args, **kwargs) > File > "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/options.py", > line 1270, in change_view > form = ModelForm(instance=obj) > File > "/usr/local/lib/python2.7/dist-packages/reviewboard/scmtools/forms.py", > line 297, in __init__ > hosting_accounts) > File > "/usr/local/lib/python2.7/dist-packages/reviewboard/scmtools/forms.py", > line 471, in _get_hosting_service_info > if account.service_name == hosting_service.id > File > "/usr/local/lib/python2.7/dist-packages/reviewboard/hostingsvcs/models.py", > line 54, in is_authorized > return service.is_authorized() > File > "/usr/local/lib/python2.7/dist-packages/reviewboard/hostingsvcs/gitlab.py", > line 279, in is_authorized > return 'private_token' in self.account.data > TypeError: argument of type 'NoneType' is not iterable > > > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -- Christian Hammond President/CEO of Beanbag Makers of Review Board -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Review link in email notification is wrong on RB 3.0.1
Hi, We have a fix for this coming in the next release, which will be after the holidays. Christian On Thu, Dec 21, 2017 at 08:19 <sin...@stronghold.kr> wrote: > Hi, > > I've just finished upgrading reviewboard from v2.5.16 to v3.0.1. > [installed via bitnami] > After the upgrading, email notification has the wrong review link. > Below quote is an example, application name reviewboard was added twice to > the URL. > >> This is an automatically generated e-mail. To reply, visit: >> http://192.168.0.250:8081/*reviewboard/*/reviewboard/r/107/ > > > I've checked that Server URL setting [http://192.168.0.250:8081] seems > correct in Admin > General Settings. > And it shouldn't be related to upgrading from the old one, because I > installed fresh new reviewboard v3.0.1 [via bitnami as well], and it also > has the same problem. > > If I want to fix this issue, what do I have to do? Might be > bitnami package problem? > > Thank you in advance. > > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -- Christian Hammond President/CEO of Beanbag Makers of Review Board -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: How to set extra_data for review model in RVB3.0?
I haven’t been able to fix it yet. With the holidays coming up, things have been busy, and we’ve had a couple higher-priority bugs taking our time. I’ll make my way back to this soon though. Christian On Tue, Dec 19, 2017 at 18:27 Xy Sui <oswi...@gmail.com> wrote: > Hi Christian, > > Any progress on this topic? > > BR > oswicer > > > On Thursday, December 14, 2017 at 7:00:10 PM UTC+8, Xy Sui wrote: > >> Hi, >> >> I'm getting desperate after hours' searching/trying... One of our >> extensions doesn't work now in RVB3.0 because previous setExtraData method >> doesn't work anymore for review model. >> >> In my implementation, I wrote one RB.ReviewDialogHook javascript hook >> with one customized view. And I would like to save some data in model >> Review's extraData field. I noticed model Review does have "setExtraData" >> method, but it's not working... >> >> And it looks like the extension rbstopwatch also saves data in >> extra_data, while the extension is broken in RVB 3.0 as well. So I couldn't >> find one working example either. >> >> Could anybody help? Or anybody has one working example for extra_data >> setting in javascript? >> >> Thanks. >> >> BR >> oswicer >> >> >> -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -- Christian Hammond President/CEO of Beanbag Makers of Review Board -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4621: Enhancement on screenshot view
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4621/ -- New update by bhsiung For Beanbag, Inc. > Review Board > Ticket #4621 Reply: This improvement was released as part of Review Board 3.0. Your system administrator will need to upgrade in order to get it. Status: - New + Fixed Milestones: + Release-3.0.x -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4617: Diff fragments do not load correctly when the fragment contains non-ASCII characters
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4617/ -- New update by jhominal For Beanbag, Inc. > Review Board > Ticket #4617 Reply: So the plan was to put in the character counts instead of byte lengths as a temporary measure just for this release, so that we could ship tomorrow. However, given that it didn't really solve the problem, and given that the holidays are coming up, we're going to delay the release to the week after Christmas and do this right. The proper solution, which I've been working on, is to retain byte strings and move to binary parsing on the client side. We'll be loading all data into an `ArrayBuffer`, parsing that out, grabbing byte lengths, and then converting the chunks of content into JavaScript strings via JavaScript's `Blob` and `FileReader`. I have this working locally, and reliably, but it still needs additional love and testing. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4620: Diff fragments do not load correctly when the fragment contains non-BMP characters
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4620/ -- New update by jhominal For Beanbag, Inc. > Review Board > Ticket #4620 Reply: Moving discussion over to bug #4617, since the bug isn't truly fixed. Status: - New + Duplicate Duplicate of: + 4617 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4617: Diff fragments do not load correctly when the fragment contains non-ASCII characters
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4617/ -- New update by jhominal For Beanbag, Inc. > Review Board > Ticket #4617 Reply: You're right, this is a problem. I'd like to reuse this bug for any further discussion on this, since the core problem is not truly fixed. Reopening. Status: - Fixed + Confirmed -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4617: Diff fragments do not load correctly when the fragment contains non-ASCII characters
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4617/ -- New update by jhominal For Beanbag, Inc. > Review Board > Ticket #4617 Reply: Fixed on release-3.0.x (4f73586b29857839648043988b7193645e76d12f) Status: - Confirmed + Fixed -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Uploaded Avatar issues with http/https in RB 3.0.1
That was exactly the problem. We're no longer normalizing the casing at the right place. We'll have a fix in for the next point release (aiming for Tuesday). Christian On Fri, Dec 15, 2017 at 1:37 PM, Christian Hammond <christ...@beanbaginc.com > wrote: > It very well could be. I’ll investigate that possibility. > > Christian > > > On Fri, Dec 15, 2017 at 08:11 Peter Hodgson <peterb.hodg...@gmail.com> > wrote: > >> Hi Christian, >> >> Interesting, okay, >> >> I'm seeing the issue across the board everywhere an avatar is expected, >> the dashboard, infoboxes, and the user page itself. Instead of the expected >> gravatar avatar I see the default white silhouette on a grey circular >> background. >> >> Previous examples non-redacted (I didn't really need to). >> >> v2.5.17 - working for all ldap users >> https://secure.gravatar.com/avatar/ >> 483f151626d3ac0ec8a1c5d443dc57ee?s=24d=mm >> <https://secure.gravatar.com/avatar/330e7f60f1888b8f6e?s=24d=mm>" >> width="24" height="24" alt="peter.hodgson" class="gravatar"> >> >> v3.0.1 - not working for *most *ldap users >> https://secure.gravatar.com/avatar/ >> 483f151626d3ac0ec8a1c5d443dc57ee?s=24d=mm >> <https://secure.gravatar.com/avatar/483f151626d3ac?s=24d=mm>" >> alt="Peter Hodgson" width="24" height="24" srcset="https://secure. >> gravatar.com/avatar/483f151626d3ac0ec8a1c5d443dc57ee?s=24d=mm >> <https://secure.gravatar.com/avatar/483f151626d3a?s=24d=mm> 1x, >> https://secure.gravatar.com/avatar/483f151626d3ac0ec8a1c5d443dc57 >> ee?s=72d=mm >> <https://secure.gravatar.com/avatar/483f151626d3a?s=72d=mm> 3x, >> https://secure.gravatar.com/avatar/483f151626d3ac0ec8a1c5d443dc57 >> ee?s=48d=mm >> <https://secure.gravatar.com/avatar/483f151626d3a?s=48d=mm> 2x" >> class="avatar"> >> >> Looking directly at user emails shows up something interesting. I have >> discovered one ldap user who still has a working gravatar in 3.0.1, his >> username and email do not consist of Firstname.Lastname and is a lower case >> abbreviation. Looking at the difference between my user (non working >> gravatar) and the admin user with my email address (working gravatar) the >> difference in email address is that the admin one is all lowercase rather >> than capitalised first letters. None of these email addresses have been >> changed across versions but it seems none with an upper case letter still >> work. >> >> Case sensitive hashing now perhaps? Seems unlikely. >> >> Thanks again, >> Peter >> >> On Thursday, 14 December 2017 20:20:42 UTC, Christian Hammond wrote: >> >>> Hi Peter, >>> >>> The LDAP code hasn't changed between the releases. When logging in via >>> LDAP for the first time, a local User entry is created with details coming >>> from LDAP, but those details aren't re-queried from LDAP later, so a user >>> that existed in 2.5.17 should have the same details as one in 3.0.1. >>> >>> The difference in alt text is just the new template factoring in full >>> names. I checked the logic for building the hashes, and they seem to be the >>> same. Can you verify the stored e-mail addresses for those users on both >>> versions? >>> >>> Where are you seeing the bad Gravatars? What shows up in their place? >>> >>> Christian >>> >> >>> On Thu, Dec 14, 2017 at 4:04 AM, Peter Hodgson <peterb@gmail.com> >>> wrote: >>> >>>> Sorry to be so noisy Christian, I'm now seeing problems with gravatar >>>> sourced images. The switch to v3x has moved to use a srcset which makes >>>> sense but the actual links being used have changed. >>>> >>>> At a wild guess it looks like it's related to ldap use, possibly >>>> different fields being used to generate the gravatar link? >>>> >>>> v2.5.17 - working for ldap users >>>> https://secure.gravatar.com/avatar/ >>>> 330e7f60f1888b8f6e?s=24d=mm" width="24" height="24" >>>> alt="peter.hodgson" class="gravatar"> >>>> >>>> v3.0.1 - not working for ldap users >>>> https://secure.gravatar.com/avatar/483f151626d3ac? >>>> s=24d=mm" alt="Peter Hodgson" width="24" height="24" srcset=" >>>> https://secure.gravatar.co
Re: How to set extra_data for review model in RVB3.0?
That’s definitely the wrong form for it to be sending. It should show up as
“extra_data.veto=1”. You see the same behavior in your extension?
That repro case is helpful. I’m going to dig into that.
Christian
On Thu, Dec 14, 2017 at 22:46 Xy Sui <oswi...@gmail.com> wrote:
> Hi,
>
> I'm testing the setExtraData in this way now (also to simply the code
> demonstration here)
>
> In reviewboard/static/rb/js/views/reviewDialogView.es6.js, method
> "_saveReview". I added/modified 2 lines inside the 1st block f of
> funcQueue('reviewForm').add:
>
> *this.model.setExtraData("veto", 1);*
>
> and
>
> saveFunc.call(this.model, {
> attrs: ['public', 'shipIt', 'forceTextType',
>'includeTextTypes', 'publishToOwnerOnly','
> *extraData*'],
>
> The expected result is each time one review is saved ,the "veto" field in
> extra_data will be saved as well. And I got the payload in client side is:
>
> api_format=json=1_it=false_text_type=html_text_types=raw%2Cmarkdown_data%5Bveto%5D=1
>
> You could see one param "extra_data[veto]:
> 1" is included inside, while the review resource API doesn't accept it
> because it only accepts 3 forms: extra_data:json, extra_data:json-patch and
> extra_data.xxx
>
> In my payload, the key name with square brackets "[veto]" is not taken as
> correct extra_data fields.
>
> I got the same results in FX and chrome.
>
> Do you have the example code for modified rbstopwatch?
>
>
>
> On Thursday, December 14, 2017 at 7:00:10 PM UTC+8, Xy Sui wrote:
>>
>> Hi,
>>
>> I'm getting desperate after hours' searching/trying... One of our
>> extensions doesn't work now in RVB3.0 because previous setExtraData method
>> doesn't work anymore for review model.
>>
>> In my implementation, I wrote one RB.ReviewDialogHook javascript hook
>> with one customized view. And I would like to save some data in model
>> Review's extraData field. I noticed model Review does have "setExtraData"
>> method, but it's not working...
>>
>> And it looks like the extension rbstopwatch also saves data in
>> extra_data, while the extension is broken in RVB 3.0 as well. So I couldn't
>> find one working example either.
>>
>> Could anybody help? Or anybody has one working example for extra_data
>> setting in javascript?
>>
>> Thanks.
>>
>> BR
>> oswicer
>>
>>
>> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
--
--
Christian Hammond
President/CEO of Beanbag
Makers of Review Board
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: Uploaded Avatar issues with http/https in RB 3.0.1
It very well could be. I’ll investigate that possibility. Christian On Fri, Dec 15, 2017 at 08:11 Peter Hodgson <peterb.hodg...@gmail.com> wrote: > Hi Christian, > > Interesting, okay, > > I'm seeing the issue across the board everywhere an avatar is expected, > the dashboard, infoboxes, and the user page itself. Instead of the expected > gravatar avatar I see the default white silhouette on a grey circular > background. > > Previous examples non-redacted (I didn't really need to). > > v2.5.17 - working for all ldap users > https://secure.gravatar.com/avatar/483f151626d3ac0ec8a1c5d443dc57ee?s=24d=mm > <https://secure.gravatar.com/avatar/330e7f60f1888b8f6e?s=24d=mm>" > width="24" height="24" alt="peter.hodgson" class="gravatar"> > > v3.0.1 - not working for *most *ldap users > https://secure.gravatar.com/avatar/483f151626d3ac0ec8a1c5d443dc57ee?s=24d=mm > <https://secure.gravatar.com/avatar/483f151626d3ac?s=24d=mm>" > alt="Peter Hodgson" width="24" height="24" srcset=" > https://secure.gravatar.com/avatar/483f151626d3ac0ec8a1c5d443dc57ee?s=24d=mm > <https://secure.gravatar.com/avatar/483f151626d3a?s=24d=mm> 1x, > https://secure.gravatar.com/avatar/483f151626d3ac0ec8a1c5d443dc57ee?s=72d=mm > <https://secure.gravatar.com/avatar/483f151626d3a?s=72d=mm> 3x, > https://secure.gravatar.com/avatar/483f151626d3ac0ec8a1c5d443dc57ee?s=48d=mm > <https://secure.gravatar.com/avatar/483f151626d3a?s=48d=mm> 2x" > class="avatar"> > > Looking directly at user emails shows up something interesting. I have > discovered one ldap user who still has a working gravatar in 3.0.1, his > username and email do not consist of Firstname.Lastname and is a lower case > abbreviation. Looking at the difference between my user (non working > gravatar) and the admin user with my email address (working gravatar) the > difference in email address is that the admin one is all lowercase rather > than capitalised first letters. None of these email addresses have been > changed across versions but it seems none with an upper case letter still > work. > > Case sensitive hashing now perhaps? Seems unlikely. > > Thanks again, > Peter > > On Thursday, 14 December 2017 20:20:42 UTC, Christian Hammond wrote: > >> Hi Peter, >> >> The LDAP code hasn't changed between the releases. When logging in via >> LDAP for the first time, a local User entry is created with details coming >> from LDAP, but those details aren't re-queried from LDAP later, so a user >> that existed in 2.5.17 should have the same details as one in 3.0.1. >> >> The difference in alt text is just the new template factoring in full >> names. I checked the logic for building the hashes, and they seem to be the >> same. Can you verify the stored e-mail addresses for those users on both >> versions? >> >> Where are you seeing the bad Gravatars? What shows up in their place? >> >> Christian >> > >> On Thu, Dec 14, 2017 at 4:04 AM, Peter Hodgson <peterb@gmail.com> >> wrote: >> >>> Sorry to be so noisy Christian, I'm now seeing problems with gravatar >>> sourced images. The switch to v3x has moved to use a srcset which makes >>> sense but the actual links being used have changed. >>> >>> At a wild guess it looks like it's related to ldap use, possibly >>> different fields being used to generate the gravatar link? >>> >>> v2.5.17 - working for ldap users >>> https://secure.gravatar.com/avatar/330e7f60f1888b8f6e?s=24d=mm; >>> width="24" height="24" alt="peter.hodgson" class="gravatar"> >>> >>> v3.0.1 - not working for ldap users >>> https://secure.gravatar.com/avatar/483f151626d3ac?s=24d=mm; >>> alt="Peter Hodgson" width="24" height="24" srcset=" >>> https://secure.gravatar.com/avatar/483f151626d3a?s=24d=mm 1x, >>> https://secure.gravatar.com/avatar/483f151626d3a?s=72d=mm 3x, >>> https://secure.gravatar.com/avatar/483f151626d3a?s=48d=mm 2x" >>> class="avatar"> >>> >>> however the non-ldap admin user which has my email address is still >>> working in v3.0.1 >>> https://secure.gravatar.com/avatar/330e7f60f1888b8f6e?s=24d=mm; >>> alt="admin" width="24" height="24" srcset=" >>> https://secure.gravatar.com/avatar/330e7f60f1888b8f6e?s=24d=mm >>> 1x, >>> https://secure.gravatar.com/avatar/330e7
Re: Review Board Ticket #4617: Diff fragments do not load correctly when the fragment contains non-ASCII characters
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4617/ -- New update by jhominal For Beanbag, Inc. > Review Board > Ticket #4617 Reply: Thanks for the report and the patched code. I'll get a repro case going and get this into the next release. Status: - New + Confirmed Milestones: + Release-3.0.x Tags: + Component:DiffViewer Assigned to: + chipx86 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: How to set extra_data for review model in RVB3.0?
I can confirm that when updating rbstopwatch to use setExtraData() followed by a save(), it works properly. I'd need to see what your code and the data from the browser looks like to figure out what's going wrong. Christian On Thu, Dec 14, 2017 at 12:31 PM, Christian Hammond < christ...@beanbaginc.com> wrote: > Sorry, I realize rbstopwatch isn't using setExtraData, but rather setting > extraData manually. I'm going to toy with the code here, see if I can > reproduce the problem. > > Christian > > On Thu, Dec 14, 2017 at 12:29 PM, Christian Hammond < > christ...@beanbaginc.com> wrote: > >> Hi, >> >> Can you show me your code that both sets this and then saves the review, >> along with what the browser is reporting being sent to and received from >> the server? (Full headers and payloads would help.) >> >> rbstopwatch was indeed broken (fix coming in RB 3.0.2), but once I fixed >> that, setExtraData did work properly, so I'm wondering if there's a change >> that's impacting your code in a more subtle way. >> >> Christian >> >> On Thu, Dec 14, 2017 at 3:00 AM, Xy Sui <oswi...@gmail.com> wrote: >> >>> Hi, >>> >>> I'm getting desperate after hours' searching/trying... One of our >>> extensions doesn't work now in RVB3.0 because previous setExtraData method >>> doesn't work anymore for review model. >>> >>> In my implementation, I wrote one RB.ReviewDialogHook javascript hook >>> with one customized view. And I would like to save some data in model >>> Review's extraData field. I noticed model Review does have "setExtraData" >>> method, but it's not working... >>> >>> And it looks like the extension rbstopwatch also saves data in >>> extra_data, while the extension is broken in RVB 3.0 as well. So I couldn't >>> find one working example either. >>> >>> Could anybody help? Or anybody has one working example for extra_data >>> setting in javascript? >>> >>> Thanks. >>> >>> BR >>> oswicer >>> >>> >>> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to reviewboard+unsubscr...@googlegroups.com. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> >> >> -- >> Christian Hammond >> President/CEO of Beanbag <https://www.beanbaginc.com/> >> Makers of Review Board <https://www.reviewboard.org/> >> > > > > -- > Christian Hammond > President/CEO of Beanbag <https://www.beanbaginc.com/> > Makers of Review Board <https://www.reviewboard.org/> > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: How to set extra_data for review model in RVB3.0?
Sorry, I realize rbstopwatch isn't using setExtraData, but rather setting extraData manually. I'm going to toy with the code here, see if I can reproduce the problem. Christian On Thu, Dec 14, 2017 at 12:29 PM, Christian Hammond < christ...@beanbaginc.com> wrote: > Hi, > > Can you show me your code that both sets this and then saves the review, > along with what the browser is reporting being sent to and received from > the server? (Full headers and payloads would help.) > > rbstopwatch was indeed broken (fix coming in RB 3.0.2), but once I fixed > that, setExtraData did work properly, so I'm wondering if there's a change > that's impacting your code in a more subtle way. > > Christian > > On Thu, Dec 14, 2017 at 3:00 AM, Xy Sui <oswi...@gmail.com> wrote: > >> Hi, >> >> I'm getting desperate after hours' searching/trying... One of our >> extensions doesn't work now in RVB3.0 because previous setExtraData method >> doesn't work anymore for review model. >> >> In my implementation, I wrote one RB.ReviewDialogHook javascript hook >> with one customized view. And I would like to save some data in model >> Review's extraData field. I noticed model Review does have "setExtraData" >> method, but it's not working... >> >> And it looks like the extension rbstopwatch also saves data in >> extra_data, while the extension is broken in RVB 3.0 as well. So I couldn't >> find one working example either. >> >> Could anybody help? Or anybody has one working example for extra_data >> setting in javascript? >> >> Thanks. >> >> BR >> oswicer >> >> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard+unsubscr...@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. >> > > > > -- > Christian Hammond > President/CEO of Beanbag <https://www.beanbaginc.com/> > Makers of Review Board <https://www.reviewboard.org/> > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: How to set extra_data for review model in RVB3.0?
Hi, Can you show me your code that both sets this and then saves the review, along with what the browser is reporting being sent to and received from the server? (Full headers and payloads would help.) rbstopwatch was indeed broken (fix coming in RB 3.0.2), but once I fixed that, setExtraData did work properly, so I'm wondering if there's a change that's impacting your code in a more subtle way. Christian On Thu, Dec 14, 2017 at 3:00 AM, Xy Sui <oswi...@gmail.com> wrote: > Hi, > > I'm getting desperate after hours' searching/trying... One of our > extensions doesn't work now in RVB3.0 because previous setExtraData method > doesn't work anymore for review model. > > In my implementation, I wrote one RB.ReviewDialogHook javascript hook with > one customized view. And I would like to save some data in model Review's > extraData field. I noticed model Review does have "setExtraData" method, > but it's not working... > > And it looks like the extension rbstopwatch also saves data in extra_data, > while the extension is broken in RVB 3.0 as well. So I couldn't find one > working example either. > > Could anybody help? Or anybody has one working example for extra_data > setting in javascript? > > Thanks. > > BR > oswicer > > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Uploaded Avatar issues with http/https in RB 3.0.1
Hi Peter, The LDAP code hasn't changed between the releases. When logging in via LDAP for the first time, a local User entry is created with details coming from LDAP, but those details aren't re-queried from LDAP later, so a user that existed in 2.5.17 should have the same details as one in 3.0.1. The difference in alt text is just the new template factoring in full names. I checked the logic for building the hashes, and they seem to be the same. Can you verify the stored e-mail addresses for those users on both versions? Where are you seeing the bad Gravatars? What shows up in their place? Christian On Thu, Dec 14, 2017 at 4:04 AM, Peter Hodgson <peterb.hodg...@gmail.com> wrote: > Sorry to be so noisy Christian, I'm now seeing problems with gravatar > sourced images. The switch to v3x has moved to use a srcset which makes > sense but the actual links being used have changed. > > At a wild guess it looks like it's related to ldap use, possibly different > fields being used to generate the gravatar link? > > v2.5.17 - working for ldap users > https://secure.gravatar.com/avatar/330e7f60f1888b8f6e?s=24; > amp;d=mm" width="24" height="24" alt="peter.hodgson" class="gravatar"> > > v3.0.1 - not working for ldap users > https://secure.gravatar.com/avatar/483f151626d3ac? > s=24d=mm" alt="Peter Hodgson" width="24" height="24" srcset=" > https://secure.gravatar.com/avatar/483f151626d3a?s=24d=mm 1x, > https://secure.gravatar.com/avatar/483f151626d3a?s=72d=mm 3x, > https://secure.gravatar.com/avatar/483f151626d3a?s=48d=mm 2x" > class="avatar"> > > however the non-ldap admin user which has my email address is still > working in v3.0.1 > https://secure.gravatar.com/avatar/330e7f60f1888b8f6e?s=24; > amp;d=mm" alt="admin" width="24" height="24" srcset="https://secure. > gravatar.com/avatar/330e7f60f1888b8f6e?s=24d=mm 1x, > https://secure.gravatar.com/avatar/330e7f60f1888b8f6e?s=72d=mm > 3x, https://secure.gravatar.com/avatar/330e7f60f1888b8f6e? > s=48d=mm 2x" class="avatar"> > > I wonder if the alt text changing for the normal users is indicative of > this change of source fields for the link generation. It's worth noting > that I haven't changed any ldap settings between the two versions. > > Thanks, > Peter > > > On Wednesday, 13 December 2017 12:57:00 UTC, Peter Hodgson wrote: >> >> That makes perfect sense. The reason I'd wanted to set it at install time >> is I've been extending a dockerised version, but, as you point out the >> domain method is part of the site_config table so gets migrated with the >> rest of the data. This'll work perfectly. >> >> I'm happy, >> >> Thanks again, >> Peter >> >> On Wednesday, 13 December 2017 00:53:57 UTC, Christian Hammond wrote: >>> >>> Glad it worked! >>> >>> There's no way to set this during install today, but it's something we >>> should add. You can set it automatically using the set-siteconfig >>> management command: >>> >>> rb-site manage /path/to/sitedir set-siteconfig -- >>> --key=site_domain_method --value=https >>> >>> Hopefully you aren't needing to create site directories often. If you're >>> scaling out or moving servers, you want to copy the site directory and run >>> rb-site upgrade, instead of installing a new site directory, as some >>> important state will otherwise change. >>> >>> Christian >>> >>> On Tue, Dec 12, 2017 at 1:54 AM, Peter Hodgson <peterb@gmail.com> >>> wrote: >>> >>>> Hi Christian, >>>> >>>> Thanks very much, that was it exactly, the general settings page had >>>> the url as http. The avatars are now working great. >>>> >>>> Is that setting generated from the --domain-name parameter of rb-site >>>> install? I presume there's no way to set that on install? >>>> >>>> Thanks again, >>>> Peter >>>> >>>> On Saturday, 9 December 2017 20:56:14 UTC, Christian Hammond wrote: >>>>> >>>>> Hi Peter, >>>>> >>>>> Thanks! >>>>> >>>>> This looks like it might be setting-related, so let's start there. Can >>>>> you tell me if the Admin UI -> General Settings page lists the URL of the >>>>> server as using http or https? And is Media URL using a relative path or a >>>>> URL (and if so, is that using htt
Re: Site-root being applied twice to links sent in emails in upgraded 3.0.1 install
That's such an annoying problem. Chrome has removed all ability to prevent that from happening. We're going to need to consider some alternative to password fields... As for where to look, there's https://hellosplat.com/s/beanbag/tickets/ (or https://www.reviewboard.org/bugs/, which redirects there), but I'm not sure if this was filed already. Christian On Thu, Dec 14, 2017 at 5:01 AM, Peter Hodgson <peterb.hodg...@gmail.com> wrote: > "Possibly related but it seems that comments on existing reviews aren't > generating emails." - Disregard this, chrome remembering my > Username/Password was autopopulating those fields in the email settings > page which got picked up when I saved something else. My bad. > > > On Thursday, 14 December 2017 11:23:40 UTC, Peter Hodgson wrote: >> >> Hi Christian, >> >> No problem, that's the price of progress. Is there somewhere else I >> should be looking for these known bugs before reporting them and adding >> noise? >> >> Possibly related but it seems that comments on existing reviews aren't >> generating emails. >> >> Thanks, >> Peter >> >> On Thursday, 14 December 2017 00:23:50 UTC, Christian Hammond wrote: >>> >>> Hi Peter, >>> >>> That's definitely a regression in 3.0 with subdirectory installs. We >>> have a fix in progress already, and will be shipping that in 3.0.2. Sorry >>> for the trouble! >>> >>> Christian >>> >>> On Wed, Dec 13, 2017 at 4:11 PM, Peter Hodgson <peterb@gmail.com> >>> wrote: >>> >>>> Hi, >>>> >>>> I am in the position of emails being generated with the site config >>>> applied twice eg. The below from a mail. >>>> >>>> “This is an automatically generated e-mail. To reply, visit: >>>> https://reviewboard.redacted.com/ReviewBoard//ReviewBoard/r/237/“ >>>> >>>> This is the same for the diff link in the email but I can’t find >>>> anywhere else it happens, ie. all links on the review page/info boxes work. >>>> >>>> One consideration that could be how I got here is that I did a fresh >>>> site install of v3 against the v2 DB, letting it perform the evolutions >>>> then. Could that be relevant? >>>> >>>> Thanks in advance, >>>> Peter >>>> >>>> -- >>>> Supercharge your Review Board with Power Pack: >>>> https://www.reviewboard.org/powerpack/ >>>> Want us to host Review Board for you? Check out RBCommons: >>>> https://rbcommons.com/ >>>> Happy user? Let us know! https://www.reviewboard.org/users/ >>>> --- >>>> You received this message because you are subscribed to the Google >>>> Groups "reviewboard" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to reviewboard...@googlegroups.com. >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> >>> >>> >>> -- >>> Christian Hammond >>> President/CEO of Beanbag <https://www.beanbaginc.com/> >>> Makers of Review Board <https://www.reviewboard.org/> >>> >> -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Site-root being applied twice to links sent in emails in upgraded 3.0.1 install
Hi Peter, That's definitely a regression in 3.0 with subdirectory installs. We have a fix in progress already, and will be shipping that in 3.0.2. Sorry for the trouble! Christian On Wed, Dec 13, 2017 at 4:11 PM, Peter Hodgson <peterb.hodg...@gmail.com> wrote: > Hi, > > I am in the position of emails being generated with the site config > applied twice eg. The below from a mail. > > “This is an automatically generated e-mail. To reply, visit: > https://reviewboard.redacted.com/ReviewBoard//ReviewBoard/r/237/“ > > This is the same for the diff link in the email but I can’t find anywhere > else it happens, ie. all links on the review page/info boxes work. > > One consideration that could be how I got here is that I did a fresh site > install of v3 against the v2 DB, letting it perform the evolutions then. > Could that be relevant? > > Thanks in advance, > Peter > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4616: serialize_avatar_url_field fails for any user without an avatar
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4616/ -- New update by kyz For Beanbag, Inc. > Review Board > Ticket #4616 Milestones: + Release-3.0.x -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4616: serialize_avatar_url_field fails for any user without an avatar
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4616/ -- New update by kyz For Beanbag, Inc. > Review Board > Ticket #4616 Status: - New + Confirmed Tags: - Priority:Medium + Component:API + Component:Avatars + Component:Avatars + Priority:High Assigned to: + brennie -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Uploaded Avatar issues with http/https in RB 3.0.1
Glad it worked! There's no way to set this during install today, but it's something we should add. You can set it automatically using the set-siteconfig management command: rb-site manage /path/to/sitedir set-siteconfig -- --key=site_domain_method --value=https Hopefully you aren't needing to create site directories often. If you're scaling out or moving servers, you want to copy the site directory and run rb-site upgrade, instead of installing a new site directory, as some important state will otherwise change. Christian On Tue, Dec 12, 2017 at 1:54 AM, Peter Hodgson <peterb.hodg...@gmail.com> wrote: > Hi Christian, > > Thanks very much, that was it exactly, the general settings page had the > url as http. The avatars are now working great. > > Is that setting generated from the --domain-name parameter of rb-site > install? I presume there's no way to set that on install? > > Thanks again, > Peter > > On Saturday, 9 December 2017 20:56:14 UTC, Christian Hammond wrote: >> >> Hi Peter, >> >> Thanks! >> >> This looks like it might be setting-related, so let's start there. Can >> you tell me if the Admin UI -> General Settings page lists the URL of the >> server as using http or https? And is Media URL using a relative path or a >> URL (and if so, is that using http or https)? >> >> Any uploaded avatar should be referenced based on the Media URL path, so >> I'd first suspect it to be that. If that's the case, this would also impact >> file attachments and their thumbnails. >> >> Christian >> >> On Fri, Dec 8, 2017 at 8:23 AM, Peter Hodgson <peterb@gmail.com> >> wrote: >> >>> Hi guys, >>> >>> Congrats on getting v3 out. I'm a big fan of ReviewBoard, it's certainly >>> made my life easier and v3 looks great. >>> >>> An issue I've having is uploaded avatar images not being shown whilst >>> using ReviewBoard through https as they are linked as http. >>> >>> Chrome reports them as >>> Mixed Content: The page at 'https://redacted.com/ReviewBoard/dashboard/' >>> was loaded over HTTPS, but requested an insecure image ' >>> http://redacted.com/ReviewBoard/media/uploaded/avatars/p/ >>> pe/peter.hodgson__xyz.jpg'. This request has been blocked; the content >>> must be served over HTTPS. >>> >>> My position is possibly complicated by the RB server being behind a >>> reverse proxy but I've had no other similar issues. >>> >>> Thanks in advance, >>> Peter >>> >>> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to reviewboard...@googlegroups.com. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> >> >> -- >> Christian Hammond >> President/CEO of Beanbag <https://www.beanbaginc.com/> >> Makers of Review Board <https://www.reviewboard.org/> >> > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Uploaded Avatar issues with http/https in RB 3.0.1
Hi Peter, Thanks! This looks like it might be setting-related, so let's start there. Can you tell me if the Admin UI -> General Settings page lists the URL of the server as using http or https? And is Media URL using a relative path or a URL (and if so, is that using http or https)? Any uploaded avatar should be referenced based on the Media URL path, so I'd first suspect it to be that. If that's the case, this would also impact file attachments and their thumbnails. Christian On Fri, Dec 8, 2017 at 8:23 AM, Peter Hodgson <peterb.hodg...@gmail.com> wrote: > Hi guys, > > Congrats on getting v3 out. I'm a big fan of ReviewBoard, it's certainly > made my life easier and v3 looks great. > > An issue I've having is uploaded avatar images not being shown whilst > using ReviewBoard through https as they are linked as http. > > Chrome reports them as > Mixed Content: The page at 'https://redacted.com/ReviewBoard/dashboard/' > was loaded over HTTPS, but requested an insecure image ' > http://redacted.com/ReviewBoard/media/uploaded/ > avatars/p/pe/peter.hodgson__xyz.jpg'. This request has been blocked; the > content must be served over HTTPS. > > My position is possibly complicated by the RB server being behind a > reverse proxy but I've had no other similar issues. > > Thanks in advance, > Peter > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Customizing emails sent by reviewboard
Hi, Right now, custom fields can't augment the e-mails, but I think that's a feature worth adding. Right now, I'd say if anyone is available to contribute patches, that would be the fastest way to get this added, but otherwise I can add it to our roadmap. Christian On Wed, Dec 6, 2017 at 8:06 AM, <czy...@gmail.com> wrote: > Hi over there! > > Is there any way to change content of emails sent by reviewboard after > creating / changing review request ? > > As we can see in attached file email consists of "Description" and "Diffs" > sections. But is there any way to add "Note to Reviewers" section to sent > emails? > > > > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Reviewboard migrating issues
That looks like something is getting in the way of outgoing HTTP access. Do you use a proxy server? Christian On Wed, Dec 6, 2017 at 1:16 AM, RB_user <karthikut...@gmail.com> wrote: > Following https://www.reviewboard.org/docs/manual/3.0/admin/ > upgrading/upgrading-reviewboard/ to upgrade. > > > # easy_install -U ReviewBoard > Searching for ReviewBoard > Reading http://pypi.python.org/simple/ReviewBoard/ > Reading http://pypi.python.org/simple/ReviewBoard/newLocation; > return; > } > > var > Download error: no host given -- Some packages may not be found! > Reading http://pypi.python.org/simple/ReviewBoard/\ > Best match: ReviewBoard 1.7.27 > Adding ReviewBoard 1.7.27 to easy-install.pth file > Installing rb-site script to /usr/bin > Installing rbssh script to /usr/bin > > Using /usr/lib/python2.6/site-packages > Reading http://downloads.reviewboard.org/mirror/ > Reading http://downloads.reviewboard.org/releases/ReviewBoard/1.7/ > Processing dependencies for ReviewBoard > Finished processing dependencies for ReviewBoard > > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
New releases: Review Board 2.5.17 and 3.0.1
Hi everyone, We just released Review Board 2.5.17 and 3.0.1, which fix a handful of bugs in search, LDAP, GitLab, avatars, and more. As always, more details are up in the announcement: https://www.reviewboard.org/news/2017/12/05/review-board-2-5-17-and-3-0-1-are-now-out/ Thanks to everyone who reported these bugs to us and were patient while we tracked them down! Christian -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: ReviewBoard search question
The fix will be included in 2.5.17 and 3.0.1. I expect we’ll get 2.5.17 out in about a week. Christian On Wed, Nov 29, 2017 at 05:31 'Rob Backhurst' via reviewboard < reviewboard@googlegroups.com> wrote: > Hi Christian, > > Thanks for the quick reply. > Would it be possible to let me know when this change (back) has been made > please? Or should I keep an eye out for the change on future releases? > > Thanks > Rob > > > On Wednesday, 29 November 2017 09:41:24 UTC, Rob Backhurst wrote: >> >> Hi, >> >> We are running RB 2.5.16 and have noticed some changes in the search >> functionality from previous versions. >> >> What is the intended behaviour of the search? >> Should the Search API and/or the "quick search" include review requests >> marked as submitted? >> If not, when was this changed and is there a reason for the change? >> >> Thanks >> Rob >> > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -- Christian Hammond President/CEO of Beanbag Makers of Review Board -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: ReviewBoard search question
Hi Rob, We had a rewrite of the API resource backing quick search that aimed to make queries faster, more secure, and to limit results on larger servers. As part of this, we went from building one of our queries to using a centralized convenience method, which had the side effect of limiting the results to open review requests. We'll change that part of the query back to how it was in earlier releases. This change was made in 2.5.14. Christian On Wed, Nov 29, 2017 at 1:41 AM, 'Rob Backhurst' via reviewboard < reviewboard@googlegroups.com> wrote: > Hi, > > We are running RB 2.5.16 and have noticed some changes in the search > functionality from previous versions. > > What is the intended behaviour of the search? > Should the Search API and/or the "quick search" include review requests > marked as submitted? > If not, when was this changed and is there a reason for the change? > > Thanks > Rob > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Long lines get cut off in diff view
Looks like the lines are missing a character or two. I have seen this once, and when I looked, it was a quirk with how the browser chose to wrap vs. extend the container for the line. I’ll keep my eye open and see if I can reproduce and figure out the issue, but it was non-obvious last time. What I did find was resizing the window would trigger a relayout, resolving the problem. I’d be curious if this works around the issue for you. Christian On Thu, Nov 23, 2017 at 16:24 Rob Petti <rob.pe...@gmail.com> wrote: > That's odd... Here's the attachment again. > > On Thu, Nov 23, 2017 at 5:15 PM, Christian Hammond < > christ...@beanbaginc.com> wrote: > >> Hi Rob, >> >> Unfortunately that screenshot didn’t go through for me. Looks like it’s >> some inline thing instead of an attachment. Can you try re-attaching? >> >> Christian >> >> >> On Thu, Nov 23, 2017 at 10:09 Rob Petti <rob.pe...@gmail.com> wrote: >> >>> Hi all, >>> >>> One of my users is having a strange issue with the diff viewer in >>> ReviewBoard 2.5.16. When long lines wrap, part of the text near the edge of >>> the view gets cut off. >>> >>> They claim it happens in Chrome 62 and Firefox 57, but I was only able >>> to reproduce the problem in IE 11. >>> >>> Any ideas on what the issue might be, or how to resolve it? >>> >>> [image: image001.jpg] >>> >>> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to reviewboard+unsubscr...@googlegroups.com. >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- >> -- >> Christian Hammond >> President/CEO of Beanbag >> Makers of Review Board >> > -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> > You received this message because you are subscribed to a topic in the >> Google Groups "reviewboard" group. >> To unsubscribe from this topic, visit >> https://groups.google.com/d/topic/reviewboard/E_QhfFCtm0Q/unsubscribe. >> To unsubscribe from this group and all its topics, send an email to >> reviewboard+unsubscr...@googlegroups.com. >> > >> For more options, visit https://groups.google.com/d/optout. >> > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -- Christian Hammond President/CEO of Beanbag Makers of Review Board -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Long lines get cut off in diff view
Hi Rob, Unfortunately that screenshot didn’t go through for me. Looks like it’s some inline thing instead of an attachment. Can you try re-attaching? Christian On Thu, Nov 23, 2017 at 10:09 Rob Petti <rob.pe...@gmail.com> wrote: > Hi all, > > One of my users is having a strange issue with the diff viewer in > ReviewBoard 2.5.16. When long lines wrap, part of the text near the edge of > the view gets cut off. > > They claim it happens in Chrome 62 and Firefox 57, but I was only able to > reproduce the problem in IE 11. > > Any ideas on what the issue might be, or how to resolve it? > > [image: image001.jpg] > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -- Christian Hammond President/CEO of Beanbag Makers of Review Board -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Reviewboard migrating issues
You can’t downgrade to older versions. You’ll need to use 2.0.15 or newer on this server. Christian On Thu, Nov 23, 2017 at 03:59 RB_user <karthikut...@gmail.com> wrote: > Hi, > > [root@banvmlin01 site-packages]# sudo rb-site upgrade /var/www/newmachine/ > Rebuilding directory structure > Updating database. This may take a while. > > The log output below, including warnings and errors, > can be ignored unless upgrade fails. > > -- -- > Creating tables ... > Upgrading Review Board from 2.0.15 to 1.7.27 > > [!] Unable to execute the manager command syncdb: No module named > db.fields > > [!] Unable to execute the manager command evolve: No module named > db.fields > --- --- > > Resetting in-database caches. > > Upgrade complete! > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -- Christian Hammond President/CEO of Beanbag Makers of Review Board -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Reviewboard migrating issues
Hi, I want to make sure this isn’t backwards. You downgraded from 2.0.15 to 1.7.27? If so, that’s not something that’s supported. I suspect that’s actually backwards though. Do you have logs of the rb-site upgrade? Also, do you have a backup of the database from the old machine? Christian On Wed, Nov 22, 2017 at 05:27 RB_user <karthikut...@gmail.com> wrote: > Hi, > > Recently we migrated our review board from one Linux machine to another > (different OS). > The earlier version was 2.0.15 (Python2.7) and new machine runs on Python > 2.6 and RB version 1.7.27. > > Successfully imported the database dump. But now when i try to access RB > site, it throws an error as given below: > > > Traceback (most recent call last): > > > > File "/usr/lib/python2.6/site-packages/django/core/handlers/base.py", > line 87, in get_response > > response = middleware_method(request) > > > > File > "/usr/lib/python2.6/site-packages/reviewboard/accounts/middleware.py", line > 12, in process_request > > user = Profile.objects.get(user=request.user) > > > > File "/usr/lib/python2.6/site-packages/django/db/models/manager.py", > line 131, in get > > return self.get_query_set().get(*args, **kwargs) > > > > File "/usr/lib/python2.6/site-packages/django/db/models/query.py", line > 361, in get > > num = len(clone) > > > > File "/usr/lib/python2.6/site-packages/django/db/models/query.py", line > 85, in __len__ > > self._result_cache = list(self.iterator()) > > > > File "/usr/lib/python2.6/site-packages/django/db/models/query.py", line > 291, in iterator > > for row in compiler.results_iter(): > > > > File > "/usr/lib/python2.6/site-packages/django/db/models/sql/compiler.py", line > 763, in results_iter > > for rows in self.execute_sql(MULTI): > > > > File > "/usr/lib/python2.6/site-packages/django/db/models/sql/compiler.py", line > 818, in execute_sql > > cursor.execute(sql, params) > > > > File > "/usr/lib/python2.6/site-packages/django/db/backends/mysql/base.py", line > 114, in execute > > return self.cursor.execute(query, args) > > > > File "/usr/lib64/python2.6/site-packages/MySQLdb/cursors.py", line 173, > in execute > > self.errorhandler(self, exc, value) > > > > File "/usr/lib64/python2.6/site-packages/MySQLdb/connections.py", line > 36, in defaulterrorhandler > > raise errorclass, errorvalue > > > > DatabaseError: (1054, "Unknown column 'accounts_profile.show_submitted' in > 'field list'") > > > how do i resolve this issue? > > Thanks in advance > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -- Christian Hammond President/CEO of Beanbag Makers of Review Board -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Unable to install reviewboat extension on RB 3.0
It’s not yet, but it will be in the coming weeks. We’ll have an announcement when it’s available. Christian On Tue, Nov 21, 2017 at 22:06 MoonWalker <daniel.cabrera...@gmail.com> wrote: > I tried to install reviewboat extension using: > > $ pip install reviewbot-extension > Could not find any downloads that satisfy the requirement > reviewbot-extension > Cleaning up... > No distributions at all found for reviewbot-extension > Storing debug log for failure in /home/administrator/.pip/pip.log > > Seams like the extension is not available yet :-( > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -- Christian Hammond President/CEO of Beanbag Makers of Review Board -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Post RB 3.0 Update log output issues
Hi, Those are normal status log entries about the upgrade process, and are always shown when the database needs modifications. As the note above them says, you can safely ignore anything if the upgrade is successful. Christian On Tue, Nov 21, 2017 at 21:36 MoonWalker <daniel.cabrera...@gmail.com> wrote: > I upgrade to RB 3.0 and it seams like is working ok (so far). But I > noticed the following messages during the upgrade, and not sure if I shall > worry or do something about it: > > sudo rb-site upgrade /var/www/reviewboard/ > Rebuilding directory structure > Upgrading site settings_local.py > Updating database. This may take a while. > > The log output below, including warnings and errors, > can be ignored unless upgrade fails. > > -- -- > Creating tables ... > Creating table corsheaders_corsmodel > Creating table integrations_integrationconfig > Creating table oauth2_provider_application > Creating table oauth2_provider_grant > Creating table oauth2_provider_accesstoken > Creating table oauth2_provider_refreshtoken > Creating table reviewboard_oauth_application > Creating table reviews_generalcomment > Creating table reviews_statusupdate > Upgrading Review Board from 2.5.16 to 3.0 > There are unapplied evolutions for accounts. > There are unapplied evolutions for attachments. > There are unapplied evolutions for changedescs. > There are unapplied evolutions for oauth. > There are unapplied evolutions for reviews. > There are unapplied evolutions for site. > There are unapplied evolutions for webapi. > Adding baseline version for new models > Evolutions in oauth baseline: disabled_for_security > Project signature has changed - an evolution is required > Installing custom SQL ... > Installing indexes ... > Installed 0 object(s) from 0 fixture(s) > > This may take a while. Please be patient, and do not cancel the upgrade! > > Applying database evolutions for accounts... > Applying database evolutions for attachments... > Applying database evolutions for changedescs... > Applying database evolutions for reviews... > Applying database evolutions for site... > Evolution successful. > --- --- > > Resetting in-database caches. > > Upgrade complete! > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -- Christian Hammond President/CEO of Beanbag Makers of Review Board -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Review Board 3.0 is released!
Hi everyone, I'm really happy to announce that Review Board 3.0 is here! We've been working on this release for a very long time, and there's a lot that we've introduced. Support for third-party service integrations (Slack, Travis-CI, CircleCI, and others coming soon), general comments, issue verification, Emojis, better reviews/discussions, OAuth2, new API and extension capabilities, Ship It! revocation, and I could go on and on. But instead of writing this all a third time, I'd like to point you to the news announcement, which points to the *extensive* release notes: https://www.reviewboard.org/news/2017/11/21/its-here-review-board-3-0-is-here/ If you're planning to upgrade to 3.0, please make sure you try it out on a test server first. While we've been running 3.0 for some time and have found it very stable, it's always best to test before putting a product into production (and back up your database and site directory!). It's Thanksgiving this week here in the US, so we'll be taking a little break, but when we come back we'll be working on Review Board 3.0.1, Power Pack <https://www.reviewboard.org/powerpack/> 2.0, and RBCommons <https://rbcommons.com/> 3.0. Thanks everyone for your patience, your bug reports, and your testing. You've helped make this a great release :) (P.S., If anyone wants to share the announcement on Reddit or Hacker News, send a link our way!) Christian -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: No Capcha in registration
When I go to the Register page for rb.freedroid.org, I see a Recaptcha widget. You might have a browser extension that's blocking it. Perhaps an ad blocker? You'll need to see which extension might be interfering. Christian On Mon, Nov 20, 2017 at 12:37 AM, Kunjappu Abhijith.R <gadha1...@gmail.com> wrote: > As shown in the screen-shot, there is no capcha and yet it outs a warning > that I need to respond to it. > > https://screenshots.firefox.com/n9JnJ6xSQRrUJ6Hv/rb.freedroid.org > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: rb-extension-pack Compability with Review Board 3.0
The extension won't be getting patched. At least not right away, but it won't need to be. The existing version will work with the 3.0 release. It was just using a deprecated attribute that got left out of a new implementation. Christian On Sun, Nov 19, 2017 at 4:59 PM, Daniel Morgan < daniel.kenji.mor...@gmail.com> wrote: > Christian, > > Thank you for the reply. > I will wait for the patch to be applied and check again. > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: rb-extension-pack Compability with Review Board 3.0
This particular issue will be fixed by release. It's a regression in Djblets that I'll have a patch for. Christian On Thu, Nov 16, 2017 at 2:40 PM, David Trowbridge <trowb...@gmail.com> wrote: > Daniel, > > I'm not sure we'll have time before the release but we'll definitely be > making sure that everything gets updated asap. > > -David > > On Wed, Nov 15, 2017 at 7:20 PM Daniel Morgan < > daniel.kenji.mor...@gmail.com> wrote: > >> Are there any plans to check the compatibility for the Extensions >> contained in rb-extension-pack with Review Board 3.0? >> I am using a few of the Extensions there and have encountered errors >> using Review Board 3.0 RC1. >> >> For example, when configuring the message for the "Message of the Day" >> Extension, I get the following error. >> The log output is as follows (sensitive details edited): >> >> None - User1 - /admin/extensions/rbmotd.extension.MotdExtension/config/ >> - djblets.log.middleware - Exception thrown for user User1 at >> http://x.x.x.x/admin/extensions/rbmotd.extension.MotdExtension/config/ >> >> 'MotdSettingsForm' object has no attribute 'siteconfig' >> Traceback (most recent call last): >> File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", >> line 112, in get_response >> response = wrapped_callback(request, *callback_args, >> **callback_kwargs) >> File "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py", >> line 99, in _wrapped_view >> response = view_func(request, *args, **kwargs) >> File >> "/usr/local/lib/python2.7/dist-packages/reviewboard/extensions/views.py", >> line 15, in configure_extension >> template_name) >> File "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py", >> line 99, in _wrapped_view >> response = view_func(request, *args, **kwargs) >> File >> "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/views/decorators.py", >> line 17, in _checklogin >> return view_func(request, *args, **kwargs) >> File "/usr/local/lib/python2.7/dist-packages/djblets/extensions/views.py", >> line 64, in configure_extension >> form.save() >> File >> "/usr/local/lib/python2.7/dist-packages/rbmotd-1.0-py2.7.egg/rbmotd/forms.py", >> line 22, in save >> self.siteconfig.set( >> AttributeError: 'MotdSettingsForm' object has no attribute 'siteconfig' >> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard+unsubscr...@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. >> > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4606: File list isn't updating when switching in multi page review.
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4606/ -- New update by theBoss For Beanbag, Inc. > Review Board > Ticket #4606 Reply: Fixed on release-3.0.x (de4591fdc4e29e0e66f32d8e3bfb1eb6023c97cd) Status: - PendingReview + Fixed -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4606: File list isn't updating when switching in multi page review.
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4606/ -- New update by theBoss For Beanbag, Inc. > Review Board > Ticket #4606 Reply: Fix up at https://reviews.reviewboard.org/r/9373/ Status: - Confirmed + PendingReview -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4606: File list isn't updating when switching in multi page review.
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4606/ -- New update by theBoss For Beanbag, Inc. > Review Board > Ticket #4606 Status: - New + Confirmed Milestones: + Release-3.0 Tags: + Component:DiffViewer -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4606: File list isn't updating when switching in multi page review.
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4606/ -- New update by theBoss For Beanbag, Inc. > Review Board > Ticket #4606 Reply: I'll be looking into this tomorrow. Assigned to: + chipx86 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: ReviewRequestDropdownActionHook error in RB3.0
Hi,
Thanks for the report! We'll look into the cause, make sure it's fixed for
3.0.
Christian
On Fri, Nov 10, 2017 at 08:05 SHKLO O <misbl...@gmail.com> wrote:
> Hi, I have an extension which uses ReviewRequestDropdownActionHook just to
> show button which I use to call JS function.
> The extension turns on without a problem but when you Disable and Enable
> it again it shows following error "*KeyError: u'test_link **(that's id of
> ActionHook written in ReviewRequestActionHook>)** already corresponds to
> a registered review request action*'"
>
> When I don't Disable it but try to use the extension it sometimes shows
> the error immediately, sometimes in a few seconds.
>
> The problem started after switching to RB 3.0
>
> Here's what Initialization looks like in extension.py initialize function:
>
> ReviewRequestDropdownActionHook(self, [{
> 'label': 'Test',
> 'items': [{
> 'url': '#',
> 'id': 'test_link',
> 'label': 'Test',
> }]
> }])
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
--
--
Christian Hammond
President/CEO of Beanbag
Makers of Review Board
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4603: Overlapping information section in review page with long branch/bug value.
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4603/ -- New update by Cypih For Beanbag, Inc. > Review Board > Ticket #4603 Reply: Fixed on release-3.0.x (276b5f9a56bb54164cf9483cca864d1105f897bc) Status: - PendingReview + Fixed -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4603: Overlapping information section in review page with long branch/bug value.
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4603/ -- New update by Cypih For Beanbag, Inc. > Review Board > Ticket #4603 Reply: Fix up for review: https://reviews.reviewboard.org/r/9357/ Status: - Confirmed + PendingReview -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4603: Overlapping information section in review page with long branch/bug value.
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4603/ -- New update by Cypih For Beanbag, Inc. > Review Board > Ticket #4603 Status: - New + Confirmed Milestones: + Release-3.0 Tags: + Component:Reviews Summary: - Overlapping information section in review page with long branch/bug value. + Overlapping information section in review page with long branch/bug value. Assigned to: + chipx86 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: New Release: Review Board 3.0 RC 1
We expect to put out the final release in just a couple weeks. We're just finishing up documentation. Thanksgiving in the US may affect the release schedule a bit, but it'll be just around that time. Christian On Tue, Nov 7, 2017 at 2:46 PM, MoonWalker <daniel.cabrera...@gmail.com> wrote: > Well done guys! Do you guys think that RB3.x can be ready for production > this year? > > > On Tuesday, November 7, 2017 at 11:12:48 AM UTC+11, Christian Hammond > wrote: >> >> Hi everyone, >> >> Review Board 3.0 RC 1 is now out. This is expected to be the final >> pre-release of Review Board 3.0. At this point, we're focusing on >> documentation for the final release, which should be out by the end of the >> month. >> >> Some of the highlights of this release include: >> >> * New logic for when boxes on the review request page (reviews, updates, >> etc.) are collapsed by default >> * New API support for working with JSON structures in extra_data JSON >> fields. >> * Better high-DPI support >> * Other polish, performance improvements, and usability fixes. >> >> More information can be found on the official announcement >> <https://www.reviewboard.org/news/2017/11/06/review-board-3-0-rc-1-now-out/> >> and release notes >> <https://www.reviewboard.org/docs/releasenotes/reviewboard/3.0-rc-1/>. >> >> If you're planning to upgrade to 3.0, please test this release so you >> don't run into any unexpected surprises. We're in the home stretch now. >> >> Thanks! >> >> Christian >> >> -- >> Christian Hammond >> President/CEO of Beanbag <https://www.beanbaginc.com/> >> Makers of Review Board <https://www.reviewboard.org/> >> > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
New Release: Review Board 3.0 RC 1
Hi everyone, Review Board 3.0 RC 1 is now out. This is expected to be the final pre-release of Review Board 3.0. At this point, we're focusing on documentation for the final release, which should be out by the end of the month. Some of the highlights of this release include: * New logic for when boxes on the review request page (reviews, updates, etc.) are collapsed by default * New API support for working with JSON structures in extra_data JSON fields. * Better high-DPI support * Other polish, performance improvements, and usability fixes. More information can be found on the official announcement <https://www.reviewboard.org/news/2017/11/06/review-board-3-0-rc-1-now-out/> and release notes <https://www.reviewboard.org/docs/releasenotes/reviewboard/3.0-rc-1/>. If you're planning to upgrade to 3.0, please test this release so you don't run into any unexpected surprises. We're in the home stretch now. Thanks! Christian -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Authentication methods disappeared
Hi Ken, It does sound like a version mismatch error then. Can you check the Apache error log for anything saying VersionMismatch? Christian On Wed, Nov 1, 2017 at 08:31 Ken Rachynski <krachyn...@me.com> wrote: > Oh, the only Hosting Service I see in the Add a Repository page is GitHub > Enterprise. > > This is the output of `pip list`: > asn1crypto (0.23.0) > bcrypt (3.1.4) > cffi (1.11.2) > cryptography (2.1.2) > Django (1.6.11) > django-evolution (0.7.7) > django-haystack (2.4.1) > django-multiselectfield (0.1.8) > django-pipeline (1.3.27) > Djblets (0.9.9) > dnspython (1.15.0) > docutils (0.14) > enum34 (1.1.6) > feedparser (5.2.1) > futures (3.1.1) > idna (2.6) > ipaddress (1.0.18) > Markdown (2.4.1) > mimeparse (0.1.3) > MySQL-python (1.2.5) > olefile (0.44) > paramiko (2.3.1) > Pillow (4.3.0) > pillowfight (0.3) > pip (9.0.1) > publicsuffix (1.1.0) > pyasn1 (0.3.7) > pycparser (2.18) > Pygments (2.2.0) > PyNaCl (1.1.2) > python-dateutil (2.6.1) > python-ldap (2.4.45) > python-memcached (1.58) > pytz (2017.2) > recaptcha-client (1.0.6) > ReviewBoard (2.5.16) > setuptools (36.6.0) > six (1.11.0) > Whoosh (2.7.4) > > Ken > > On Tuesday, 31 October 2017 15:54:32 UTC-6, Christian Hammond wrote: > >> Hi Ken, >> >> Can you also check the hosting service options? If GitHub, Bitbucket, >> etc. are all present, then the general dependency stuff should be fine. >> Basically, we use a thing called Python Entrypoints to register things like >> the hosting services and authentication backends, and if Review Board has a >> dependency version mismatch (such as requires Django 1.6 but a different >> version is installed), all entrypoints will break. If those hosting >> services are present, then the version mismatches can be ruled out. >> >> If python-ldap wasn't installed, then that was likely the culprit. >> However, it probably just upgraded. You'll need to restart Apache for any >> new version to take effect. >> >> Christian >> > >> On Mon, Oct 30, 2017 at 2:03 PM, Ken Rachynski <krach...@me.com> wrote: >> >>> Hi Christian, >>> >>> I thought it was already installed, but pip install -U python-ldap >>> returned this: >>> Collecting python-ldap >>> Using cached python-ldap-2.4.45.tar.gz >>> Requirement already up-to-date: setuptools in >>> /usr/lib/python2.7/site-packages (from python-ldap) >>> Installing collected packages: python-ldap >>> Running setup.py install for python-ldap ... done >>> Successfully installed python-ldap-2.4.45 >>> >>> I have 10 repository types listed, though I only need Git. >>> >>> Is there anything I can look at to see if a dependency is doing that >>> prevention? >>> >>> On Monday, 30 October 2017 13:57:22 UTC-6, Christian Hammond wrote: >>>> >>>> Hi Ken, >>>> >>>> It sounds as if the modules needed for AD are no longer installed (or, >>>> potentially, there's a dependency version mismatch error preventing our AD >>>> backend from loading -- see if there's a full list of repository types in >>>> the Add Repository page). >>>> >>>> Can you see if the python-ldap package is installed? If you're using >>>> pip or easy_install for Review Board packages, run: >>>> >>>> $ pip install -U python-ldap >>>> >>>> Or: >>>> >>>> $ easy_install -U python-ldap >>>> >>>> Christian >>>> >>>> >>>> On Fri, Oct 27, 2017 at 19:24 Ken Rachynski <krach...@me.com> wrote: >>>> >>>>> Hi, I just tried to do an upgrade with all kinds of "no turning back >>>>> now" errors. I went from 2.5.6.1 to 2.5.16. In the process, I discovered >>>>> that 2.5.6.1 appears to be the last version supported by python 2.6.6. So >>>>> I >>>>> did an upgrade to add python 2.7 to my CentOS 6 server. After much back >>>>> and >>>>> forth, I managed to get Review Board installed and mostly working. The >>>>> only >>>>> thing that I appear to be missing right now is Active Directory >>>>> authentication; well, any authentication other than Standard Registration >>>>> and Legacy Authentication Modules. I can still see my AD configuration but >>>>> no amount of twiddling seems to make Review Board use those settings. >>>>>
Re: Adding the custom Git repository (AWS CodeCommit) but getting error saying " Please correct the error below. A repository was not found at the specified path."
Hi Madhuri, Due to limitations in Git's remote access protocol, it's not possible to specify arbitrary Git clone URLs and access the kind of information Review Board requires for reviewing changes. Because of this, support must be written to utilize a service's API instead, if one is available. The good news is that we have written and are testing AWS CodeCommit support, which will be in the next major release of Power Pack ( https://www.reviewboard.org/powerpack/). If you're interested in testing a beta, we can get one sent your way. It is a paid product, so you'll need to purchase a license to use it after the 30 day trial period. Christian On Wed, Nov 1, 2017 at 17:36 Madhuri A <madhuri.a...@gmail.com> wrote: > I have provided the URL ,username and password > > but it is still looking for local .git folder. > > Can you suggest me what is the best way to configure the remote git > repository ? > > Regards, > Madhuri > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -- Christian Hammond President/CEO of Beanbag Makers of Review Board -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4601: Making changes to testing information of a review request hides the testing information.
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4601/ -- New update by rcreagha For Beanbag, Inc. > Review Board > Ticket #4601 Reply: Fixed on release-3.0.x (9e22cc8d57bebeff5918419348f74f9a9e80e7e8) Status: - PendingReview + Fixed -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: A couple of issues with the Gitlab integration
Hi Clément, We're working on rebuilding the GitLab support to use newer APIs so that subgroups work. We have this working internally and hope to ship it soon. We've been trying to get Review Board 3.0 out the door, so it'll probably be after we wrap that up (final RC release is this week), but will be soon. As for the username, we should be able to make that editable, but it shouldn't be a blocker for you. Review Board shouldn't be talking over SSH to the Git repository itself, so I imagine you're hitting issues when setting up RBTools? If so, it's best to just specify the repository name by setting REPOSITORY in .reviewboardrc instead of having it match based on a clone URL, as that'll be faster and won't depend on the username set in that path. Christian On Tue, Oct 31, 2017 at 1:29 PM, Clément Moyroud <clement.moyr...@gmail.com> wrote: > Hello, > > I've hit a couple roadblocks when trying to set-up ReviewBoard to talk to > our Gitlab instance: > 1. The code assumes that the user for the SSH connection is 'git' (i.e. > git@:repo.git), but for Omnibus-based Gitlab instances it's > actually 'gitlab'. Could you please make that field editable? > 2. Gitlab supports sub-groups, and ReviewBoard does not like them. When > using e.g. 'groupA/groupB' for the 'Gitlab group name' field, we get this > error message: "A group with this name was not found, or your user may not > have access to it." > > Do you plan to add support to sub-groups soon? For now we've worked around > the issue by editing the SQL DB directly. > > Thanks, > > Clément > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Authentication methods disappeared
Hi Ken, Can you also check the hosting service options? If GitHub, Bitbucket, etc. are all present, then the general dependency stuff should be fine. Basically, we use a thing called Python Entrypoints to register things like the hosting services and authentication backends, and if Review Board has a dependency version mismatch (such as requires Django 1.6 but a different version is installed), all entrypoints will break. If those hosting services are present, then the version mismatches can be ruled out. If python-ldap wasn't installed, then that was likely the culprit. However, it probably just upgraded. You'll need to restart Apache for any new version to take effect. Christian On Mon, Oct 30, 2017 at 2:03 PM, Ken Rachynski <krachyn...@me.com> wrote: > Hi Christian, > > I thought it was already installed, but pip install -U python-ldap > returned this: > Collecting python-ldap > Using cached python-ldap-2.4.45.tar.gz > Requirement already up-to-date: setuptools in /usr/lib/python2.7/site-packages > (from python-ldap) > Installing collected packages: python-ldap > Running setup.py install for python-ldap ... done > Successfully installed python-ldap-2.4.45 > > I have 10 repository types listed, though I only need Git. > > Is there anything I can look at to see if a dependency is doing that > prevention? > > On Monday, 30 October 2017 13:57:22 UTC-6, Christian Hammond wrote: >> >> Hi Ken, >> >> It sounds as if the modules needed for AD are no longer installed (or, >> potentially, there's a dependency version mismatch error preventing our AD >> backend from loading -- see if there's a full list of repository types in >> the Add Repository page). >> >> Can you see if the python-ldap package is installed? If you're using pip >> or easy_install for Review Board packages, run: >> >> $ pip install -U python-ldap >> >> Or: >> >> $ easy_install -U python-ldap >> >> Christian >> >> >> On Fri, Oct 27, 2017 at 19:24 Ken Rachynski <krach...@me.com> wrote: >> >>> Hi, I just tried to do an upgrade with all kinds of "no turning back >>> now" errors. I went from 2.5.6.1 to 2.5.16. In the process, I discovered >>> that 2.5.6.1 appears to be the last version supported by python 2.6.6. So I >>> did an upgrade to add python 2.7 to my CentOS 6 server. After much back and >>> forth, I managed to get Review Board installed and mostly working. The only >>> thing that I appear to be missing right now is Active Directory >>> authentication; well, any authentication other than Standard Registration >>> and Legacy Authentication Modules. I can still see my AD configuration but >>> no amount of twiddling seems to make Review Board use those settings. >>> >>> I don't see any kind of messages in the logs saying that AD was tried >>> and failed, so I'm rather at a loss of how to tell what is actually wrong >>> with my system. For now, I think I'm just going to add passwords to all the >>> users that were AD authed so they can get in and work. >>> >>> Ken >>> >>> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to reviewboard...@googlegroups.com. >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- >> -- >> Christian Hammond >> President/CEO of Beanbag >> Makers of Review Board >> > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: reviewboard hangs while parsing diff file
)[2]) > File > "/opt/reviewboard-2.5-0/apps/reviewboard/htdocs/venv/lib/python2.7/site-packages/django/http/request.py", > line 242, in read > return self._stream.read(*args, **kwargs) > File > "/opt/reviewboard-2.5-0/apps/reviewboard/htdocs/venv/lib/python2.7/site-packages/django/core/handlers/wsgi.py", > line 57, in read > result = self.buffer + self._read_limited(size - len(self.buffer)) > File > "/opt/reviewboard-2.5-0/apps/reviewboard/htdocs/venv/lib/python2.7/site-packages/django/core/handlers/wsgi.py", > line 45, in _read_limited > result = self.stream.read(size) > UnreadablePostError: request data read error > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -- Christian Hammond President/CEO of Beanbag Makers of Review Board -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Reviewboard post commit hook fails with XML error
Hi Ron, RBTools is just calling out to the svn command, which is what's complaining. It sounds like svn itself is having trouble talking to the repository from within the hook directory. Review Board isn't involved at that stage. You can set DEBUG to True in that script to try to see how far it gets. You'd need to redirect output (standard and error output) from the hook script to some file. That should at least help pin down what svn command is failing so that you can better diagnose what's going on. Christian On Thu, Oct 26, 2017 at 16:28 Ron Tech <rontech...@gmail.com> wrote: > When trying to setup subversion with reviewboard and a post commit hook it > fails with an xml error. I'm able to commit to the repository without the > post-commit hook but once I add it, it fails. > svn: E175009: Commit failed (details follow): > svn: E175009: The XML response contains invalid XML > svn: E130003: Malformed XML: mismatched tag > > The svn repository is using a self-signed certificate. I'm not sure if > that is the problem and reviewboard doesn't have the option to work with > that? > > Here is the post-commit file I am using from git > https://github.com/reviewboard/reviewboard/blob/master/contrib/tools/svn-hook-postcommit-review > > The file running this is the post-commit file. > > #!/bin/bash > > REPO="$1" > REV="$2" > > /usr/bin/python /mnt/data/svn/flowplay-sa/hooks/post-commit.reviewboard.py > "$REPOS" "$REV" || exit 1 > > Thank you. > > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -- Christian Hammond President/CEO of Beanbag Makers of Review Board -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: How to update apache inside of review board?
Hi, It's unclear if you're trying to upgrade the Review Board product or the Apache web server, but the commands you're running will only upgrade Review Board, and the versions you're giving are for Apache. You'll need to reach out to Bitnami about this. They're in a better position to help, since it's a very custom environment they've put together, and we don't have much insight into it. Christian On Thu, Oct 26, 2017 at 07:10 Not Saying <d92...@gmail.com> wrote: > I found below on upgrading from Bitnami. Does need access to any repo > from Redhat? Thanks for the help. > > cd installdir/apps/reviewboard/htdocs/ > sudo venv/bin/easy_install -U ReviewBoard > sudo venv/bin/rb-site upgrade > installdir/apps/reviewboard/rb-sites/reviewboard/ > > > On Wednesday, October 25, 2017 at 6:50:52 AM UTC-7, Not Saying wrote: > >> Is there a procedure to update apache inside of review board? Is so >> what is it? >> >> Thank you >> Donovan >> > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -- Christian Hammond President/CEO of Beanbag Makers of Review Board -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Wrong url in API response
Hi Stefan,
It sounds like the setting didn't take effect, or some existing responses
were cached by RBTools. Can you try to fully restart Apache, to force all
settings to reload?
Christian
On Tue, Oct 24, 2017 at 9:26 AM, Stefan Prawda <d0hanz...@gmail.com> wrote:
>
> Hi,
> I have RB 2.5.16 behind reverse-proxy (apache). Its url is correctly
> configured under General Settings -> Server (here shown as
> http://reviewboard-domain/), and i can freely navigate on website.
> Said that, i encountered error when trying to use rbt 0.7.10:
>
> $ rbt status -d
>> >>> RBTools 0.7.10
>> >>> Python 2.7.12 (default, Nov 19 2016, 06:48:10)
>> [GCC 5.4.0 20160609]
>> >>> Running on Linux-4.10.0-37-generic-x86_64-with-LinuxMint-18.2-sonya
>> >>> Home = /home/stefanprawda
>> >>> Current directory = /home/stefanprawda/repos/REPO/trunk
>> >>> Command line: rbt status -d
>> >>> Running: tf vc help
>> >>> Checking for a Subversion repository...
>> >>> Running: svn --non-interactive info
>> >>> Running: diff --version
>> >>> Running: svn --non-interactive --version -q
>> >>> repository info: Path: https://svn-domain/REPO, Base path: /trunk,
>> Supports changesets: False
>> >>> Making HTTP GET request to http://reviewboard-domain/api/
>> >>> Making HTTP GET request to http://localhost:8083/api/
>> session/?expand=user
>> Traceback (most recent call last):
>
> ...
>>
> rbtools.api.errors.ServerInterfaceError: [Errno 111] Connection refused
>>
>
> After checking manually http://reviewboard-domain/api/ it is clearly
> shown:
>
> http://localhost:8083/api/users/{username}/api-
>> tokens/{api_token_id}/
>>
> But to the end inside tags the url is correct.
>
> Can you advise me?
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
--
Christian Hammond
President/CEO of Beanbag <https://www.beanbaginc.com/>
Makers of Review Board <https://www.reviewboard.org/>
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: Unable to download attachments that have been uploaded.
Glad you got it working! Looks like MySQL was missing a core component. Was it an installation problem? Christian On Wed, Oct 18, 2017 at 17:54 Not Saying <d92...@gmail.com> wrote: > I got it working. THANKS > > > On Tuesday, October 17, 2017 at 10:01:17 AM UTC-7, Not Saying wrote: > >> RHEL 7 >> *Review Board* <http://linuxa2.ng1.loc/reviewboard/> 2.5.15 >> >> *I click on the download button and it give me a page *This page can’t >> be displayed >> The URL is >> http://localhost/reviewboard/media/uploaded/files/2017/10/16/4654d4a1-10f2-45c5-ab3d-6e9f37b85624__Atsugi_UH_06012017.pdf >> >> I see the localhost in the URL where is that defined so I can change it. >> >> Thank you. >> >> -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -- Christian Hammond President/CEO of Beanbag Makers of Review Board -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4467: Uploading File dialog triggers a JavaScript error if it can't communicate with the web server
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4467/ -- New update by chipx86 For Beanbag, Inc. > Review Board > Ticket #4467 Reply: Fixed on release-2.5.x (751d099788495f7f9b951a8e418f6f3ec3ad1851). Thanks! Status: - Confirmed + Fixed -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: MySQL/MariaDB utf8mb4
Hi Vince, Right now, don't use utf8mb4 by itself. That *is* the right encoding to use for proper Unicode support, yes, but additional settings need to be enabled manually on your database (globally and per-table) in order for key lengths to not be truncated (which will otherwise break things horribly). I could provide this information if you wanted to be a guinea pig, but the reality is that future upgrades won't be able to apply the settings on newer tables just yet, so upgrades can still break the compatibility. I've done a lot of experimentation with this, and I'm hoping that by the Review Board 4.0 timeframe that I can have built-in support, documentation, and a conversion tool for properly enabling utf8mb4 and all related settings as part of Review Board. I know exactly what needs to be done, it's just a matter of doing it and having a lot of testing in place, which we weren't able to do for 3.0. Christian On Wed, Oct 18, 2017 at 9:57 AM, Vince Thyng <vth...@gmail.com> wrote: > Is anyone using utf8mb4? We are looking at moving from latin1 to utf8. > This article makes the case for using it over utf8, https://mathiasbynens. > be/notes/mysql-utf8mb4 and am hoping someone in the community already has > experience with it. I figure we will need to look at the size of every > text field to be sure that losing 25% of the max will not cut off any data, > or else increase the size before switching to mb4. > > Thanks! > > Vince > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Index failure after upgrade to ReviewBoard 2.5.16
Hi Rob,
That doesn't include the code I mentioned in my previous e-mail. Note the
standalone 'hasattr' call on the line preceding the if statement. The
workaround is to call that in a standalone way to prime a cache and avoid
the error.
Christian
On Tue, Oct 17, 2017 at 1:17 AM, 'Rob Backhurst' via reviewboard <
reviewboard@googlegroups.com> wrote:
> 77 # Give priority to a template.
> 78 if self.use_template:
> 79 return self.prepare_template(obj)
> 80 elif self.model_attr is not None:
> 81 # Check for `__` in the field for looking through the
> relation.
> 82 attrs = self.model_attr.split('__')
> 83 current_object = obj
> 84
> 85 for attr in attrs:
> 86 if hasattr(current_object, attr):
> 87 raise SearchFieldError("The model '%s'
> does not have a model_attr '%s'." % (repr(current_object), attr))
> 88
> 89 current_object = getattr(current_object, attr,
> None)
> 90
> 91 if current_object is None:
> 92 if self.has_default():
> 93 current_object = self._default
> 94 # Fall out of the loop, given any further
> attempts at
> 95 # accesses will fail misreably.
>
>
> Thanks
> Rob
>
> On Tuesday, 17 October 2017 06:28:49 UTC+1, Christian Hammond wrote:
>>
>> Can you show me all the code within about 5 lines of your modification?
>>
>> Christian
>>
>>
>> On Mon, Oct 16, 2017 at 18:01 'Rob Backhurst' via reviewboard <
>> revie...@googlegroups.com> wrote:
>>
>>> Hi Christian,
>>>
>>> It crashes straight away with this error...
>>>
>>> Removing all documents from your index because you said so.
>>> All documents removed.
>>> Indexing 558 users
>>> ERROR:root:Error updating auth using default
>>> Traceback (most recent call last):
>>> File
>>> "/usr/lib/python2.7/site-packages/haystack/management/commands/update_index.py",
>>> line 188, in handle_label
>>> self.update_backend(label, using)
>>> File
>>> "/usr/lib/python2.7/site-packages/haystack/management/commands/update_index.py",
>>> line 233, in update_backend
>>> do_update(backend, index, qs, start, end, total,
>>> verbosity=self.verbosity, commit=self.commit)
>>> File
>>> "/usr/lib/python2.7/site-packages/haystack/management/commands/update_index.py",
>>> line 96, in do_update
>>> backend.update(index, current_qs, commit=commit)
>>> File
>>> "/usr/lib/python2.7/site-packages/haystack/backends/whoosh_backend.py",
>>> line 196, in update
>>> doc = index.full_prepare(obj)
>>> File "/usr/lib/python2.7/site-packages/haystack/indexes.py", line
>>> 212, in full_prepare
>>> self.prepared_data = self.prepare(obj)
>>> File "/usr/lib/python2.7/site-packages/haystack/indexes.py", line
>>> 203, in prepare
>>> self.prepared_data[field.index_fieldname] = field.prepare(obj)
>>> File "/usr/lib/python2.7/site-packages/haystack/fields.py", line 159,
>>> in prepare
>>> return self.convert(super(CharField, self).prepare(obj))
>>> File "/usr/lib/python2.7/site-packages/haystack/fields.py", line 87,
>>> in prepare
>>> raise SearchFieldError("The model '%s' does not have a model_attr
>>> '%s'." % (repr(current_object), attr))
>>> SearchFieldError: The model '' does not have a model_attr
>>> 'username'.
>>> - show quoted text -
>>> File "/usr/lib/python2.7/site-packages/haystack/fields.py", line 159,
>>> in prepare
>>> return self.convert(super(CharField, self).prepare(obj))
>>> File "/usr/lib/python2.7/site-packages/haystack/fields.py", line 87,
>>> in prepare
>>> raise SearchFieldError("The model '%s' does not have a model_attr
>>> '%s'." % (repr(current_object), attr))
>>> haystack.exceptions.SearchFieldError: The model '' does
>>> not have a model_attr 'username'.
>>>
>>> Thanks
>>> Rob
>>>
>>> On Monday, 16 October 2017 22:46:09 UTC+1, Christian Hammond wrote:
>>>
>>>> Hi Rob,
>>>>
>>>> Actually, this should function as a workaround for now. You can do this
>
Re: Unable to download attachments that have been uploaded.
Hi, Looks like your Media Path setting may be pointing to the wrong place, or your Review Board server name setting isn't set to your domain name. Can you check the Administration UI -> General Settings and see what those are set to? Christian On Tue, Oct 17, 2017 at 10:06 AM, Not Saying <d92...@gmail.com> wrote: > > > On Tuesday, October 17, 2017 at 10:01:17 AM UTC-7, Not Saying wrote: >> >> RHEL 7 >> *Review Board* <http://linuxa2.ng1.loc/reviewboard/> 2.5.15 >> >> *I click on the download button and it give me a page *This page can’t >> be displayed >> The URL is http://localhost/reviewboard/media/uploaded/files/2017/10/16 >> /4654d4a1-10f2-45c5-ab3d-6e9f37b85624__Atsugi_UH_06012017.pdf >> >> I see the localhost in the URL where is that defined so I can change it. >> If I change the local host to linuxa2ng1.loc the download works. >> > > > > > >> Thank you. >> >> -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Index failure after upgrade to ReviewBoard 2.5.16
Can you show me all the code within about 5 lines of your modification?
Christian
On Mon, Oct 16, 2017 at 18:01 'Rob Backhurst' via reviewboard <
reviewboard@googlegroups.com> wrote:
> Hi Christian,
>
> It crashes straight away with this error...
>
> Removing all documents from your index because you said so.
> All documents removed.
> Indexing 558 users
> ERROR:root:Error updating auth using default
> Traceback (most recent call last):
> File
> "/usr/lib/python2.7/site-packages/haystack/management/commands/update_index.py",
> line 188, in handle_label
> self.update_backend(label, using)
> File
> "/usr/lib/python2.7/site-packages/haystack/management/commands/update_index.py",
> line 233, in update_backend
> do_update(backend, index, qs, start, end, total,
> verbosity=self.verbosity, commit=self.commit)
> File
> "/usr/lib/python2.7/site-packages/haystack/management/commands/update_index.py",
> line 96, in do_update
> backend.update(index, current_qs, commit=commit)
> File
> "/usr/lib/python2.7/site-packages/haystack/backends/whoosh_backend.py",
> line 196, in update
> doc = index.full_prepare(obj)
> File "/usr/lib/python2.7/site-packages/haystack/indexes.py", line 212,
> in full_prepare
> self.prepared_data = self.prepare(obj)
> File "/usr/lib/python2.7/site-packages/haystack/indexes.py", line 203,
> in prepare
> self.prepared_data[field.index_fieldname] = field.prepare(obj)
> File "/usr/lib/python2.7/site-packages/haystack/fields.py", line 159, in
> prepare
> return self.convert(super(CharField, self).prepare(obj))
> File "/usr/lib/python2.7/site-packages/haystack/fields.py", line 87, in
> prepare
> raise SearchFieldError("The model '%s' does not have a model_attr
> '%s'." % (repr(current_object), attr))
> SearchFieldError: The model '' does not have a model_attr
> 'username'.
> - show quoted text -
> File "/usr/lib/python2.7/site-packages/haystack/fields.py", line 159, in
> prepare
> return self.convert(super(CharField, self).prepare(obj))
> File "/usr/lib/python2.7/site-packages/haystack/fields.py", line 87, in
> prepare
> raise SearchFieldError("The model '%s' does not have a model_attr
> '%s'." % (repr(current_object), attr))
> haystack.exceptions.SearchFieldError: The model '' does not
> have a model_attr 'username'.
>
> Thanks
> Rob
>
> On Monday, 16 October 2017 22:46:09 UTC+1, Christian Hammond wrote:
>
>> Hi Rob,
>>
>> Actually, this should function as a workaround for now. You can do this
>> in that same Haystack file. Change the entirety of that previous code to:
>>
>> hasattr(current_object, attr)
>>
>> if hasattr(current_object, attr):
>> raise SearchFieldError("The model '%s' does not have a model_attr
>> '%s'." % (repr(current_object), attr))
>>
>> What will happen is the initial hasattr will trigger the crash that's
>> resulting in the failure, but we're discarding the result of the initial
>> one. A lucky (in this case) side-effect is that only the first call on a
>> given review request will fail, and the second will succeed (internal state
>> caching stuff). This should allow a full index to proceed.
>>
>> It's a temporary fix until we get the next release out.
>>
>> Christian
>>
> On Mon, Oct 16, 2017 at 11:48 AM, 'Rob Backhurst' via reviewboard <
>> revie...@googlegroups.com> wrote:
>>
> Thanks Christian, is that something we’ll need to do directly to the
>>> database? I don’t suppose you have any info on what needs to be done? Our
>>> DBA is on leave at the mo.
>>>
>>> No probs, not always easy to get to the bottom of these things!
>>>
>>> Thanks
>>>
>> Rob
>>>
>>> Sent from my iPhone
>>>
>>> On 16 Oct 2017, at 19:15, Christian Hammond <chri...@beanbaginc.com>
>>> wrote:
>>>
>>> Interesting. Okay, yeah, you'd need to remove the commit ID from one of
>>> them for now. I'll put a fix together for the next 2.5.x and schedule a
>>> release. Thanks for your patience on this!
>>>
>>> Christian
>>>
>>>
>>> On Mon, Oct 16, 2017 at 07:46 'Rob Backhurst' via reviewboard <
>>> revie...@googlegroups.com> wrote:
>>>
>>> Hi Christian,
>>>>
>>>> Here you go...
>>>>
>>>> ERROR:root:Error updating reviews using default
>>>> Traceback (most recent call last):
>>>>
Re: Index failure after upgrade to ReviewBoard 2.5.16
Hi Rob,
Actually, this should function as a workaround for now. You can do this in
that same Haystack file. Change the entirety of that previous code to:
hasattr(current_object, attr)
if hasattr(current_object, attr):
raise SearchFieldError("The model '%s' does not have a model_attr
'%s'." % (repr(current_object), attr))
What will happen is the initial hasattr will trigger the crash that's
resulting in the failure, but we're discarding the result of the initial
one. A lucky (in this case) side-effect is that only the first call on a
given review request will fail, and the second will succeed (internal state
caching stuff). This should allow a full index to proceed.
It's a temporary fix until we get the next release out.
Christian
On Mon, Oct 16, 2017 at 11:48 AM, 'Rob Backhurst' via reviewboard <
reviewboard@googlegroups.com> wrote:
> Thanks Christian, is that something we’ll need to do directly to the
> database? I don’t suppose you have any info on what needs to be done? Our
> DBA is on leave at the mo.
>
> No probs, not always easy to get to the bottom of these things!
>
> Thanks
> Rob
>
> Sent from my iPhone
>
> On 16 Oct 2017, at 19:15, Christian Hammond <christ...@beanbaginc.com>
> wrote:
>
> Interesting. Okay, yeah, you'd need to remove the commit ID from one of
> them for now. I'll put a fix together for the next 2.5.x and schedule a
> release. Thanks for your patience on this!
>
> Christian
>
>
> On Mon, Oct 16, 2017 at 07:46 'Rob Backhurst' via reviewboard <
> reviewboard@googlegroups.com> wrote:
>
>> Hi Christian,
>>
>> Here you go...
>>
>> ERROR:root:Error updating reviews using default
>> Traceback (most recent call last):
>> File
>> "/usr/lib/python2.7/site-packages/haystack/management/commands/update_index.py",
>> line 188, in handle_label
>> self.update_backend(label, using)
>> File
>> "/usr/lib/python2.7/site-packages/haystack/management/commands/update_index.py",
>> line 233, in update_backend
>> do_update(backend, index, qs, start, end, total,
>> verbosity=self.verbosity, commit=self.commit)
>> File
>> "/usr/lib/python2.7/site-packages/haystack/management/commands/update_index.py",
>> line 96, in do_update
>> backend.update(index, current_qs, commit=commit)
>> File
>> "/usr/lib/python2.7/site-packages/haystack/backends/whoosh_backend.py",
>> line 196, in update
>> doc = index.full_prepare(obj)
>> File "/usr/lib/python2.7/site-packages/haystack/indexes.py", line 212,
>> in full_prepare
>> self.prepared_data = self.prepare(obj)
>> File "/usr/lib/python2.7/site-packages/haystack/indexes.py", line 203,
>> in prepare
>> self.prepared_data[field.index_fieldname] = field.prepare(obj)
>> File "/usr/lib/python2.7/site-packages/haystack/fields.py", line 166,
>> in prepare
>> return self.convert(super(CharField, self).prepare(obj))
>> File "/usr/lib/python2.7/site-packages/haystack/fields.py", line 90,
>> in prepare
>> getattr(current_object, attr)
>> File
>> "/usr/lib/python2.7/site-packages/reviewboard/reviews/models/review_request.py",
>> line 273, in get_commit
>> commit_id=six.text_type(self.changenum))
>> File "/usr/lib/python2.7/site-packages/django/db/models/query.py",
>> line 493, in update
>> rows = query.get_compiler(self.db).execute_sql(None)
>> File "/usr/lib/python2.7/site-packages/django/db/models/sql/compiler.py",
>> line 980, in execute_sql
>> cursor = super(SQLUpdateCompiler, self).execute_sql(result_type)
>> File "/usr/lib/python2.7/site-packages/django/db/models/sql/compiler.py",
>> line 786, in execute_sql
>> cursor.execute(sql, params)
>> File "/usr/lib/python2.7/site-packages/django/db/backends/util.py",
>> line 53, in execute
>> return self.cursor.execute(sql, params)
>> File "/usr/lib/python2.7/site-packages/django/db/utils.py", line 99,
>> in __exit__
>> six.reraise(dj_exc_type, dj_exc_value, traceback)
>> File "/usr/lib/python2.7/site-packages/django/db/backends/util.py",
>> line 53, in execute
>> return self.cursor.execute(sql, params)
>> File "/usr/lib/python2.7/site-packages/django/db/backends/mysql/base.py",
>> line 124, in execute
>> return self.cursor.execute(query, args)
>> File "/usr/lib64/python2.7/site-packages/MySQLdb/cursors.py", line
>> 205, in execute
>> self.errorhandler(self, exc, value)
>
Re: Index failure after upgrade to ReviewBoard 2.5.16
nt/commands/rebuild_index.py",
> line 26, in handle
> call_command('update_index', **options)
> File "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",
> line 159, in call_command
> return klass.execute(*args, **defaults)
> File "/usr/lib/python2.7/site-packages/django/core/management/base.py",
> line 285, in execute
> output = self.handle(*args, **options)
> File
> "/usr/lib/python2.7/site-packages/haystack/management/commands/update_index.py",
> line 183, in handle
> return super(Command, self).handle(*items, **options)
> File "/usr/lib/python2.7/site-packages/django/core/management/base.py",
> line 385, in handle
> label_output = self.handle_label(label, **options)
> File
> "/usr/lib/python2.7/site-packages/haystack/management/commands/update_index.py",
> line 188, in handle_label
> self.update_backend(label, using)
> File
> "/usr/lib/python2.7/site-packages/haystack/management/commands/update_index.py",
> line 233, in update_backend
> do_update(backend, index, qs, start, end, total,
> verbosity=self.verbosity, commit=self.commit)
> File
> "/usr/lib/python2.7/site-packages/haystack/management/commands/update_index.py",
> line 96, in do_update
> backend.update(index, current_qs, commit=commit)
> File "/usr/lib/python2.7/site-packages/haystack/backends/whoosh_backend.py",
> line 196, in update
> doc = index.full_prepare(obj)
> File "/usr/lib/python2.7/site-packages/haystack/indexes.py", line 212,
> in full_prepare
> self.prepared_data = self.prepare(obj)
> File "/usr/lib/python2.7/site-packages/haystack/indexes.py", line 203,
> in prepare
> self.prepared_data[field.index_fieldname] = field.prepare(obj)
> File "/usr/lib/python2.7/site-packages/haystack/fields.py", line 164,
> in prepare
> return self.convert(super(CharField, self).prepare(obj))
> File "/usr/lib/python2.7/site-packages/haystack/fields.py", line 92, in
> prepare
> raise SearchFieldError("The model '%s' ('%s' -- %s.%s at %s -- %s:%s)
> does not have a model_attr '%s' (%s -- %s)." % (obj.__class__.__name__,
> current_object.pk, current_object.__class__.__module__,
> current_object.__class__.__name__, inspect.getfile(obj.__class__),
> id(obj), id(current_object), attr, hasattr(current_object, attr), has_attr))
> haystack.exceptions.SearchFieldError: The model 'ReviewRequest' ('27393'
> -- reviewboard.reviews.models.review_request.ReviewRequest at
> /usr/lib/python2.7/site-packages/reviewboard/reviews/models/review_request.pyc
> -- 231638480:231638480) does not have a model_attr 'commit' (True -- False).
>
>
> Thaks
> Rob
>
>
>
> On Monday, 16 October 2017 06:31:25 UTC+1, Christian Hammond wrote:
>>
>> Hi Rob,
>>
>> At this point, "Gremlins" appear to be the best answer from what I'm able
>> to see right now. The output in that error is directly contradicting the
>> conditional that allows the error to be shown, so something really bizarre
>> is happening that absolutely should not be able to happen. It's not normal.
>>
>> There's one last thing I want to see... I don't think it's going to give
>> me any answers directly, but let's see where this goes.
>>
>> Change the code to:
>>
>> import inspect
>> has_attr = hasattr(current_object, attr)
>> print '%r (%s): %s' % (current_object.__class__, id(current_object),
>> has_attr)
>> if not has_attr:
>> raise SearchFieldError("The model '%s' ('%s' -- %s.%s at %s --
>> %s:%s) does not have a model_attr '%s' (%s -- %s)." %
>> (obj.__class__.__name__, current_object.pk, current_object.__class__.__
>> module__, current_object.__class__.__name__,
>> inspect.getfile(obj.__class__), id(obj), id(current_object), attr,
>> hasattr(current_object, attr), has_attr))
>>
>> Christian
>>
>> On Fri, Oct 13, 2017 at 2:41 AM, 'Rob Backhurst' via reviewboard <
>> revie...@googlegroups.com> wrote:
>>
>>> No probs - where do we go from here?
>>>
>>> Thanks
>>> Rob
>>>
>>> On Thursday, 12 October 2017 19:58:13 UTC+1, Stephen Gallagher wrote:
>>>>
>>>> Ok, I just wanted to rule out an easy solution.
>>>> On Thu, Oct 12, 2017 at 5:47 AM 'Rob Backhurst' via reviewboard <
>>>> revie...@googlegroups.com> wrote:
>>>>
>>>>> Just to add, the haystack version shown in the reviewboard shell is
>>>>> looking better now though.
>>>>>
>>>>>
Re: Index failure after upgrade to ReviewBoard 2.5.16
Hi Rob,
At this point, "Gremlins" appear to be the best answer from what I'm able
to see right now. The output in that error is directly contradicting the
conditional that allows the error to be shown, so something really bizarre
is happening that absolutely should not be able to happen. It's not normal.
There's one last thing I want to see... I don't think it's going to give me
any answers directly, but let's see where this goes.
Change the code to:
import inspect
has_attr = hasattr(current_object, attr)
print '%r (%s): %s' % (current_object.__class__, id(current_object),
has_attr)
if not has_attr:
raise SearchFieldError("The model '%s' ('%s' -- %s.%s at %s --
%s:%s) does not have a model_attr '%s' (%s -- %s)." %
(obj.__class__.__name__, current_object.pk,
current_object.__class__.__module__,
current_object.__class__.__name__, inspect.getfile(obj.__class__), id(obj),
id(current_object), attr, hasattr(current_object, attr), has_attr))
Christian
On Fri, Oct 13, 2017 at 2:41 AM, 'Rob Backhurst' via reviewboard <
reviewboard@googlegroups.com> wrote:
> No probs - where do we go from here?
>
> Thanks
> Rob
>
> On Thursday, 12 October 2017 19:58:13 UTC+1, Stephen Gallagher wrote:
>>
>> Ok, I just wanted to rule out an easy solution.
>> On Thu, Oct 12, 2017 at 5:47 AM 'Rob Backhurst' via reviewboard <
>> revie...@googlegroups.com> wrote:
>>
>>> Just to add, the haystack version shown in the reviewboard shell is
>>> looking better now though.
>>>
>>> >>> import reviewboard
>>> >>> print reviewboard.VERSION
>>> (2, 5, 16, 0, u'final', 0, True)
>>> >>> print reviewboard.__file__
>>> /usr/lib/python2.7/site-packages/reviewboard/__init__.pyc
>>> >>> import haystack
>>> >>> print haystack.__version__
>>> (2, 4, 1)
>>> >>> print haystack.__file__
>>> /usr/lib/python2.7/site-packages/haystack/__init__.pyc
>>>
>>>
>>> Thanks
>>> Rob
>>>
>>> On Thursday, 12 October 2017 10:41:59 UTC+1, Rob Backhurst wrote:
>>>>
>>>> Hi Stephen,
>>>>
>>>> I've installed that on our test system and re-run the index -
>>>> unfortunately the same problem.
>>>>
>>>> Thanks
>>>> Rob
>>>>
>>>> On Wednesday, 11 October 2017 19:21:22 UTC+1, Stephen Gallagher wrote:
>>>>>
>>>>>
>>>>>
>>>>> On Wed, Oct 11, 2017 at 7:40 AM 'Rob Backhurst' via reviewboard <
>>>>> revie...@googlegroups.com> wrote:
>>>>>
>>>>>> Hi Christian,
>>>>>>
>>>>>> Ok, lets hope this can tell you something useful...
>>>>>>
>>>>>>
>>>>>
>>>>> Rob, I just packaged up Haystack 2.4.1 (and did rudimentary testing to
>>>>> see that ReviewBoard still works). Would you mind installing the RPM at
>>>>> https://bodhi.fedoraproject.org/updates/python-django-
>>>>> haystack-2.4.1-1.el7 , restarting httpd and seeing if that fixes
>>>>> things?
>>>>>
>>>>> I'd like to see if this issue might just already be fixed in the newer
>>>>> release.
>>>>>
>>>> --
>>> Supercharge your Review Board with Power Pack:
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons:
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "reviewboard" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to reviewboard...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
--
Christian Hammond
President/CEO of Beanbag <https://www.beanbaginc.com/>
Makers of Review Board <https://www.reviewboard.org/>
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: Issue: Only team foundation available when adding repository (Windows install)
bscribed to the Google >>>>> Groups "reviewboard" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to reviewboard+unsubscr...@googlegroups.com. >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> >>>> >>>> >>>> -- >>>> Erik Johansson >>>> Home Page: http://ejohansson.se/ >>>> PGP Key: http://ejohansson.se/erik.asc >>>> >>>> -- >>>> Supercharge your Review Board with Power Pack: >>>> https://www.reviewboard.org/powerpack/ >>>> Want us to host Review Board for you? Check out RBCommons: >>>> https://rbcommons.com/ >>>> Happy user? Let us know! https://www.reviewboard.org/users/ >>>> --- >>>> You received this message because you are subscribed to the Google >>>> Groups "reviewboard" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to reviewboard+unsubscr...@googlegroups.com. >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to reviewboard+unsubscr...@googlegroups.com. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> >> >> -- >> Erik Johansson >> Home Page: http://ejohansson.se/ >> PGP Key: http://ejohansson.se/erik.asc >> > > > > -- > Erik Johansson > Home Page: http://ejohansson.se/ > PGP Key: http://ejohansson.se/erik.asc > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Exporting Reviewboard contents
Hi Gene, We're beta-testing a feature for Power Pack that does exactly this. It needs some hand-holding right now, and may require some post-import work, but if you want to give it a try, I can send a build your way with instructions. You'll need to get a Power Pack trial license first at https://www.reviewboard.org/powerpack/trial/ Just to check, what version of Review Board are you using? Christian On Sun, Oct 15, 2017 at 10:14 PM, Gene Paul Quevedo <gene.quev...@gmail.com> wrote: > Hi, > > Is there any tool, internal or external to Reviewboard, that can export > reviews or review requests and so we can import them on another Reviewboard > instance? > > Our usecase on this matter is we have an external team coming in help us > in on of our projects and we want them to have their own Reviewboard server > but contains only a subset of the > Reviews already existing in our current Production server, rather than > duplicating our server and removing the majority of the reviews > > much thanks for any help > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Getting error: 'ascii' codec can't decode byte 0xc3 in position 1264: ordinal not in range(128)
That change did miss the release. It will be present in RC1.
Christian
On Tue, Oct 10, 2017 at 7:27 AM, Nicolas Ferrari <ferrari.nico...@gmail.com>
wrote:
> Hi, the issue is still present in the 3.0.x version.
>
> Regards,
>
> On Monday, October 2, 2017 at 11:11:17 PM UTC+2, Christian Hammond wrote:
>>
>> Hi Ali,
>>
>> We have a fix for this in our tree (commit
>> 23fbc2f28742442835c4c275e81c1ad0cb163ed6),
>> which will be part of the next 2.5.x release.
>>
>> Christian
>>
>> On Mon, Oct 2, 2017 at 7:05 AM, Ali Lokhandwala <a...@huestones.co.uk>
>> wrote:
>>
>>> Hi,
>>> I am getting this error on our repo files when raising reviews post
>>> commit using:
>>>
>>> - root - Unable to update new review request from commit ID
>>> 949e6492ab2c243e8828c8329218089000a4da39 on repository ID=5: 'ascii' codec
>>> can't decode byte 0xc3 in position 1264: ordinal not in range(128)
>>> Traceback (most recent call last):
>>> File
>>> "/opt/bitnami/apps/reviewboard/htdocs/reviewboard/reviews/managers.py",
>>> line 156, in create
>>> draft.update_from_commit_id(commit_id)
>>> File
>>> "/opt/bitnami/apps/reviewboard/htdocs/reviewboard/reviews/models/review_request_draft.py",
>>> line 278, in update_from_commit_id
>>> self.update_from_committed_change(commit_id)
>>> File
>>> "/opt/bitnami/apps/reviewboard/htdocs/reviewboard/reviews/models/review_request_draft.py",
>>> line 346, in update_from_committed_change
>>> diff_file_contents=commit.diff.encode('utf-8'),
>>> UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 1264:
>>> ordinal not in range(128)
>>>
>>> --
>>> Supercharge your Review Board with Power Pack:
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons:
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "reviewboard" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to reviewboard...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>>
>>
>> --
>> Christian Hammond
>> President/CEO of Beanbag <https://www.beanbaginc.com/>
>> Makers of Review Board <https://www.reviewboard.org/>
>>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
--
Christian Hammond
President/CEO of Beanbag <https://www.beanbaginc.com/>
Makers of Review Board <https://www.reviewboard.org/>
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: Index failure after upgrade to ReviewBoard 2.5.16
lf, obj):
> return self.convert(super(MultiValueField, self).prepare(obj))
>
> def convert(self, value):
> if value is None:
> return None
>
> return list(value)
>
>
> class FacetField(SearchField):
> """
> ``FacetField`` is slightly different than the other fields because it
> can
> work in conjunction with other fields as its data source.
>
> Accepts an optional ``facet_for`` kwarg, which should be the field name
> (not ``index_fieldname``) of the field it should pull data from.
> """
> instance_name = None
>
> def __init__(self, **kwargs):
> handled_kwargs = self.handle_facet_parameters(kwargs)
> super(FacetField, self).__init__(**handled_kwargs)
>
> def handle_facet_parameters(self, kwargs):
> if kwargs.get('faceted', False):
> raise SearchFieldError("FacetField (%s) does not accept the
> 'faceted' argument." % self.instance_name)
>
> if not kwargs.get('null', True):
> raise SearchFieldError("FacetField (%s) does not accept False
> for the 'null' argument." % self.instance_name)
>
> if not kwargs.get('indexed', True):
> raise SearchFieldError("FacetField (%s) does not accept False
> for the 'indexed' argument." % self.instance_name)
>
> if kwargs.get('facet_class'):
> raise SearchFieldError("FacetField (%s) does not accept the
> 'facet_class' argument." % self.instance_name)
>
> self.facet_for = None
> self.facet_class = None
>
> # Make sure the field is nullable.
> kwargs['null'] = True
>
> if 'facet_for' in kwargs:
> self.facet_for = kwargs['facet_for']
> del(kwargs['facet_for'])
>
> return kwargs
>
> def get_facet_for_name(self):
> return self.facet_for or self.instance_name
>
>
> class FacetCharField(FacetField, CharField):
> pass
>
>
> class FacetIntegerField(FacetField, IntegerField):
> pass
>
>
> class FacetFloatField(FacetField, FloatField):
> pass
>
>
> class FacetDecimalField(FacetField, DecimalField):
> pass
>
>
> class FacetBooleanField(FacetField, BooleanField):
> pass
>
>
> class FacetDateField(FacetField, DateField):
> pass
>
>
> class FacetDateTimeField(FacetField, DateTimeField):
> pass
>
>
> class FacetMultiValueField(FacetField, MultiValueField):
> pass
>
>
> On Monday, 9 October 2017 17:22:42 UTC+1, Christian Hammond wrote:
>>
>> Can you send me the fields.py file as you now have it? That output
>> contradicts the logic that should be in the code.
>>
>> Christian
>>
>>
>> On Mon, Oct 9, 2017 at 03:29 'Rob Backhurst' via reviewboard <
>> revie...@googlegroups.com> wrote:
>>
>>> Hi Christian,
>>>
>>> See the new output below...
>>>
>>> Removing all documents from your index because you said so.
>>> All documents removed.
>>> Indexing 558 users
>>> Indexing 27878 review requests
>>> ERROR:root:Error updating reviews using default
>>> Traceback (most recent call last):
>>> File
>>> "/usr/lib/python2.7/site-packages/haystack/management/commands/update_index.py",
>>> line 189, in handle_label
>>> self.update_backend(label, using)
>>> File
>>> "/usr/lib/python2.7/site-packages/haystack/management/commands/update_index.py",
>>> line 234, in update_backend
>>> do_update(backend, index, qs, start, end, total, self.verbosity)
>>> File
>>> "/usr/lib/python2.7/site-packages/haystack/management/commands/update_index.py",
>>> line 89, in do_update
>>> backend.update(index, current_qs)
>>> File
>>> "/usr/lib/python2.7/site-packages/haystack/backends/whoosh_backend.py",
>>> line 191, in update
>>> doc = index.full_prepare(obj)
>>> File "/usr/lib/python2.7/site-packages/haystack/indexes.py", line
>>> 207, in full_prepare
>>> self.prepared_data = self.prepare(obj)
>>> File "/usr/lib/python2.7/site-packages/haystack/indexes.py", line
>>> 198, in prepare
>>> self.prepared_data[field.index_fieldname] = field.prepare(obj)
>>> File "/usr/lib/python2.7/site-packages/haystack/fields.py", line 160,
>>> in prepare
>>> return self.convert(super(CharField, self).prepare(obj))
>>> File "/usr/lib/python2.
Re: Review Board 3.0 beta 2 is out -- beta testers needed!
The expectation is that we'll have a single RC release, based on our usage so far. Christian On Mon, Oct 9, 2017 at 4:07 PM, MoonWalker <daniel.cabrera...@gmail.com> wrote: > I am guessing that base on the testers feedback we way see additional RCs > before the final release > > On Tuesday, October 10, 2017 at 8:12:20 AM UTC+11, Christian Hammond wrote: >> >> The plan is to get RC1 out in 2-3 weeks, based on what bugs get reported >> to us. This is basically what we'll end up shipping as 3.0 (minus some docs >> and bug fixes/visual polish). So if you'd like, you can install RC1 when >> it's out. Just test first on a non-production server. >> >> Christian >> >> >> On Mon, Oct 9, 2017 at 14:00 MoonWalker <daniel.c...@gmail.com> wrote: >> >>> >>> When do you guys think that RB 3 will be *ready* for production? >>> >>> On Saturday, October 7, 2017 at 4:15:54 AM UTC+11, Christian Hammond >>> wrote: >>>> >>>> Hi everyone, >>>> >>>> We just put out a release of Review Board 3.0 beta 2. There's a lot of >>>> new features in this release, and at this point we're feature-complete, >>>> focusing on bug fixing. Some of the highlights include: >>>> >>>> * Highlighting of new updates and discussions on review requests >>>> * Ability to revoke Ship Its >>>> * Ability to require the reviewer's verification on closed issues >>>> * OAuth2 Provider support >>>> * Emoji shortcodes >>>> * CircleCI and Travis CI integration >>>> * On-the-fly search indexing >>>> * Lots more >>>> >>>> We'd like to get the RC1 (Release Candidate 1) release out in two >>>> weeks. In the meantime, we're focusing on bug fixing and documentation. >>>> >>>> We could really use your help on testing this release (on a test >>>> server, not production!). Installing the beta on a test server, along with >>>> a copy of your database, and ensuring everything works will help us to ship >>>> a better final release of 3.0. >>>> >>>> If you use or develop in-house extensions, we'd like your feedback as >>>> well. We've done a lot of work on our extension capabilities, adding >>>> improved support for custom fields and review request actions, and we could >>>> use feedback here. >>>> >>>> Our release announcement for beta 2 is here: https://www.reviewboard. >>>> org/news/2017/10/05/review-board-3-0-beta-2-here/ >>>> >>>> Christian >>>> >>>> -- >>>> Christian Hammond >>>> President/CEO of Beanbag <https://www.beanbaginc.com/> >>>> Makers of Review Board <https://www.reviewboard.org/> >>>> >>> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to reviewboard...@googlegroups.com. >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- >> -- >> Christian Hammond >> President/CEO of Beanbag >> Makers of Review Board >> > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Jenkins CI integration on RB 3 Plz
Yeah, our integrations are actually not part of the Review Board code base. They live in a rbintegrations package, which we'll be maintaining and releasing separately from Review Board, so that it's not dependent on the Review Board release cycle as much. Christian On Mon, Oct 9, 2017 at 4:28 PM, MoonWalker <daniel.cabrera...@gmail.com> wrote: > BTW IMO plugins/extensions is the way to go, since it can extend RB > functionality without messing around with RB core > > On Tuesday, October 10, 2017 at 8:10:24 AM UTC+11, Christian Hammond wrote: >> >> Hi, >> >> I definitely want to do Jenkins support. It won't happen by 3.0 but it's >> on my radar. Supporting another CI system requires a lot of work, so we >> still have to see what's involved. There's also a question of what we'll be >> shipping with Review Board and what we'll be shipping with Power Pack, >> which we need to discuss internally. >> >> Christian >> >> >> On Mon, Oct 9, 2017 at 13:59 MoonWalker <daniel.c...@gmail.com> wrote: >> >>> I read that RB 3 beta 2 added support for Travis CI and Circle CI. Could >>> you please add support for Jenkins as well. Not sure if that can be done >>> with Webhooks in the mean time >>> >>> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to reviewboard...@googlegroups.com. >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- >> -- >> Christian Hammond >> President/CEO of Beanbag >> Makers of Review Board >> > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
