RE: It's too easy to upload diffs wrongly
You do not need them to run post-review from the command line themselves. Our users work on windows (server is on unix) and I have a script that does all the hard work. All the users need to do is right click on the main source folder and choose between these two options (added to the list via a registry key): - Review request - Update review request The former will create the review request without any additional action(s) required by the user, and the latter will ask for the review request number to update. Easy. At least depending on what your needs are. Regards, Elardus Elardus Erasmus DigiCore Technologies (Pty) Ltd Embedded Software Engineer [cid:imageafc275.JPG@f8006872.59244af5] Tel: +27 12 450 2272 * Fax: +27 12 450 2311 Email: elard...@digicore.co.za * Website: www.ctrack.co.zahttp://www.ctrack.co.za/ * Email Disclaimerhttp://www.ctrack.co.za/about_ctrack/email_signature_disclaimer.aspx From: reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com] On Behalf Of Brian Armstrong Sent: 04 December 2012 08:52 To: reviewboard@googlegroups.com Subject: Re: It's too easy to upload diffs wrongly I think the interface for uploading diffs is very minimalistic and vague about what to do. The first time, without fail, any of our developers have tried to use the upload diff interface it has failed to work properly and results in an error about not being able to apply the diff or being unable to find the parent revision. This has led to me spending time with each of these developers to train them how to properly upload diffs. I'd say something there is very broken if it doesn't work like people are expecting it to work and it doesn't have a clear explanation of what it is expecting. Also, if the diff can't be applied properly, it should show an error on the upload screen about it. They shouldn't have to click view diff every time to make sure it uploaded correctly. I think saying the fix for the confusing interface is to not use the interface and to use the command line tool instead is not actually a solution to the problem. It is also not an option for everyone (like our Skins team who just does CSS and Javascript and is scared of the command line). We have them using reviewboard, but they will only upload their diffs manually. They have run into this same kind of problem, and it just makes the tool overly complicated and not worth the time to learn. Giving this kind of solution to a problem is not only insufficient, but it also shows that the problem is real and the tool is lacking in functionality and clearness. If it's not understandable and usable, then it's broken. If it's broken, then it needs to be fixed. The correct fix should not be use something else. That being said, it is open source, so I'd love to see the diff of changes that Will made. They'd probably be helpful for our users too. On Friday, November 30, 2012 3:53:20 PM UTC-7, David Trowbridge wrote: It's correct to upload full diffs. The best way to do this is to use the post-review tool, which (with no arguments) will do the right thing. -David -David On Fri, Nov 30, 2012 at 2:49 PM, Will ultra...@gmail.comjavascript: wrote: So... don't any users know how whether it's correct to upload full diffs or partial diffs? On Thursday, 22 November 2012 12:44:25 UTC, Will wrote: Where is it described in the documentation the correct way to make several diffs and upload them incrementally? We had a situation where one of our developers only uploaded partial diffs each time (just the changes since the last time he uploaded a diff), meaning there was no way to see his complete set of diffs together. I don't blame him because how was he supposed to know not to do that? We ended up hacking some extra instructions into the add review template and marking them bold red to try and prevent people doing this. ReviewBoard assumes all diffs are complete (from first commit to last), and it figures out the rest, allowing reviewers to easily drill down by revision if they want. If any of the uploaded diffs are not complete, then reviewers can completely miss changes that were made. a) where is the right way to add diffs documented? b) shouldn't reviewboard make it a lot more difficult to upload diffs wrongly -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard...@googlegroups.comjavascript: For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr
RBTools review creating taking very long
/
HTTP GETting http://HQDCTWS019:50001/api/repositories/33/info/
HTTP GETting http://HQDCTWS019:50001/api/repositories/34/
HTTP GETting http://HQDCTWS019:50001/api/repositories/34/info/
HTTP GETting http://HQDCTWS019:50001/api/repositories/35/
HTTP GETting http://HQDCTWS019:50001/api/repositories/35/info/
HTTP GETting http://HQDCTWS019:50001/api/repositories/36/
HTTP GETting http://HQDCTWS019:50001/api/repositories/36/info/
HTTP GETting http://HQDCTWS019:50001/api/repositories/37/
HTTP GETting http://HQDCTWS019:50001/api/repositories/37/info/
HTTP GETting http://HQDCTWS019:50001/api/repositories/38/
HTTP GETting http://HQDCTWS019:50001/api/repositories/38/info/
HTTP GETting http://HQDCTWS019:50001/api/repositories/39/
HTTP GETting http://HQDCTWS019:50001/api/repositories/39/info/
HTTP GETting http://HQDCTWS019:50001/api/repositories/40/
HTTP GETting http://HQDCTWS019:50001/api/repositories/40/info/
Uploading diff, size: 7846
HTTP POSTing to http://HQDCTWS019:50001/api/review-requests/581/diffs/: {'ba
sedir': '/Trunk/Source'}
Review request #581 posted.
http://HQDCTWS019:50001/r/581/
Elardus Erasmus
DigiCore Technologies (Pty) Ltd
Embedded Software Engineer
[cid:imageb68af6.JPG@0a94a6e9.e3db4714]
Tel: +27 12 450 2272 * Fax: +27 12 450 2311
Email: elard...@digicore.co.za * Website:
www.ctrack.co.zahttp://www.ctrack.co.za/ * Email
Disclaimerhttp://www.ctrack.co.za/about_ctrack/email_signature_disclaimer.aspx
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=eninline: imageb68af6.JPG@0a94a6e9.e3db4714
RE: SVN 1.7 support
IIRC: - the sever (ubuntu) was upgraded to the latest 1.7 subversion - clients (on windows) were upgraded to the latest subversion (1.7.4 at that time) - RBtools on clients upgraded to 0.4.1. I did not strip out/modify anything. The only problem I ran into was that the diff.exe program of the svn client installation messed with my GNU diff.exe path. I sorted that and it worked. Now that I think about it, I may have upgraded pysvn on the server also since some compatibility issues were reported (google). Elardus Erasmus DigiCore Technologies (Pty) Ltd Embedded Software Engineer [cid:image90a104.JPG@c27b87cc.0b9e4341] Tel: +27 12 450 2272 * Fax: +27 12 450 2311 Email: elard...@digicore.co.za * Website: www.ctrack.co.zahttp://www.ctrack.co.za/ * Email Disclaimerhttp://www.ctrack.co.za/about_ctrack/email_signature_disclaimer.aspx From: reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com] On Behalf Of mxbraun Sent: 27 August 2012 16:29 To: reviewboard@googlegroups.com Subject: Re: SVN 1.7 support Do you happen to recall if you stripped out the new 1.7 stuff from the diff, or did you modify pysvn or RB to handle the new content? We're about to try something to handle these as well, and are considering the pros/cons of both approaches. (I'd prefer the latter, but suspect implementing the former is much easier.) m@ On Thursday, August 23, 2012 8:38:50 AM UTC-5, Elardus wrote: I have. Just don't ask me for the steps. They are long forgotten. But it was not too much of a hassle IIRC. Elardus Elardus Erasmus DigiCore Technologies (Pty) Ltd Embedded Software Engineer [https://groups.google.com/group/reviewboard/attach/ef2bb6a87cdee452/image892851.JPG@83b7751c.bc184850?part=4authuser=0] Tel: +27 12 450 2272 * Fax: +27 12 450 2311 Email: elar...@digicore.co.zajavascript: * Website: www.ctrack.co.zahttp://www.ctrack.co.za/ * Email Disclaimerhttp://www.ctrack.co.za/about_ctrack/email_signature_disclaimer.aspx From: revie...@googlegroups.comjavascript: [mailto:revie...@googlegroups.comjavascript:] On Behalf Of Daniel Laird Sent: 23 August 2012 15:25 To: revie...@googlegroups.comjavascript: Subject: SVN 1.7 support Has anyone managed to patch or modify reviewboard so that diffs generated under SVN 1.7 actually work with post-review and ReviewBoard? The upgrade to SVN is about to hit my department and it will be a shame to stop reviewing code as a result of this change Dan -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard...@googlegroups.comjavascript: For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=eninline: image90a104.JPG@c27b87cc.0b9e4341
RE: SVN 1.7 support
I have. Just don't ask me for the steps. They are long forgotten. But it was not too much of a hassle IIRC. Elardus Elardus Erasmus DigiCore Technologies (Pty) Ltd Embedded Software Engineer [cid:image892851.JPG@83b7751c.bc184850] Tel: +27 12 450 2272 * Fax: +27 12 450 2311 Email: elard...@digicore.co.za * Website: www.ctrack.co.zahttp://www.ctrack.co.za/ * Email Disclaimerhttp://www.ctrack.co.za/about_ctrack/email_signature_disclaimer.aspx From: reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com] On Behalf Of Daniel Laird Sent: 23 August 2012 15:25 To: reviewboard@googlegroups.com Subject: SVN 1.7 support Has anyone managed to patch or modify reviewboard so that diffs generated under SVN 1.7 actually work with post-review and ReviewBoard? The upgrade to SVN is about to hit my department and it will be a shame to stop reviewing code as a result of this change Dan -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=eninline: image892851.JPG@83b7751c.bc184850
RE: post-review, subversion and diff engines on windows
Okay thanks. I was not aware that svn diff did always work directly. I thougt maybe the fact that the latest subversion created diffs in unified format got it to work now. The suggestion then would have been to add a switch to the post-review command to enable/disable the use of GNUdiff/plain svn diff for subversion based repositories. That would have made installation/setup of the client (at least on windows) a bit easier. Best regards, Elardus Erasmus DigiCore Technologies Embedded Software Engineer [cid:image931ed7.JPG@28e910c1.4c674b78] Tel: +27 12 450 2272 * Fax: +27 12 450 2311 Email: elard...@digicore.co.za * Website: www.ctrack.co.zahttp://www.ctrack.co.za/ * Email Disclaimerhttp://www.ctrack.co.za/about_ctrack/email_signature_disclaimer.aspx From: reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com] On Behalf Of Christian Hammond Sent: 24 April 2012 06:25 To: reviewboard@googlegroups.com Subject: Re: post-review, subversion and diff engines on windows Hi, svn diffs have always directly worked, but there were issues with the diffs they produced. I honestly don't remember what they are, so we'd have to dig into it a bit, but forcing GNU diff worked around them. Wish I was more helpful than that. Christian -- Christian Hammond - chip...@chipx86.commailto:chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Apr 23, 2012 at 6:27 AM, Elardus Erasmus elard...@digicore.co.zamailto:elard...@digicore.co.za wrote: Hi there, I have just upgraded the client side subversion (Windows) to 1.7.4 and RBtools to 0.4.1. After the upgrade post-review did not function anymore. The problem was that the diff.exe program of the CollabNet installation messed with my GNU diff.exe. I sorted that and it is working now. During the debugging process I generated a diff set using simply svn diff file (not external diff program specified), and saved the output to a file for use with the post-review switch -diff-filename=file. It worked. I guess it is because svn diff now produce unified format diffs. Are there any plans to do away with GNU diff program requirement on windows? Best regards, -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.commailto:reviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=eninline: image931ed7.JPG@28e910c1.4c674b78
post-review, subversion and diff engines on windows
Hi there, I have just upgraded the client side subversion (Windows) to 1.7.4 and RBtools to 0.4.1. After the upgrade post-review did not function anymore. The problem was that the diff.exe program of the CollabNet installation messed with my GNU diff.exe. I sorted that and it is working now. During the debugging process I generated a diff set using simply svn diff file (not external diff program specified), and saved the output to a file for use with the post-review switch -diff-filename=file. It worked. I guess it is because svn diff now produce unified format diffs. Are there any plans to do away with GNU diff program requirement on windows? Best regards, Elardus Erasmus DigiCore Technologies Embedded Software Engineer [cid:image8dc44d.JPG@e4ac947d.d53648f8] Tel: +27 12 450 2272 * Fax: +27 12 450 2311 Email: elard...@digicore.co.za * Website: www.ctrack.co.zahttp://www.ctrack.co.za/ * Email Disclaimerhttp://www.ctrack.co.za/about_ctrack/email_signature_disclaimer.aspx -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=eninline: image8dc44d.JPG@e4ac947d.d53648f8
