Re: RBTools Ticket #4551: Allow rbt diff to take --no-renames argument for GIT repos

[Rick Liu]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4551/
--

New update by totoroliu
For Beanbag, Inc. > RBTools > Ticket #4551


Reply:

Do you know when your change can be merged?
or could you create another pull-request to be merged into next rbtools 
release?

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: RBTools Ticket #4551: Allow rbt diff to take --no-renames argument for GIT repos

[Rick Liu]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4551/
--

New update by totoroliu
For Beanbag, Inc. > RBTools > Ticket #4551


Reply:

It looks like your review #9221 https://reviews.reviewboard.org/r/9221/ has 
been committed back in Nov 2017.
I just updated to the latest RBTools 1.0.1,
but it seems I'm still unable to run "rbt diff --no-renames" nor unable to 
see --no-renames feature from "rbt diff --help".

How do I use this --no-renames feature?

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: RBTools Ticket #4551: Allow rbt diff to take --no-renames argument for GIT repos

[Rick Liu]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4551/
--

New update by totoroliu
For Beanbag, Inc. > RBTools > Ticket #4551


Reply:

hi~ is there any update to this?
or the pull-request has been merged and released?

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

RBTools Ticket #4754: rbt diff output raw string

[Rick Liu]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4754/
--

New ticket #4754 by totoroliu
For Beanbag, Inc. > RBTools

Status: New
Tags: Priority:Medium, Type:Defect


--
 rbt diff output raw string
==

# What version are you running?
```
Ubuntu 18.04.1
RBTools 1.0.1
svn, version 1.9.7 (r1800392)
Python 3.6.6
```

# What steps will reproduce the problem?
1. SVN commit a text file with content:
```
$ cat Test/test1
line1
line2
line3
line4
line5
```

2. Replace line3 with "new line3"

3. svn diff output:
```
Index: Test/test1
===
--- Test/test1  (revision 26385)
+++ Test/test1  (working copy)
@@ -1,5 +1,5 @@
 line1
 line2
-line3
+new line3
 line4
 line5
```

4. rbt diff output:
```
$ rbt diff
b'Index: 
/TestProject/trunk/Test/test1\n===\n---
 /TestProject/trunk/Test/test1\t(revision 26385)\n+++ 
/TestProject/trunk/Test/test1\t(working copy)\n@@ -1,5 +1,5 @@\n line1\n 
line2\n-line3\n+new line3\n line4\n line5\n
```


# What is the expected output? What do you see instead?
```
Ubuntu 16.04.5
RBTools 1.0.1
svn, version 1.9.9 (r1835931)
Python 2.7.14

$ svn diff
Index: Test/test1
===
--- Test/test1  (revision 26385)
+++ Test/test1  (working copy)
@@ -1,5 +1,5 @@
 line1
 line2
-line3
+new line3
 line4
 line5

$ rbt diff
Index: /TestProject/trunk/Test/test1
===
--- /TestProject/trunk/Test/test1   (revision 26385)
+++ /TestProject/trunk/Test/test1   (working copy)
@@ -1,5 +1,5 @@
 line1
 line2
-line3
+new line3
 line4
 line5
```

# What operating system are you using?
Ubuntu 18.04.1

# Attach the debug out from the command.

```
$ rbt diff --debug
>>> RBTools 1.0.1
>>> Python 3.6.6 (default, Sep 12 2018, 18:26:19) 
[GCC 8.0.1 20180414 (experimental) [trunk revision 259383]]
>>> Running on Linux-4.15.0-36-generic-x86_64-with-Ubuntu-18.04-bionic
>>> Home = /home/devops
>>> Current directory = /home/devops/TestProject_trunk
>>> Command line: rbt diff --debug
>>> Running: tf vc help
>>> Checking for a Bazaar repository...
>>> Unable to execute "bzr help": skipping Bazaar
>>> Checking for a ClearCase repository...
>>> Unable to execute "cleartool help": skipping ClearCase
>>> Checking for a CVS repository...
>>> Unable to execute "cvs": skipping CVS
>>> Checking for a Git repository...
>>> Running: git rev-parse --git-dir
>>> Command exited with rc 128: ['git', 'rev-parse', '--git-dir']
fatal: not a git repository (or any of the parent directories): .git
---
>>> Checking for a Mercurial repository...
>>> Unable to execute "hg --help": skipping Mercurial
>>> Checking for a Perforce repository...
>>> Unable to execute "p4 help": skipping Perforce
>>> Checking for a Plastic repository...
>>> Unable to execute "cm version": skipping Plastic
>>> Checking for a Subversion repository...
>>> Running: svn --non-interactive info
>>> Running: diff --version
>>> Running: svn --non-interactive --version -q
>>> Repository info: Path: https://scm-yvr-mirror.fortinet.com/svn/svntest, 
>>> Base path: /TestProject/trunk, Supports changesets: False
>>> Checking for a Team Foundation Server repository...
>>> Unable to execute "tf help": skipping TFS
>>> Making HTTP GET request to https://reviewboard-test.corp.fortinet.com/api/
>>> Running: svn --non-interactive status -q --ignore-externals
>>> Running: svn --non-interactive diff --diff-cmd=diff --notice-ancestry -r 
>>> BASE
>>> Running: svn --non-interactive info Test/test1
>>> Running: svn --non-interactive info Test
>>> Running: svn --non-interactive diff --diff-cmd=diff --notice-ancestry -r 
>>> BASE --no-diff-deleted
b'Index: 
/TestProject/trunk/Test/test1\n===\n---
 /TestProject/trunk/Test/test1\t(revision 26385)\n+++ 
/TestProject/trunk/Test/test1\t(working copy)\n@@ -1,5 +1,5 @@\n line1\n 
line2\n-line3\n+new line3\n line4\n line5\n'

```


# Please provide any additional information below.


--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

RBTools 1.0.1 diff output raw string with Python 3.6.6

[Rick Liu]

Hi,

I'm trying out RBTools 1.0.1 on Ubuntu 18.04.1 using Python 3.6.6.
The "rbt diff" outputs raw string like:

$ rbt diff
b'Index: 
/TestProject/trunk/Test/test1\n===\n---
 /TestProject/trunk/Test/test1\t(revision 26385)\n+++ 
/TestProject/trunk/Test/test1\t(working copy)\n@@ -1,5 +1,5 @@\n line1\n 
line2\n-line3\n+new line3\n line4\n line5\n'


I have created a bug at:

https://hellosplat.com/s/beanbag/tickets/4753/



Rick

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Reviewboard SVN 1.10 binary file detection not working

[Rick Liu]

I also hit this problem when using SVN 1.10.
and have created a bug ticket:
https://hellosplat.com/s/beanbag/tickets/4750/

In additional to the display issue,
rbt patch also would incorrectly patching the regular text file (if change 
contains binary file),
and resulting svn property conflicts for the regular text file.

Rick


On Thursday, September 27, 2018 at 11:55:46 AM UTC-7, Kevin Yu wrote:
>
> Hi,
>
> I noticed when I upgraded Subversion to 1.10, Reviewboard stopped 
> displaying binary files on Diff GUI.
>
>Index: /abc/branches/3.x/3.0/trunk/cooked/basepkgs/abc.pkg
>
>
>   ===
>
>   Cannot display: file marked as a binary type.
>
>   svn:mime-type = application/octet-stream
>
>   
>
>   Property changes on:
> cooked/basepkgs/abc.pkg
>
>   ___
>
>   Added: svn:mime-type
>
>   ## -0,0 +1 ##
>
>   +application/octet-stream
>
>   \ No newline at end of property
>
> 
>
> From SVN 1.9 "rbt diff" output, I have:
>
> 
>
> Index: /abc/branches/3.x/3.0/trunk/cooked/basepkgs/abc.pkg
>
>   ===
>
>   Cannot display: file marked as a binary type.
>
>   svn:mime-type = application/octet-stream
>
>   Index:
> /abc/branches/3.x/3.0/trunk/cooked/basepkgs/abc.pkg
>
>   ===
>
>   ---
> /abc/branches/3.x/3.0/trunk/cooked/basepkgs/abc.pkg (nonexistent)+++
> /abc/branches/3.x/3.0/trunk/cooked/basepkgs/abc.pkg (working copy)
>
>   
>
>   Property changes on:
> cooked/basepkgs/abc.pkg
>
>   ___
>
>   Added: svn:mime-type
>
>   ## -0,0 +1 ##
>
>   +application/octet-stream
>
>   \ No newline at end of property
>
> In this case, abc.pkg would not show up on the Diff GUI. I suspect it has 
> to do with the binary format change in diff in SVN 1.10.2.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4750: SVN 1.10 binary file not showing up DIFF file list

[Rick Liu]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4750/
--

New update by totoroliu
For Beanbag, Inc. > Review Board > Ticket #4750


Reply:

With SVN 1.10,
if the DIFF file has mixed of text file change and binary file change,
rbt patch would incorrectly patch text file change with binary file svn 
property 
and caused SVN property conflicts.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Review Board Ticket #4750: SVN 1.10 binary file not showing up DIFF file list

[Rick Liu]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4750/
--

New ticket #4750 by totoroliu
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect


--
SVN 1.10 binary file not showing up DIFF file list
==

# What version are you running?
ReviewBoard 2.5.17

# What's the URL of the page containing the problem?
/r/###/diff/1#index_header

# What steps will reproduce the problem?
1. Use SVN 1.10 to create a change containing binary file
2. rbt post
3. 


# What is the expected output? What do you see instead?
When using SVN 1.9,
the DIFF page would still show the binary file name in the file list,
and the DIFF section would show "This is a binary file. The content cannot be 
displayed.
But when using SVN 1.10,
the binary file name can't be found on DIFF page at all.


# What operating system are you using? What browser?
Ubuntu 16.04
Chromium 69.0.3497.81


# Please provide any additional information below.
the binary file "svn diff" output is differnet between SVN 1.9 and SVN 1.10:

SVN 1.9:

Index: /binary1
===
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: /binary1
===
--- /binary1(nonexistent)
+++ /binary1(working copy)

Property changes on: /binary1
___
Added: svn:mime-type
## -0,0 +1 ##
+application/octet-stream
\ No newline at end of property


SVN 1.10:
Index: /binary1
===
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream

Property changes on: /binary1
___
Added: svn:mime-type
## -0,0 +1 ##
+application/octet-stream
\ No newline at end of property





--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Review Board Ticket #4732: SVN delete an empty file with svn property causes DIFF display error

[Rick Liu]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4732/
--

New ticket #4732 by totoroliu
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect

File attachments:

 * Selection_018.png
   

 * Selection_019.png
   



--
SVN delete an empty file with svn property causes DIFF display error
==

# What version are you running?
Ubuntu 14.04
Reviewboard server 2.5.17

# What's the URL of the page containing the problem?
https:///r//diff/#index_header


# What steps will reproduce the problem?
1. svn commit an empty file with svn property (svn:executable on)
2. svn rm the empty file and rbt post the change
3. 


# What is the expected output? What do you see instead?
I expect to see "This empty file was deleted. The content cannot be displayed." 
with pink background.
(refer to screeshot: Selection_018.png)

But I see "There was error displaying this diff." with yellow background.
(refer to screeshot: Selection_019.png)

# What operating system are you using? What browser?
Server: Ubuntu 14.04
Client: Ubuntu 16.04 Chromium Version 68.0.3440.106 (Official Build) Built on 
Ubuntu , running on Ubuntu 16.04 (64-bit)


# Please provide any additional information below.


--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Does rbtool support add/remove empty file in SVN?

[Rick Liu]

Hi,

I got unexpected behavior when working with empty file,
and I created 2 bug tickets:

https://hellosplat.com/s/beanbag/tickets/4672/
https://hellosplat.com/s/beanbag/tickets/4673/

I'm not sure if rbtool support empty file or not.

Rick

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

RBTools Ticket #4673: rbt patch is unable to remove a folder containing an empty file

[Rick Liu]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4673/
--

New ticket #4673 by totoroliu
For Beanbag, Inc. > RBTools

Status: New
Tags: Priority:Medium, Type:Defect


--
 rbt patch is unable to remove a folder containing an empty file
==

# What version are you running?
RBTools 0.7.11
svn, version 1.9.7 (r1800392)
Ubuntu 16.04.4 LTS

# What steps will reproduce the problem?
```
$ cd into a svn repo

$ # Prepare environment
$ mkdir folder
$ touch folder/empty.file
$ svn add folder
$ svn status
A folder
A folder/empty.file
$ svn commit -m "add a folder with an empty file"

$ # Prepare Review Request
$ svn rm folder
D folder
D folder/empty.file
$ svn status
D folder
D folder/empty.file
$ rbt post

$ # Revert local changes and run rbt patch
$ svn revet -R .
$ svn status
$ rbt patch --debug 

$ svn status
D   folder/empty.file

$ ls -l folder
total 0

```


# What is the expected output? What do you see instead?
expect to see:
```
D folder
D folder/empty.file

$ svn status
D folder
D folder/empty.file
```


# What operating system are you using?
Ubuntu 16.04.4 LTS

# Attach the debug out from the command.

```
$ rbt patch --debug 25893
>>> RBTools 0.7.11
>>> Python 2.7.12 (default, Dec  4 2017, 14:50:18) 
[GCC 5.4.0 20160609]
>>> Running on Linux-4.4.0-112-generic-x86_64-with-Ubuntu-16.04-xenial
>>> Home = /home/rickliu
>>> Current directory = /home/rickliu/scrach/TestProject_trunk
>>> Command line: rbt patch --debug 25893
>>> Running: tf vc help
>>> Checking for a Subversion repository...
>>> Running: svn --non-interactive info
>>> Running: diff --version
>>> Running: svn --non-interactive --version -q
>>> repository info: Path: https://svn.com/svn/svntest, Base path: 
>>> /TestProject/trunk, Supports changesets: False
>>> Making HTTP GET request to https://reviewboard.com/api/
>>> Making HTTP GET request to 
>>> https://reviewboard.com/api/repositories/?tool=Subversion
>>> Cached response for HTTP GET 
>>> https://reviewboard.com/api/repositories/?tool=Subversion expired and was 
>>> modified
>>> Making HTTP GET request to https://reviewboard.com/api/repositories/1/info/
>>> Cached response for HTTP GET 
>>> https://reviewboard.com/api/repositories/1/info/ expired and was modified
>>> repository info: Path: https://svn.com/svn/svntest, Base path: 
>>> /TestProject/trunk, Supports changesets: False
>>> Making HTTP GET request to 
>>> https://reviewboard.com/api/review-requests/25893/diffs/
>>> Cached response for HTTP GET 
>>> https://reviewboard.com/api/review-requests/25893/diffs/ expired and was 
>>> modified
>>> Making HTTP GET request to 
>>> https://reviewboard.com/api/review-requests/25893/diffs/8/
>>> Added cache entry for HTTP GET request to 
>>> https://reviewboard.com/api/review-requests/25893/diffs/8/
>>> Making HTTP GET request to 
>>> https://reviewboard.com/api/review-requests/25893/diffs/8/
>>> Added cache entry for HTTP GET request to 
>>> https://reviewboardt.com/api/review-requests/25893/diffs/8/
Patch is being applied from request 25893 with diff revision 8.
>>> Running: svn --non-interactive patch --strip=3 /tmp/tmpMlmtpM
>>> Running: svn --non-interactive delete --force folder/empty.file
Successfully applied patch.

```


# Please provide any additional information below.
If the folder doesn't contain an empty file,
rbt patch would always be able to remove the folder if the folder becomes empty.

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

RBTools Ticket #4672: rbt patch is unable to add a folder containing an empty file

[Rick Liu]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4672/
--

New ticket #4672 by totoroliu
For Beanbag, Inc. > RBTools

Status: New
Tags: Priority:Medium, Type:Defect


--
rbt patch is unable to add a folder containing an empty file
==

# What version are you running?
RBTools 0.7.11
svn, version 1.9.7 (r1800392)
Ubuntu 16.04.4 LTS

# What steps will reproduce the problem?
```
$ cd into a svn repo
$ mkdir folder
$ touch folder/empty.file
$ svn add folder
$ svn status
A folder
A folder/empty.file

$ rbt post
...
...
...

$ # (revert all the change)
$ svn revert -R . && rm -rf folder
$ rbt patch --debug 
```




# What is the expected output? What do you see instead?
"svn status" should be:
```
$ svn status
A folder
A folder/empty.file
```

But it's:
```
$ svn status
?   folder
```

And rbt patch output shows error but exit code is still 0:
```
ERROR: Unable to execute "svn add" on: folder/empty.file
```



# What operating system are you using?
Ubuntu 16.04.4 LTS


# Attach the debug out from the command.

```
$ rbt patch --debug 25893
>>> RBTools 0.7.11
>>> Python 2.7.12 (default, Dec  4 2017, 14:50:18) 
[GCC 5.4.0 20160609]
>>> Running on Linux-4.4.0-112-generic-x86_64-with-Ubuntu-16.04-xenial
>>> Home = /home/rickliu
>>> Current directory = /home/rickliu/scrach/TestProject_trunk
>>> Command line: rbt patch --debug 25893
>>> Running: tf vc help
>>> Checking for a Subversion repository...
>>> Running: svn --non-interactive info
>>> Running: diff --version
>>> Running: svn --non-interactive --version -q
>>> repository info: Path: https://svn.com/svn/svntest, Base path: 
>>> /TestProject/trunk, Supports changesets: False
>>> Making HTTP GET request to https://reviewboard.com/api/
>>> Making HTTP GET request to 
>>> https://reviewboard.com/api/repositories/?tool=Subversion
>>> Cached response for HTTP GET 
>>> https://reviewboard.com/api/repositories/?tool=Subversion expired and was 
>>> modified
>>> Making HTTP GET request to https://reviewboard.com/api/repositories/1/info/
>>> Cached response for HTTP GET 
>>> https://reviewboard.com/api/repositories/1/info/ expired and was modified
>>> repository info: Path: https://svn.com/svn/svntest, Base path: 
>>> /TestProject/trunk, Supports changesets: False
>>> Making HTTP GET request to 
>>> https://reviewboard.com/api/review-requests/25893/diffs/
>>> Cached response for HTTP GET 
>>> https://reviewboard.com/api/review-requests/25893/diffs/ expired and was 
>>> modified
>>> Making HTTP GET request to 
>>> https://reviewboard.com/api/review-requests/25893/diffs/7/
>>> Added cache entry for HTTP GET request to 
>>> https://reviewboard.com/api/review-requests/25893/diffs/7/
>>> Making HTTP GET request to 
>>> https://reviewboard.com/api/review-requests/25893/diffs/7/
>>> Added cache entry for HTTP GET request to 
>>> https://reviewboard.com/api/review-requests/25893/diffs/7/
Patch is being applied from request 25893 with diff revision 7.
>>> Running: svn --non-interactive patch --strip=3 /tmp/tmpdb0zdr
>>> Running: svn --non-interactive add --force folder/empty.file
>>> Command exited with rc 1: ['svn', '--non-interactive', u'add', u'--force', 
>>> u'folder/empty.file']
svn: E15: Can't find parent directory's node while trying to add 
'/home/rickliu/scrach/TestProject_trunk/folder/empty.file'
svn: E155010: The node '/home/rickliu/scrach/TestProject_trunk/folder' was not 
found.
---
ERROR: Unable to execute "svn add" on: folder/empty.file

Skipped missing target: 'folder/empty.file'
Summary of conflicts:
  Skipped paths: 1

Successfully applied patch.


$ echo $?
0

$ svn status
?   folder

$ ls -l folder
total 0
-rw-rw-r-- 1 rickliu rickliu 0 Mar 16 13:01 empty.file

$ svn add folder
A folder
A folder/empty.file
```


# Please provide any additional information below.


--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: RBTools Ticket #4662: rbt diff error: CRITICAL: too many values to unpack

[Rick Liu]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4662/
--

New update by totoroliu
For Beanbag, Inc. > RBTools > Ticket #4662


Reply:

test2.txt (error):
```
$ cat test2.txt 
--  T1 (ESF)   65
```

test3.txt (ok):
```
$ cat test3.txt 
-- T1 (ESF) 65
```

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: RBTools Ticket #4662: rbt diff error: CRITICAL: too many values to unpack

[Rick Liu]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4662/
--

New update by totoroliu
For Beanbag, Inc. > RBTools > Ticket #4662


Reply:

Somehow if I removes some multiple spaces in between the words, then rbt 
diff becomes working.
So it looks like multiple spaces triggered the error

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

RBTools Ticket #4662: rbt diff error: CRITICAL: too many values to unpack

[Rick Liu]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4662/
--

New ticket #4662 by totoroliu
For Beanbag, Inc. > RBTools

Status: New
Tags: Priority:Medium, Type:Defect

File attachments:

 * test2.txt
   

 * svn.diff
   



--
rbt diff error: CRITICAL: too many values to unpack
==

# What version are you running?
rbt --version
RBTools 0.7.11

# What steps will reproduce the problem?
1. Prepare a test text file below and commit into SVN:
test2.txt:
--  T1 (ESF)   65

2. svn rm test2.txt

3. svn diff:
Index: test2.txt
===
--- test2.txt   (revision 201771)
+++ test2.txt   (nonexistent)
@@ -1 +0,0 @@
---  T1 (ESF)   65

4. rbt diff
CRITICAL: too many values to unpack




# What is the expected output? What do you see instead?
It should show similar diff as "svn diff"
but it throws out erorr.

$ rbt diff
CRITICAL: too many values to unpack

# What operating system are you using?
Ubuntu 16.04 LTS

# Attach the debug out from the command.

```
$ $ rbt diff --debug
>>> RBTools 0.7.11
>>> Python 2.7.12 (default, Dec  4 2017, 14:50:18) 
[GCC 5.4.0 20160609]
>>> Running on Linux-4.4.0-112-generic-x86_64-with-Ubuntu-16.04-xenial
>>> Home = /home/rickliu
>>> Current directory = /tmp/rick_rb_test_trunk/
>>> Command line: rbt diff --debug
>>> Running: tf vc help
>>> Checking for a Subversion repository...
>>> Running: svn --non-interactive info
>>> Running: diff --version
>>> Running: svn --non-interactive --version -q
>>> repository info: Path: https://xxx.com/svn/, Base path: 
>>> /rick_rb_test/trunk/, Supports changesets: False
>>> Making HTTP GET request to https://reviewboard-test.com/api/
>>> Running: svn --non-interactive info
>>> Running: diff --version
>>> Running: svn --non-interactive --version -q
>>> repository info: Path: https://xxx.com/svn/, Base path: 
>>> /rick_rb_test/trunk, Supports changesets: False
>>> Running: svn --non-interactive status -q --ignore-externals
>>> Running: svn --non-interactive diff --diff-cmd=diff --notice-ancestry -r 
>>> BASE
>>> Running: svn --non-interactive info test2.txt
>>> Running: svn --non-interactive diff --diff-cmd=diff --notice-ancestry -r 
>>> BASE --no-diff-deleted
>>> Running: svn --non-interactive info test2.txt
>>> Running: svn --non-interactive info test2.txt
>>> Running: svn --non-interactive info test2.txt
Traceback (most recent call last):
  File "/usr/local/bin/rbt", line 11, in 
sys.exit(main())
  File "/usr/local/lib/python2.7/dist-packages/rbtools/commands/main.py", line 
133, in main
command.run_from_argv([RB_MAIN, command_name] + args)
  File "/usr/local/lib/python2.7/dist-packages/rbtools/commands/__init__.py", 
line 665, in run_from_argv
exit_code = self.main(*args) or 0
  File "/usr/local/lib/python2.7/dist-packages/rbtools/commands/diff.py", line 
69, in main
extra_args=extra_args)
  File "/usr/local/lib/python2.7/dist-packages/rbtools/clients/svn.py", line 
405, in diff
diff = self.convert_to_absolute_paths(diff, repository_info)
  File "/usr/local/lib/python2.7/dist-packages/rbtools/clients/svn.py", line 
663, in convert_to_absolute_paths
file, rest = self.parse_filename_header(line)
ValueError: too many values to unpack

```

# Please provide any additional information below.
It's related to Ticket# 4546


--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: RBTools Ticket #4546: rbt diff is different from svn diff

[Rick Liu]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4546/
--

New update by totoroliu
For Beanbag, Inc. > RBTools > Ticket #4546


Reply:

Attach test2.txt and svn.diff


Files:
- test2.txt
  
- svn.diff
  

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: RBTools Ticket #4546: rbt diff is different from svn diff

[Rick Liu]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4546/
--

New update by totoroliu
For Beanbag, Inc. > RBTools > Ticket #4546


Reply:

Hi David,

I'm using "RBTools 0.7.11" now,
and I got "CRITICAL: too many values to unpack" error
if my text file test2.txt contains:
--  T1 (ESF)   65

svn diff
Index: test2.txt
===
--- test2.txt   (revision 201771)
+++ test2.txt   (nonexistent)
@@ -1 +0,0 @@
---  T1 (ESF)   65


rbt diff --debug
>>> RBTools 0.7.11
>>> Python 2.7.12 (default, Dec  4 2017, 14:50:18) 
[GCC 5.4.0 20160609]
>>> Running on Linux-4.4.0-112-generic-x86_64-with-Ubuntu-16.04-xenial
>>> Home = /home/rickliu
>>> Current directory = /tmp/rick_rb_test_trunk/
>>> Command line: rbt diff --debug
>>> Running: tf vc help
>>> Checking for a Subversion repository...
>>> Running: svn --non-interactive info
>>> Running: diff --version
>>> Running: svn --non-interactive --version -q
>>> repository info: Path: https://xxx.com/svn/xxx, Base path: 
/rick_rb_test_trunk/, Supports changesets: False
>>> Making HTTP GET request to https://reviewboard.xxx.com/api/
>>> Running: svn --non-interactive info
>>> Running: diff --version
>>> Running: svn --non-interactive --version -q
>>> repository info: Path: https://xxx.com/svn/xxx, Base path: 
/rick_rb_test_trunk/, Supports changesets: False
>>> Running: svn --non-interactive status -q --ignore-externals
>>> Running: svn --non-interactive diff --diff-cmd=diff --notice-ancestry 
-r BASE
>>> Running: svn --non-interactive info test2.txt
>>> Running: svn --non-interactive diff --diff-cmd=diff --notice-ancestry 
-r BASE --no-diff-deleted
>>> Running: svn --non-interactive info test2.txt
>>> Running: svn --non-interactive info test2.txt
>>> Running: svn --non-interactive info test2.txt
Traceback (most recent call last):
  File "/usr/local/bin/rbt", line 11, in 
sys.exit(main())
  File "/usr/local/lib/python2.7/dist-packages/rbtools/commands/main.py", 
line 133, in main
command.run_from_argv([RB_MAIN, command_name] + args)
  File 
"/usr/local/lib/python2.7/dist-packages/rbtools/commands/__init__.py", line 
665, in run_from_argv
exit_code = self.main(*args) or 0
  File "/usr/local/lib/python2.7/dist-packages/rbtools/commands/diff.py", 
line 69, in main
extra_args=extra_args)
  File "/usr/local/lib/python2.7/dist-packages/rbtools/clients/svn.py", 
line 405, in diff
diff = self.convert_to_absolute_paths(diff, repository_info)
  File "/usr/local/lib/python2.7/dist-packages/rbtools/clients/svn.py", 
line 663, in convert_to_absolute_paths
file, rest = self.parse_filename_header(line)
ValueError: too many values to unpack

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Ticket 4586: rbt diff: CRITICAL: too many values to unpack

[Rick Liu]

https://hellosplat.com/s/beanbag/tickets/4586/

This bug is similar to a fixed bug (Ticket 4556: 
https://hellosplat.com/s/beanbag/tickets/4556/),
where RBTools has issue dealing DIFF file contains '---' in change lines.

Rick

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Ticket 4587: rbt patch failed to work for svn merge change

[Rick Liu]

https://hellosplat.com/s/beanbag/tickets/4587/

Hi,

I found a critical bug that rbt has problem to support SVN merge change-set
when merge source and merge destination have different level of SVN URL.


Rick

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

RBTools Ticket #4586: rbt diff: CRITICAL: too many values to unpack

[Rick Liu]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4586/
--

New ticket #4586 by totoroliu
For Beanbag, Inc. > RBTools

Status: New
Tags: Priority:Medium, Type:Defect


--
rbt diff: CRITICAL: too many values to unpack
==

# What version are you running?
RBTools 0.7.10
svn, version 1.9.3 (r1718519)

# What steps will reproduce the problem?
1. SVN commit a text file "test5" with this content:
```
--  --
--  Copyright (C) 2002-2004 Dmitriy Anisimkov   --
--  --
--  This library is free software; you can redistribute it and/or modify--
```

2. Remove LINE2:
```
--  Copyright (C) 2002-2004 Dmitriy Anisimkov   --
```

3. rbt diff



# What is the expected output? What do you see instead?
I expect to see something similar to "svn diff" output:
```
Index: test5
===
--- test5   (revision 19370)
+++ test5   (working copy)
@@ -1,5 +1,4 @@
 --  --
---  Copyright (C) 2002-2004 Dmitriy Anisimkov   --
 --  --
 --  This library is free software; you can redistribute it and/or modify-- 
```

But "rbt diff" shows:
CRITICAL: too many values to unpack


# What operating system are you using?
Ubuntu 16.04.3 LTS


# Attach the debug out from the command.

```
$ $ rbt diff --debug
>>> RBTools 0.7.10
>>> Python 2.7.12 (default, Nov 19 2016, 06:48:10) 
[GCC 5.4.0 20160609]
>>> Running on Linux-4.4.0-93-generic-x86_64-with-Ubuntu-16.04-xenial
>>> Home = /home/rickliu
>>> Current directory = /home/rickliu/scrach/TestProject_trunk/Test
>>> Command line: rbt diff --debug
>>> Running: tf vc help
>>> Checking for a Subversion repository...
>>> Running: svn --non-interactive info
>>> Running: diff --version
>>> Running: svn --non-interactive --version -q
>>> repository info: Path: http://xxx.com/svn/svntest, Base path: 
>>> /TestProject/trunk/Test, Supports changesets: False
>>> Making HTTP GET request to http://172.16.182.156/api/
>>> Running: svn --non-interactive info
>>> Running: diff --version
>>> Running: svn --non-interactive --version -q
>>> repository info: Path: http://xxx.com/svn/svntest, Base path: 
>>> /TestProject/trunk/Test, Supports changesets: False
>>> Running: svn --non-interactive status -q --ignore-externals
>>> Running: svn --non-interactive diff --diff-cmd=diff --notice-ancestry -r 
>>> BASE
>>> Running: svn --non-interactive info test5
>>> Running: svn --non-interactive diff --diff-cmd=diff --notice-ancestry -r 
>>> BASE --no-diff-deleted
>>> Running: svn --non-interactive info test5
>>> Running: svn --non-interactive info test5
>>> Running: svn --non-interactive info test5
Traceback (most recent call last):
  File "/usr/local/bin/rbt", line 11, in 
sys.exit(main())
  File "/usr/local/lib/python2.7/dist-packages/rbtools/commands/main.py", line 
133, in main
command.run_from_argv([RB_MAIN, command_name] + args)
  File "/usr/local/lib/python2.7/dist-packages/rbtools/commands/__init__.py", 
line 678, in run_from_argv
exit_code = self.main(*args) or 0
  File "/usr/local/lib/python2.7/dist-packages/rbtools/commands/diff.py", line 
70, in main
extra_args=extra_args)
  File "/usr/local/lib/python2.7/dist-packages/rbtools/clients/svn.py", line 
366, in diff
diff = self.convert_to_absolute_paths(diff, repository_info)
  File "/usr/local/lib/python2.7/dist-packages/rbtools/clients/svn.py", line 
624, in convert_to_absolute_paths
file, rest = self.parse_filename_header(line)
ValueError: too many values to unpack

```


# Please provide any additional information below.


--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Ticket 4555: rbt diff failed to capture line ending changes on Windows system

[Rick Liu]

Hi,

On linux system,
"rbt diff" is able to capture line ending changes
and produce the same result as "svn diff".

However,
it looks like on Windows system,
"rbt diff" is unable to capture the line ending changes.

https://hellosplat.com/s/beanbag/tickets/4555/

Rick

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Ticket 4556: rbt diff produces incorrect patch.diff format which caused rbt patch (svn patch) incorrectly delete files

[Rick Liu]

+link
https://hellosplat.com/s/beanbag/tickets/4556/

On Thursday, June 8, 2017 at 7:52:55 PM UTC-7, Rick Liu wrote:
>
> Hi,
>
> I found there's a serious bug for "rbt diff" and "rbt patch" for svn merge 
> changes.
> If the svn merge change involves "replace file with history scheduled with 
> a commit" (aks svn status: R  +),
> the rbt patch (and svn patch) would incorrectly delete the file instead of 
> replace the file.
>
> Rick
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Ticket 4556: rbt diff produces incorrect patch.diff format which caused rbt patch (svn patch) incorrectly delete files

[Rick Liu]

Hi,

I found there's a serious bug for "rbt diff" and "rbt patch" for svn merge 
changes.
If the svn merge change involves "replace file with history scheduled with 
a commit" (aks svn status: R  +),
the rbt patch (and svn patch) would incorrectly delete the file instead of 
replace the file.

Rick

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: RBTools Ticket #4556: rbt diff produces incorrect patch.diff format which caused rbt patch (svn patch) incorrectly delete files

[Rick Liu]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4556/
--

New update by totoroliu
For Beanbag, Inc. > RBTools > Ticket #4556


Reply:

```
$ rbt patch --debug 104521
>>> RBTools 0.7.10
>>> Python 2.7.12 (default, Nov 19 2016, 06:48:10) 
[GCC 5.4.0 20160609]
>>> Running on Linux-4.4.0-78-generic-x86_64-with-Ubuntu-16.04-xenial
>>> Home = /home/rickliu
>>> Current directory = /tmp/server
>>> Command line: rbt patch --debug 104521
>>> Running: tf vc help
>>> Checking for a Subversion repository...
>>> Running: svn --non-interactive info
>>> Running: diff --version
>>> Running: svn --non-interactive --version -q
>>> repository info: Path: http://x/svn/, Base path: /server, Supports 
changesets: False
>>> Making HTTP GET request to http://reviewboard.xx.com/api/
>>> Making HTTP GET request to 
http://reviewboard.xx.com/api/repositories/?tool=Subversion
>>> Cached response for HTTP GET 
http://reviewboard.xx.com/api/repositories/?tool=Subversion expired and was 
modified
>>> Making HTTP GET request to 
http://reviewboard.xx.com/api/review-requests/104521/diffs/
>>> Added cache entry for HTTP GET request to 
http://reviewboard.xx.com/api/review-requests/104521/diffs/
>>> Making HTTP GET request to 
http://reviewboard.xx.com/api/review-requests/104521/diffs/1/
>>> Added cache entry for HTTP GET request to 
http://reviewboard.xx.com/api/review-requests/104521/diffs/1/
>>> Making HTTP GET request to 
http://reviewboard.xx.com/api/review-requests/104521/diffs/1/
>>> Added cache entry for HTTP GET request to 
http://reviewboard.xx.com/api/review-requests/104521/diffs/1/
Patch is being applied from request 104521 with diff revision 1.
>>> Running: svn --non-interactive patch --strip=5 /tmp/tmptMkAQ5

Uapache2/include/cache_common.h
> hunk @@ -0,0 +1,56 @@ already applied
D apache2/include/cache_common.h

Successfully applied patch.
rickliu@rickliu-linux:/tmp/server$ svn st
D   apache2/include/cache_common.h

```

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

RBTools Ticket #4556: rbt diff produces incorrect patch.diff format which caused rbt patch (svn patch) incorrectly delete files

[Rick Liu]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4556/
--

New ticket #4556 by totoroliu
For Beanbag, Inc. > RBTools

Status: New
Tags: Priority:Medium, Type:Defect


--
rbt diff produces incorrect patch.diff format which caused rbt patch (svn 
patch) incorrectly delete files
==

# What version are you running?
RBTools 0.7.10
svn, version 1.9.3 (r1718519)
diff (GNU diffutils) 3.3
Ubuntu 16.04.2 LTS

# What steps will reproduce the problem?
1. Run "svn merge" to have "svn status" with "R  +   FileA" (aka replace with 
History scheduled with commit.)
2. rbt diff --svn-show-copies-as-adds=y --include FileA
3. svn diff FileA
4. rbt patch or svn patch would result FileA been deleted


# What is the expected output? What do you see instead?
"rbt diff" should be in similar format as "svn diff".
"svn diff" has single diff header (Index:) for FileA.
"rbt diff" has TWO diff headers (Index:) for FileA.
With the TWO diff headers,
the first header is deleting the file at current branch;
the second header is adding the file back from the merge source.
However,
rbt patch (svn patch) is failed to add the file back,
and results the file been deleted.



# What operating system are you using?
Ubuntu 16.04.2 LTS


# Attach the debug out from the command.

```
$ svn st apache2/include/cache_common.h
R  +apache2/include/cache_common.h



$ svn diff apache2/include/cache_common.h
Index: apache2/include/cache_common.h
===
--- apache2/include/cache_common.h  (revision 99047)
+++ apache2/include/cache_common.h  (working copy)

Property changes on: apache2/include/cache_common.h
___
Deleted: svn:eol-style
## -1 +0,0 ##
-native
\ No newline at end of property
Added: svn:executable
## -0,0 +1 ##
+*
\ No newline at end of property



$ rbt diff --svn-show-copies-as-adds=y --include apache2/include/cache_common.h 
--debug
>>> RBTools 0.7.10
>>> Python 2.7.12 (default, Nov 19 2016, 06:48:10) 
[GCC 5.4.0 20160609]
>>> Running on Linux-4.4.0-78-generic-x86_64-with-Ubuntu-16.04-xenial
>>> Home = /home/rickliu
>>> Current directory = /tmp/server
>>> Command line: rbt diff --svn-show-copies-as-adds=y --include 
>>> apache2/include/cache_common.h --debug
>>> Running: tf vc help
>>> Checking for a Subversion repository...
>>> Running: svn --non-interactive info
>>> Running: diff --version
>>> Running: svn --non-interactive --version -q
>>> repository info: Path: http:///svn/, Base path: /server, Supports 
>>> changesets: False
>>> Making HTTP GET request to http://reviewboard..com/api/
>>> Running: svn --non-interactive info
>>> Running: diff --version
>>> Running: svn --non-interactive --version -q
>>> repository info: Path: http:///svn/, Base path: /server, Supports 
>>> changesets: False
>>> Running: svn --non-interactive diff --diff-cmd=diff --notice-ancestry -r 
>>> BASE apache2/include/cache_common.h --show-copies-as-adds
>>> Running: svn --non-interactive info apache2/include/cache_common.h
>>> Running: svn --non-interactive diff --diff-cmd=diff --notice-ancestry -r 
>>> BASE apache2/include/cache_common.h --show-copies-as-adds --no-diff-deleted
>>> Running: svn --non-interactive info apache2/include/cache_common.h
>>> Running: svn --non-interactive info apache2/include/cache_common.h
>>> Running: svn --non-interactive info apache2/include/cache_common.h
>>> Running: svn --non-interactive info apache2/include/cache_common.h
>>> Running: svn --non-interactive info apache2/include/cache_common.h
Index: /server/apache2/include/cache_common.h
===
--- /server/apache2/include/cache_common.h  (revision 99047)
+++ /server/apache2/include/cache_common.h  (nonexistent)
@@ -1,56 +0,0 @@
-/* Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements.  See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License.  You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-/**
- * @file cache_common.h
- 

RBTools Ticket #4555: rbt diff is different from svn diff on Windows platform when there's line ending difference

[Rick Liu]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4555/
--

New ticket #4555 by totoroliu
For Beanbag, Inc. > RBTools

Status: New
Tags: Priority:Medium, Type:Defect

File attachments:

 * _progress_CRLF.scss
   

 * _progress_LF.scss
   



--
rbt diff is different from svn diff on Windows platform when there's line 
ending difference
==

# What version are you running?
RBTools 0.7.10
svn, version 1.9.5 (r1770682)
diff (GNU diffutils) 2.8.7
Windows 10 Pro 64-bit


# What steps will reproduce the problem?
1. Under SVN, prepare a text fileA with Linux line-ending (LF) and commit.
2. Change fileA Linux line-ending (LF) to Windows line-ending (CRLF)
3. svn diff would show each line is different
4. rbt diff would show diff header only without content difference


# What is the expected output? What do you see instead?
rbt diff should produce the same diff output as svn diff


# What operating system are you using?
Windows 10 Pro 64-bit


# Attach the debug out from the command.

```
components> svn diff
Index: _progress.scss
===
--- _progress.scss  (revision 52283)
+++ _progress.scss  (working copy)
@@ -1,17 +1,17 @@
-@charset "UTF-8";
-
-.progress.progress-labelled {
-position: relative;
-width: 100%;
-height: 20px;
-margin-bottom: 0;
-text-align: center;
-
-.progress-bar {
-position: absolute;
-top: 0;
-left: 0;
-overflow: hidden;
-color: $forti-text-default-invert;
-}
-}
+@charset "UTF-8";
+
+.progress.progress-labelled {
+position: relative;
+width: 100%;
+height: 20px;
+margin-bottom: 0;
+text-align: center;
+
+.progress-bar {
+position: absolute;
+top: 0;
+left: 0;
+overflow: hidden;
+color: $forti-text-default-invert;
+}
+}


components>rbt diff
Index: /components/_progress.scss  (added)
===
--- /components/_progress.scss (revision 0)
+++ /components/_progress.scss (revision 0)


components>rbt diff --debug
>>> RBTools 0.7.10
>>> Python 2.7.13 (v2.7.13:a06454b1afa1, Dec 17 2016, 20:42:59) [MSC v.1500 32 
>>> bit (Intel)]
>>> Running on Windows-10-10.0.14393
>>> Home = C:\Users\ricklilu\AppData\Roaming
>>> Current directory = C:\components
>>> Command line: rbt diff --debug
>>> Running: tf vc help
>>> Checking for a Subversion repository...
>>> Running: svn --non-interactive info
>>> Running: diff --version
>>> Running: svn --non-interactive --version -q
>>> repository info: Path: http://scm-yvr.fortinet.com/svn/svnfct, Base path: 
>>> /components, Supports changesets: False
>>> Making HTTP GET request to http://reviewboard.corp.fortinet.com/api/
>>> Running: svn --non-interactive info
>>> Running: diff --version
>>> Running: svn --non-interactive --version -q
>>> repository info: Path: http://scm-yvr.fortinet.com/svn/svnfct, Base path: 
>>> /components, Supports changesets: False
>>> Running: svn --non-interactive status -q --ignore-externals
>>> Running: svn --non-interactive diff --diff-cmd=diff --notice-ancestry -r 
>>> BASE
>>> Running: svn --non-interactive diff --diff-cmd=diff --notice-ancestry -r 
>>> BASE --no-diff-deleted
>>> Running: svn --non-interactive info _progress.scss
>>> Running: svn --non-interactive info _progress.scss
>>> Running: svn --non-interactive info _progress.scss
Index: /components/_progress.scss  (added)
===
--- /components/_progress.scss (revision 0)
+++ /components/_progress.scss (revision 0)

```


# Please provide any additional information below.


--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Feature Request for rbt diff to support "--no-renames" argument for GIT repos

[Rick Liu]

Hi,

Could we add a new argument "--no-renames" to "rbt diff" for GIT repos?
"rbt diff" is running "git diff" at the backend.
"git diff" supports "--no-renames" option to generate DIFF file to avoid 
incorrect rename action.

But "rbt diff" doesn't take this argument right now.

Attach the ticket number here for reference:
https://hellosplat.com/s/beanbag/tickets/4551/


Thanks,
Rick

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

RBTools Ticket #4551: Allow rbt diff to take --no-renames argument for GIT repos

[Rick Liu]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4551/
--

New ticket #4551 by totoroliu
For Beanbag, Inc. > RBTools

Status: New
Tags: Priority:Medium, Type:Enhancement


--
Allow rbt diff to take --no-renames argument for GIT repos
==

# What version are you running?
RBTools 0.7.9

# Describe the enhancement and the motivation for it.
rbt diff is running git diff in the backend to get the DIFF.
GIT diff supports "--no-renames" arguments,
but there's no way to pass "--no-renames" to rbt diff to use.


# Please provide any additional information below.


--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: blocker: rbt diff missing change lines

[Rick Liu]

Thanks  Christian!

Rick


2017/5/1 下午8:25，"Christian Hammond" <christ...@beanbaginc.com>寫道：

Hi Rick,

Thanks for reporting this, and for the detailed bug report.

The problem is that the "---" line looks like a file marker, and it's
getting lost during diff normalization (where we work around a bunch of
issues in svn diffs). We'll need to keep some additional state to deal with
this.

Let me follow up on the bug report with some extra details.

Christian

-- 
Christian Hammond
President/CEO of Beanbag <https://www.beanbaginc.com/>
Makers of Review Board <https://www.reviewboard.org/>

On Mon, May 1, 2017 at 5:45 PM, Rick Liu <totoroliu...@gmail.com> wrote:

> Hi,
>
> I just reported a bug under ReviewBoard bug system:
> https://hellosplat.com/s/beanbag/tickets/4546/
>
> But I'd like to know if there's a quick work-around for the issue.
>
> I have a test file example like below under SVN:
>
>
> ```
>
> -- test line1
> -- this line (test1)
> -- test lin2
> -- test line (test2)
> ```
>
> And then I remove the LINE#2:
> ```
> -- this line (test1)
> ```
>
> svn diff would show:
> ```
>
> $ svn diff
> Index: test
> ===
> --- test(revision 16006)
> +++ test(working copy)
> @@ -1,4 +1,3 @@
>  -- test line1
> --- this line (test1)
>  -- test lin2
>  -- test line (test2)
>
> ```
>
> But rbt diff is missing the line of change:
> ```
>
> $ rbt diff
> Index: /TestProject/trunk/Test/folder/test
> ===
> --- /TestProject/trunk/Test/folder/test (revision 16006)
> +++ /TestProject/trunk/Test/folder/test (working copy)
> @@ -1,4 +1,3 @@
>  -- test line1
>  -- test lin2
>  -- test line (test2)
>
> ```
>
>
> I suspect it's rbtools parser is mistakenly treat '---' as part of DIFF
> source line.
> I'm currently using rbtools-0.7.9,
> and wondering if there can be a quick patch/fix for this?
>
>
> Thanks,
> Rick
>
>
>
>
>
>
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
>
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/
powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to a topic in the
Google Groups "reviewboard" group.
To unsubscribe from this topic, visit https://groups.google.com/d/
topic/reviewboard/POjfbwnXg-4/unsubscribe.
To unsubscribe from this group and all its topics, send an email to
reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

blocker: rbt diff missing change lines

[Rick Liu]

Hi,

I just reported a bug under ReviewBoard bug system:
https://hellosplat.com/s/beanbag/tickets/4546/

But I'd like to know if there's a quick work-around for the issue.

I have a test file example like below under SVN:


```

-- test line1
-- this line (test1)
-- test lin2
-- test line (test2)
```

And then I remove the LINE#2:
```
-- this line (test1)
```

svn diff would show:
```

$ svn diff
Index: test
===
--- test(revision 16006)
+++ test(working copy)
@@ -1,4 +1,3 @@
 -- test line1
--- this line (test1)
 -- test lin2
 -- test line (test2)

```

But rbt diff is missing the line of change:
```

$ rbt diff
Index: /TestProject/trunk/Test/folder/test
===
--- /TestProject/trunk/Test/folder/test (revision 16006)
+++ /TestProject/trunk/Test/folder/test (working copy)
@@ -1,4 +1,3 @@
 -- test line1
 -- test lin2
 -- test line (test2)

```


I suspect it's rbtools parser is mistakenly treat '---' as part of DIFF 
source line.
I'm currently using rbtools-0.7.9,
and wondering if there can be a quick patch/fix for this?


Thanks,
Rick







-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: RBTools Ticket #4546: rbt diff is different from svn diff

[Rick Liu]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4546/
--

New update by totoroliu
For Beanbag, Inc. > RBTools > Ticket #4546


Reply:

Upload the test files


Files:
- test
  
- svn.diff
  
- rbt.diff
  

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4438: sending emails fails with excessively large number of files

[Rick Liu]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4438/
--

New update by torcolvin
For Beanbag, Inc. > Review Board > Ticket #4438


Reply:

I created a pull-request to disable "X-ReviewBoard-Diff-For" line to fix 
this issue:
https://github.com/reviewboard/reviewboard/pull/42

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Does reviewboard 2.5.4 support binary file?

[Rick Liu]

Environment:
OS: Ubuntu 14.04 x64
Reviewboard: 2.5.4
Python 2.7.6
RBTools 0.7.5


We use "rbt post" to post a review contains binary file.
The web front-end correctly identified the file as binary file in diff view.
But:
1.
I can't find any link to download the new binary file to be submitted.
2.
When I "ship-it" to submit the review,
it failed to be merged into SVN.

I googled the binary support for reviewboard.
Some said yes and some said no,
so I'm confused here.

Thanks,

Rick

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.