Re: post-review: Ignore whitespace?
Thanks for the quick response Christian. Is this option under the My Account page? I don't currently see an option for this. I'm on version 1.6.3. Can you comment if this is one of the versions the option you speak of is not working in? Does the server configuration have to enable this option as well? Thanks again. On Fri, Jul 12, 2013 at 5:27 PM, Christian Hammond chip...@chipx86.com wrote: Hi Robert, We purposefully do not provide this feature for diff uploads. From the Review Board diff viewer, you can hide lines that are whitespace-only changes (okay, this is broken in the past couple releases, but the next one will fix it). We prefer to do customization of display like that on the Review Board side, and in fact, it's very important that Review Board does not have a mangled view of how the diff looks, since we apply the patch and do some processing and caching on the result. Christian Robert Dailey wrote: Is there a way to tell post-review to ignore whitespace in diffs that it uploads? I use this tool through P4V (perforce visual client). Sometimes a file is full of tabs to spaces conversions and it mixes in with real, useful code changes. I'd like to see a way to upload a diff without whitespace OR a user-option in ReviewBoard to hide diffs on lines with only whitespace changes. Anyone? Thanks. -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Python 3.3.2 x86_64 support?
I'm attempting to install RBTools via easy_install -U but getting failure. I'm using Python 3.3.2 x64 on Windows 7: C:\Workeasy_install -U RBTools Searching for RBTools Reading https://pypi.python.org/simple/RBTools/ Reading http://www.reviewboard.org/ Reading http://downloads.reviewboard.org/releases/RBTools/0.3/ Reading http://downloads.reviewboard.org/releases/RBTools/0.4/ Reading http://downloads.reviewboard.org/releases/RBTools/0.5/ Reading http://downloads.reviewboard.org/releases/RBTools/0.2/ Reading http://www.review-board.org/ Reading http://downloads.review-board.org/releases/ Reading http://downloads.review-board.org/releases/RBTools/0.2/ Best match: RBTools 0.5.1 Downloading http://downloads.reviewboard.org/releases/RBTools/0.5/RBTools-0.5.1.tar.gz Processing RBTools-0.5.1.tar.gz Writing c:\users\rdailey\appdata\local\temp\easy_install-yk_t17\RBTools-0.5.1\setup.cfg Running RBTools-0.5.1\setup.py -q bdist_egg --dist-dir c:\users\rdailey\appdata\local\temp\easy_install-yk_t17\RBTools-0 .5.1\egg-dist-tmp-m_3a1p File build\bdist.win-amd64\egg\rbtools\api\request.py, line 267 os.chmod(cookie_file, 0600) ^ SyntaxError: invalid token File build\bdist.win-amd64\egg\rbtools\clients\clearcase.py, line 438 except APIError, e: ^ SyntaxError: invalid syntax File build\bdist.win-amd64\egg\rbtools\clients\cvs.py, line 44 except socket.error, msg: ^ SyntaxError: invalid syntax File build\bdist.win-amd64\egg\rbtools\clients\perforce.py, line 120 print record['data'] ^ SyntaxError: invalid syntax File build\bdist.win-amd64\egg\rbtools\clients\svn.py, line 392 except APIError, e: ^ SyntaxError: invalid syntax File build\bdist.win-amd64\egg\rbtools\clients\tests.py, line 542 raise SkipTest(msg), None, sys.exc_info()[2] ^ SyntaxError: invalid syntax File build\bdist.win-amd64\egg\rbtools\clients\__init__.py, line 108 print 'Command:\n' + str(cmd) ^ SyntaxError: invalid syntax File build\bdist.win-amd64\egg\rbtools\commands\attach.py, line 56 except APIError, e: ^ SyntaxError: invalid syntax File build\bdist.win-amd64\egg\rbtools\commands\close.py, line 62 except APIError, e: ^ SyntaxError: invalid syntax File build\bdist.win-amd64\egg\rbtools\commands\diff.py, line 93 print diff ^ SyntaxError: invalid syntax File build\bdist.win-amd64\egg\rbtools\commands\main.py, line 39 print help_text ^ SyntaxError: invalid syntax File build\bdist.win-amd64\egg\rbtools\commands\patch.py, line 62 except APIError, e: ^ SyntaxError: invalid syntax File build\bdist.win-amd64\egg\rbtools\commands\post.py, line 303 except APIError, e: ^ SyntaxError: invalid syntax File build\bdist.win-amd64\egg\rbtools\commands\publish.py, line 46 except APIError, e: ^ SyntaxError: invalid syntax File build\bdist.win-amd64\egg\rbtools\commands\status.py, line 78 printr/%s - %s % (request.id, request.summary) ^ SyntaxError: invalid syntax File build\bdist.win-amd64\egg\rbtools\commands\__init__.py, line 159 except CommandError, e: ^ SyntaxError: invalid syntax File build\bdist.win-amd64\egg\rbtools\postreview.py, line 164 print == HTTP Authentication Required ^ SyntaxError: invalid syntax File build\bdist.win-amd64\egg\rbtools\tests.py, line 141 except APIError, e: ^ SyntaxError: invalid syntax File build\bdist.win-amd64\egg\rbtools\utils\filesystem.py, line 41 except SyntaxError, e: ^ SyntaxError: invalid syntax File build\bdist.win-amd64\egg\rbtools\utils\process.py, line 17 print msg ^ SyntaxError: invalid syntax zip_safe flag not set; analyzing archive contents... Adding rbtools 0.5.1 to easy-install.pth file Installing rbt-script.py script to C:\Python33\Scripts Installing rbt.exe script to C:\Python33\Scripts Installing post-review-script.py script to C:\Python33\Scripts Installing post-review.exe script to C:\Python33\Scripts Installed c:\python33\lib\site-packages\rbtools-0.5.1-py3.3.egg Processing dependencies for RBTools Finished processing dependencies for RBTools C:\Work -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and
Re: Problem with RBTools 0.5
Thanks Steven, I'll let the IT department know.
On Tue, Apr 16, 2013 at 2:56 PM, Steven MacLeod ste...@smacleod.ca wrote:
Hi Robert,
Sorry this has taken so long to figure out, the answer was in one of your
previous emails. The version of Review Board you are running is not
supported by the new RBTools stuff (the 'rbt' command, and the new API
client).
There were a couple of changes to the Review Board Web API that the new
stuff relies on, and the earliest supported version of Review Board is
1.6.12.
You should be able to continue using post-review for now, as it hasn't
changed, but going forward as it's deprecated and replaced by rbt you'll
need to upgrade your version of Review Board. 1.6.3 is actually pretty old,
and should probably be upgraded for many other reasons as well.
- Steve
On Mon, Apr 15, 2013 at 11:11 AM, Robert Dailey rcdailey.li...@gmail.com
wrote:
Sorry for the long delay in response, been busy at work! Here is the
result of the command you requested:
$ curl http://reviewboard.corp.good.com/api/review-requests/44580/diffs/
-i
HTTP/1.1 200 OK
Date: Mon, 15 Apr 2013 15:10:06 GMT
Server: Apache/2.2.21 (Unix) mod_wsgi/3.3 Python/2.7 mod_ssl/2.2.17
OpenSSL/1.0.0c
Content-Length: 269
Content-Language: en-us
Expires: Mon, 15 Apr 2013 15:10:06 GMT
Vary: Accept,Cookie,Accept-Language,Accept-Encoding
Last-Modified: Mon, 15 Apr 2013 15:10:06 GMT
Cache-Control: max-age=0
Content-Type: application/json
{total_results: 0, diffs: [], stat: ok, links: {self:
{href:
http://reviewboard.corp.good.com/api/review-requests/44580/diffs/;,
method: GET}, create: {href:
http://reviewboard.corp.good.com/api/review-requests/44580/diffs/;,
method: POST}}}
On Mon, Apr 8, 2013 at 5:12 PM, Steven MacLeod ste...@smacleod.ca wrote:
It appears your Apache server won't allow a HEAD request.
Can I see the output of:
$ curl
http://reviewboard.corp.good.com/api/review-requests/44580/diffs/
-i
On Mon, Apr 8, 2013 at 4:27 PM, Robert Dailey rcdailey.li...@gmail.com
wrote:
Here you go:
C:\workcurl
http://reviewboard.corp.good.com/api/review-requests/44580/diffs/
-I
HTTP/1.1 405 METHOD NOT ALLOWED
Date: Mon, 08 Apr 2013 20:24:40 GMT
Server: Apache/2.2.21 (Unix) mod_wsgi/3.3 Python/2.7 mod_ssl/2.2.17
OpenSSL/1.0.0c
Content-Language: en-us
Expires: Mon, 08 Apr 2013 20:24:40 GMT
Vary: Accept,Cookie,Accept-Language
Last-Modified: Mon, 08 Apr 2013 20:24:40 GMT
Allow: GET, POST
Cache-Control: max-age=0
Content-Type: text/html; charset=utf-8
On Fri, Apr 5, 2013 at 12:28 AM, Steven MacLeod ste...@smacleod.ca
wrote:
Hi Robert,
Sorry for the delay in response, this slipped by in my inbox.
Could you please send me the output of:
$ curl
http://reviewboard.corp.good.com/api/review-requests/44580/diffs/
-I
Basically I need to take a look at the headers being returned in the
HTTP
request to RB.
On Fri, Mar 29, 2013 at 1:40 PM, Robert Dailey
rcdailey.li...@gmail.com
wrote:
Using RB version 1.6.3. Output of the command you requested is
below:
DEBUG:root:Checking for a Bazaar repository...
DEBUG:root:Checking for a CVS repository...
DEBUG:root:Checking for a ClearCase repository...
DEBUG:root:Checking for a Git repository...
DEBUG:root:Running: git rev-parse --git-dir
DEBUG:root:Command exited with rc 128: ['git', 'rev-parse',
'--git-dir']
fatal: Not a git repository (or any of the parent directories): .git
---
DEBUG:root:Checking for a Mercurial repository...
DEBUG:root:Checking for a Perforce repository...
DEBUG:root:Running: p4 info
DEBUG:root:Running: diff --version
DEBUG:root:repository info: Path: perforce-rws2.corp.good.com:3666,
Base path: None, Supports changesets: True
DEBUG:root:Making HTTP GET request to
http://reviewboard.corp.good.com/api/
DEBUG:root:Making HTTP GET request to
http://reviewboard.corp.good.com/api/info/
INFO:root:Generating diff for changenum 303396
DEBUG:root:Running: p4 describe -s 303396
DEBUG:root:Processing delete of
//depot/dev/DominoProcessDecomp/DominoProcessDecomp.sln
DEBUG:root:Writing
//depot/dev/DominoProcessDecomp/DominoProcessDecomp.sln#4 to
c:\users\rdailey\appdata\local\temp\tmpivyvra
DEBUG:root:Running: p4 print -o
c:\users\rdailey\appdata\local\temp\tmpivyvra -q
//depot/dev/DominoProcessDecomp/DominoProcessDecomp.sln#4
DEBUG:root:Running: diff -urNp
c:\users\rdailey\appdata\local\temp\tmpivyvra
c:\users\rdailey\appdata\local\temp\tmpljgwo3
DEBUG:root:Command exited with rc 1: ['diff', '-urNp',
'c:\\users\\rdailey\\appdata\\local\\temp\\tmpivyvra',
'c:\\users\\rdailey\\appdata\\local\\temp\\tmpljgwo3']
--- c:\users\rdailey\appdata\local\temp\tmpivyvra 2013-03-29
12:39:00.971865100 -0500
+++ c:\users\rdailey\appdata
Re: Problem with RBTools 0.5
Sorry for the long delay in response, been busy at work! Here is the
result of the command you requested:
$ curl http://reviewboard.corp.good.com/api/review-requests/44580/diffs/ -i
HTTP/1.1 200 OK
Date: Mon, 15 Apr 2013 15:10:06 GMT
Server: Apache/2.2.21 (Unix) mod_wsgi/3.3 Python/2.7 mod_ssl/2.2.17
OpenSSL/1.0.0c
Content-Length: 269
Content-Language: en-us
Expires: Mon, 15 Apr 2013 15:10:06 GMT
Vary: Accept,Cookie,Accept-Language,Accept-Encoding
Last-Modified: Mon, 15 Apr 2013 15:10:06 GMT
Cache-Control: max-age=0
Content-Type: application/json
{total_results: 0, diffs: [], stat: ok, links: {self:
{href: http://reviewboard.corp.good.com/api/review-requests/44580/diffs/;,
method: GET}, create: {href:
http://reviewboard.corp.good.com/api/review-requests/44580/diffs/;,
method: POST}}}
On Mon, Apr 8, 2013 at 5:12 PM, Steven MacLeod ste...@smacleod.ca wrote:
It appears your Apache server won't allow a HEAD request.
Can I see the output of:
$ curl http://reviewboard.corp.good.com/api/review-requests/44580/diffs/
-i
On Mon, Apr 8, 2013 at 4:27 PM, Robert Dailey rcdailey.li...@gmail.com
wrote:
Here you go:
C:\workcurl
http://reviewboard.corp.good.com/api/review-requests/44580/diffs/
-I
HTTP/1.1 405 METHOD NOT ALLOWED
Date: Mon, 08 Apr 2013 20:24:40 GMT
Server: Apache/2.2.21 (Unix) mod_wsgi/3.3 Python/2.7 mod_ssl/2.2.17
OpenSSL/1.0.0c
Content-Language: en-us
Expires: Mon, 08 Apr 2013 20:24:40 GMT
Vary: Accept,Cookie,Accept-Language
Last-Modified: Mon, 08 Apr 2013 20:24:40 GMT
Allow: GET, POST
Cache-Control: max-age=0
Content-Type: text/html; charset=utf-8
On Fri, Apr 5, 2013 at 12:28 AM, Steven MacLeod ste...@smacleod.ca
wrote:
Hi Robert,
Sorry for the delay in response, this slipped by in my inbox.
Could you please send me the output of:
$ curl
http://reviewboard.corp.good.com/api/review-requests/44580/diffs/
-I
Basically I need to take a look at the headers being returned in the
HTTP
request to RB.
On Fri, Mar 29, 2013 at 1:40 PM, Robert Dailey
rcdailey.li...@gmail.com
wrote:
Using RB version 1.6.3. Output of the command you requested is below:
DEBUG:root:Checking for a Bazaar repository...
DEBUG:root:Checking for a CVS repository...
DEBUG:root:Checking for a ClearCase repository...
DEBUG:root:Checking for a Git repository...
DEBUG:root:Running: git rev-parse --git-dir
DEBUG:root:Command exited with rc 128: ['git', 'rev-parse',
'--git-dir']
fatal: Not a git repository (or any of the parent directories): .git
---
DEBUG:root:Checking for a Mercurial repository...
DEBUG:root:Checking for a Perforce repository...
DEBUG:root:Running: p4 info
DEBUG:root:Running: diff --version
DEBUG:root:repository info: Path: perforce-rws2.corp.good.com:3666,
Base path: None, Supports changesets: True
DEBUG:root:Making HTTP GET request to
http://reviewboard.corp.good.com/api/
DEBUG:root:Making HTTP GET request to
http://reviewboard.corp.good.com/api/info/
INFO:root:Generating diff for changenum 303396
DEBUG:root:Running: p4 describe -s 303396
DEBUG:root:Processing delete of
//depot/dev/DominoProcessDecomp/DominoProcessDecomp.sln
DEBUG:root:Writing
//depot/dev/DominoProcessDecomp/DominoProcessDecomp.sln#4 to
c:\users\rdailey\appdata\local\temp\tmpivyvra
DEBUG:root:Running: p4 print -o
c:\users\rdailey\appdata\local\temp\tmpivyvra -q
//depot/dev/DominoProcessDecomp/DominoProcessDecomp.sln#4
DEBUG:root:Running: diff -urNp
c:\users\rdailey\appdata\local\temp\tmpivyvra
c:\users\rdailey\appdata\local\temp\tmpljgwo3
DEBUG:root:Command exited with rc 1: ['diff', '-urNp',
'c:\\users\\rdailey\\appdata\\local\\temp\\tmpivyvra',
'c:\\users\\rdailey\\appdata\\local\\temp\\tmpljgwo3']
--- c:\users\rdailey\appdata\local\temp\tmpivyvra 2013-03-29
12:39:00.971865100 -0500
+++ c:\users\rdailey\appdata\local\temp\tmpljgwo3 2013-03-29
12:39:00.798330400 -0500
@@ -1,44 +0,0 @@
-
-Microsoft Visual Studio Solution File, Format Version 9.00
-# Visual Studio 2005
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = services,
server\gmmserver\domino\server\services\services.vcproj,
{40E4563C-EDCE-4F19-8A3F-F9497265ACEE}
-EndProject
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = interface,
server\gmmserver\domino\server\interface\interface.vcproj,
{EADFA55E-6196-44CC-A496-1FDEC07DDE54}
-EndProject
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = groupware,
server\gmmserver\domino\server\groupware\groupware.vcproj,
{C4D3A251-B853-43E2-84C8-5501FE40EEE8}
-EndProject
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = gwserver,
server\gmmserver\domino\server\gwserver\gwserver.vcproj,
{0B59A140-C1D4-4A06-ACD8-5A78745D3C9F}
-EndProject
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = gwclient,
server\gmmserver\domino\server\gwclient
Re: Problem with RBTools 0.5
I'm not on Linux, how can I get you what you want on Windows 7?
On Fri, Apr 5, 2013 at 12:28 AM, Steven MacLeod ste...@smacleod.ca wrote:
Hi Robert,
Sorry for the delay in response, this slipped by in my inbox.
Could you please send me the output of:
$ curl http://reviewboard.corp.good.com/api/review-requests/44580/diffs/
-I
Basically I need to take a look at the headers being returned in the HTTP
request to RB.
On Fri, Mar 29, 2013 at 1:40 PM, Robert Dailey rcdailey.li...@gmail.com
wrote:
Using RB version 1.6.3. Output of the command you requested is below:
DEBUG:root:Checking for a Bazaar repository...
DEBUG:root:Checking for a CVS repository...
DEBUG:root:Checking for a ClearCase repository...
DEBUG:root:Checking for a Git repository...
DEBUG:root:Running: git rev-parse --git-dir
DEBUG:root:Command exited with rc 128: ['git', 'rev-parse', '--git-dir']
fatal: Not a git repository (or any of the parent directories): .git
---
DEBUG:root:Checking for a Mercurial repository...
DEBUG:root:Checking for a Perforce repository...
DEBUG:root:Running: p4 info
DEBUG:root:Running: diff --version
DEBUG:root:repository info: Path: perforce-rws2.corp.good.com:3666,
Base path: None, Supports changesets: True
DEBUG:root:Making HTTP GET request to
http://reviewboard.corp.good.com/api/
DEBUG:root:Making HTTP GET request to
http://reviewboard.corp.good.com/api/info/
INFO:root:Generating diff for changenum 303396
DEBUG:root:Running: p4 describe -s 303396
DEBUG:root:Processing delete of
//depot/dev/DominoProcessDecomp/DominoProcessDecomp.sln
DEBUG:root:Writing
//depot/dev/DominoProcessDecomp/DominoProcessDecomp.sln#4 to
c:\users\rdailey\appdata\local\temp\tmpivyvra
DEBUG:root:Running: p4 print -o
c:\users\rdailey\appdata\local\temp\tmpivyvra -q
//depot/dev/DominoProcessDecomp/DominoProcessDecomp.sln#4
DEBUG:root:Running: diff -urNp
c:\users\rdailey\appdata\local\temp\tmpivyvra
c:\users\rdailey\appdata\local\temp\tmpljgwo3
DEBUG:root:Command exited with rc 1: ['diff', '-urNp',
'c:\\users\\rdailey\\appdata\\local\\temp\\tmpivyvra',
'c:\\users\\rdailey\\appdata\\local\\temp\\tmpljgwo3']
--- c:\users\rdailey\appdata\local\temp\tmpivyvra 2013-03-29
12:39:00.971865100 -0500
+++ c:\users\rdailey\appdata\local\temp\tmpljgwo3 2013-03-29
12:39:00.798330400 -0500
@@ -1,44 +0,0 @@
-
-Microsoft Visual Studio Solution File, Format Version 9.00
-# Visual Studio 2005
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = services,
server\gmmserver\domino\server\services\services.vcproj,
{40E4563C-EDCE-4F19-8A3F-F9497265ACEE}
-EndProject
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = interface,
server\gmmserver\domino\server\interface\interface.vcproj,
{EADFA55E-6196-44CC-A496-1FDEC07DDE54}
-EndProject
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = groupware,
server\gmmserver\domino\server\groupware\groupware.vcproj,
{C4D3A251-B853-43E2-84C8-5501FE40EEE8}
-EndProject
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = gwserver,
server\gmmserver\domino\server\gwserver\gwserver.vcproj,
{0B59A140-C1D4-4A06-ACD8-5A78745D3C9F}
-EndProject
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = gwclient,
server\gmmserver\domino\server\gwclient\gwclient.vcproj,
{933240B0-F445-49E7-AB25-7BAE6B3C458C}
-EndProject
-Global
- GlobalSection(SolutionConfigurationPlatforms) = preSolution
- Debug|Win32 = Debug|Win32
- Release|Win32 = Release|Win32
- EndGlobalSection
- GlobalSection(ProjectConfigurationPlatforms) = postSolution
- {40E4563C-EDCE-4F19-8A3F-F9497265ACEE}.Debug|Win32.ActiveCfg =
Debug|Win32
- {40E4563C-EDCE-4F19-8A3F-F9497265ACEE}.Debug|Win32.Build.0 = Debug|Win32
- {40E4563C-EDCE-4F19-8A3F-F9497265ACEE}.Release|Win32.ActiveCfg =
Release|Win32
- {40E4563C-EDCE-4F19-8A3F-F9497265ACEE}.Release|Win32.Build.0 =
Release|Win32
- {EADFA55E-6196-44CC-A496-1FDEC07DDE54}.Debug|Win32.ActiveCfg =
Debug|Win32
- {EADFA55E-6196-44CC-A496-1FDEC07DDE54}.Debug|Win32.Build.0 = Debug|Win32
- {EADFA55E-6196-44CC-A496-1FDEC07DDE54}.Release|Win32.ActiveCfg =
Release|Win32
- {EADFA55E-6196-44CC-A496-1FDEC07DDE54}.Release|Win32.Build.0 =
Release|Win32
- {C4D3A251-B853-43E2-84C8-5501FE40EEE8}.Debug|Win32.ActiveCfg =
Debug|Win32
- {C4D3A251-B853-43E2-84C8-5501FE40EEE8}.Debug|Win32.Build.0 = Debug|Win32
- {C4D3A251-B853-43E2-84C8-5501FE40EEE8}.Release|Win32.ActiveCfg =
Release|Win32
- {C4D3A251-B853-43E2-84C8-5501FE40EEE8}.Release|Win32.Build.0 =
Release|Win32
- {0B59A140-C1D4-4A06-ACD8-5A78745D3C9F}.Debug|Win32.ActiveCfg =
Debug|Win32
- {0B59A140-C1D4-4A06-ACD8-5A78745D3C9F}.Debug|Win32.Build.0 = Debug|Win32
- {0B59A140-C1D4-4A06-ACD8-5A78745D3C9F}.Release|Win32.ActiveCfg =
Release|Win32
- {0B59A140-C1D4-4A06-ACD8-5A78745D3C9F}.Release|Win32.Build.0 =
Release|Win32
- {933240B0-F445-49E7-AB25-7BAE6B3C458C}.Debug|Win32.ActiveCfg =
Debug|Win32
Re: Problem with RBTools 0.5
Here you go:
C:\workcurl http://reviewboard.corp.good.com/api/review-requests/44580/diffs/
-I
HTTP/1.1 405 METHOD NOT ALLOWED
Date: Mon, 08 Apr 2013 20:24:40 GMT
Server: Apache/2.2.21 (Unix) mod_wsgi/3.3 Python/2.7 mod_ssl/2.2.17
OpenSSL/1.0.0c
Content-Language: en-us
Expires: Mon, 08 Apr 2013 20:24:40 GMT
Vary: Accept,Cookie,Accept-Language
Last-Modified: Mon, 08 Apr 2013 20:24:40 GMT
Allow: GET, POST
Cache-Control: max-age=0
Content-Type: text/html; charset=utf-8
On Fri, Apr 5, 2013 at 12:28 AM, Steven MacLeod ste...@smacleod.ca wrote:
Hi Robert,
Sorry for the delay in response, this slipped by in my inbox.
Could you please send me the output of:
$ curl http://reviewboard.corp.good.com/api/review-requests/44580/diffs/
-I
Basically I need to take a look at the headers being returned in the HTTP
request to RB.
On Fri, Mar 29, 2013 at 1:40 PM, Robert Dailey rcdailey.li...@gmail.com
wrote:
Using RB version 1.6.3. Output of the command you requested is below:
DEBUG:root:Checking for a Bazaar repository...
DEBUG:root:Checking for a CVS repository...
DEBUG:root:Checking for a ClearCase repository...
DEBUG:root:Checking for a Git repository...
DEBUG:root:Running: git rev-parse --git-dir
DEBUG:root:Command exited with rc 128: ['git', 'rev-parse', '--git-dir']
fatal: Not a git repository (or any of the parent directories): .git
---
DEBUG:root:Checking for a Mercurial repository...
DEBUG:root:Checking for a Perforce repository...
DEBUG:root:Running: p4 info
DEBUG:root:Running: diff --version
DEBUG:root:repository info: Path: perforce-rws2.corp.good.com:3666,
Base path: None, Supports changesets: True
DEBUG:root:Making HTTP GET request to
http://reviewboard.corp.good.com/api/
DEBUG:root:Making HTTP GET request to
http://reviewboard.corp.good.com/api/info/
INFO:root:Generating diff for changenum 303396
DEBUG:root:Running: p4 describe -s 303396
DEBUG:root:Processing delete of
//depot/dev/DominoProcessDecomp/DominoProcessDecomp.sln
DEBUG:root:Writing
//depot/dev/DominoProcessDecomp/DominoProcessDecomp.sln#4 to
c:\users\rdailey\appdata\local\temp\tmpivyvra
DEBUG:root:Running: p4 print -o
c:\users\rdailey\appdata\local\temp\tmpivyvra -q
//depot/dev/DominoProcessDecomp/DominoProcessDecomp.sln#4
DEBUG:root:Running: diff -urNp
c:\users\rdailey\appdata\local\temp\tmpivyvra
c:\users\rdailey\appdata\local\temp\tmpljgwo3
DEBUG:root:Command exited with rc 1: ['diff', '-urNp',
'c:\\users\\rdailey\\appdata\\local\\temp\\tmpivyvra',
'c:\\users\\rdailey\\appdata\\local\\temp\\tmpljgwo3']
--- c:\users\rdailey\appdata\local\temp\tmpivyvra 2013-03-29
12:39:00.971865100 -0500
+++ c:\users\rdailey\appdata\local\temp\tmpljgwo3 2013-03-29
12:39:00.798330400 -0500
@@ -1,44 +0,0 @@
-
-Microsoft Visual Studio Solution File, Format Version 9.00
-# Visual Studio 2005
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = services,
server\gmmserver\domino\server\services\services.vcproj,
{40E4563C-EDCE-4F19-8A3F-F9497265ACEE}
-EndProject
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = interface,
server\gmmserver\domino\server\interface\interface.vcproj,
{EADFA55E-6196-44CC-A496-1FDEC07DDE54}
-EndProject
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = groupware,
server\gmmserver\domino\server\groupware\groupware.vcproj,
{C4D3A251-B853-43E2-84C8-5501FE40EEE8}
-EndProject
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = gwserver,
server\gmmserver\domino\server\gwserver\gwserver.vcproj,
{0B59A140-C1D4-4A06-ACD8-5A78745D3C9F}
-EndProject
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = gwclient,
server\gmmserver\domino\server\gwclient\gwclient.vcproj,
{933240B0-F445-49E7-AB25-7BAE6B3C458C}
-EndProject
-Global
- GlobalSection(SolutionConfigurationPlatforms) = preSolution
- Debug|Win32 = Debug|Win32
- Release|Win32 = Release|Win32
- EndGlobalSection
- GlobalSection(ProjectConfigurationPlatforms) = postSolution
- {40E4563C-EDCE-4F19-8A3F-F9497265ACEE}.Debug|Win32.ActiveCfg =
Debug|Win32
- {40E4563C-EDCE-4F19-8A3F-F9497265ACEE}.Debug|Win32.Build.0 = Debug|Win32
- {40E4563C-EDCE-4F19-8A3F-F9497265ACEE}.Release|Win32.ActiveCfg =
Release|Win32
- {40E4563C-EDCE-4F19-8A3F-F9497265ACEE}.Release|Win32.Build.0 =
Release|Win32
- {EADFA55E-6196-44CC-A496-1FDEC07DDE54}.Debug|Win32.ActiveCfg =
Debug|Win32
- {EADFA55E-6196-44CC-A496-1FDEC07DDE54}.Debug|Win32.Build.0 = Debug|Win32
- {EADFA55E-6196-44CC-A496-1FDEC07DDE54}.Release|Win32.ActiveCfg =
Release|Win32
- {EADFA55E-6196-44CC-A496-1FDEC07DDE54}.Release|Win32.Build.0 =
Release|Win32
- {C4D3A251-B853-43E2-84C8-5501FE40EEE8}.Debug|Win32.ActiveCfg =
Debug|Win32
- {C4D3A251-B853-43E2-84C8-5501FE40EEE8}.Debug|Win32.Build.0 = Debug|Win32
- {C4D3A251-B853-43E2-84C8-5501FE40EEE8}.Release|Win32.ActiveCfg =
Release|Win32
- {C4D3A251-B853-43E2-84C8-5501FE40EEE8}.Release|Win32.Build.0 =
Release|Win32
Re: Problem with RBTools 0.5
No one will help? On Thu, Mar 28, 2013 at 3:54 PM, Robert Dailey rcdailey.li...@gmail.com wrote: I am getting the following error uploading my review from a Perforce changelist. This impedes my day to day work, so I hope that someone can help me quickly. The error I get while trying to run 'rbt post' is: CRITICAL:root:'ResourceList' object has no attribute 'upload_diff' I have only transitioned from review-board to RBT 0.5, most of the commands are the same so I am only invoking a different process. I am using Python 2.7.3 on Windows 7 x64. Here is the command I'm running: rbt post --server=http://my.review.board.url --p4-client=$c --p4-port=$p --username=myuser --password=mypassword %C Note that the previous command I used was: post-review %C --server=http://my.review.board.url --p4-client=$c --p4-port=$p --username=myuser --password=mypassword The post-review command always worked fine for me. I installed RBTools 0.5 using easy_install (logs below). Note that I run this as a custom tool in P4V, so %C actually maps to the Changelist number. $c maps to client name, $p is port, and so on. C:\Users\rdaileyeasy_install -U RBTools Searching for RBTools Reading http://pypi.python.org/simple/RBTools/ Reading http://www.reviewboard.org/ Reading http://downloads.reviewboard.org/releases/RBTools/0.3/ Reading http://downloads.reviewboard.org/releases/RBTools/0.4/ Reading http://downloads.reviewboard.org/releases/RBTools/0.5/ Reading http://downloads.reviewboard.org/releases/RBTools/0.2/ Reading http://www.review-board.org/ Reading http://downloads.review-board.org/releases/ Reading http://downloads.review-board.org/releases/RBTools/0.2/ Best match: RBTools 0.5 Downloading http://downloads.reviewboard.org/releases/RBTools/0.5/RBTools-0.5-py2.7.egg Processing RBTools-0.5-py2.7.egg Moving RBTools-0.5-py2.7.egg to c:\python27\lib\site-packages Removing rbtools 0.4.1 from easy-install.pth file Adding RBTools 0.5 to easy-install.pth file Installing post-review-script.py script to C:\Python27\Scripts Installing post-review.exe script to C:\Python27\Scripts Installing post-review.exe.manifest script to C:\Python27\Scripts Installing rbt-script.py script to C:\Python27\Scripts Installing rbt.exe script to C:\Python27\Scripts Installing rbt.exe.manifest script to C:\Python27\Scripts Installed c:\python27\lib\site-packages\rbtools-0.5-py2.7.egg Processing dependencies for RBTools Finished processing dependencies for RBTools -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Problem with RBTools 0.5
://reviewboard.corp.good.com/api/review-requests/44580/diffs/
Traceback (most recent call last):
File C:\Python27\Scripts\rbt-script.py, line 8, in module
load_entry_point('RBTools==0.5', 'console_scripts', 'rbt')()
File
C:\Python27\lib\site-packages\rbtools-0.5-py2.7.egg\rbtools\commands\main.py,
line 99, in main
File
C:\Python27\lib\site-packages\rbtools-0.5-py2.7.egg\rbtools\commands\__init__.py,
line 150, in run_from_argv
File
C:\Python27\lib\site-packages\rbtools-0.5-py2.7.egg\rbtools\commands\post.py,
line 450, in main
File
C:\Python27\lib\site-packages\rbtools-0.5-py2.7.egg\rbtools\commands\post.py,
line 324, in post_request
File
C:\Python27\lib\site-packages\rbtools-0.5-py2.7.egg\rbtools\api\transport\sync.py,
line 289, in __getattr__
AttributeError: 'ResourceList' object has no attribute 'upload_diff'
On Fri, Mar 29, 2013 at 12:20 PM, Steven MacLeod ste...@smacleod.ca wrote:
Hi Robert,
What version of Review Board is there server running? Could you also provide
the output of rbt post -d --server=http://my.review.board.url --p4-client=$c
--p4-port=$p --username=myuser --password=mypassword %C
The post-review script is still part of rbtools 0.5, so you can use that as
a backup until we have this figured out.
On Mar 29, 2013 11:01 AM, Robert Dailey rcdailey.li...@gmail.com wrote:
No one will help?
On Thu, Mar 28, 2013 at 3:54 PM, Robert Dailey rcdailey.li...@gmail.com
wrote:
I am getting the following error uploading my review from a Perforce
changelist. This impedes my day to day work, so I hope that someone
can help me quickly. The error I get while trying to run 'rbt post'
is:
CRITICAL:root:'ResourceList' object has no attribute 'upload_diff'
I have only transitioned from review-board to RBT 0.5, most of the
commands are the same so I am only invoking a different process. I am
using Python 2.7.3 on Windows 7 x64.
Here is the command I'm running:
rbt post --server=http://my.review.board.url --p4-client=$c
--p4-port=$p --username=myuser --password=mypassword %C
Note that the previous command I used was:
post-review %C --server=http://my.review.board.url --p4-client=$c
--p4-port=$p --username=myuser --password=mypassword
The post-review command always worked fine for me. I installed RBTools
0.5 using easy_install (logs below). Note that I run this as a custom
tool in P4V, so %C actually maps to the Changelist number. $c maps to
client name, $p is port, and so on.
C:\Users\rdaileyeasy_install -U RBTools
Searching for RBTools
Reading http://pypi.python.org/simple/RBTools/
Reading http://www.reviewboard.org/
Reading http://downloads.reviewboard.org/releases/RBTools/0.3/
Reading http://downloads.reviewboard.org/releases/RBTools/0.4/
Reading http://downloads.reviewboard.org/releases/RBTools/0.5/
Reading http://downloads.reviewboard.org/releases/RBTools/0.2/
Reading http://www.review-board.org/
Reading http://downloads.review-board.org/releases/
Reading http://downloads.review-board.org/releases/RBTools/0.2/
Best match: RBTools 0.5
Downloading
http://downloads.reviewboard.org/releases/RBTools/0.5/RBTools-0.5-py2.7.egg
Processing RBTools-0.5-py2.7.egg
Moving RBTools-0.5-py2.7.egg to c:\python27\lib\site-packages
Removing rbtools 0.4.1 from easy-install.pth file
Adding RBTools 0.5 to easy-install.pth file
Installing post-review-script.py script to C:\Python27\Scripts
Installing post-review.exe script to C:\Python27\Scripts
Installing post-review.exe.manifest script to C:\Python27\Scripts
Installing rbt-script.py script to C:\Python27\Scripts
Installing rbt.exe script to C:\Python27\Scripts
Installing rbt.exe.manifest script to C:\Python27\Scripts
Installed c:\python27\lib\site-packages\rbtools-0.5-py2.7.egg
Processing dependencies for RBTools
Finished processing dependencies for RBTools
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an
email to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
---
You received this message
Problem with RBTools 0.5
I am getting the following error uploading my review from a Perforce changelist. This impedes my day to day work, so I hope that someone can help me quickly. The error I get while trying to run 'rbt post' is: CRITICAL:root:'ResourceList' object has no attribute 'upload_diff' I have only transitioned from review-board to RBT 0.5, most of the commands are the same so I am only invoking a different process. I am using Python 2.7.3 on Windows 7 x64. Here is the command I'm running: rbt post --server=http://my.review.board.url --p4-client=$c --p4-port=$p --username=myuser --password=mypassword %C Note that the previous command I used was: post-review %C --server=http://my.review.board.url --p4-client=$c --p4-port=$p --username=myuser --password=mypassword The post-review command always worked fine for me. I installed RBTools 0.5 using easy_install (logs below). Note that I run this as a custom tool in P4V, so %C actually maps to the Changelist number. $c maps to client name, $p is port, and so on. C:\Users\rdaileyeasy_install -U RBTools Searching for RBTools Reading http://pypi.python.org/simple/RBTools/ Reading http://www.reviewboard.org/ Reading http://downloads.reviewboard.org/releases/RBTools/0.3/ Reading http://downloads.reviewboard.org/releases/RBTools/0.4/ Reading http://downloads.reviewboard.org/releases/RBTools/0.5/ Reading http://downloads.reviewboard.org/releases/RBTools/0.2/ Reading http://www.review-board.org/ Reading http://downloads.review-board.org/releases/ Reading http://downloads.review-board.org/releases/RBTools/0.2/ Best match: RBTools 0.5 Downloading http://downloads.reviewboard.org/releases/RBTools/0.5/RBTools-0.5-py2.7.egg Processing RBTools-0.5-py2.7.egg Moving RBTools-0.5-py2.7.egg to c:\python27\lib\site-packages Removing rbtools 0.4.1 from easy-install.pth file Adding RBTools 0.5 to easy-install.pth file Installing post-review-script.py script to C:\Python27\Scripts Installing post-review.exe script to C:\Python27\Scripts Installing post-review.exe.manifest script to C:\Python27\Scripts Installing rbt-script.py script to C:\Python27\Scripts Installing rbt.exe script to C:\Python27\Scripts Installing rbt.exe.manifest script to C:\Python27\Scripts Installed c:\python27\lib\site-packages\rbtools-0.5-py2.7.egg Processing dependencies for RBTools Finished processing dependencies for RBTools -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Screenshots for version 1.7?
Thanks, I wasn't aware of the live site :) Doesn't look too much different to me. The reviews/diff pages which are what I look at the most, seem mostly different other than a few border changes. On Thu, Sep 27, 2012 at 4:04 PM, Chris Clark chris.cl...@actian.com wrote: On Wednesday, September 26, 2012 11:26:36 AM UTC-7, Robert Dailey wrote: Are there any screenshots I can look at for various UI improvements for version 1.7? What do code review pages look like? Have you seen the live site http://reviews.reviewboard.org/r/3347/ ? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Question about diffs for moved code
Sometimes I like to take 100-200 lines of code from one file, make modifications to that code, and then move it to a separate file as a refactoring step. A couple of people on my team have complained about this since now it is impossible to diff the individual changes to the code since it was moved, but Reviewboard isn't picking up that it is moved to another file and diffing the common parts. Is there a workaround or fix for this? What should the process be for changes like this? Any way I can make such a change easier for my team to review? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Screenshots for version 1.7?
Are there any screenshots I can look at for various UI improvements for version 1.7? What do code review pages look like? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Problem with uploading consecutive diffs with updates
This happens outside of interdiff too. There is never a reason to say something can't be fixed. It may be difficult, but not impossible. Either review-board or post-review has access to file revisions in Perforce. All you need to do is simply set your base (original) in the diff to be locked to the latest revision of the file (or at least match the base revision that is in my changelist). post-review can check this prior to updating an existing review, so there's no reason this can't be done. I don't know the logistics of how Review Board or post-review works, but in theory this is a solvable problem. On Mon, May 14, 2012 at 8:12 PM, Christian Hammond chip...@chipx86.comwrote: Oh! The interdiff was the key thing. So, yes, viewing a diff between uploaded diffs will give you that result. There's really not anything we can do about this. What that is really doing is taking the patched set of files in r1 and diffing them against the patched set in r2. Since there are changes in r2 that came about from the sync, you're going to get some junk in there. It's annoying, but we basically don't know any better. There's a bug open about this, but it'll probably stay open forever. One option that some people use (it's a bit manual, but...) is to sync with the same changes in r1 and post that up, and *then* put the changes from r2 up. However, this is kind of time-consuming and annoying without some patch management system inbetween (like quilt or Git). Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, May 14, 2012 at 10:28 AM, Robert Dailey rcdailey.li...@gmail.comwrote: When I say get latest I'm referring to the Get Latest Revision option in P4V. I don't use p4 directly, so I'm not sure what command it maps to. Right click in your workspace view on the folder you want to get latest changes, and click Get Latest Revision. This will pull down the latest changes in perforce to files. Your description is almost right. I've corrected it below: You have a changelist with some code in it. You sync, new changes are pulled in. You *re-*post the *existing* changeset to Review Board, and the diff is including the things that came from the sync? This is absolutely correct. Note that I'm only working with 1 changelist. I update my existing review with the same changelist a second time, and any updates pulled from the perforce server (that other people made) will appear in the diff on Review Board. Also please note that all I'm doing is running the post-review command twice: 1) Create a new changelist, modify some source code 2) Use that post-review command to create a new review on Review Board. 3) Run Get Latest Revision in P4V to pull down latest source code changes. Files previously put up for review are modified by the sync. I resolve any conflicts and make more changes to the source files. 4) Run the same post-review command a second time, same one as before, same changelist number 5) View the diff online at Review Board server, and do a diff between r1 and r2, in this diff I see the changes I made in r2 as well as the diff for code changes pulled down from the Perforce server (those are the changes I did not make). Hope this makes more sense. Is this a problem with post-review, or am I simply not running the right commands? On Sun, May 13, 2012 at 5:48 PM, Christian Hammond chip...@chipx86.comwrote: Hi Robert, Sorry for the late reply. I've been on vacation. I'm not sure I'm fully understanding the problem you're hitting. Let me see if I have this right. You have a changelist with some code in it. You sync, new changes are pulled in. You post the new changeset to Review Board, and the diff is including the things that came from the sync? I've never seen this behavior, and use Review Board with Perforce almost daily. Posting a new review request *should* include only what changed for those files. When you say a get latest, is this 'p4 sync', or something else? This sounds like this is a client-side problem, where the changes aren't resolved properly or the metadata isn't being updated properly, causing the revision for the files to be incorrect. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, May 7, 2012 at 8:39 AM, Robert Dailey rcdailey.li...@gmail.comwrote: Can someone help me out here? On Wed, May 2, 2012 at 1:37 PM, Robert Dailey rcdailey.li...@gmail.com wrote: So I'm using Perforce and I upload my initial reviews (as well as follow up changes and updates) using this command. Note that this is a Custom Tool in P4V: %C --server=http://reviewboard.company.com --p4-client=$c --p4-port=$p --username=user --password=password %C is the changelist number in Perforce $c is the current workspace $p is the current port The problem
Re: Problem with uploading consecutive diffs with updates
When I say get latest I'm referring to the Get Latest Revision option in P4V. I don't use p4 directly, so I'm not sure what command it maps to. Right click in your workspace view on the folder you want to get latest changes, and click Get Latest Revision. This will pull down the latest changes in perforce to files. Your description is almost right. I've corrected it below: You have a changelist with some code in it. You sync, new changes are pulled in. You *re-*post the *existing* changeset to Review Board, and the diff is including the things that came from the sync? This is absolutely correct. Note that I'm only working with 1 changelist. I update my existing review with the same changelist a second time, and any updates pulled from the perforce server (that other people made) will appear in the diff on Review Board. Also please note that all I'm doing is running the post-review command twice: 1) Create a new changelist, modify some source code 2) Use that post-review command to create a new review on Review Board. 3) Run Get Latest Revision in P4V to pull down latest source code changes. Files previously put up for review are modified by the sync. I resolve any conflicts and make more changes to the source files. 4) Run the same post-review command a second time, same one as before, same changelist number 5) View the diff online at Review Board server, and do a diff between r1 and r2, in this diff I see the changes I made in r2 as well as the diff for code changes pulled down from the Perforce server (those are the changes I did not make). Hope this makes more sense. Is this a problem with post-review, or am I simply not running the right commands? On Sun, May 13, 2012 at 5:48 PM, Christian Hammond chip...@chipx86.comwrote: Hi Robert, Sorry for the late reply. I've been on vacation. I'm not sure I'm fully understanding the problem you're hitting. Let me see if I have this right. You have a changelist with some code in it. You sync, new changes are pulled in. You post the new changeset to Review Board, and the diff is including the things that came from the sync? I've never seen this behavior, and use Review Board with Perforce almost daily. Posting a new review request *should* include only what changed for those files. When you say a get latest, is this 'p4 sync', or something else? This sounds like this is a client-side problem, where the changes aren't resolved properly or the metadata isn't being updated properly, causing the revision for the files to be incorrect. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, May 7, 2012 at 8:39 AM, Robert Dailey rcdailey.li...@gmail.comwrote: Can someone help me out here? On Wed, May 2, 2012 at 1:37 PM, Robert Dailey rcdailey.li...@gmail.comwrote: So I'm using Perforce and I upload my initial reviews (as well as follow up changes and updates) using this command. Note that this is a Custom Tool in P4V: %C --server=http://reviewboard.company.com --p4-client=$c --p4-port=$p --username=user --password=password %C is the changelist number in Perforce $c is the current workspace $p is the current port The problem I'm experiencing is updates to code in my changelist being included in my diffs in reviewboard. So suppose I have files checked out in my changelist. If I do a get latest from Perforce, and some of those checked out files get changed, and I resolve conflicts, those updates I pulled down will now show up in my diff. Reviewboard should not be showing these changes in my diff, in other words, Reviewboard needs to use the latest base of each file when diffing, which it does not. It continues to use the same revisions of the files that it originally used when the review was first created. Is there a fix for this? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit
Re: Problem with uploading consecutive diffs with updates
Can someone help me out here? On Wed, May 2, 2012 at 1:37 PM, Robert Dailey rcdailey.li...@gmail.comwrote: So I'm using Perforce and I upload my initial reviews (as well as follow up changes and updates) using this command. Note that this is a Custom Tool in P4V: %C --server=http://reviewboard.company.com --p4-client=$c --p4-port=$p --username=user --password=password %C is the changelist number in Perforce $c is the current workspace $p is the current port The problem I'm experiencing is updates to code in my changelist being included in my diffs in reviewboard. So suppose I have files checked out in my changelist. If I do a get latest from Perforce, and some of those checked out files get changed, and I resolve conflicts, those updates I pulled down will now show up in my diff. Reviewboard should not be showing these changes in my diff, in other words, Reviewboard needs to use the latest base of each file when diffing, which it does not. It continues to use the same revisions of the files that it originally used when the review was first created. Is there a fix for this? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
