I'm seeing a "The file was not found in the repository" error against a Git server but don't know why...

2017-06-23 Thread eric via reviewboard
Very confused. Perhaps this is fixed by an upgrade? I'm running 2.5.9.

I've got a user who clones a Git repository, makes a random change to the 
source, commits the change, then tries "rbt post -d". It fails. I've been 
able to reproduce the problem, so it isn't restricted to the specific user.

(Note that I've blanked details specific to our environment, that seem 
unrelated to the bug.)

>>> RBTools 0.7.10
>>> Python 2.7.10 (default, Feb  7 2017, 00:08:15) 
___
>>> Command line: rbt post -d
>>> Running: tf vc help
>>> Checking for a Subversion repository...
>>> Running: svn --non-interactive info
>>> Command exited with rc 1: ['svn', '--non-interactive', u'info']
svn: E155007: '___' is not a working copy
---
>>> Checking for a Git repository...
>>> Running: git rev-parse --git-dir
>>> Running: git config core.bare
>>> Running: git rev-parse --show-toplevel
>>> Running: git symbolic-ref -q HEAD
>>> Running: git config --get branch.master.merge
>>> Running: git config --get branch.master.remote
>>> Running: git config --get remote.origin.url
>>> repository info: Path: https://__, Base path: , 
Supports changesets: False
>>> Making HTTP GET request to https://___api/
>>> Running: git rev-parse refs/heads/master
>>> Running: git merge-base e7b4515500eddbacd3846f24e59e6b5c5672fa6b 
origin/master
>>> Running: git rev-parse 0c5abaf3d4854a4e13f084b85aa7bb9f3b8c491e
>>> Running: git status --porcelain --untracked-files=no 
--ignore-submodules=dirty
>>> Running: git rev-parse --git-dir
>>> Running: git version
>>> Running: git -c core.quotepath=false -c diff.noprefix=false diff 
--no-color --full-index --ignore-submodules -M --no-ext-diff 
0c5abaf3d4854a4e13f084b85aa7bb9f3b8c491e..e7b4515500eddbacd3846f24e59e6b5c5672fa6b
>>> Making HTTP GET request to 
https://__api/validation/diffs/
>>> Cached response for HTTP GET 
https://api/validation/diffs/ expired and was modified
>>> Making HTTP POST request to 
https://api/validation/diffs/
>>> Got API Error 207 (HTTP code 400): The file was not found in the 
repository.
>>> Error data: {u'stat': u'fail', u'file': u'karma.conf.js', u'err': 
{u'msg': u'The file was not found in the repository.', u'code': 207}, 
u'revision': u'3c350734aaf218bc5d8c2b5ee1e257ff22ac2e7d'}
Traceback (most recent call last):
  File "/usr/local/bin/rbt", line 9, in 
load_entry_point('RBTools==0.7.10', 'console_scripts', 'rbt')()
  File 
"/Library/Python/2.7/site-packages/RBTools-0.7.10-py2.7.egg/rbtools/commands/main.py",
 
line 133, in main
command.run_from_argv([RB_MAIN, command_name] + args)
  File 
"/Library/Python/2.7/site-packages/RBTools-0.7.10-py2.7.egg/rbtools/commands/__init__.py",
 
line 663, in run_from_argv
exit_code = self.main(*args) or 0
  File 
"/Library/Python/2.7/site-packages/RBTools-0.7.10-py2.7.egg/rbtools/commands/post.py",
 
line 812, in main
(msg_prefix, e))
rbtools.commands.CommandError: Error validating diff

What's going on, and how do I fix it?

Eric


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Review groups UI not letting me delete users....

2017-03-16 Thread eric via reviewboard
I recently upgraded our deployment of ReviewBoard from 2.0.X to 2.5.9. Now, 
some of my reviewboard instance owners are reporting that they cannot edit 
review groups.

Specifically, on this page: ${server_root_path}/admin/db/reviews/group/1/

the UI for removing users from the a review group doesn't seem to work. 
When I tried it myself, as superuser, I also ran into problems.

In the "ACCESS CONTROL" area of the page, in the box listing the users, the 
"x" on the right side of each row listing a user - it doesn't highlight for 
me when I mouse-over the "x". Clicking on the "x" has no effect. I was able 
to get it to work briefly by adding a user to the group, and then the "x" 
controls would highlight. However, as soon as I clicked one, they stopped 
working again.

Is this a general problem with the software, or something about our 
deployment?

Thanks!

Eric.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: http 500 internal server error reviewboard

2016-09-28 Thread eric via reviewboard
I've not used webhooks myself, but based on the stack trace, it appears 
that you've turned them on, and the attempt to invoke a hook is failing.

So go look in your configuration, and either fix your webhook 
configuration, or disable them?

Eric.

On Tuesday, September 27, 2016 at 12:43:01 PM UTC-7, Vipul Singh wrote:
>
> hello
> i am getting http 500 internal error whenever i try to publish a new 
> review request. my reviewboard is running on CentOs 7.
> Here is my log file :-
>
> [Mon Sep 26 20:01:16.923283 2016] [:error] [pid 12652] 
> ERROR:root:Exception thrown for user vipul at 
> http://10.31.227.139/api/review-requests/25/draft/
> [Mon Sep 26 20:01:16.923330 2016] [:error] [pid 12652]
> [Mon Sep 26 20:01:16.923335 2016] [:error] [pid 12652]  [Errno 111] Connection refused>
> [Mon Sep 26 20:01:16.923338 2016] [:error] [pid 12652] Traceback (most 
> recent call last):
> [Mon Sep 26 20:01:16.923341 2016] [:error] [pid 12652]   File 
> "/usr/lib/python2.7/site-packages/django/core/handlers/base.py", line 112, 
> in get_response
> [Mon Sep 26 20:01:16.923344 2016] [:error] [pid 12652] response = 
> wrapped_callback(request, *callback_args, **callback_kwargs)
> [Mon Sep 26 20:01:16.923347 2016] [:error] [pid 12652]   File 
> "/usr/lib/python2.7/site-packages/django/views/decorators/cache.py", line 
> 52, in _wrapped_view_func
> [Mon Sep 26 20:01:16.923351 2016] [:error] [pid 12652] response = 
> view_func(request, *args, **kwargs)
> [Mon Sep 26 20:01:16.923354 2016] [:error] [pid 12652]   File 
> "/usr/lib/python2.7/site-packages/django/views/decorators/vary.py", line 
> 19, in inner_func
> [Mon Sep 26 20:01:16.923357 2016] [:error] [pid 12652] response = 
> func(*args, **kwargs)
> [Mon Sep 26 20:01:16.923360 2016] [:error] [pid 12652]   File 
> "/usr/lib/python2.7/site-packages/djblets/webapi/resources/base.py", line 
> 196, in __call__
> [Mon Sep 26 20:01:16.923363 2016] [:error] [pid 12652] request, 
> method, view, api_format=api_format, *args, **kwargs)
> [Mon Sep 26 20:01:16.923366 2016] [:error] [pid 12652]   File 
> "/usr/lib/python2.7/site-packages/djblets/webapi/resources/mixins/api_tokens.py",
>  
> line 65, in call_method_view
> [Mon Sep 26 20:01:16.923369 2016] [:error] [pid 12652] return 
> view(request, *args, **kwargs)
> [Mon Sep 26 20:01:16.923372 2016] [:error] [pid 12652]   File 
> "/usr/lib/python2.7/site-packages/djblets/webapi/resources/base.py", line 
> 464, in put
> [Mon Sep 26 20:01:16.923375 2016] [:error] [pid 12652] return 
> self.update(request, *args, **kwargs)
> [Mon Sep 26 20:01:16.923378 2016] [:error] [pid 12652]   File 
> "/usr/lib/python2.7/site-packages/djblets/webapi/decorators.py", line 122, 
> in _call
> [Mon Sep 26 20:01:16.923381 2016] [:error] [pid 12652] return 
> view_func(*args, **kwargs)
> [Mon Sep 26 20:01:16.923383 2016] [:error] [pid 12652]   File 
> "/usr/lib/python2.7/site-packages/reviewboard/webapi/decorators.py", line 
> 139, in _check
> [Mon Sep 26 20:01:16.923386 2016] [:error] [pid 12652] return 
> view_func(*args, **kwargs)
> [Mon Sep 26 20:01:16.923389 2016] [:error] [pid 12652]   File 
> "/usr/lib/python2.7/site-packages/djblets/webapi/decorators.py", line 122, 
> in _call
> [Mon Sep 26 20:01:16.923392 2016] [:error] [pid 12652] return 
> view_func(*args, **kwargs)
> [Mon Sep 26 20:01:16.923408 2016] [:error] [pid 12652]   File 
> "/usr/lib/python2.7/site-packages/djblets/webapi/decorators.py", line 143, 
> in _checklogin
> [Mon Sep 26 20:01:16.923413 2016] [:error] [pid 12652] return 
> view_func(*args, **kwargs)
> [Mon Sep 26 20:01:16.923416 2016] [:error] [pid 12652]   File 
> "/usr/lib/python2.7/site-packages/djblets/webapi/decorators.py", line 122, 
> in _call
> [Mon Sep 26 20:01:16.923419 2016] [:error] [pid 12652] return 
> view_func(*args, **kwargs)
> [Mon Sep 26 20:01:16.923422 2016] [:error] [pid 12652]   File 
> "/usr/lib/python2.7/site-packages/djblets/webapi/decorators.py", line 122, 
> in _call
> [Mon Sep 26 20:01:16.923425 2016] [:error] [pid 12652] return 
> view_func(*args, **kwargs)
> [Mon Sep 26 20:01:16.923428 2016] [:error] [pid 12652]   File 
> "/usr/lib/python2.7/site-packages/djblets/webapi/decorators.py", line 307, 
> in _validate
> [Mon Sep 26 20:01:16.923431 2016] [:error] [pid 12652] return 
> view_func(*args, **new_kwargs)
> [Mon Sep 26 20:01:16.923434 2016] [:error] [pid 12652]   File 
> "/usr/lib/python2.7/site-packages/reviewboard/webapi/resources/review_request_draft.py",
>  
> line 493, in update
> [Mon Sep 26 20:01:16.923437 2016] [:error] [pid 12652] 
> review_request.publish(user=request.user, trivial=trivial)
> [Mon Sep 26 20:01:16.923440 2016] [:error] [pid 12652]   File 
> "/usr/lib/python2.7/site-packages/reviewboard/reviews/models/review_request.py",
>  
> line 848, in publish
> [Mon Sep 26 20:01:16.923443 2016] [:error] [pid 12652] 
> changedesc=changes)
> [Mon Sep 26 20:01:16.923446 2016] [:error] [pid 12652]   File 
> 

Re: Attempted to switch my server to HTTPS, and rbt setup-repo reports SSLV3_ALERT_HANDSHAKE_FAILURE

2016-09-09 Thread eric via reviewboard
Some follow-on information.

I grabbed my Apache configuration for the server 
from https://mozilla.github.io/server-side-tls/ssl-config-generator/
Initially, I tried the "Modern" configuration.

When I switch to the "Intermediate" configuration, it starts working.

I updated my logging on the server to track which protocol & cipher are 
being used, and I see this when I connect from the browser:

TLSv1.2 ECDHE-RSA-AES128-GCM-SHA256

(That's good)


... but I see this if I run "rbt setup-repo" or "rbt post"

TLSv1 DHE-RSA-AES128-SHA


Why is it that rbt uses the older protocol & cipher? I've been advised to 
go run wireshark, and maybe that will provide more insight.


Eric.



On Friday, September 9, 2016 at 10:02:28 AM UTC-7, er...@tibco.com wrote:
>
> The specific, full message is this:
>
> ERROR: Could not reach the Review Board server at : SSL: 
> SSLV3_ALERT_HANDSHAKE_FAILURE] sslv3 alert handshake failure (_ssl.c:590)
>
>
> This is not a self-signed certificate. My web browsers all work fine when 
> I connect to the site. When I do this:
>
>
> > python
>
> > import ssl
>
> > ssl.OPENSSL_VERSION
>
> >>> 'OpenSSL 1.0.2h  3 May 2016'
>
>
> I'm sort of at a loss for how to troubleshoot this. I turn on all the 
> debugging and logging I can on the server, and I'm not seeing any 
> additional information.
>
>
> It doesn't look like rbt setup-repo takes any "verbose" options that will 
> clarify the problem.
>
>
> Suggestions?
>
>
> Thanks!
>
>
> Eric.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Attempted to switch my server to HTTPS, and rbt setup-repo reports SSLV3_ALERT_HANDSHAKE_FAILURE

2016-09-09 Thread eric via reviewboard
The specific, full message is this:

ERROR: Could not reach the Review Board server at : SSL: 
SSLV3_ALERT_HANDSHAKE_FAILURE] sslv3 alert handshake failure (_ssl.c:590)


This is not a self-signed certificate. My web browsers all work fine when I 
connect to the site. When I do this:


> python

> import ssl

> ssl.OPENSSL_VERSION

>>> 'OpenSSL 1.0.2h  3 May 2016'


I'm sort of at a loss for how to troubleshoot this. I turn on all the 
debugging and logging I can on the server, and I'm not seeing any 
additional information.


It doesn't look like rbt setup-repo takes any "verbose" options that will 
clarify the problem.


Suggestions?


Thanks!


Eric.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: A weird unicode puzzle after upgrade from 2.0.20 to 2.5.4

2016-05-15 Thread eric via reviewboard
I have finally re-run my entire automated migration process from start to 
finish.

After running condensediffs *before* the upgrade, I was then able to run 
condensediffs after the upgrade as well, all without any warnings or errors.

Perhaps you should add a step to the upgrade guide, advising Administrators 
to rebuild their search index, and also condense diffs?

So I seem to have found a work-around to the problem - in case anyone else 
runs into it.

Eric.

On Saturday, May 14, 2016 at 1:40:06 PM UTC-7, er...@tibco.com wrote:
>
> I re-ran the migration, and before doing anything, set the DEBUG flag to 
> True before fetching any diffs.
>
> I can confirm that it fails on *every* diff, not just random ones here and 
> there.
>
> Running with DEBUG = False, the warning doesn't throw an exception, but I 
> do see an entry in the log:
> WARNING:py.warnings:/usr/lib64/python2.7/site-packages/django/db/backends/mysql/base.py:124:
>  
> Warning: Invalid utf8 character string: '81FE48'
>
> After I've viewed the diffs of a review request once, the warnings stop 
> appearing (consistent with the data being migrated to compressed form.). 
> Switching back to DEBUG = True, and I no longer see failures for the review 
> request diffs that I looked at while DEBUG = False
>
> Trying a different approach, I ran "rb-site manage __ -- 
> condensediffs", and that also generated the same warnings. Here's a sample:
>
> WARNING:py.warnings:/usr/lib64/python2.7/site-packages/django/db/backends/mysql/base.py:124:
>  
> Warning: Invalid utf8 character string: 'D76700'
>
>   return self.cursor.execute(query, args)
>
>
> WARNING:py.warnings:/usr/lib64/python2.7/site-packages/django/db/backends/mysql/base.py:124:
>  
> Warning: Invalid utf8 character string: 'A9C813'
>
>   return self.cursor.execute(query, args)
>
>
> ...
>
>
> This generated 169000+ lines of output, corresponding to 56435 individual 
> warning messages out of a total of 76032 diff files condensed.
>
>
> This gave me an idea.
>
>
> I ran "rb-site ... condensediffs" before the upgrade, then once again 
> after the upgrade.
>
>
> Problem went away.
>
>
> Weird. Do you want me to try to find out more, and if so, what?
>
>
> Eric.
>
>
>
> On Friday, May 13, 2016 at 1:49:53 PM UTC-7, Christian Hammond wrote:
>>
>> Hi Eric,
>>
>> Hmm, we'll need to look into that. Is there a way you'd be able to send 
>> us the diff for that? (I can help you find it.) We will need a copy in 
>> order to diagnose this. We can sign an NDA for it.
>>
>> Christian
>>
>>
>> On Friday, May 13, 2016, eric via reviewboard <revie...@googlegroups.com> 
>> wrote:
>>
>>> After I migrated my server to 2.5.4, I'm seeing a weird error. I 
>>> restarted both memcached and apache2, and then browse to a specific review 
>>> request.
>>>
>>> Then I click on the "Diff" tab. (After I turned on DEBUG = True in the 
>>> settings_local.py file) I see this instead of diffs.
>>>
>>> Traceback (most recent call last):
>>>   File 
>>> "/usr/lib64/python2.7/site-packages/ReviewBoard-2.5.4-py2.7.egg/reviewboard/diffviewer/views.py",
>>>  
>>> line 275, in get
>>> response = renderer.render_to_response(request)
>>>   File 
>>> "/usr/lib64/python2.7/site-packages/ReviewBoard-2.5.4-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>>  
>>> line 56, in render_to_response
>>> return HttpResponse(self.render_to_string(request))
>>>   File 
>>> "/usr/lib64/python2.7/site-packages/ReviewBoard-2.5.4-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>>  
>>> line 74, in render_to_string
>>> large_data=True)
>>>   File 
>>> "/usr/lib64/python2.7/site-packages/Djblets-0.9.3-py2.7.egg/djblets/cache/backend.py",
>>>  
>>> line 295, in cache_memoize
>>> compress_large_data))
>>>   File 
>>> "/usr/lib64/python2.7/site-packages/Djblets-0.9.3-py2.7.egg/djblets/cache/backend.py",
>>>  
>>> line 249, in cache_memoize_iter
>>> items = items_or_callable()
>>>   File 
>>> "/usr/lib64/python2.7/site-packages/Djblets-0.9.3-py2.7.egg/djblets/cache/backend.py",
>>>  
>>> line 292, in 
>>> lambda: [lookup_callable()],
>>>   File 
>>> "/usr/lib64/python2.7/site-packages/ReviewBoard-2.5.4-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>>  
>>> line 73, in 
>>> lambda: se

Re: A weird unicode puzzle after upgrade from 2.0.20 to 2.5.4

2016-05-14 Thread eric via reviewboard
I re-ran the migration, and before doing anything, set the DEBUG flag to 
True before fetching any diffs.

I can confirm that it fails on *every* diff, not just random ones here and 
there.

Running with DEBUG = False, the warning doesn't throw an exception, but I 
do see an entry in the log:
WARNING:py.warnings:/usr/lib64/python2.7/site-packages/django/db/backends/mysql/base.py:124:
 
Warning: Invalid utf8 character string: '81FE48'

After I've viewed the diffs of a review request once, the warnings stop 
appearing (consistent with the data being migrated to compressed form.). 
Switching back to DEBUG = True, and I no longer see failures for the review 
request diffs that I looked at while DEBUG = False

Trying a different approach, I ran "rb-site manage __ -- 
condensediffs", and that also generated the same warnings. Here's a sample:

WARNING:py.warnings:/usr/lib64/python2.7/site-packages/django/db/backends/mysql/base.py:124:
 
Warning: Invalid utf8 character string: 'D76700'

  return self.cursor.execute(query, args)


WARNING:py.warnings:/usr/lib64/python2.7/site-packages/django/db/backends/mysql/base.py:124:
 
Warning: Invalid utf8 character string: 'A9C813'

  return self.cursor.execute(query, args)


...


This generated 169000+ lines of output, corresponding to 56435 individual 
warning messages out of a total of 76032 diff files condensed.


This gave me an idea.


I ran "rb-site ... condensediffs" before the upgrade, then once again after 
the upgrade.


Problem went away.


Weird. Do you want me to try to find out more, and if so, what?


Eric.



On Friday, May 13, 2016 at 1:49:53 PM UTC-7, Christian Hammond wrote:
>
> Hi Eric,
>
> Hmm, we'll need to look into that. Is there a way you'd be able to send us 
> the diff for that? (I can help you find it.) We will need a copy in order 
> to diagnose this. We can sign an NDA for it.
>
> Christian
>
>
> On Friday, May 13, 2016, eric via reviewboard <revie...@googlegroups.com 
> > wrote:
>
>> After I migrated my server to 2.5.4, I'm seeing a weird error. I 
>> restarted both memcached and apache2, and then browse to a specific review 
>> request.
>>
>> Then I click on the "Diff" tab. (After I turned on DEBUG = True in the 
>> settings_local.py file) I see this instead of diffs.
>>
>> Traceback (most recent call last):
>>   File 
>> "/usr/lib64/python2.7/site-packages/ReviewBoard-2.5.4-py2.7.egg/reviewboard/diffviewer/views.py",
>>  
>> line 275, in get
>> response = renderer.render_to_response(request)
>>   File 
>> "/usr/lib64/python2.7/site-packages/ReviewBoard-2.5.4-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>  
>> line 56, in render_to_response
>> return HttpResponse(self.render_to_string(request))
>>   File 
>> "/usr/lib64/python2.7/site-packages/ReviewBoard-2.5.4-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>  
>> line 74, in render_to_string
>> large_data=True)
>>   File 
>> "/usr/lib64/python2.7/site-packages/Djblets-0.9.3-py2.7.egg/djblets/cache/backend.py",
>>  
>> line 295, in cache_memoize
>> compress_large_data))
>>   File 
>> "/usr/lib64/python2.7/site-packages/Djblets-0.9.3-py2.7.egg/djblets/cache/backend.py",
>>  
>> line 249, in cache_memoize_iter
>> items = items_or_callable()
>>   File 
>> "/usr/lib64/python2.7/site-packages/Djblets-0.9.3-py2.7.egg/djblets/cache/backend.py",
>>  
>> line 292, in 
>> lambda: [lookup_callable()],
>>   File 
>> "/usr/lib64/python2.7/site-packages/ReviewBoard-2.5.4-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>  
>> line 73, in 
>> lambda: self.render_to_string_uncached(request),
>>   File 
>> "/usr/lib64/python2.7/site-packages/ReviewBoard-2.5.4-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>  
>> line 87, in render_to_string_uncached
>> request=request)
>>   File 
>> "/usr/lib64/python2.7/site-packages/ReviewBoard-2.5.4-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>>  
>> line 429, in populate_diff_chunks
>> chunks = list(generator.get_chunks())
>>   File 
>> "/usr/lib64/python2.7/site-packages/ReviewBoard-2.5.4-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>  
>> line 756, in get_chunks
>> for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
>>   File 
>> "/usr/lib64/python2.7/site-packages/ReviewBoard-2.5.4-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>  
>> line 107, in get_chunks
>> large_data=True)
>>   File 
>> "/usr/

A weird unicode puzzle after upgrade from 2.0.20 to 2.5.4

2016-05-13 Thread eric via reviewboard
After I migrated my server to 2.5.4, I'm seeing a weird error. I restarted 
both memcached and apache2, and then browse to a specific review request.

Then I click on the "Diff" tab. (After I turned on DEBUG = True in the 
settings_local.py file) I see this instead of diffs.

Traceback (most recent call last):
  File 
"/usr/lib64/python2.7/site-packages/ReviewBoard-2.5.4-py2.7.egg/reviewboard/diffviewer/views.py",
 
line 275, in get
response = renderer.render_to_response(request)
  File 
"/usr/lib64/python2.7/site-packages/ReviewBoard-2.5.4-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 56, in render_to_response
return HttpResponse(self.render_to_string(request))
  File 
"/usr/lib64/python2.7/site-packages/ReviewBoard-2.5.4-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 74, in render_to_string
large_data=True)
  File 
"/usr/lib64/python2.7/site-packages/Djblets-0.9.3-py2.7.egg/djblets/cache/backend.py",
 
line 295, in cache_memoize
compress_large_data))
  File 
"/usr/lib64/python2.7/site-packages/Djblets-0.9.3-py2.7.egg/djblets/cache/backend.py",
 
line 249, in cache_memoize_iter
items = items_or_callable()
  File 
"/usr/lib64/python2.7/site-packages/Djblets-0.9.3-py2.7.egg/djblets/cache/backend.py",
 
line 292, in 
lambda: [lookup_callable()],
  File 
"/usr/lib64/python2.7/site-packages/ReviewBoard-2.5.4-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 73, in 
lambda: self.render_to_string_uncached(request),
  File 
"/usr/lib64/python2.7/site-packages/ReviewBoard-2.5.4-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 87, in render_to_string_uncached
request=request)
  File 
"/usr/lib64/python2.7/site-packages/ReviewBoard-2.5.4-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 
line 429, in populate_diff_chunks
chunks = list(generator.get_chunks())
  File 
"/usr/lib64/python2.7/site-packages/ReviewBoard-2.5.4-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 756, in get_chunks
for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
  File 
"/usr/lib64/python2.7/site-packages/ReviewBoard-2.5.4-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 107, in get_chunks
large_data=True)
  File 
"/usr/lib64/python2.7/site-packages/Djblets-0.9.3-py2.7.egg/djblets/cache/backend.py",
 
line 295, in cache_memoize
compress_large_data))
  File 
"/usr/lib64/python2.7/site-packages/Djblets-0.9.3-py2.7.egg/djblets/cache/backend.py",
 
line 249, in cache_memoize_iter
items = items_or_callable()
  File 
"/usr/lib64/python2.7/site-packages/Djblets-0.9.3-py2.7.egg/djblets/cache/backend.py",
 
line 292, in 
lambda: [lookup_callable()],
  File 
"/usr/lib64/python2.7/site-packages/ReviewBoard-2.5.4-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 106, in 
lambda: list(self.get_chunks_uncached()),
  File 
"/usr/lib64/python2.7/site-packages/ReviewBoard-2.5.4-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 763, in get_chunks_uncached
new = get_patched_file(old, self.filediff, self.request)
  File 
"/usr/lib64/python2.7/site-packages/ReviewBoard-2.5.4-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 
line 230, in get_patched_file
diff = tool.normalize_patch(filediff.diff, filediff.source_file,
  File 
"/usr/lib64/python2.7/site-packages/ReviewBoard-2.5.4-py2.7.egg/reviewboard/diffviewer/models.py",
 
line 218, in _get_diff
self._migrate_diff_data()
  File 
"/usr/lib64/python2.7/site-packages/ReviewBoard-2.5.4-py2.7.egg/reviewboard/diffviewer/models.py",
 
line 421, in _migrate_diff_data
diff_hash_is_new = self._set_diff(self.legacy_diff_hash.binary)
  File 
"/usr/lib64/python2.7/site-packages/ReviewBoard-2.5.4-py2.7.egg/reviewboard/diffviewer/models.py",
 
line 225, in _set_diff
RawFileDiffData.objects.get_or_create_from_data(diff)
  File 
"/usr/lib64/python2.7/site-packages/ReviewBoard-2.5.4-py2.7.egg/reviewboard/diffviewer/managers.py",
 
line 345, in get_or_create_from_data
'compression': compression,
  File "/usr/lib64/python2.7/site-packages/django/db/models/manager.py", 
line 154, in get_or_create
return self.get_queryset().get_or_create(**kwargs)
  File "/usr/lib64/python2.7/site-packages/django/db/models/query.py", line 
383, in get_or_create
obj.save(force_insert=True, using=self.db)
  File "/usr/lib64/python2.7/site-packages/django/db/models/base.py", line 
545, in save
force_update=force_update, update_fields=update_fields)
  File "/usr/lib64/python2.7/site-packages/django/db/models/base.py", line 
573, in save_base
updated = self._save_table(raw, cls, force_insert, force_update, using, 
update_fields)
  File "/usr/lib64/python2.7/site-packages/django/db/models/base.py", line 
654, in _save_table
result = self._do_insert(cls._base_manager, using, fields, update_pk, 
raw)
  File "/usr/lib64/python2.7/site-packages/django/db/models/base.py", line 
687, in _do_insert
using=using, raw=raw)
  File 

Re: Search showing incomplete results (v. 2.5.4, just rebuilt indices)

2016-05-13 Thread eric via reviewboard
Ugh. Me with egg on my face.

My automated script to perform the indexing, and turn on searching - turns 
out I had a typo.

Eric.

On Thursday, May 12, 2016 at 5:08:04 PM UTC-7, Christian Hammond wrote:
>
> Hi Eric,
>
> Just to check, is Search enabled in Settings?
>
> The auto-complete won't show results from the search index. You'll have to 
> hit enter to see the results. We're changing this for 3.0 (along with 
> adding on-the-fly search indexing).
>
> Christian
>
> -- 
> Christian Hammond
> President/CEO of Beanbag <https://www.beanbaginc.com/>
> Makers of Review Board <https://www.reviewboard.org/>
>
> On Thu, May 12, 2016 at 11:07 AM, eric via reviewboard <
> revie...@googlegroups.com > wrote:
>
>> I'm getting ready to roll out the latest ReviewBoard for my company. 
>> Upgrade went smoothly. Looks like you've even fully integrated a patch I 
>> submitted a while back (thanks for that!)
>>
>> While I was at it, I figured I should turn on indexing for the first time.
>>
>> After doing a:
>>
>> rb-site manage ${path_to_instance} -- rebuild_index
>>
>> After switching to view "all requests", I start typing in the search box, 
>> and it doesn't match against some of the items I can see on my first page 
>> of all available requests.
>>
>> In particular, I'm interested in searching for bug numbers. Sometimes my 
>> users put these in the summary of a review request, and some times they put 
>> it in the Bugs field. Whether or not a bug number is listed in the Bugs 
>> field appears to have no affect on whether it gets properly indexed for 
>> search.
>>
>> What's going on? Any tips for troubleshooting?
>>
>> Eric.
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.