Re: Review Comments Everywhere

[eyal]

On Nov 11, 1:20 am, Christian Hammond [EMAIL PROTECTED] wrote:
  People wrote comments, and I updated my diff. I can understand in ver2
  I can't see comments of ver1, but why not diff between 1-2? I want to
  read comments of ver1 on 1-2 diff so to check whether all comments are
  handled.

 The comments may not make sense on an interdiff. An interdiff is really its
 own diff, and shouldn't contain comments from the other revisions. Lines
 won't match up correctly in most cases and the comments will just end up
 confusing. There's just no real solution to this. Furthermore, you may not
 be able to create an new comment on a line if a comment from a previous
 revision is showing up there.

This is actually something I find lacking in reviewboard. Without
going back and forth between the review request page and the diff
viewer, it's impossible to see how each comment was addressed in the
new revision.
The behavior I guess I'd expect is that comments are linked to a
single revision (but not to interdiffs), and that viewing an interdiff
will show the comments for both revisions (each on its own side, so
it's clear which revision the comment refers to).

Eyal

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

changing django settings with djblets.siteconfig

[eyal]

Hi,

I've got a question about how djblets.siteconfig handles changes in
the settings.py and settings_local.py files.

After upgrading to r1537 (and introducing djblets.siteconfig), as I
understand, a SiteConfiguration object has been created (and stored in
the db) that reflects the existing state of settings.py and
setting_local.py.

If I later make changes to settings_local.py (for example, changing
the cache backend), it's not reflected in the SiteConfiguration
object, and ReviewBoard never sees this change. There also doesn't
seem to be an easy way to update this field (the settings admin
interface doesn't include it).

This shouldn't be this cumbersome. I get a feeling that I missed
something...


Thanks,
Eyal

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---