Re: Stripping comments from patches -- not so good
Yes, I am referring to the comments that preced the actual diff in the patch. Reviewboard throws them away, which makes it a kind of severe limitation for us to use in our workflow (which uses git). Thanks On Tue, Aug 4, 2009 at 4:19 PM, Dan Savilonisd...@n-cube.org wrote: Hi Joyjit, Are you talking about comments that precede the actual diff in the patch? This is a problem for git patches, and a bug 1229 is open for it. I looked into the issue a bit and I think it can be resolved by maintaining the extra info as part of the diff set. Right now, RB splits the diff into separate file diffs which are then concatenated together for downloading the full diff. I'm interested in this change, so I'll look into modifying the code when I have a chance. Dan On Jul 29, 6:11 pm, joyjit joy...@gmail.com wrote: When one submits a patch file (in unified diff format), reviewboard seems to throw away the comments that are embedded in the patch file. This is not good. It would be nice to have reviewboard accept those comments and add it to the Description field. And it would also be nice for reviewboard to preserve the patch in its entirety when one chooses Download Diff from the web gui.. Thanks Joyjit --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Stripping comments from patches -- not so good
When one submits a patch file (in unified diff format), reviewboard seems to throw away the comments that are embedded in the patch file. This is not good. It would be nice to have reviewboard accept those comments and add it to the Description field. And it would also be nice for reviewboard to preserve the patch in its entirety when one chooses Download Diff from the web gui.. Thanks Joyjit --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Reviewboard 1.0 + CentOS 5.3 -- can't get logging to work
Hi, I am trying to debug another problem (RB is only occasionally sending out email). From the the Admin dashboard, under Settings -- Logging I have enabled logging and set the logging directory to /var/lg/reviewboard. Made sure that this directory is writeable by root (my apache runs as root). And then, in reviewboard/reviews/email.py I have added the code to enable logging (as suggested by Christian): At top of file: import logging And in send_review_mail, before the message.send(), added: logging.info(Sending e-mail with subject '%s' from '%s' to '%s', CC '%s'\n, subject, from_email, to_field, cc_field) And then I have restarted apache. And I see no logs. My /var/log/reviewboard directory is empty. My /var/www/review-board/logs directory is also empty. I have also gone into my /var/www/review-board/conf/settings_local.py and set DEBUG = True and restarted apache. This did not help either... How can I turn on logging? Thanks in advance --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Reviewboard + CentOS 5.3 + git -- problem with missing email notifications
Hi Christian, Thank you for your response. Is there DEBUG flag or logging that I can enable that will provide me some visibility as to what review board is doing when it is supposed to send out email (but is not)? Currently, the only visibility I have is looking at my sendmail log file (/var/log/maillog)... and when I look at that file, I see reviewboard is just behaving erratically -- sometimes it sends email, and sometimes it doesnt. --Joyjit On Jul 24, 2:42 pm, Christian Hammond chip...@chipx86.com wrote: Hi, This is not a problem I've heard of before with Review Board. The only times people have reported issues with sending e-mail, it turned out to be a configuration problem on the mail server software. It's possible it's rejecting those e-mails for some reasons (not trusting the From: we put in or something). For all mail sending, we go through Django's mail API, which in turn uses Python's built-in smtplib mail code. So any problem in actual transmission would either have to be in Python (which I sort of doubt) or the mail server. Unfortunately, I don't have any real ideas off-hand as to why you'd hit this. Maybe somebody else has had this problem and will respond. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Fri, Jul 24, 2009 at 2:26 PM, joyjit joy...@gmail.com wrote: Hi all, I have managed to set up Review Board 1.0 on CentOS 5.3. We are using it with git. It works great, except for one annoying problem -- it seems to be frequently (and apparently randomly) miss sending email messages. For example, when one submits a patch for review (and publishes it), Review Board is supposed to send out an email message to all the reviewers. My installation of Review Board seems to be only doing this occasionally. It is correctly configured to use sendmail. And it does occasionally send out the email notifications. However, when I take a look at my servers mail log file (/var/log/ maillog) I see that indeed, occasionally there is no trace of reviewboard to have even attempted to send out email messages. -- Is anybody else seeing this problem? -- How can I help diagnose this problem ? (perhaps by turning on debug flags etc, but how?) Thanks in advance! --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
