Preventing commits from going through if status is still in review stage
Is there documentation on how to set this up with post-commit or pre- commit hooks where a user can't push changes into the repository unless the changeset has been reviewed and approved? I'm using git as our repo and so far I've gotten as far as being able to use post-review to submit a review request. Not I need to figure out a way to lock users from pushing to the central repo until their changeset has been reviewed and approved. Is there a workflow for this scenario? James -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Preventing commits from going through if status is still in review stage
There's nothing we provide, as it varies quite a bit between installs, repository types, etc. Right now anything you do requires a fair bit of custom code. We're working on a formal Python API for Review Board, which will make this easier from a development standpoint. From a workflow standpoint, the difficulty is in identifying which commits are tied with which review requests. This is easier on a system like Subversion. Just have some field identifying the review request in the commit message. With Git, you'd have to be careful to have it in the commit message for a single commit, or in the message for a merge, in order for that to work the same. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Sep 12, 2011 at 11:36 AM, james james.ngu...@gmail.com wrote: Is there documentation on how to set this up with post-commit or pre- commit hooks where a user can't push changes into the repository unless the changeset has been reviewed and approved? I'm using git as our repo and so far I've gotten as far as being able to use post-review to submit a review request. Not I need to figure out a way to lock users from pushing to the central repo until their changeset has been reviewed and approved. Is there a workflow for this scenario? James -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Preventing commits from going through if status is still in review stage
The Python API or even a Restful call to the reviewboard would be nice. Then I could probably call reviewboard from a curl and check on the changeset status. For instance this is my git log: --- SNIPPET --- commit 08c36a414d56a7e1db26bfd7f5fabe2cb9d0aff7 Author: james ja...@jenkins.sm.kernelfire.com Date: Mon Sep 12 11:50:22 2011 -0700 slim down repo --- SNIPPET --- Couldn't I then use the commit hash to identify the review request along with the git commit changeset? On Sep 12, 11:59 am, Christian Hammond chip...@chipx86.com wrote: There's nothing we provide, as it varies quite a bit between installs, repository types, etc. Right now anything you do requires a fair bit of custom code. We're working on a formal Python API for Review Board, which will make this easier from a development standpoint. From a workflow standpoint, the difficulty is in identifying which commits are tied with which review requests. This is easier on a system like Subversion. Just have some field identifying the review request in the commit message. With Git, you'd have to be careful to have it in the commit message for a single commit, or in the message for a merge, in order for that to work the same. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Sep 12, 2011 at 11:36 AM, james james.ngu...@gmail.com wrote: Is there documentation on how to set this up with post-commit or pre- commit hooks where a user can't push changes into the repository unless the changeset has been reviewed and approved? I'm using git as our repo and so far I've gotten as far as being able to use post-review to submit a review request. Not I need to figure out a way to lock users from pushing to the central repo until their changeset has been reviewed and approved. Is there a workflow for this scenario? James -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Preventing commits from going through if status is still in review stage
No, not necessarily. When you post a diff, it generates a squashed diff, whichay mean the SHA1 will differ. We also just have no mechanism today to look up a review request by this sort of info. Christian On Monday, September 12, 2011, james james.ngu...@gmail.com wrote: The Python API or even a Restful call to the reviewboard would be nice. Then I could probably call reviewboard from a curl and check on the changeset status. For instance this is my git log: --- SNIPPET --- commit 08c36a414d56a7e1db26bfd7f5fabe2cb9d0aff7 Author: james ja...@jenkins.sm.kernelfire.com Date: Mon Sep 12 11:50:22 2011 -0700 slim down repo --- SNIPPET --- Couldn't I then use the commit hash to identify the review request along with the git commit changeset? On Sep 12, 11:59 am, Christian Hammond chip...@chipx86.com wrote: There's nothing we provide, as it varies quite a bit between installs, repository types, etc. Right now anything you do requires a fair bit of custom code. We're working on a formal Python API for Review Board, which will make this easier from a development standpoint. From a workflow standpoint, the difficulty is in identifying which commits are tied with which review requests. This is easier on a system like Subversion. Just have some field identifying the review request in the commit message. With Git, you'd have to be careful to have it in the commit message for a single commit, or in the message for a merge, in order for that to work the same. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Sep 12, 2011 at 11:36 AM, james james.ngu...@gmail.com wrote: Is there documentation on how to set this up with post-commit or pre- commit hooks where a user can't push changes into the repository unless the changeset has been reviewed and approved? I'm using git as our repo and so far I've gotten as far as being able to use post-review to submit a review request. Not I need to figure out a way to lock users from pushing to the central repo until their changeset has been reviewed and approved. Is there a workflow for this scenario? James -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Preventing commits from going through if status is still in review stage
On Sep 12, 12:35 pm, Christian Hammond chip...@chipx86.com wrote: No, not necessarily. When you post a diff, it generates a squashed diff, whichay mean the SHA1 will differ. Ah. Got it. We also just have no mechanism today to look up a review request by this sort of info. Yeah. This was more of a wishful feature request for a later release or something. Right now it seems like it's just an auto incremented review id. Christian On Monday, September 12, 2011, james james.ngu...@gmail.com wrote: The Python API or even a Restful call to the reviewboard would be nice. Then I could probably call reviewboard from a curl and check on the changeset status. For instance this is my git log: --- SNIPPET --- commit 08c36a414d56a7e1db26bfd7f5fabe2cb9d0aff7 Author: james ja...@jenkins.sm.kernelfire.com Date: Mon Sep 12 11:50:22 2011 -0700 slim down repo --- SNIPPET --- Couldn't I then use the commit hash to identify the review request along with the git commit changeset? On Sep 12, 11:59 am, Christian Hammond chip...@chipx86.com wrote: There's nothing we provide, as it varies quite a bit between installs, repository types, etc. Right now anything you do requires a fair bit of custom code. We're working on a formal Python API for Review Board, which will make this easier from a development standpoint. From a workflow standpoint, the difficulty is in identifying which commits are tied with which review requests. This is easier on a system like Subversion. Just have some field identifying the review request in the commit message. With Git, you'd have to be careful to have it in the commit message for a single commit, or in the message for a merge, in order for that to work the same. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Sep 12, 2011 at 11:36 AM, james james.ngu...@gmail.com wrote: Is there documentation on how to set this up with post-commit or pre- commit hooks where a user can't push changes into the repository unless the changeset has been reviewed and approved? I'm using git as our repo and so far I've gotten as far as being able to use post-review to submit a review request. Not I need to figure out a way to lock users from pushing to the central repo until their changeset has been reviewed and approved. Is there a workflow for this scenario? James -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
