Re: How to set extra_data for review model in RVB3.0?

Thanks for the suggestion. David. It indeed works! BR > oswicer > > > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know!

Re: How to set extra_data for review model in RVB3.0?

Hi, The ExtraDataMixin exists but none of the built-in code uses it, and I think it's broken. We need to rethink it a bit anyway in light of the new JSON Patch and JSON Merge Patch support that was added in 3.0. For now, I think this will get you up and running: const extraData =

Re: How to set extra_data for review model in RVB3.0?

I haven’t been able to fix it yet. With the holidays coming up, things have been busy, and we’ve had a couple higher-priority bugs taking our time. I’ll make my way back to this soon though. Christian On Tue, Dec 19, 2017 at 18:27 Xy Sui wrote: > Hi Christian, > > Any

Re: How to set extra_data for review model in RVB3.0?

Hi Christian, Any progress on this topic? BR oswicer On Thursday, December 14, 2017 at 7:00:10 PM UTC+8, Xy Sui wrote: > > Hi, > > I'm getting desperate after hours' searching/trying... One of our > extensions doesn't work now in RVB3.0 because previous setExtraData method > doesn't work

Re: How to set extra_data for review model in RVB3.0?

That’s definitely the wrong form for it to be sending. It should show up as “extra_data.veto=1”. You see the same behavior in your extension? That repro case is helpful. I’m going to dig into that. Christian On Thu, Dec 14, 2017 at 22:46 Xy Sui wrote: > Hi, > > I'm testing

Re: How to set extra_data for review model in RVB3.0?

Hi, I'm testing the setExtraData in this way now (also to simply the code demonstration here) In reviewboard/static/rb/js/views/reviewDialogView.es6.js, method "_saveReview". I added/modified 2 lines inside the 1st block f of funcQueue('reviewForm').add:

Re: How to set extra_data for review model in RVB3.0?

I can confirm that when updating rbstopwatch to use setExtraData() followed by a save(), it works properly. I'd need to see what your code and the data from the browser looks like to figure out what's going wrong. Christian On Thu, Dec 14, 2017 at 12:31 PM, Christian Hammond <

Re: How to set extra_data for review model in RVB3.0?

Sorry, I realize rbstopwatch isn't using setExtraData, but rather setting extraData manually. I'm going to toy with the code here, see if I can reproduce the problem. Christian On Thu, Dec 14, 2017 at 12:29 PM, Christian Hammond < christ...@beanbaginc.com> wrote: > Hi, > > Can you show me your

Re: How to set extra_data for review model in RVB3.0?

Hi, Can you show me your code that both sets this and then saves the review, along with what the browser is reporting being sent to and received from the server? (Full headers and payloads would help.) rbstopwatch was indeed broken (fix coming in RB 3.0.2), but once I fixed that, setExtraData

How to set extra_data for review model in RVB3.0?

Hi, I'm getting desperate after hours' searching/trying... One of our extensions doesn't work now in RVB3.0 because previous setExtraData method doesn't work anymore for review model. In my implementation, I wrote one RB.ReviewDialogHook javascript hook with one customized view. And I would