Re: ReviewBoard extension hook

2015-12-15 Thread David Trowbridge
Jerome, The hook that you're looking at is a pluggable way to choose how the "approved" and "approval_failure" fields should behave ( https://www.reviewboard.org/docs/manual/2.5/webapi/2.0/resources/review-request/#fields). These fields are used in things like git hook scripts to automatically

Re: ReviewBoard extension hook

2015-12-15 Thread Jérôme Godbout
Thanks David, that really helpful, I was indeed looking for the signals and got confuse with the hook. I now get the differences between the two now. Thanks again, regards, Jerome On Tue, Dec 15, 2015 at 12:26 PM, David Trowbridge wrote: > Jerome, > > The hook that you're

ReviewBoard extension hook

2015-12-15 Thread jerome
Hi, I'm looking to create a hook extension inside ReviewBoard. I manage to create and install it seem to be recognized and I can enable it. But I think I got the wrong hook and I cannot figure out when it is really called. I try the review-request-approval-hook, but it doesn't seem to be called