Re: SVN post-commit hook for RB - problem logging into RB site via http authentication

2010-02-25 Thread Stodge
This is the simplest patch: 261,262c261,262 self.rb_user = None self.rb_pass = None --- self.rb_user = options.http_username self.rb_pass = options.http_password 2639a2640,2646 parser.add_option(--http-username, dest=http_username,

Re: SVN post-commit hook for RB - problem logging into RB site via http authentication

2010-02-25 Thread Stodge
I created an enhancement request http://code.google.com/p/reviewboard/issues/detail?id=1514 with an attached patch. First ever patch so be kind! On Feb 25, 7:43 am, Stodge sto...@gmail.com wrote: This is the simplest patch: 261,262c261,262         self.rb_user = None         self.rb_pass

SVN post-commit hook for RB - problem logging into RB site via http authentication

2010-02-24 Thread Stodge
My review board site is protected by Apache's basic authentication. So when I run the SVN post-commit hook for review board (from RBTools) it's asking me for a username/password to login to the RB site. I thought this was all taken care of by the post-review script? Or does that only handle

Re: SVN post-commit hook for RB - problem logging into RB site via http authentication

2010-02-24 Thread Stodge
I wonder if post-review could be modified: class ReviewBoardHTTPPasswordMgr(urllib2.HTTPPasswordMgr): Adds HTTP authentication support for URLs. Python 2.4's password manager has a bug in http authentication when the target server uses a non-standard port. This works around

Re: SVN post-commit hook for RB - problem logging into RB site via http authentication

2010-02-24 Thread Christian Hammond
Hi, The --username and --password parameters are only for the user on Review Board. It doesn't handle HTTP authentication. I'd be perfectly happy to accept a patch that adds --http-username and --http-password. Christian -- Christian Hammond - chip...@chipx86.com Review Board -