Issue 3663 in reviewboard: Custom order the diff files

2014-11-06 Thread reviewboard
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 3663 by shaan.h...@gmail.com: Custom order the diff files https://code.google.com/p/reviewboard/issues/detail?id=3663 *** For customer support, please post to reviewbo...@googlegroups.com *** If you have a patch, please

Issue 3666 in reviewboard: rbtools thresholds to warn and/or prevent uploading huge diff

2014-11-06 Thread reviewboard
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 3666 by nano...@gmail.com: rbtools thresholds to warn and/or prevent uploading huge diff https://code.google.com/p/reviewboard/issues/detail?id=3666 *** For customer support, please post to

Re: Issue 3666 in reviewboard: rbtools thresholds to warn and/or prevent uploading huge diff

2014-11-06 Thread reviewboard
Comment #1 on issue 3666 by nano...@gmail.com: rbtools thresholds to warn and/or prevent uploading huge diff https://code.google.com/p/reviewboard/issues/detail?id=3666 reply to myself. For server settings, there is already diffviewer_max_diff_size. So I think we must define it now for

Issue 3667 in reviewboard: Ignore whitespace in diff viewer

2014-11-06 Thread reviewboard
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 3667 by alder...@gmail.com: Ignore whitespace in diff viewer https://code.google.com/p/reviewboard/issues/detail?id=3667 *** For customer support, please post to reviewbo...@googlegroups.com *** If you have a patch,

Re: Issue 3662 in reviewboard: Ability to copy code from the diff view

2014-11-06 Thread reviewboard
Updates: Status: Duplicate Mergedinto: 1094 Comment #1 on issue 3662 by trowb...@gmail.com: Ability to copy code from the diff view https://code.google.com/p/reviewboard/issues/detail?id=3662 This is fixed in 2.0.9 and newer. -- You received this message because this project

Re: Issue 3665 in reviewboard: Copy does not work for new files

2014-11-06 Thread reviewboard
Updates: Status: Duplicate Mergedinto: 3661 Comment #1 on issue 3665 by trowb...@gmail.com: Copy does not work for new files https://code.google.com/p/reviewboard/issues/detail?id=3665 (No comment was entered for this change.) -- You received this message because this

Re: Issue 1094 in reviewboard: Copy/paste source code

2014-11-06 Thread reviewboard
Comment #10 on issue 1094 by trowb...@gmail.com: Copy/paste source code https://code.google.com/p/reviewboard/issues/detail?id=1094 Issue 3662 has been merged into this issue. -- You received this message because this project is configured to send all issue notifications to this address.

Re: Issue 3661 in reviewboard: Unable to select text in a new file when viewing the text of a New File

2014-11-06 Thread reviewboard
Comment #1 on issue 3661 by trowb...@gmail.com: Unable to select text in a new file when viewing the text of a New File https://code.google.com/p/reviewboard/issues/detail?id=3661 Issue 3665 has been merged into this issue. -- You received this message because this project is configured to

Re: Issue 3664 in reviewboard: Changing review owner

2014-11-06 Thread reviewboard
Updates: Status: Duplicate Mergedinto: 2180 Comment #1 on issue 3664 by trowb...@gmail.com: Changing review owner https://code.google.com/p/reviewboard/issues/detail?id=3664 (No comment was entered for this change.) -- You received this message because this project is

Re: Issue 2180 in reviewboard: Allow ownership of review requests to be claimed

2014-11-06 Thread reviewboard
Comment #9 on issue 2180 by trowb...@gmail.com: Allow ownership of review requests to be claimed https://code.google.com/p/reviewboard/issues/detail?id=2180 Issue 3664 has been merged into this issue. -- You received this message because this project is configured to send all issue

Re: Issue 3667 in reviewboard: Ignore whitespace in diff viewer

2014-11-06 Thread reviewboard
Updates: Status: NeedInfo Comment #1 on issue 3667 by trowb...@gmail.com: Ignore whitespace in diff viewer https://code.google.com/p/reviewboard/issues/detail?id=3667 In the bottom-right of the first box, there's a toggle: Show/Hide Whitespace Changes. Does this not do what you

Re: Issue 3667 in reviewboard: Ignore whitespace in diff viewer

2014-11-06 Thread reviewboard
Updates: Status: NotABug Comment #3 on issue 3667 by trowb...@gmail.com: Ignore whitespace in diff viewer https://code.google.com/p/reviewboard/issues/detail?id=3667 (No comment was entered for this change.) -- You received this message because this project is configured to send all

Re: Issue 3659 in reviewboard: RBTools 0.6.2 not able to differentiate the binary content

2014-11-06 Thread reviewboard
Updates: Status: NeedInfo Comment #2 on issue 3659 by trowb...@gmail.com: RBTools 0.6.2 not able to differentiate the binary content https://code.google.com/p/reviewboard/issues/detail?id=3659 (No comment was entered for this change.) -- You received this message because this

Re: Issue 3659 in reviewboard: RBTools 0.6.2 not able to differentiate the binary content

2014-11-06 Thread reviewboard
Comment #3 on issue 3659 by marc.fo...@gmail.com: RBTools 0.6.2 not able to differentiate the binary content https://code.google.com/p/reviewboard/issues/detail?id=3659 Yes a jks file is binary. using an older version of rbt that supports post-review the review is still posted even when

Re: Issue 3659 in reviewboard: RBTools 0.6.2 not able to differentiate the binary content

2014-11-06 Thread reviewboard
Comment #4 on issue 3659 by trowb...@gmail.com: RBTools 0.6.2 not able to differentiate the binary content https://code.google.com/p/reviewboard/issues/detail?id=3659 I don't see how this is a bug. You want a review request with no diffs? -- You received this message because this project is

Re: Issue 3659 in reviewboard: RBTools 0.6.2 not able to differentiate the binary content

2014-11-06 Thread reviewboard
Comment #5 on issue 3659 by shahgunj...@gmail.com: RBTools 0.6.2 not able to differentiate the binary content https://code.google.com/p/reviewboard/issues/detail?id=3659 We want review request with diffs, using RBTools 0.6.2. -- You received this message because this project is configured

Re: Issue 3659 in reviewboard: RBTools 0.6.2 not able to differentiate the binary content

2014-11-06 Thread reviewboard
Comment #6 on issue 3659 by trowb...@gmail.com: RBTools 0.6.2 not able to differentiate the binary content https://code.google.com/p/reviewboard/issues/detail?id=3659 I *really* don't understand what you mean. We've never done diffs of binary files. What behavior are you seeing with the