Re: Issue 1918 in reviewboard: git diffs are not parsed correctly

2014-06-16 Thread reviewboard
Comment #17 on issue 1918 by chip...@gmail.com: git diffs are not parsed correctly http://code.google.com/p/reviewboard/issues/detail?id=1918 Not a problem. Glad we got that figured out! It's nearly 4AM here, so I'm crashing. Have a good day! -- You received this message because this projec

Re: Issue 1918 in reviewboard: git diffs are not parsed correctly

2014-06-16 Thread reviewboard
Comment #16 on issue 1918 by ivan.gav...@gmail.com: git diffs are not parsed correctly http://code.google.com/p/reviewboard/issues/detail?id=1918 You were right, ticket 3800 is created for SVN repository. After we've migrated svn to git the .reviewboardrc setting still pointed to SVN repo

Re: Issue 1918 in reviewboard: git diffs are not parsed correctly

2014-06-16 Thread reviewboard
Comment #15 on issue 1918 by chip...@gmail.com: git diffs are not parsed correctly http://code.google.com/p/reviewboard/issues/detail?id=1918 The web UI actually uses the API call to do the upload. It must have to do with how the request's payload is being formatted. Though this shouldn't

Re: Issue 1918 in reviewboard: git diffs are not parsed correctly

2014-06-16 Thread reviewboard
Comment #14 on issue 1918 by ivan.gav...@gmail.com: git diffs are not parsed correctly http://code.google.com/p/reviewboard/issues/detail?id=1918 It's works when feeding diff manually with web interface but not with API call, maybe the problem is there? -- You received this message becaus

Re: Issue 1918 in reviewboard: git diffs are not parsed correctly

2014-06-16 Thread reviewboard
Comment #13 on issue 1918 by ivan.gav...@gmail.com: git diffs are not parsed correctly http://code.google.com/p/reviewboard/issues/detail?id=1918 I'm using 2.0.2 -- You received this message because this project is configured to send all issue notifications to this address. You may adjust

Re: Issue 1918 in reviewboard: git diffs are not parsed correctly

2014-06-16 Thread reviewboard
Comment #12 on issue 1918 by chip...@gmail.com: git diffs are not parsed correctly http://code.google.com/p/reviewboard/issues/detail?id=1918 What version of Review Board? I just fed that diff into my instance, and it had no problem parsing it. -- You received this message because this proj

Re: Issue 1918 in reviewboard: git diffs are not parsed correctly

2014-06-16 Thread reviewboard
Comment #11 on issue 1918 by ivan.gav...@gmail.com: git diffs are not parsed correctly http://code.google.com/p/reviewboard/issues/detail?id=1918 Attaching raw diff, raw request and raw response files. I'm generating diff based on what I found in https://github.com/reviewboard/rbtools/blob

Re: Issue 1918 in reviewboard: git diffs are not parsed correctly

2014-06-16 Thread reviewboard
Comment #10 on issue 1918 by chip...@gmail.com: git diffs are not parsed correctly http://code.google.com/p/reviewboard/issues/detail?id=1918 Thanks for the info. A few more questions that would help. If you can attach the raw diff, I can take a deeper look into it. Can you show me the ways

Re: Issue 1918 in reviewboard: git diffs are not parsed correctly

2014-06-16 Thread reviewboard
Comment #9 on issue 1918 by ivan.gav...@gmail.com: git diffs are not parsed correctly http://code.google.com/p/reviewboard/issues/detail?id=1918 I can attach http request/response dump from Charles if that helps. -- You received this message because this project is configured to send all i

Re: Issue 1918 in reviewboard: git diffs are not parsed correctly

2014-06-16 Thread reviewboard
Comment #8 on issue 1918 by ivan.gav...@gmail.com: git diffs are not parsed correctly http://code.google.com/p/reviewboard/issues/detail?id=1918 I'm using API to attach git diffs to the ticket. No matter how I generate git diff i'm getting the error: { "fields": { "path": ["No v

Re: Issue 1918 in reviewboard: git diffs are not parsed correctly

2014-06-16 Thread reviewboard
Comment #7 on issue 1918 by chip...@gmail.com: git diffs are not parsed correctly http://code.google.com/p/reviewboard/issues/detail?id=1918 Sorry, this is an old bug and much has changed since. You're going to have to provide more information than that. I don't really even know what you

Re: Issue 1918 in reviewboard: git diffs are not parsed correctly

2014-06-16 Thread reviewboard
Comment #6 on issue 1918 by ivan.gav...@gmail.com: git diffs are not parsed correctly http://code.google.com/p/reviewboard/issues/detail?id=1918 This is obviously a bug. ReviewBoard provides API for uploading diffs, we can't use rbt post to work around bugs in those :( -- You received thi

Re: Issue 1918 in reviewboard: git diffs are not parsed correctly

2011-02-08 Thread reviewboard
Updates: Status: NotABug Comment #5 on issue 1918 by chip...@gmail.com: git diffs are not parsed correctly http://code.google.com/p/reviewboard/issues/detail?id=1918 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups

Re: Issue 1918 in reviewboard: git diffs are not parsed correctly

2011-02-08 Thread reviewboard
Updates: Status: UserError Owner: chipx86 Comment #4 on issue 1918 by chip...@gmail.com: git diffs are not parsed correctly http://code.google.com/p/reviewboard/issues/detail?id=1918 If you're using git-svn then you have to use post-review. It knows how to format compatible

Re: Issue 1918 in reviewboard: git diffs are not parsed correctly

2011-02-08 Thread reviewboard
Comment #3 on issue 1918 by champagn...@gmail.com: git diffs are not parsed correctly http://code.google.com/p/reviewboard/issues/detail?id=1918 I am actually using git-svn as a client for a subversion repository. ReviewBoard is hooked up to the svn repo. I imagine this isn't a common sc

Re: Issue 1918 in reviewboard: git diffs are not parsed correctly

2011-02-08 Thread reviewboard
Updates: Status: NeedInfo Labels: -Type-Defect Type-Support Comment #2 on issue 1918 by chip...@gmail.com: git diffs are not parsed correctly http://code.google.com/p/reviewboard/issues/detail?id=1918 Can you please show me exactly what you use to generate the diff? Please s

Re: Issue 1918 in reviewboard: git diffs are not parsed correctly

2011-02-08 Thread reviewboard
Comment #1 on issue 1918 by champagn...@gmail.com: git diffs are not parsed correctly http://code.google.com/p/reviewboard/issues/detail?id=1918 It worked if I touched up the diff to look exactly like a subversion diff. I think the key was adding "(revision )" and "(working copy)" afte

Issue 1918 in reviewboard: git diffs are not parsed correctly

2010-12-16 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1918 by owen.omalley: git diffs are not parsed correctly http://code.google.com/p/reviewboard/issues/detail?id=1918 What version are you running? 1.5 What's the URL of the page containing the problem? uploading a diff What