Issue 826 in reviewboard: Publishing screenshot comment reviews fails and duplicates comments
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 826 by timw.at.work: Publishing screenshot comment reviews fails and duplicates comments http://code.google.com/p/reviewboard/issues/detail?id=826 *NOTE: Do not post confidential information in this bug report.* What's the URL of the page containing the problem? http://server/r/123/s/456/ What steps will reproduce the problem? 1. Comment on a portion of a screenshot 2. Comment on a portion of another another in the same review request 3. Edit the review (add some review text separate from the comments) 4. Publish the review 5. Re-visit the review request page What is the expected output? What do you see instead? Expected: After 5, the review is published, and it shows up as you just left it in step 4. Actual: After 4, multiple "error" boxes appear in the page body. The still-draft review now has four comments, where each entered comment has been duplicated and attached to a seemingly-unrelated screenshot (from a different review request). What operating system are you using? What browser? Ubuntu 8.10 x86_64's Firefox 3.0.5 Please provide any additional information below. I traced the HTTP traffic, and the POSTs seem to be reasonable. As in Issue 820, I see comments double-posting (once on entry, and once milliseconds before the publish POST occurs). Once the described error has occurred, I notice in the Admin tool that the review indeed links to 4 comments, and the most recent two are linked to unrelated screenshots. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 818 in reviewboard: Name conflict in djblets.datagrid.grids.DataGrid
Comment #2 on issue 818 by iamzhanghu: Name conflict in djblets.datagrid.grids.DataGrid http://code.google.com/p/reviewboard/issues/detail?id=818 Adding a prefix/suffix to the column should work. But it will effect many of my exsited codes. So I prefer to address this issue in djblets. I guess most guys using djblets as a kind of add-on. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 818 in reviewboard: Name conflict in djblets.datagrid.grids.DataGrid
Comment #1 on issue 818 by timw.at.work: Name conflict in djblets.datagrid.grids.DataGrid http://code.google.com/p/reviewboard/issues/detail?id=818 Consider an alternative (to the original poster): namespace your fields. Since Django doesn't do so already, consider providing your own helper, def _colname(unqualifiedName): return "my_namespace_" + unqualifiedName Then use _colname() everywhere you name a column. The rb authors could do this to, but they are the purveyor of the base model, so that doesn't seem like it warrants namespacing. If you're referring to the 'id' python class member, then you might be SOL (I have next to no python experience). If that's the case, then it probably makes sense for there to be a 'best practice' for explicitly namespacing your fields when you extend classes you didn't write and/or don't control (in some languages, you can be warned when you are accidentally overriding/shadowing a method/field, but I am not sure that would be possible in python). -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 822 in reviewboard: post-review: Locale for svn should be set to C
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 822 by lukasz.jernas: post-review: Locale for svn should be set to C http://code.google.com/p/reviewboard/issues/detail?id=822 What steps will reproduce the problem? 1. run post-review in an environment different than C or en 2. watch it fail on detecting the repository format deej...@sulaco:~/PRACA/osm/merkaartor$ ./post-review The current directory does not contain a checkout from a supported source code repository. deej...@sulaco:~/PRACA/osm/merkaartor$ locale LANG=pl_PL.UTF-8 LC_CTYPE="pl_PL.UTF-8" LC_NUMERIC="pl_PL.UTF-8" LC_TIME="pl_PL.UTF-8" LC_COLLATE="pl_PL.UTF-8" LC_MONETARY="pl_PL.UTF-8" LC_MESSAGES="pl_PL.UTF-8" LC_PAPER="pl_PL.UTF-8" LC_NAME="pl_PL.UTF-8" LC_ADDRESS="pl_PL.UTF-8" LC_TELEPHONE="pl_PL.UTF-8" LC_MEASUREMENT="pl_PL.UTF-8" LC_IDENTIFICATION="pl_PL.UTF-8" LC_ALL= What is the expected output? What do you see instead? post-review should set it's own locale to C and then execute any checks and commands on the repository it's run in. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 820 in reviewboard: It is possible for a user to create multiple draft reviews, leading to an unviewable review
Updates: Status: Confirmed Owner: chipx86 Labels: -Priority-Medium Priority-Critical Milestone-Release1.0 Comment #2 on issue 820 by chipx86: It is possible for a user to create multiple draft reviews, leading to an unviewable review http://code.google.com/p/reviewboard/issues/detail?id=820 I've recently noticed this as well. We need to make this a priority for alpha 2. Thanks for all the research on it. I'm going to go through later and see if I can get a solid repro case and get this fixed. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Comment on GettingStarted in reviewboard
Comment by chipx86: andreas: We're working on supporting fastcgi better, as well as mod_wsgi. A fastcgi init script is coming in alpha 2. I'm sorry the configuration tools caused you problems, but ultimately it's saved many of our users a lot of frustration. The number of support requests since reducing rb-site has dropped dramatically. Most people don't know how to set up Apache correctly, and providing sample files or documentation was not good enough. These concerns are best taken to the mailing list, as the comments here are largely ignored and will soon go away. For more information: http://code.google.com/p/reviewboard/wiki/GettingStarted --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 721 in reviewboard: Diff Viewer SCMError - callback_get_login required
Updates: Status: NeedInfo Comment #4 on issue 721 by chipx86: Diff Viewer SCMError - callback_get_login required http://code.google.com/p/reviewboard/issues/detail?id=721 The error is definitely opaque, and not sent by us. Do you know what version of PySVN you have? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 813 in reviewboard: Non C locale patches fail
Comment #3 on issue 813 by timw.at.work: Non C locale patches fail http://code.google.com/p/reviewboard/issues/detail?id=813 It surprises me that a tool to generate data interchange files (svn diff) would localize the internal diff markers (much like 'diff' doesn't consult the user's preferred date format when printing the file timestamp). It seems like either 1) svn shouldn't be localizing diff output, or 2) svn should have a simple command-line way to override that behavior. It is somewhat sad that the diff format (or svn's extension of that) cannot support separate per-chunk or per-file metadata. You (lukasz) are right that rb does search for '(revision ...)', and that's probably the easiest restriction to fix (as long as the parsing code is strict enough to require it be at the end of the path). -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 821 in reviewboard: Updating a diff with a diff + parent diff does not work.
Updates: Status: NeedInfo Comment #1 on issue 821 by chipx86: Updating a diff with a diff + parent diff does not work. http://code.google.com/p/reviewboard/issues/detail?id=821 What version/nightly are you using? Both Review Board and Djblets. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 796 in reviewboard: post-review tool doesn't create a review if reviewboard was installed on a url that is not root at '/', e.g. '/reviews'
Updates: Status: Fixed Owner: chipx86 Labels: Milestone-Release1.0 Component-Scripts Comment #5 on issue 796 by chipx86: post-review tool doesn't create a review if reviewboard was installed on a url that is not root at '/', e.g. '/reviews' http://code.google.com/p/reviewboard/issues/detail?id=796 Fixed in r1676. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 824 in reviewboard: Enter key does nothing in the Attach Screenshot dialog
Updates: Status: Fixed Owner: chipx86 Labels: Milestone-Release1.0 Component-Screenshots Usability Keyboard Comment #1 on issue 824 by chipx86: Enter key does nothing in the Attach Screenshot dialog http://code.google.com/p/reviewboard/issues/detail?id=824 This is fixed in the UI rewrite in 1.0 alpha 1. We'll upgrade the servers at work probably this week. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 824 in reviewboard: Enter key does nothing in the Attach Screenshot dialog
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 824 by jamesdlin: Enter key does nothing in the Attach Screenshot dialog http://code.google.com/p/reviewboard/issues/detail?id=824 *NOTE: Do not post confidential information in this bug report.* What's the URL of the page containing the problem? What steps will reproduce the problem? 1. Try attaching a screenshot to a review request. 2. Fill out the caption and path. 3. Press the enter key. What is the expected output? What do you see instead? Something seems to happen (I see my browser's throbber moving momentarily), but the screenshot doesn't actually seem to be added to the review request. I would expect it to submit, as if I had clicked on the "Attach" button. What operating system are you using? What browser? Windows XPx64sp2 with Firefox 3.0.5. Please provide any additional information below. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Comment on GettingStarted in reviewboard
Comment by andreas.kloeckner: Wow, installing RB is really unnecessarily hard. 1) The rb-site tool somehow forgot to create the fcgi server script that I was supposed to run, and I have no idea what to put in there. (find -name '*fcgi*' also draws a blank) 2) Don't hide installations behind opaque (if shiny) configuration tools. Ultimately, you're not doing your users a favor. I can set up Django apps just fine, but I have *no* idea how to set up RB. I've given up. Unrelatedly, you may want to think about supporting mod_wsgi. For me, it's much less crashy than mod_python. Django likes it, too. For more information: http://code.google.com/p/reviewboard/wiki/GettingStarted --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 821 in reviewboard: Updating a diff with a diff + parent diff does not work.
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 821 by d...@compsci.ca: Updating a diff with a diff + parent diff does not work. http://code.google.com/p/reviewboard/issues/detail?id=821 What steps will reproduce the problem? 1. Make a review request with just a diff. 2. Try to update the diff and a parent diff. 3. Press Upload. 4. Nothing happens, no error, the upload diff box just stays there and the review request is not changed at all. What is the expected output? What do you see instead? Expected output: The upload diff box going away and thre review request being updated with the new diff. Instead: The upload diff box statys up and nothing happens when the upload button is pressed. The review request is left unchanged. Note: Update diff works fine when no parent diff is given. What operating system are you using? What browser? Server: Gentoo Linux with apache. Client: Windows Vista and Firefox 3.0.5 -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 820 in reviewboard: It is possible for a user to create multiple draft reviews, leading to an unviewable review
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 820 by timw.at.work: It is possible for a user to create multiple
draft reviews, leading to an unviewable review
http://code.google.com/p/reviewboard/issues/detail?id=820
*NOTE: Do not post confidential information in this bug report.*
What's the URL of the page containing the problem?
"View diff" page on another user's published review
What steps will reproduce the problem?
1. Comment on multiple lines in the diff
2. Edit some of your comments (by clicking on the comment markers, changing
the text, and hitting Save)
3. Hit "Edit Review" on the green draft-review banner
4. Fill in some review text and change one or more of the comments
5. Hit "Publish Review"
I have not minimized the steps, yet, but I've only just encountered this
recently (and once). It may be necessary to further click on some
just-entered comments and click cancel.
What is the expected output? What do you see instead?
Expected:
The (single) review I have been composing is published, and an email is
sent.
Actual:
An email is sent for the review I expected, but the publish action
redirects me to an exception page ('get()' returning multiple rows instead
of 1). The account who just published the review can no longer access that
review (the same exception page shows).
What operating system are you using? What browser?
Ubuntu 8.10 x86_64's Firefox 3.0.5
Please provide any additional information below.
If it matters, there were other reviews (with code references) on an older
diff. I think I did not click on any markers for these older reviews, since
I was reviewing a newer diff with no existing reviews.
Unfortunately, I didn't capture the stack trace.
It is likely easy to reproduce the stack trace: just use the Admin tool to
toggle the 'Public' field to 'false' for at least two reviews from the same
user in the same review request, then try to view the review request as
that user.
The real issue seems to be caused by several factors:
1) get() is used when retrieving a user's draft review(s) for a given
review request,
2) the JSON API and/or the underlying model does not prevent the creation
of multiple (user, review request, non-Public review) sets, and
3) some of the JS in the diff viewer page is (accidentally or
intentionally) trying to create a new review request instead of modifying
the current draft in at least one situation.
If multiple drafts are reasonable, (1) is the only problem, and some GUI
work may be in order.
It seems to me that the real problem is (3).
The existence of (2) allows (3) to violate the model's invariants so that
it becomes impossible for the user to fix it.
Workaround:
If you encounter this (an exception when trying to view a review), either
(1) view it anonymously, or (2) log in as Administrator and find the
offending reviews (either delete them or mark them as Public).
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---
Issue 805 in reviewboard: post-review script fails when using CVS.
Updates: Status: Fixed Owner: chipx86 Labels: -Priority-Medium Priority-High Milestone-Release1.0 Component-Scripts Comment #3 on issue 805 by chipx86: post-review script fails when using CVS. http://code.google.com/p/reviewboard/issues/detail?id=805 Thanks. Fixed in r1674. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 721 in reviewboard: Diff Viewer SCMError - callback_get_login required
Comment #3 on issue 721 by dgfitch: Diff Viewer SCMError - callback_get_login required http://code.google.com/p/reviewboard/issues/detail?id=721 This error also occurs if you HAVE entered login information, and then it starts failing for some reason (expired password, in my case) -- the callback_get_login is pretty opaque to me as an idiot administrator, so maybe it just needs a better message. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 825 in reviewboard: Support for Microsoft Team Services/Team Foundation repositories
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 825 by benjamin.podszun: Support for Microsoft Team Services/Team Foundation repositories http://code.google.com/p/reviewboard/issues/detail?id=825 Supporting the given product as SCM backend (primary) or even bugtracker (very low prio) would be awesome. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
