Re: Issue 1113 in reviewboard: post-review tool cannot handle revisions with deleted files in Subversion
Comment #4 on issue 1113 by rix0...@gmail.com: post-review tool cannot handle revisions with deleted files in Subversion http://code.google.com/p/reviewboard/issues/detail?id=1113 Still not fixed in 0.3.2. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2101 in reviewboard: Files changed links don't work with Google Chrome 12.0.742.53
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2101 by lauren...@gmail.com: Files changed links don't work with Google Chrome 12.0.742.53 http://code.google.com/p/reviewboard/issues/detail?id=2101 What version are you running? 1.5.5 What's the URL of the page containing the problem? internal to VMware What steps will reproduce the problem? 1. Open any review board page 2. Try to click on a Files Changed link at the top of the bottom of the page 3. it just scrolls up a few lines instead of going to the correct location within the page What operating system are you using? What browser? Mac OS 10.6.6, Google Chrome 12.0.742.53 it works fine with Firefox on the same machine. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2102 in reviewboard: Ship it false positive during review submission
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2102 by bela.lub...@gmail.com: Ship it false positive during review submission http://code.google.com/p/reviewboard/issues/detail?id=2102 ReviewBoard 1.5.5 URL: https://reviewboard.eng.vmware.com/r/%d/ Steps: 1. Click Review 2. Enter some text 3. Leave [ ] Ship it UN-checked 4. Put mouse cursor on Publish Review 5. Put eyes on [ ] Ship it button 6. Click (thus performing Publish Review) 7. Observe that [v] Ship it appears (a grey check mark) while the submission is happening 8. Observe that the review that's emailed out and posted does *not* say Ship it Expected: (a) [ ] Ship it button does not temporarily claim to be checked; (b) resulting review does not say Ship it! Actual: (a) button *does* temporarily and heart-stoppingly claim to be checked; (b) resulting review correctly does not say Ship it! Therefore this is a cosmetic, not functional bug; but could easily cause human action (like posting another review saying Ignore the ship it on that last review, it got turned on by mistake somehow when in fact that didn't really happen). OS: Ubuntu 9.10 x86_64 Browser: Opera 11.10 COUNTEREXAMPLE: tried with IE8, Win XP SP3 x86_32, checkmark did not appear. Therefore, some degree of browser interaction. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2102 in reviewboard: Ship it false positive during review submission
Comment #1 on issue 2102 by bela.lub...@gmail.com: Ship it false positive during review submission http://code.google.com/p/reviewboard/issues/detail?id=2102 BTW, this is similar to issue 788, however 788 appears to have been talking about Ship it actually being turned on in the submitted review, not just briefly *displayed* as on during submission. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2102 in reviewboard: Ship it false positive during review submission
Updates: Status: ThirdParty Labels: Browser Comment #2 on issue 2102 by chip...@gmail.com: Ship it false positive during review submission http://code.google.com/p/reviewboard/issues/detail?id=2102 It's actually a browser bug. We don't do anything but disable the entry. Opera is drawing the disabled state with the checkbox, which is very much a bug on their end. Certainly an annoying one, but I don't think we can do anything about it. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2005 in reviewboard: IE support broken in 1.6beta1
Comment #6 on issue 2005 by ben.al...@gmail.com: IE support broken in 1.6beta1 http://code.google.com/p/reviewboard/issues/detail?id=2005 I can confirm this behavior. I was running ReviewBoard 1.5.5 with no problems, but upon upgrading to 1.6 beta 2 I started having problems with Internet Explorer. None of the review request fields are editable (the pencil icons are also missing), and buttons like Publish and Download Diff don't do anything when clicked on. I can also confirm that accessing the server (which is on our local intranet) using an IP address instead of a DNS name results in everything working as expected. I am seeing this behavior in IE9, but colleagues have reported the same behavior in IE7. There seem to be some Javascript problems when loading the page. Here's what IE9's web developer console told me: SCRIPT1028: Expected identifier, string or number datastore.js?1305235942, line 154 character 13 SCRIPT1028: Expected identifier, string or number ui.autocomplete.min.js?1305235942, line 1 character 5860 SCRIPT5009: 'RB' is undefined reviews.js?1305235942, line 8 character 1 SCRIPT5007: Unable to get value of the property 'nodeType': object is null or undefined jquery-1.3.2.min.js, line 19 character 13138 The first two errors correspond to commas that are immediately followed by a closing curly-brace. The third error indicates that reviews.js doesn't recognize the 'RB' object, but since this is defined in datastore.js I'm assuming that this is a side effect of the first error. I haven't yet been able to decipher the fourth error. Removing these extraneous commas seems to fix the problem on my system. Attached are diffs against datastore.js and autocomplete.min.js. These changes were tested in IE7, IE9, and Firefox 4.0.1. Using these changes results in zero Javascript error messages on the debug console for both IE and Firefox. Attachments: datastore.js.diff 775 bytes ui.autocomplete.min.js.diff 20.1 KB -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2005 in reviewboard: IE support broken in 1.6beta1
Comment #7 on issue 2005 by ben.al...@gmail.com: IE support broken in 1.6beta1 http://code.google.com/p/reviewboard/issues/detail?id=2005 FYI, the previous patch to ui.autocomplete.min.js corresponds to removing the comma at the end of line 431 in ui.autocomplete.js. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
