Re: Issue 3191 in reviewboard: consequent searches crash with 'initVM() must be called first' error
Comment #3 on issue 3191 by bod...@gmail.com: consequent searches crash with 'initVM() must be called first' error http://code.google.com/p/reviewboard/issues/detail?id=3191 Thanks for comments guys. Do you have any estimates, when the 2.0 final release will be available? Thanks, Bogdan -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Issue 3193 in reviewboard: RBTools 0.5.5 drops Python 2.4 compatibility
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3193 by dpr...@gmail.com: RBTools 0.5.5 drops Python 2.4 compatibility http://code.google.com/p/reviewboard/issues/detail?id=3193 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be rejected. *** *** For customer support, please post to reviewbo...@googlegroups.com *** *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** Do not post confidential information in this bug report! What version are you running? 0.5.5 What steps will reproduce the problem? 1. Byte compile rbtools using Python 2.4 2. Error will be raised on setup_repo.py What is the expected output? What do you see instead? File /usr/lib/python2.4/site-packages/rbtools/commands/setup_repo.py, line 100 except IOError as e: ^ SyntaxError: invalid syntax What operating system are you using? What browser? RHEL 5.9 (64-bit) Please provide any additional information below. This appears to be the only location in the code where new exception raising syntax is used. Reertins this file to use the old method should bring back compatibility with Python 2.4 and later. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3193 in reviewboard: RBTools 0.5.5 drops Python 2.4 compatibility
Comment #1 on issue 3193 by dpr...@gmail.com: RBTools 0.5.5 drops Python 2.4 compatibility http://code.google.com/p/reviewboard/issues/detail?id=3193 A patch has been submitted for this issue to ReviewBoard. https://reviews.reviewboard.org/r/5267/ -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3022 in reviewboard: rb-site manage index does not work
Comment #14 on issue 3022 by e...@plaxis.com: rb-site manage index does not work http://code.google.com/p/reviewboard/issues/detail?id=3022 I think I have solved part of the problem :D In our company, we have a 'commit-reader'-script running on the codereview server, which monitors any svn-commits. For each such commit, a draft review-request (or update review, depending on the commit-message) is created. During initialization of this script, it tries to synchronize svn and Review Board, by issuing many webapi-requests onto the Review Board server in order to find out which svn-revisions have already been added to Review Board. However, each webapi http-request creates a new record in the django_sessions-table. This gave problems, as the hard-disk quickly ran out of memory. In order to fix this, I 'patched' the Sessions-middleware, by creating the following file (about 2 years ago): # settings_local_sessionmiddleware.py == from django.contrib.sessions.middleware import SessionMiddleware def dontsave(must_create=True): pass class PatchedSessionMiddleware(SessionMiddleware): def process_request(self, request): super(PatchedSessionMiddleware, self).process_request(request) # Because the commit_reader performs lots of requests to /api/... urls, # for each request a session-id would be stored in the database. # This would grow the database in size very quickly. # # This check prevents that. if request.path_info[0:5] == '/api/': request.session.save = dontsave # First import the original MIDDLEWARE_CLASSES-list from reviewboard.settings import MIDDLEWARE_CLASSES # Now overwrite the SessionMiddleware-class with our patched version cls = SessionMiddleware.__module__ + '.' + SessionMiddleware.__name__ idx = MIDDLEWARE_CLASSES.index(cls) MIDDLEWARE_CLASSES[idx] = __name__ + '.' + PatchedSessionMiddleware.__name__ # And finally I added the following line to the settings_local.py file: from settings_local_sessionmiddleware import MIDDLEWARE_CLASSES Apparently, importing this file was the cause of the current problem (perhaps due to a circular dependency?). By removing this line, it looks like everything works again. Indexing now works fine, as well as the 'rb-site manage shell' (although issuing 'print settings.__file__' still complains about the 'Settings' object not having this attribute). The only issue that remains is the Sessions-middleware. If I inspect my database, I see: relation | size -+- public.django_session_pkey | 1785 MB public.django_session_expire_date | 1030 MB public.django_session | 699 MB pg_toast.pg_toast_16671 | 203 MB public.diffviewer_filediff | 70 MB pg_toast.pg_toast_119386| 51 MB public.diffviewer_filediffdata | 19 MB public.reviews_reviewrequest| 3776 kB public.diffviewer_filediff_diff_hash_id | 3040 kB public.diffviewer_filediff_diff_hash_id_like| 3040 kB public.reviews_comment | 2752 kB pg_toast.pg_toast_16671_index | 2600 kB public.diffviewer_filediff_diffset_id | 2088 kB public.changedescs_changedescription| 1912 kB public.diffviewer_filediff_parent_diff_hash_id_like | 1848 kB public.diffviewer_filediff_parent_diff_hash_id | 1840 kB public.diffviewer_filediffdata_pkey | 1776 kB public.diffviewer_filediff_pkey | 1728 kB public.reviews_review | 1424 kB public.diffviewer_diffset | 1136 kB As can be seen, the session-data uses quite some space. Furthermore, I believe I already emptied the django_session table back then, when I created the patched middleware-class. Is this a known problem and is there a better way to solve this? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Issue 3194 in reviewboard: Automatically determine subversion branch
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 3194 by daniel.f...@remcom.com: Automatically determine subversion branch http://code.google.com/p/reviewboard/issues/detail?id=3194 *** For customer support, please post to reviewbo...@googlegroups.com *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** Do not post confidential information in this enhancement request! What version are you running? ReviewBoard 1.7.21, rbt tools 0.5.5 What's the URL of the page this enhancement relates to, if any? http://mercury/admin/db/scmtools/repository/add/ Describe the enhancement and the motivation for it. We use subversion with a repository that contains dozens of sub-repositories each with dozens of branches. For instance, our base repository path may be https://svn/, under that is https://svn/repo1 https://svn/repo2 https://svn/repo3 ... and within a repo is https://svn/repo1/branches/branch1 https://svn/repo1/branches/branch2 https://svn/repo1/branches/branch3 ... It would be have ReviewBoard know the exact branch the subversion diff is created from. Using rbt post from the branch in question, this seems quite doable. The current workflow is all users need to manually type in the branch (or put it in each .reviewboardrc file in each branch they work on). Of course this is done inconsistently. rbt post would ideally be able to pull this from the URL of the working copy it is run from. What operating system are you using? What browser? Windows 7, Google Chrome 32 Please provide any additional information below. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Issue 3195 in reviewboard: Enable rbt post --guess-summary for subversion
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 3195 by daniel.f...@remcom.com: Enable rbt post --guess-summary for subversion http://code.google.com/p/reviewboard/issues/detail?id=3195 *** For customer support, please post to reviewbo...@googlegroups.com *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** Do not post confidential information in this enhancement request! What version are you running? ReviewBoard 1.7.21, rbt tools 0.5.5 What's the URL of the page this enhancement relates to, if any? NA - rbt tools feature Describe the enhancement and the motivation for it. Enable rbt post --guess-summary (and --guess-description!) based on latest subversion commit. This is enabled for git/hg/mercurial etc but not subversion. What operating system are you using? What browser? Windows 7, Chrome 32 Please provide any additional information below. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Issue 3196 in reviewboard: Would be good to add support web links in the various field including the bugs field
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 3196 by jatt...@gmail.com: Would be good to add support web links in the various field including the bugs field http://code.google.com/p/reviewboard/issues/detail?id=3196 What version are you running? - Review Board 1.7.20 What's the URL of the page this enhancement relates to, if any? http://mtv-rev001.corp.skyfire.com/reviews/r/42/ Describe the enhancement and the motivation for it. ReviewBoard is not integrated with Jira and so it's in the Bugs field it's not possible to link a bug. I tried entering a url e.g. https://jira.skyfire.com/browse/DFDR-10677, but it is not clickable. What operating system are you using? What browser? Windows7 Please provide any additional information below. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3193 in reviewboard: RBTools 0.5.5 drops Python 2.4 compatibility
Updates: Status: PendingReview Labels: Milestone-RBTools-Release0.5 Component-RBTools Comment #2 on issue 3193 by chip...@gmail.com: RBTools 0.5.5 drops Python 2.4 compatibility http://code.google.com/p/reviewboard/issues/detail?id=3193 Thanks for the fix. Just an FYI, we'll soon be releasing RBTools 0.6, and we will be dropping Python 2.4 support officially. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3196 in reviewboard: Would be good to add support web links in the various field including the bugs field
Updates: Status: NotABug Comment #1 on issue 3196 by chip...@gmail.com: Would be good to add support web links in the various field including the bugs field http://code.google.com/p/reviewboard/issues/detail?id=3196 If you set the Bug Tracker field for the repository to https://jira.skyfire.com/browse/%s, then all you have to do is put DFDR-10677 in the bug field of a review request and it'll be clickable. Give that a try and let me know if you have trouble. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3191 in reviewboard: consequent searches crash with 'initVM() must be called first' error
Comment #4 on issue 3191 by chip...@gmail.com: consequent searches crash with 'initVM() must be called first' error http://code.google.com/p/reviewboard/issues/detail?id=3191 It's going to depend on beta 2 feedback. We should be releasing beta 2 today, so you can give that a try when it's announced. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3079 in reviewboard: rbt post --open doesn't open the correct URL
Comment #1 on issue 3079 by iander...@mac.com: rbt post --open doesn't open the correct URL http://code.google.com/p/reviewboard/issues/detail?id=3079 It looks like this got fixed by RBTools 0.5.5 -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3079 in reviewboard: rbt post --open doesn't open the correct URL
Updates: Status: Fixed Comment #2 on issue 3079 by trowb...@gmail.com: rbt post --open doesn't open the correct URL http://code.google.com/p/reviewboard/issues/detail?id=3079 Thanks for the update. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Issue 3197 in reviewboard: rbt post requires summary and description for existing changenum (perforce)
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3197 by jaabr...@gmail.com: rbt post requires summary and description for existing changenum (perforce) http://code.google.com/p/reviewboard/issues/detail?id=3197 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be rejected. *** *** For customer support, please post to reviewbo...@googlegroups.com *** *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** Do not post confidential information in this bug report! What version are you running? RBTools 0.5.5/Review Board 1.7.20 What's the URL of the page containing the problem? RBTools defect only What steps will reproduce the problem? 1. Create a new review request and publish. rbt post -p --target-people=person 496863 2. Edit the existing review request and publish. rbt post -p 496863 ERROR:root:Error updating review request draft: One or more fields had errors (HTTP 400, API Error 105) changenum: Field is not supported 3. Try adding -u. rbt post -p -u 496863 ERROR:root:--summary and --description are required. 4. Add summary and description. rbt post -p -u --summary post-review... --description ...didn't need this 496863 Update Review Request #39: 'bug: none Testing rbt'? [Yes/No]: yes Review request #39 posted. https://reviewboard.some.domain/r/39/ What is the expected output? What do you see instead? Today, our developers use a single command alias with post-review to accomplish this task and expect the command from item 2 to work like it does with post-review. What operating system are you using? What browser? OS X 10.8.5/Python 2.7.2 Please provide any additional information below. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3197 in reviewboard: rbt post requires summary and description for existing changenum (perforce)
Updates: Status: NeedInfo Comment #1 on issue 3197 by trowb...@gmail.com: rbt post requires summary and description for existing changenum (perforce) http://code.google.com/p/reviewboard/issues/detail?id=3197 Is this with a submitted changelist or a pending changelist? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3193 in reviewboard: RBTools 0.5.5 drops Python 2.4 compatibility
Updates: Status: Fixed Comment #3 on issue 3193 by trowb...@gmail.com: RBTools 0.5.5 drops Python 2.4 compatibility http://code.google.com/p/reviewboard/issues/detail?id=3193 Fixed in rbtools release-0.5.x (216a51b). Thanks! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3197 in reviewboard: rbt post requires summary and description for existing changenum (perforce)
Comment #2 on issue 3197 by jaabr...@gmail.com: rbt post requires summary and description for existing changenum (perforce) http://code.google.com/p/reviewboard/issues/detail?id=3197 My example was with a pending changelist although I have noticed the same behavior with a submitted changelist. Having this work with pending is more critical. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3197 in reviewboard: rbt post requires summary and description for existing changenum (perforce)
Comment #3 on issue 3197 by trowb...@gmail.com: rbt post requires summary and description for existing changenum (perforce) http://code.google.com/p/reviewboard/issues/detail?id=3197 OK, that is definitely incorrect. I'll look into this ASAP. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3197 in reviewboard: rbt post requires summary and description for existing changenum (perforce)
Comment #4 on issue 3197 by trowb...@gmail.com: rbt post requires summary and description for existing changenum (perforce) http://code.google.com/p/reviewboard/issues/detail?id=3197 Can you re-run your commands with --debug and include the output in this report? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3197 in reviewboard: rbt post requires summary and description for existing changenum (perforce)
Updates: Status: PendingReview Owner: trowb...@gmail.com Labels: Component-RBTools Comment #5 on issue 3197 by trowb...@gmail.com: rbt post requires summary and description for existing changenum (perforce) http://code.google.com/p/reviewboard/issues/detail?id=3197 OK, I've figured out what's going on here. I'll have a change up for review shortly. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3197 in reviewboard: rbt post requires summary and description for existing changenum (perforce)
Updates: Status: Fixed Comment #6 on issue 3197 by trowb...@gmail.com: rbt post requires summary and description for existing changenum (perforce) http://code.google.com/p/reviewboard/issues/detail?id=3197 Fixed in rbtools release-0.5.x (3f2e135). This will ship with 0.5.6 In the meantime, I suggest doing the update without the publish: $ rbt post -o 496863 and then hitting Publish in the web UI. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.