Re: Issue 46 in reviewboard: 80-column indicator in diff view

2014-07-24 Thread reviewboard
Comment #19 on issue 46 by trowb...@gmail.com: 80-column indicator in diff view http://code.google.com/p/reviewboard/issues/detail?id=46 Mike has some CSS that works for this: table.sidebyside tr[line] td:before { content: ''; position: absolute; transform: translateX(80ch);

Re: Issue 46 in reviewboard: 80-column indicator in diff view

2014-07-24 Thread reviewboard
Comment #20 on issue 46 by chip...@gmail.com: 80-column indicator in diff view http://code.google.com/p/reviewboard/issues/detail?id=46 A few notes on the CSS, after playing with it, that we'll need to address: 1. The red lines end up overflowing from the left-hand side to the right-hand

Re: Issue 46 in reviewboard: 80-column indicator in diff view

2012-04-15 Thread reviewboard
Comment #17 on issue 46 by bernard3...@gmail.com: 80-column indicator in diff view http://code.google.com/p/reviewboard/issues/detail?id=46 Speaking of cached content: This is often a project or company-wide setting, so maybe this could be a global setting (turn on, turn off, column

Re: Issue 46 in reviewboard: 80-column indicator in diff view

2012-04-14 Thread reviewboard
Comment #16 on issue 46 by sambatis...@gmail.com: 80-column indicator in diff view http://code.google.com/p/reviewboard/issues/detail?id=46 I'm very interested in this feature, or some way of turning off line wrapping / configure wrap margin. Would be a very useful feature for me and my

Re: Issue 46 in reviewboard: 80-column indicator in diff view

2011-09-15 Thread reviewboard
Comment #13 on issue 46 by ju...@tuenti.com: 80-column indicator in diff view http://code.google.com/p/reviewboard/issues/detail?id=46 Some companies use other number of columns (ie: 100) so this should be configurable also -- You received this message because you are subscribed to the

Re: Issue 46 in reviewboard: 80-column indicator in diff view

2011-09-15 Thread reviewboard
Comment #14 on issue 46 by shankar@gmail.com: 80-column indicator in diff view http://code.google.com/p/reviewboard/issues/detail?id=46 The trick is to figure out *where* the 80th column is [...] For fixed-width fonts, this determination should be easy, shouldn't it? Style a

Re: Issue 46 in reviewboard: 80-column indicator in diff view

2010-07-15 Thread reviewboard
Comment #12 on issue 46 by bernard3000: 80-column indicator in diff view http://code.google.com/p/reviewboard/issues/detail?id=46 If it is decided that this should be a user-level setting, why not cache the content with that setting as part of the cache key? So yes, that means a bigger

Re: Issue 46 in reviewboard: 80-column indicator in diff view

2010-07-14 Thread reviewboard
Comment #10 on issue 46 by arunbalaji1985: 80-column indicator in diff view http://code.google.com/p/reviewboard/issues/detail?id=46 Hi, We also follow certain standards like this in our company. And we have been using review board for quite some time now. Can the review board show margin

Re: Issue 46 in reviewboard: 80-column indicator in diff view

2010-07-14 Thread reviewboard
Comment #11 on issue 46 by chipx86: 80-column indicator in diff view http://code.google.com/p/reviewboard/issues/detail?id=46 Arun, this is one of those situations where an easy solution for one group is going to cause complaints for another. In large deployments, different teams may very

Re: Issue 46 in reviewboard: 80-column indicator in diff view

2010-05-19 Thread reviewboard
Comment #9 on issue 46 by bernard3000: 80-column indicator in diff view http://code.google.com/p/reviewboard/issues/detail?id=46 If anyone comes to implement something, I would like it be changeable to 120 (we have widescreen monitors now) :) For me, I think just putting a div line on top

Re: Issue 46 in reviewboard: 80-column indicator in diff view

2010-04-20 Thread reviewboard
Comment #7 on issue 46 by timhollingsworth: 80-column indicator in diff view http://code.google.com/p/reviewboard/issues/detail?id=46 I'd love to have this. This issue is quite old - what is the chances it will be implemented? -- You received this message because you are listed in the

Re: Issue 46 in reviewboard: 80-column indicator in diff view

2010-04-20 Thread reviewboard
Comment #8 on issue 46 by chipx86: 80-column indicator in diff view http://code.google.com/p/reviewboard/issues/detail?id=46 It would need to be done in such a way where it's 1) fast, 2) customizable without regenerating the HTML, and 3) user-configurable. Not everyone at a company will

Issue 46 in reviewboard: 80-column indicator in diff view

2009-09-17 Thread codesite-noreply
Comment #6 on issue 46 by gic...@gmail.com: 80-column indicator in diff view http://code.google.com/p/reviewboard/issues/detail?id=46 Maybe the background color could be different for characters after the boundary. Example: div class=linespan class=first-80first 80 chars.../spantrailing

Issue 46 in reviewboard: 80-column indicator in diff view

2009-07-14 Thread codesite-noreply
Comment #5 on issue 46 by m...@roboss.com: 80-column indicator in diff view http://code.google.com/p/reviewboard/issues/detail?id=46 Another idea is to cut off lines longer than some length (say 90) with an ellipsis. Then show a simple tooltip for the rest of the line when the user hovers