Re: Review Board Ticket #4730: Reviewboard repository names are limited to 64 characters
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4730/ -- New update by mgokhale-arbor For Beanbag, Inc. > Review Board > Ticket #4730 Reply: Fixed in release-3.0.x (c1a2766). This will ship in 3.0.11. Thanks! Status: - New + Fixed -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4730: Reviewboard repository names are limited to 64 characters
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4730/ -- New update by mgokhale-arbor For Beanbag, Inc. > Review Board > Ticket #4730 Reply: I'll work on this! -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4730: Reviewboard repository names are limited to 64 characters
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4730/ -- New update by mgokhale-arbor For Beanbag, Inc. > Review Board > Ticket #4730 Reply: I wouldn't say that the limit is a bug, but I can see where your naming scheme runs into problems. I think a limit of 255 produces other problems, namely the display of names in the New Review Request page and elsewhere. _Usually_, repositories in Review Board are named after the actual name of the repository on whatever service is being used, with a namespace being used to disambiguate (so for instance, `Review Board` and `RBTools` would be repository names, but `CI Infrastructure` and `Web Server Infrastructure` might be used instead of `ci-team/infrastructure` and `web-team/infrastructure`. It's easier to read/consume by users, avoids a lot of wrapping issues that longer names provide, and survives the moving of repositories to other groups down the road after reorgs. I'm not against bumping up the limit, but I wouldn't want to do it in a point release, since that impacts many customers of ours who have to be careful about when they perform upgrades that impact database schema. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Review Board Ticket #4730: Reviewboard repository names are limited to 64 characters
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4730/ -- New ticket #4730 by mgokhale-arbor For Beanbag, Inc. > Review Board Status: New Tags: Priority:Medium, Type:Defect -- Reviewboard repository names are limited to 64 characters == # What version are you running? 3.0.6 # What's the URL of the page containing the problem? # What steps will reproduce the problem? We use Gitlab internally, with Reviewboard for code review. We create new Reviewboard repositories via a webhook in Gitlab every time a new repository is created. We set the name of the repository to be the namespace of the repo in Gitlab. So, for example, if the project is at git.example.com/group/project, the name in Reviewboard will be `group/project`. Since Gitlab has nested subgroups, sometimes the namespacing can be quite long, like `group/somewhat-long-subgroup-name/really-long-project-name`. Note that Gitlab can have more nesting of subgroups. A few weeks ago, one of our hooks failed with a `DataError: value too long for type character varying(64)` -- basically it was failing to create a repo with a really full name, that more than 64 characters. This seems to me to be a direct consequence of the name being limited to 64 characters in https://github.com/reviewboard/reviewboard/blob/release-3.0.6/reviewboard/scmtools/models.py#L91 (our release is 3.0.6, but it's the same in master). I _think_ this 64-character limit is a bug since the name can be quite long if you include all the namespacing inherent in systems with nested groups like Gitlab. Would the Reviewboard devs consider bumping this to 255 characters? I suspect we're probably not the only ones hitting this. -- -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
