Issue 963 in reviewboard: Option to flag a comment as a 'blocker' comment

2009-03-17 Thread codesite-noreply
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 963 by lee.winder: Option to flag a comment as a 'blocker' comment http://code.google.com/p/reviewboard/issues/detail?id=963 Quite often when reviewing code I will make a few comments on the diff. Some of these comments are im

Issue 965 in reviewboard: Edit buttons on Review Request screen are not accessible

2009-03-17 Thread codesite-noreply
Comment #1 on issue 965 by brad.taylor: Edit buttons on Review Request screen are not accessible http://code.google.com/p/reviewboard/issues/detail?id=965 Patch against RB Trunk. Attachments: edit-button-a11y.patch 517 bytes -- You received this message because you are listed in the

Issue 965 in reviewboard: Edit buttons on Review Request screen are not accessible

2009-03-17 Thread codesite-noreply
Comment #2 on issue 965 by brad.taylor: Edit buttons on Review Request screen are not accessible http://code.google.com/p/reviewboard/issues/detail?id=965 Additionally, the edit buttons are not focusable, so I'll have to figure a way to make that happen also. -- You received this message be

Issue 966 in reviewboard: Under General Settings, updating "Server" field not saved despite "successful" message

2009-03-17 Thread codesite-noreply
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 966 by ciaomary: Under General Settings, updating "Server" field not saved despite "successful" message http://code.google.com/p/reviewboard/issues/detail?id=966 What's the URL of the page containing the problem? https://rev

Issue 965 in reviewboard: Edit buttons on Review Request screen are not accessible

2009-03-17 Thread codesite-noreply
Updates: Status: Confirmed Labels: Milestone-Release1.0 Component-Reviews Comment #3 on issue 965 by chipx86: Edit buttons on Review Request screen are not accessible http://code.google.com/p/reviewboard/issues/detail?id=965 Can you submit this to our Review Board server? -- Y

Issue 965 in reviewboard: Edit buttons on Review Request screen are not accessible

2009-03-17 Thread codesite-noreply
Comment #4 on issue 965 by brad.taylor: Edit buttons on Review Request screen are not accessible http://code.google.com/p/reviewboard/issues/detail?id=965 Updated patch to make the button focusable (by using an tag) and thus clickable via Firefox (when a user hits Enter, Firefox will genera

Issue 914 in reviewboard: API Broken Alpha2: api/json/reviewrequests//reviews/

2009-03-17 Thread codesite-noreply
Comment #1 on issue 914 by ciaomary: API Broken Alpha2: api/json/reviewrequests//reviews/ http://code.google.com/p/reviewboard/issues/detail?id=914 The fix for my issue was found. I needed to pass in id=>$rid with the request. This is not documented in the API doc however. I request that th

Issue 967 in reviewboard: repository hostname lookups are not really canonical

2009-03-17 Thread codesite-noreply
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 967 by psc...@vmware.com: repository hostname lookups are not really canonical http://code.google.com/p/reviewboard/issues/detail?id=967 Currently, post-review relies on calls to various socket module functions in order to f