Issue 1334 in reviewboard: Fragment expansion brings up 404 error
Updates: Status: Fixed Comment #5 on issue 1334 by chipx86: Fragment expansion brings up 404 error http://code.google.com/p/reviewboard/issues/detail?id=1334 Should be fixed in our git repository now. You can try doing an install from there. Fixed on release-1.0.x (rdbc7668) and master (r52dc35f). -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1334 in reviewboard: Fragment expansion brings up 404 error
Comment #4 on issue 1334 by ciaomary: Fragment expansion brings up 404 error http://code.google.com/p/reviewboard/issues/detail?id=1334 We're seeing this same issue. Looking forward to the fix! Just as an added piece of info... turning off memcache on the server resolves the 404 error for us. Restarting memcache also helps in specific cases, but other folks were continuing to run into 404 errors so I've had to turn it off completely for now. Strange. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1334 in reviewboard: Fragment expansion brings up 404 error
Updates: Status: Confirmed Owner: chipx86 Labels: -Priority-Medium Priority-Critical Milestone-Release1.0.x EasyFix Comment #3 on issue 1334 by chipx86: Fragment expansion brings up 404 error http://code.google.com/p/reviewboard/issues/detail?id=1334 Looks like we're not including the revision number, just the database ID of the filediff. That would explain it. I'll get this fixed in a point release. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1334 in reviewboard: Fragment expansion brings up 404 error
Comment #2 on issue 1334 by th...@ginkel.com: Fragment expansion brings up 404 error http://code.google.com/p/reviewboard/issues/detail?id=1334 The following test was performed with a web browser that did not previously access the review request, so client-side caching should not be in place. When initially accessing the request and clicking "Expand" the error happened again. Just to be on the safe side I also shift-reloaded the page and hit "Expand" again - with unchanged results. One of the "Expand" links reads: -- 8< -- 87 lines hidden [Expand] -- 8< -- It apparently references the incorrect diff revision. In the same HTTP response (towards the top of the request) there is also a variable that correlates to the diff revision: var gRevision = '1'; This one, however, seems to be correct and reference diff #1, so I'd rule out any HTTP-related caching issues. Next, I restarted the Apache httpd that hosts Review Board to rule out any in-memory mod_python issues. The issue still persisted. Restarting memcached, however, solved the issue, so cached content seems to play an important role. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1334 in reviewboard: Fragment expansion brings up 404 error
Updates: Status: NeedInfo Labels: Component-DiffViewer Comment #1 on issue 1334 by chipx86: Fragment expansion brings up 404 error http://code.google.com/p/reviewboard/issues/detail?id=1334 Interesting. Now, what happens if you repro this and then, on the diff where it normally fails, you shift-reload to bypass the cache? I suspect this is either a server-side or a client-side caching problem, so that'll be an important test. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1334 in reviewboard: Fragment expansion brings up 404 error
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1334 by th...@ginkel.com: Fragment expansion brings up 404 error http://code.google.com/p/reviewboard/issues/detail?id=1334 *NOTE: Do not post confidential information in this bug report.* What version are you running? 1.0.3.1 What's the URL of the page containing the problem? https://reviewboard./r//diff/#index_header What steps will reproduce the problem? 1. Submit a review request through Post Review 2. In draft mode, click on "View Diff" once 3. Publish the review request 4. Open the request (either as submitter or reviewer) 5. Click on "View Diff" 6. Try to expand expand a hidden source code section by clicking on "Expand" What is the expected output? What do you see instead? Clicking on any of the "Expand" hyperlinks (to expand collapsed source code sections) in the RB diff viewer brings up a 404 error. The URL to retrieve the file fragment uses an incorrect diff index (0 instead of 1), such as: https://reviewboard./r//diff/0/fragment/2785/chunk/8/ Manually invoking the URL with a corrected diff # correctly retrieves the fragment. What operating system are you using? What browser? Server: Windows Server 2003. Client: browser-independent. Please provide any additional information below. The issue only occurs when selecting "View Diff" at least once in draft mode and does not occur when blindly publishing the review request. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
