Re: Issue 2077 in reviewboard: Incorrect git diff parsing
Updates: Status: Fixed Labels: Milestone-Release1.6.x Component-DiffViewer Component-SCMTools Comment #5 on issue 2077 by chip...@gmail.com: Incorrect git diff parsing http://code.google.com/p/reviewboard/issues/detail?id=2077 A lot of work has gone into diff parsing and into GitHub support since these bugs. I believe the issues have been fixed, unless you're posting a change that has a parent not part of the upstream repository (in which case, you want to use --parent=). Going to close this, but if you're still hitting it, please reopen. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2077 in reviewboard: Incorrect git diff parsing
Comment #4 on issue 2077 by chris.a@gmail.com: Incorrect git diff parsing http://code.google.com/p/reviewboard/issues/detail?id=2077 I changed that file mask to use https and it failed on a different file. I then tried setting up a clone of the repo that was on disk and has a cron job to update it regularly. Against that repo the same diff file works. Looking at the github API v2 docs it says there's a rate limit of 60 calls a minute. Could that be what is causing the issues here? There's a new github v3 APi that rate limits to 5000/hour, maybe that would work better? But in any case, I'd assume that since it's likely that 60+ files could be changed in a large diff, that handling this for Github should be included in the logic... -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2077 in reviewboard: Incorrect git diff parsing
Comment #3 on issue 2077 by chris.a@gmail.com: Incorrect git diff
parsing
http://code.google.com/p/reviewboard/issues/detail?id=2077
I'm running into what appears to be the same issue here. I have a project
attached to github, and it's failing to parse the diffs. It complains about
revisions not existing:
Got API Error 207 (HTTP code 400): The file was not found in the
repository
Error data: {u'stat': u'fail', u'file':
u'plugins/com.aptana.editor.dtd/parsing/DTD.grammar', u'err': {u'msg':
u'The file was not found in the repository', u'code': 207},
u'revision': u'14f130fca4dfd182e42e5b99ad543c39ba8517e3'}
The diff itself is using the SHAs of the blobs representing the file
contents before and after:
diff --git a/plugins/com.aptana.editor.dtd/parsing/DTD.grammar
b/plugins/com.aptana.editor.dtd/parsing/DTD.grammar
index
d5f60c4b1b447b0fb6191c1a34a4a40f248a7905..14f130fca4dfd182e42e5b99ad543c39ba8517e3
100644
Github expects the commit SHA containing that version of the file in it's
URLs, like so:
https://github.com/aptana/studio3/blob/5a8245f18a6a844c99eca27b497a134cd67ce431/plugins/com.aptana.editor.dtd/parsing/DTD.grammar
This also seems to be the same issue?
http://www.mail-archive.com/reviewboard@googlegroups.com/msg06300.html
Is there a way I can fix this manually? if I change the repository
from "Github" to custom, it shows
http://github.com/api/v2/yaml/blob/show/aptana/studio3/ as the
raw file URL mask, and substituting the blob from the diff there does
return what I'd expect (though note that it becomes https):
https://github.com/api/v2/yaml/blob/show/aptana/studio3/14f130fca4dfd182e42e5b99ad543c39ba8517e3
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2077 in reviewboard: Incorrect git diff parsing
Comment #2 on issue 2077 by a.chuk...@gmail.com: Incorrect git diff parsing http://code.google.com/p/reviewboard/issues/detail?id=2077 The problem was in repository setup: http://hostname/?p=repo.git;a=blob_plain;f=;h= or http://hostname/?p=repo.git;a=blob_plain;f=;hb= Later version looks for commit ID while first version looks file by its SHA1 (the thing I need). P.S. I'm interested why do you still call it ? -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2077 in reviewboard: Incorrect git diff parsing
Comment #1 on issue 2077 by a.chuk...@gmail.com: Incorrect git diff parsing http://code.google.com/p/reviewboard/issues/detail?id=2077 I tried different setup for gitweb: either http://hostname/?p=repo.git;a=blob_plain;f=;h= or http://hostname/?p=repo.git;a=blob_plain;f=;hb= None of these versions work. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2077 in reviewboard: Incorrect git diff parsing
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 2077 by a.chuk...@gmail.com: Incorrect git diff parsing
http://code.google.com/p/reviewboard/issues/detail?id=2077
* NOTE: Do not post confidential information in this bug report. *
* If you need immediate support, please contact*
* reviewbo...@googlegroups.com *
What version are you running?
Review board 1.5.5
What steps will reproduce the problem?
1. Make changes to an existing file.
2. Use post-review to upload it.
3. It fails complaining on non-existent revision.
What is the expected output? What do you see instead?
Seems that it treats git file's SHA1 to be commit id.
Please provide any additional information below.
git diff --full-index --cc -r HEAD^..HEAD
diff --git a/tmp b/tmp
index
44957fa4b300b0fbee878cb7aa95c495371f4a5c..5a3f4060c35281b591f0d09f0b10815aac6e5b20
100644
--- a/tmp
+++ b/tmp
@@ -1,2 +1 @@
-artasrt
Now add small changes
diff --git a/tmp2 b/tmp2
new file mode 100644
index
..1c975dce2df0cbcd48b1fb67f53abef77919945a
--- /dev/null
+++ b/tmp2
@@ -0,0 +1 @@
+tarstasrt
post-review -d -r 31 --revision-range=HEAD^:HEAD
Got API Error 207 (HTTP code 200): The file was not found in the
repository
Error data: {u'deprecated': {u'in_version': u'1.5'}, u'stat': u'fail',
u'file': u'tmp', u'err': {u'msg': u'The file was not found in the
repository', u'code': 207}, u'revision':
u'44957fa4b300b0fbee878cb7aa95c495371f4a5c'}
(It thinks that SHA1 of old tmp is a revision ID)
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
