Issue 676 in reviewboard: post-review fails when uploading diff
Updates: Status: Confirmed Labels: Milestone-Release1.1 Component-Docs Comment #5 on issue 676 by chipx86: post-review fails when uploading diff http://code.google.com/p/reviewboard/issues/detail?id=676 If we can't fix this, we should at least doc it. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 676 in reviewboard: post-review fails when uploading diff
Comment #4 on issue 676 by kel...@edmison.net: post-review fails when
uploading diff
http://code.google.com/p/reviewboard/issues/detail?id=676
This issue appears to be triggered by a very large diff request, and a
mysql setting preventing the sql
statement from being accepted.
I'm using reviewboard 1.0rc2, Perforce (2007.2), MySQL 5.0.
>>> Uploading diff, size: 1593200
>>> HTTP POSTing to
>>> http://reviews./api/json/reviewrequests/13/diff/new/: {}
Error uploading diff: One or more fields had errors (105)
>>> {u'fields': {u'path': [u'(1153, "Got a packet bigger than
>>> \'max_allowed_packet\' bytes")']}, u'stat': u'fail',
u'err': {u'msg': u'One or more fields had errors', u'code': 105}}
Your review request still exists, but the diff is not attached.
Note the size of the diff: 1,593,200 bytes.
Next, the max_allowed_packet setting in mysql:
mysql> show variables like "max_allowed_packet";
++-+
| Variable_name | Value |
++-+
| max_allowed_packet | 1048576 |
++-+
1 row in set (0.00 sec)
The page at
http://dev.mysql.com/doc/refman/5.0/en/packet-too-large.html
says:
"Both the client and the server have their own max_allowed_packet variable,
so if you want to handle big
packets, you must increase this variable both in the client and in the
server."
I'll try changing just the server side, but I don't know if this will be
sufficient based on what the mysql link
above says.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---
Issue 676 in reviewboard: post-review fails when uploading diff
Updates: Status: Incomplete Comment #3 on issue 676 by trowbrds: post-review fails when uploading diff http://code.google.com/p/reviewboard/issues/detail?id=676 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 676 in reviewboard: post-review fails when uploading diff
Comment #2 on issue 676 by pan126: post-review fails when uploading diff
http://code.google.com/p/reviewboard/issues/detail?id=676
Same here
{{{
>>> svn info
>>> repository info: Path: https://mpu...@svn.redefine.pl/videomakine, Base
path: /cruncher, Supports
changesets: False
>>> svn propget reviewboard:url /Users/marek/Desktop/Projects/cruncher
>>> svn diff --diff-cmd=diff
>>> svn info sql/patches/030.core_movie_is_interlaced.sql
>>> svn info sql/rollbacks/030.core_movie_is_interlaced.sql
>>> svn info sql/patches/030.core_movie_is_interlaced.sql
>>> svn info sql/patches/030.core_movie_is_interlaced.sql
>>> svn info sql/patches/030.core_movie_is_interlaced.sql
>>> svn info sql/rollbacks/030.core_movie_is_interlaced.sql
>>> svn info sql/rollbacks/030.core_movie_is_interlaced.sql
>>> svn info sql/rollbacks/030.core_movie_is_interlaced.sql
>>> svn info test.txt.delete.me
>>> Looking for 'tvod5 /' cookie in /Users/marek/.post-review-cookies.txt
>>> Cookie file loaded, but no cookie for this server
==> Review Board Login Required
Enter username and password for Review Board at http://tvod5:8080/
>>> Logging in with username "mpulczynski"
Sending None
>>> HTTP POSTing to http://tvod5:8080/api/json/accounts/login/:
{'username': 'mpulczynski', 'password':
'**'}
>>> Logged in.
>>> Attempting to create review request for None
>>> HTTP GETting /api/json/repositories/
>>> HTTP GETting /api/json/repositories/1/info/
>>> repository info: Path: https://svn.redefine.pl/videomakine, Base path:
/cruncher, Supports changesets:
False
Sending None
>>> HTTP POSTing to http://tvod5:8080/api/json/reviewrequests/new/:
{'repository_path':
u'https://svn.redefine.pl/videomakine'}
>>> Review request created
>>> Attempting to set field 'summary' to 'dupa' for review request '37'
Sending None
>>> HTTP POSTing to
http://tvod5:8080/api/json/reviewrequests/37/draft/set/: {'summary': 'dupa'}
>>> Attempting to set field 'description' to 'dupa' for review request '37'
Sending None
>>> HTTP POSTing to
http://tvod5:8080/api/json/reviewrequests/37/draft/set/:
{'description': 'dupa'}
Sending None
>>> HTTP POSTing to
http://tvod5:8080/api/json/reviewrequests/37/draft/save/: {}
>>> Review request draft saved
>>> Uploading diff, size: 986
>>>
>>> Property changes on: .
>>> ___
>>> Name: reviewboard:url
>>> + http://tvod5:8080
>>>
>>> Index: /cruncher/sql/patches/030.core_movie_is_interlaced.sql
>>>
===
>>> --- /cruncher/sql/patches/030.core_movie_is_interlaced.sql
>>> (revision
0)
>>> +++ /cruncher/sql/patches/030.core_movie_is_interlaced.sql
>>> (revision
0)
>>> @@ -0,0 +1,4 @@
>>> +BEGIN;
>>> +ALTER TABLE core_movie ADD "video_is_interlaced" boolean NULL;
>>> +COMMIT;
>>> +
>>> Index: /cruncher/sql/rollbacks/030.core_movie_is_interlaced.sql
>>>
===
>>> --- /cruncher/sql/rollbacks/030.core_movie_is_interlaced.sql
(revision 0)
>>> +++ /cruncher/sql/rollbacks/030.core_movie_is_interlaced.sql
(revision 0)
>>> @@ -0,0 +1,3 @@
>>> +BEGIN;
>>> +ALTER TABLE core_movie DROP video_is_interlaced;
>>> +COMMIT;
>>> Index: /cruncher/test.txt.delete.me
>>>
===
DUPA {'path': {'content': '\nProperty changes on:
.\n___\nName:
reviewboard:url\n
+
http://tvod5:8080\n\nIndex:
/cruncher/sql/patches/030.core_movie_is_interlaced.sql\n===
\n---
/cruncher/sql/patches/030.core_movie_is_interlaced.sql\t(revision 0)\n+++
/cruncher/sql/patches/030.core_movie_is_interlaced.sql\t(revision 0)\n@@
-0,0 +1,4 @@\n+BEGIN;\n+
ALTER TABLE core_movie ADD "video_is_interlaced" boolean
NULL;\n+COMMIT;\n+\nIndex:
/cruncher/sql/rollbacks/030.core_movie_is_interlaced.sql\n==
=\n---
/cruncher/sql/rollbacks/030.core_movie_is_interlaced.sql\t(revision 0)\n+++
/cruncher/sql/rollbacks/030.core_movie_is_interlaced.sql\t(revision 0)\n@@
-0,0 +1,3 @@\n+BEGIN;\n+
ALTER TABLE core_movie DROP video_is_interlaced;\n+COMMIT;\nIndex:
/cruncher/test.txt.delete.me\n
===\n', 'filename': 'diff'}}
Sending {'path': {'content': '\nProperty changes on:
.\n___\nName:
reviewboard:url\n
+
http://tvod5:8080\n\nIndex:
/cruncher/sql/patches/030.core_movie_is_interlaced.sql\n===
\n---
/cruncher/sql/patches/030.core_movie_is_interlaced.sql\t(revision 0)\n+++
/cruncher/sql/patches/030.core_movie_is_interlaced.sql\t(revision 0)\n@@
-0,0 +1,4 @@\n+BEGIN;\n+
ALT
Issue 676 in reviewboard: post-review fails when uploading diff
Updates: Status: NeedInfo Comment #1 on issue 676 by chipx86: post-review fails when uploading diff http://code.google.com/p/reviewboard/issues/detail?id=676 Sorry, I know this is a bit old, but do you still have a good repro case for this and can give an example of the newline issue? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 676 in reviewboard: post-review fails when uploading diff
Issue 676: post-review fails when uploading diff
http://code.google.com/p/reviewboard/issues/detail?id=676
New issue report by lukatmyshu:
*NOTE: Do not post confidential information in this bug report.*
What's the URL of the page containing the problem?
post-review command line tool
What steps will reproduce the problem?
1. Use the post-review tool to upload a diff for review
What is the expected output? What do you see instead?
The expected output is a new review should be posted. Instead, I get an
error stating
that the uploaded diff could not be uploaded. Relevant output from -d
>>> HTTP POSTing to
http://dev.meebo.com/codereview/api/json/reviewrequests/19/diff/new/:
{'basedir':
'/web/branches/communityim/im-gateway/ig'}
Error uploading diff: One or more fields had errors (105)
>>> {u'fields': {u'path': [u'The diff file is empty']}, u'stat': u'fail',
u'err': {u'msg': u'One or more
fields had errors', u'code': 105}}
Your review request still exists, but the diff is not attached.
What operating system are you using? What browser?
on linux, using svn version 1.5X
Please provide any additional information below.
I looked at the diff generated by post-review vs. the one created w/ svn
diff (works if I upload it
manually). The output differed in the position of the newlines.
Removing 'split-lines' from the
do_diff function fixed the problem for me. (Also removed the
--diff-cmd=diff)
Issue attributes:
Status: New
Owner:
Labels: Type-Defect Priority-Medium
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---
