Issue 813 in reviewboard: Non C locale patches fail
Updates: Labels: Milestone-Release1.0 Component-Scripts Comment #6 on issue 813 by chipx86: Non C locale patches fail http://code.google.com/p/reviewboard/issues/detail?id=813 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 813 in reviewboard: Non C locale patches fail
Updates: Status: Fixed Comment #5 on issue 813 by chipx86: Non C locale patches fail http://code.google.com/p/reviewboard/issues/detail?id=813 Should be fixed in r1722, in that we generate SVN diffs now with the C locale. We still don't support diffs with non-C locales, but post-review should generate proper diffs. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 813 in reviewboard: Non C locale patches fail
Comment #4 on issue 813 by chipx86: Non C locale patches fail http://code.google.com/p/reviewboard/issues/detail?id=813 Issue 822 has been merged into this issue. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 813 in reviewboard: Non C locale patches fail
Comment #3 on issue 813 by timw.at.work: Non C locale patches fail http://code.google.com/p/reviewboard/issues/detail?id=813 It surprises me that a tool to generate data interchange files (svn diff) would localize the internal diff markers (much like 'diff' doesn't consult the user's preferred date format when printing the file timestamp). It seems like either 1) svn shouldn't be localizing diff output, or 2) svn should have a simple command-line way to override that behavior. It is somewhat sad that the diff format (or svn's extension of that) cannot support separate per-chunk or per-file metadata. You (lukasz) are right that rb does search for '(revision ...)', and that's probably the easiest restriction to fix (as long as the parsing code is strict enough to require it be at the end of the path). -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 813 in reviewboard: Non C locale patches fail
Updates: Status: NeedInfo Comment #1 on issue 813 by chipx86: Non C locale patches fail http://code.google.com/p/reviewboard/issues/detail?id=813 What are you using to generate the patch? Unfortunately, this is just sort of how it has to be. Most applications that take patches with revision info need them in C locale, because it's not really feasible to support every language under the sun in the diff parser. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 813 in reviewboard: Non C locale patches fail
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 813 by lukasz.jernas: Non C locale patches fail http://code.google.com/p/reviewboard/issues/detail?id=813 Review board fails when trying to submint a patch created with diff in non C locale. Example patch: --- DirtyDock.h (wersja 13191) +++ DirtyDock.h (kopia robocza) @@ -48,6 +48,9 @@ QAction* centerZoomAction; std::vector Selection; +public: + void changeEvent(QEvent*); + void retranslateUi(); }; #endif What steps will reproduce the problem? 1. click New Review Request 2. Insert the above diff into a file a add it to the "Diff:" selector 3. click "Create Review Request" What is the expected output? What do you see instead? The patch should be sent and accepted and the usual stuff should follow, instead I get back to r/new/ with and error "Unable to parse diff revision header '(wersja 13191)'" -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
