Re: Issue 1524 in reviewboard: postreview.py should ignore user configuration when generating diffs.
Updates: Status: Fixed Comment #11 on issue 1524 by trowb...@gmail.com: postreview.py should ignore user configuration when generating diffs. http://code.google.com/p/reviewboard/issues/detail?id=1524 Fixed in rbtools master (7160581). If you set GIT_USE_EXT_DIFF = True in ~/.reviewboardrc, rbtools will not use --no-ext-diff. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1524 in reviewboard: postreview.py should ignore user configuration when generating diffs.
Updates: Labels: -Milestone-RBTools-Release1.0 Comment #9 on issue 1524 by trowb...@gmail.com: postreview.py should ignore user configuration when generating diffs. http://code.google.com/p/reviewboard/issues/detail?id=1524 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1524 in reviewboard: postreview.py should ignore user configuration when generating diffs.
Comment #8 on issue 1524 by emil@gmail.com: postreview.py should ignore user configuration when generating diffs. http://code.google.com/p/reviewboard/issues/detail?id=1524 If I recall correctly, the original issue I saw is that someone can configure external diff to run sort of graphical program that does not actually generate a diff to stdout. If I had to guess, probably someone I was helping had their external diff set to p4merge and couldn't figure out why their upload wasn't working. (As an aside, it seems that there is some debate as to whether one ought to properly use git difftool for that purpose or git with an external diff tool. Both seem to be possible. But the fact remains that with external diff, there isn't a guarantee that what you get on stdout is something RB will be able to understand once it has been uploaded.) Perhaps RB could try without no-ext-diff but if the upload fails fallback to no no-ext-diff before giving up? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1524 in reviewboard: postreview.py should ignore user configuration when generating diffs.
Comment #7 on issue 1524 by chip...@gmail.com: postreview.py should ignore user configuration when generating diffs. http://code.google.com/p/reviewboard/issues/detail?id=1524 I don't know the original rationale for why --no-ext-diff was needed, but I think I agree. We should probably revert this change. In the case where someone needs that option set, I believe they can set it locally for their git install. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1524 in reviewboard: postreview.py should ignore user configuration when generating diffs.
Updates: Status: New Comment #6 on issue 1524 by trowb...@gmail.com: postreview.py should ignore user configuration when generating diffs. http://code.google.com/p/reviewboard/issues/detail?id=1524 I'm sorry, we missed the earlier comment. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1524 in reviewboard: postreview.py should ignore user configuration when generating diffs.
Comment #5 on issue 1524 by vzeit...@gmail.com: postreview.py should ignore user configuration when generating diffs. http://code.google.com/p/reviewboard/issues/detail?id=1524 It would be really great to get any reply about this because it's annoying to have to change this in every new installation of RBTools. Especially because I still think there is absolutely no good reason for using --no-ext-diff in the first place, so it's a pity that comment #4 apparently went completely unnoticed. Of course, it's also possible that I'm missing something here, but in this case I'd be really grateful if somebody could please point out what is it. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1524 in reviewboard: postreview.py should ignore user configuration when generating diffs.
Comment #4 on issue 1524 by vzeit...@gmail.com: postreview.py should ignore user configuration when generating diffs. http://code.google.com/p/reviewboard/issues/detail?id=1524 Sorry but could the decision to add "--no-ext-diff" be please reconsidered? I don't know what is the reasoning behind explicitly ignoring the user options but IMHO the answer to "RB can't run the non-existent program I configured Git to use" is simply "Don't configure Git to use non-existent programs", not this. And I can definitely explain why this is a problem for me: I'm using a hack to disable diffs to some "not interesting" files by default, i.e. I have "foobar diff=generated" in .gitattributes and used "git config diff.generated.command true" to just suppress the diff for all files with this attribute. Unfortunately, when I use post-review, the diffs for all these files do get submitted, which is very annoying. And AFAICS there is no way to avoid it. So could the patch be either simply reverted or, if it's really needed, be at least made optional? In the latter case, please let me know if you'd accept a patch adding an option governing this behaviour. TIA! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1524 in reviewboard: postreview.py should ignore user configuration when generating diffs.
Updates: Status: Fixed Comment #3 on issue 1524 by trowbrds: postreview.py should ignore user configuration when generating diffs. http://code.google.com/p/reviewboard/issues/detail?id=1524 Fixed in rbtools 78791b9. Thanks! -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1524 in reviewboard: postreview.py should ignore user configuration when generating diffs.
Comment #2 on issue 1524 by alex.remen: postreview.py should ignore user configuration when generating diffs. http://code.google.com/p/reviewboard/issues/detail?id=1524 Easy enough to fix by using "--no-ext-diff", attaching a patch that fixes it for me at least. Attachments: postreview.py.patch 484 bytes -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1524 in reviewboard: postreview.py should ignore user configuration when generating diffs.
Updates: Status: Confirmed Labels: Milestone-RBTools-Release1.0 Component-RBTools Comment #1 on issue 1524 by chipx86: postreview.py should ignore user configuration when generating diffs. http://code.google.com/p/reviewboard/issues/detail?id=1524 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
