New files don't appear in the Review Request

2008-11-18 Thread cristian607
Hello! I am just starting to use review board. After a lot of trouble regarding its installation on our Windows server, we finally managed to get it working. I have noticed that the DIFF web interface only shows existing files that were modified. The files that are newly added are not shown. We

Re: pre-commit hook for subversion

2008-11-18 Thread cristian607
Hello, Thank you for sharing this information. We are starting to use review board, and I find the mechanism you described very interesting. I will try to make it work on our windows installation of review board. I have a question though. Why do you say "I known it's not a perfect solution, but

Re: New files don't appear in the Review Request

2008-11-18 Thread Christian Hammond
It certainly should be showing new files as well. What revision control system are you using? In some systems you have to "add" the files first before they'll show up in a diff. Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Tue, Nov 18, 2008 at 7:21 AM, cristian607 <[EMAIL

Post-review not handling binaries correctly

2008-11-18 Thread Daren
I am using post-review with a perforce repository and am running into problems when the changelist has binary files. The script outputs the following error: Traceback (most recent call last): File "post-review", line 1732, in main(sys.argv[1:]) File "post-review", line 1703, in main

Re: Post-review not handling binaries correctly

2008-11-18 Thread Christian Hammond
What version of post-review is this? I thought we had this fixed in SVN. Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Tue, Nov 18, 2008 at 2:00 PM, Daren <[EMAIL PROTECTED]> wrote: > > I am using post-review with a perforce repository and am running into > problems when

Re: Post-review not handling binaries correctly

2008-11-18 Thread Daren
I performed a sync this morning. On Nov 18, 2:09 pm, "Christian Hammond" <[EMAIL PROTECTED]> wrote: > What version of post-review is this? I thought we had this fixed in SVN. > > Christian > > -- > Christian Hammond - [EMAIL PROTECTED] > VMware, Inc. > > On Tue, Nov 18, 2008 at 2:00 PM, Daren <[