Issue checkbox in while entering comments

2011-10-14 Thread Gyanesh Singh
Hi, I need some more info on when does a reviewer tick this Issue check box? How is different from any other comment where this is not ticked? Is there any special meaning to it? The only difference I see when this is selected is that comment is shown little differently. PS: Curious on this as I

Re: Web API: interpreting line positions of diff comments

2011-10-14 Thread Robert Munteanu
I've tried to understand how this mapping is perfomed and came up with the following description/example. Can anyone confirm that I got it right? Thanks. ReviewBoard diff comments are mapped to the virtual diff table which is shown in the web interface, not to a location in the old or new

Re: Issue checkbox while entering comments

2011-10-14 Thread Gyanesh Singh
Hi, I am using RB 1.6, RBTools: 3.4 on RHEL I think the I didn't check the documentation in detail, before writing this email. I checked the documentation at http://www.reviewboard.org/docs/manual/dev/users/reviews/issue-tracking/ It says, By default, Open an issue is checked for new comments.

Internationalization and support for unicode

2011-10-14 Thread Sam
Installing RB for the first time today. I ran into problems when trying to comment on code lines using Chines; it would show up as question marks after I published it. I made a quick fix by changing the text column of a reviews_comment table to be utf8_general_ci collation in the database. I

post-review unable to log into ReviewBoard server

2011-10-14 Thread Phil Lodine
I've installed the RB 1.6.1 on my Windows 7 machine, with Apache 2.2 and mod_python, for use with our company's Subversion repository. (Many thanks to David Ball for his excellent braindump on installing RB on Windows!) The RB Admin site works fine (able to set up users, review groups etc.).

Re: Web API: interpreting line positions of diff comments

2011-10-14 Thread Christian Hammond
Hi Robert, Sorry I didn't get to this sooner, but you're correct. It's a virtual line number that is based on the generated diff using our specific algorithm. We use virtual line numbers rather than real numbers because real numbers wouldn't necessarily make sense depending on how you generate

Re: reviewboard 1.6.1 with wsgi

2011-10-14 Thread יונתן קינן
I got it to work in my personal laptop, I should note that you also need to change the settings file. /var/www/reviewboard/conf/settings_local.py You need to change SITE_ROOT from '/' to '/review/'(depends on the chosen sub directory) I also added reverse proxying so it could work with Bugzilla.

Re: post-review unable to log into ReviewBoard server

2011-10-14 Thread Christian Hammond
Hi Phil, It looks like your path to the Review Board server is configured wrong. It looks like you've installed RB in a subdirectory install, but your repository is pointing to the root of the server and not the subdirectory. If you're using the reviewboard:url SVN property, try setting it to

Re: Issue checkbox in while entering comments

2011-10-14 Thread Christian Hammond
Hi Gyanesh, The new issue tracking feature is intended as a way to speed up the review process. Typically, when a reviewer found something that needed to be changed, they would make a comment and say what the problem was. The developer would then generally reply with Fixed or Done or something.

Re: problem upgrading 1.5.6 to 1.6.1

2011-10-14 Thread Christian Hammond
Hmm hard to say. Sounds like a very round-about way of doing things. I believe there were some transformations we made during evolution time to the data in 1.6. Have you hit any problems yet? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware,

Re: Internationalization and support for unicode

2011-10-14 Thread Christian Hammond
Hi Sam, This sounds like another instance of the database not being utf-8. We operate almost entirely in utf-8, and the database needs to be able to store that. The reviews_review table is the cause for this error, but you'll likely hit it again and again with more tables unless the entire

Re: How to make compatibility mode enable RB for IE9

2011-10-14 Thread Christian Hammond
What values? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Oct 13, 2011 at 12:06 AM, jack jack jais...@gmail.com wrote: I am seeing this issue where the values are not getting populated if the

Re: Issue 2332 in reviewboard: Diff is not available intermittently

2011-10-14 Thread reviewboard
Updates: Status: NeedInfo Labels: -Type-Defect Type-Support Comment #3 on issue 2332 by chip...@gmail.com: Diff is not available intermittently http://code.google.com/p/reviewboard/issues/detail?id=2332 Are you an admin there? If not, you may need to contact your admin and

Re: Issue 2332 in reviewboard: Diff is not available intermittently

2011-10-14 Thread reviewboard
Comment #4 on issue 2332 by h13010...@gmail.com: Diff is not available intermittently http://code.google.com/p/reviewboard/issues/detail?id=2332 Hello, I have admin access on the ReviewBoard server. I see the same issue OP has mentioned. Any suggestions will be greatly appreciated.

Re: Issue 2259 in reviewboard: Replying to a comment on a review breaks the js popup on IE8

2011-10-14 Thread reviewboard
Comment #4 on issue 2259 by yos...@hotmail.com: Replying to a comment on a review breaks the js popup on IE8 http://code.google.com/p/reviewboard/issues/detail?id=2259 Here's a workaround, to change the floating review box into a fixed box on IE. ---

Re: Issue 2331 in reviewboard: Preview is not available message

2011-10-14 Thread reviewboard
Updates: Status: NeedInfo Comment #1 on issue 2331 by chip...@gmail.com: Preview is not available message http://code.google.com/p/reviewboard/issues/detail?id=2331 Has this ever worked? Does this break consistently? Does it report anything about where the temp directory is? Might

Re: Issue 2332 in reviewboard: Diff is not available intermittently

2011-10-14 Thread reviewboard
Comment #5 on issue 2332 by chip...@gmail.com: Diff is not available intermittently http://code.google.com/p/reviewboard/issues/detail?id=2332 The paths are confusing me. They look to be built with a mix of Windows and Unix line endings. That may be a red herring, given that the original

Re: Issue 2331 in reviewboard: Preview is not available message

2011-10-14 Thread reviewboard
Comment #2 on issue 2331 by katsnel...@gmail.com: Preview is not available message http://code.google.com/p/reviewboard/issues/detail?id=2331 What do you mean ever? It works fine, usually. Just the page needs to be refreshed. Perhaps this issue can be merged with 2332. It is the same

Re: Issue 2332 in reviewboard: Diff is not available intermittently

2011-10-14 Thread reviewboard
Comment #6 on issue 2332 by chip...@gmail.com: Diff is not available intermittently http://code.google.com/p/reviewboard/issues/detail?id=2332 Issue 2331 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group.

Re: Issue 2331 in reviewboard: Preview is not available message

2011-10-14 Thread reviewboard
Updates: Status: Duplicate Mergedinto: 2332 Comment #3 on issue 2331 by chip...@gmail.com: Preview is not available message http://code.google.com/p/reviewboard/issues/detail?id=2331 Didn't realize. The actual errors are different, but probably the same root cause. -- You

Re: Issue 2332 in reviewboard: Diff is not available intermittently

2011-10-14 Thread reviewboard
Comment #7 on issue 2332 by katsnel...@gmail.com: Diff is not available intermittently http://code.google.com/p/reviewboard/issues/detail?id=2332 Great, thank you. Sorry, we'll answer your questions a bit later. -- You received this message because you are subscribed to the Google Groups