Diff fie size limited to 1 MB

2012-05-16 Thread Ashish Sharma
Hi, With the release of Review Board (1.6.6), the diff file size is limited to 1MB only. Since my setup has a limit of 15MB with earlier version and with the latest update I am facing problems How can it be increased to say atleast to 10MB. thanks Ashish -- Want to help the Review Board proje

Re: Diff fie size limited to 1 MB

2012-05-16 Thread Christian Hammond
Hi Ashish, What's the size you're hitting with your diffs, and what's in them? Diffs that are megabytes in size are generally impossible to review. I'll look at making the limit flexible, but I want to better understand the problems people are hitting. Christian -- Christian Hammond - chip...@

Re: post-review throw diff error

2012-05-16 Thread Christian Hammond
Get the file from the repository (we use p4 print //depot/path/to/file#rev for this), get the diff (just for that file), and then do: patch -p0 < diff-filename You may need to tell it the location of the file, since it may not find it. Christian -- Christian Hammond - chip...@chipx86.com Revi

Re: Review Request not published

2012-05-16 Thread Geert Linders
Hi Christian, I attached the headers and data for a "publish" and for a "discard". I used the "Live http headers" and "httpfox" add-on for iceweasel to capture them. Hope that helps. Cheers - Geert -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/

Re: Review Request not published

2012-05-16 Thread Christian Hammond
Hi Geert, Hmmm so the publish.data and discard.data is what the addon is showing what's coming back from the server? Because if so, there's something very wrong here. That's XML data, and we're requesting JSON. I wonder if you could install Firebug and reproduce just to make sure that's not some b

Re: Review Request not published

2012-05-16 Thread Geert Linders
Hi Christian, I upgraded my Iceweasel to install Firebug. Now after the upgrade the problem has gone away, so I can't produce the logs you want anymore. Sorry about that. Is there anything else I can do for you to help? -- Want to help the Review Board project? Donate today at http://www.rev

Re: Review Request not published

2012-05-16 Thread Christian Hammond
Hi Geert, I wondered about that. I imagine there was some bug with Iceweasel causing that. Based on the Firefox version it claimed to be based off of, it's below our minimum supported browser requirements anyway. So if it works now, awesome :) Christian -- Christian Hammond - chip...@chipx86.co

Re: Problem creating a review after upgrading to 1.6.6 on CentOS 5.8 (patch file too large?)

2012-05-16 Thread Eric Johnson
I know I previously looked to see if I could get memcached to report what it has cached, but I didn't find anything. Eric On May 14, 2012, at 12:53 AM, Christian Hammond wrote: > Hi, > > Sorry, been on vacation this week. > > I'm not sure if memcached provides an easy way to see what's in th