Creating a new comment, first_line not being used correctly?

2012-09-17 Thread soorajchirag
Hi, I am looking at the web page: http://www.reviewboard.org/docs/manual/1.6/webapi/2.0/resources/review-diff-comment-list/#webapi2.0-review-diff-comment-list-resource to know how to post comments using the API on an uploaded diff. The comment is getting posted by using the parameters

Re: Creating a new comment, first_line not being used correctly?

2012-09-17 Thread Christian Hammond
Hi, The line number is not actually the line of a file, but rather the row of the side-by-side diff. This is for legacy reasons. Once upon a time, we didn't have real line number information. You'd have to figure out which row (1-based) corresponds to the line you care about and use that number.

Re: Creating a new comment, first_line not being used correctly?

2012-09-17 Thread Steven MacLeod
Hi, first_line is in reference to the line numbers of the file diff resource ( http://www.reviewboard.org/docs/manual/1.6/webapi/2.0/resources/file-diff/). This number doesn't correspond to either the left or right pane of the diff, but a combination of the two. If you were to count down the rows

Deploying reviewboard in virtualenv

2012-09-17 Thread Stephen Holsapple
Hi, I need to deploy reviewboard on a machine that doesn't have access to the internet inside a virtual environment. Does anyone else deploy reviewboard in a virtual environment? -- -Steve -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy