Re: rbt post startrev stoprev

2014-09-20 Thread David Trowbridge
A couple questions: - What version of rbtools are you using? - Can you run the same command with --debug and include the output? Thanks, -David On Fri, Sep 19, 2014 at 6:42 PM, Arjun A.M. arjun.ch...@gmail.com wrote: Hi I am not sure how exactly the post review works. I am using svn and if

Re: ReviewBoard v2.0.6 JS errors

2014-09-20 Thread Christian Hammond
Hi, Thanks for the detailed info. Sorry for the late response. I'm really unsure as to why that error involving 'extra_data' is occurring. I can't reproduce it. It *looks* as if the browser is interpreting the 404 as a success, resulting in us trying to parse the payload. That should not be

Re: ReviewBoard v2.0.6 JS errors

2014-09-20 Thread Zongwei
Thanks for fixing the apply error; I don't see it anymore in v2.07. The extra_data error is still there though, as you mentioned. I looked in Firefox, and the same AJAX call is there that 404's, but it still works correctly. I think your hunch might be right that Chrome (at least the version

Re: ReviewBoard v2.0.6 JS errors

2014-09-20 Thread Christian Hammond
Hi, Well, the 404 should be handled in Chrome itself as an error. It *is* valid to have a 404 from that API call (it just means there's no draft yet), and then we handle the failure response from it, but it sounds as if it's going down the wrong path. I'm also using Chrome and aren't hitting

Re: Issue 2766 in reviewboard: Web api 'review-requests' not returning draft review requests

2014-09-20 Thread reviewboard
Updates: Status: Fixed Comment #7 on issue 2766 by trowb...@gmail.com: Web api 'review-requests' not returning draft review requests https://code.google.com/p/reviewboard/issues/detail?id=2766 Fixed in release-2.0.x (28dbc4a). Thanks! -- You received this message because this

Re: Issue 3532 in reviewboard: Linking to a collapsed review does not expand the review

2014-09-20 Thread reviewboard
Updates: Status: Fixed Comment #3 on issue 3532 by trowb...@gmail.com: Linking to a collapsed review does not expand the review https://code.google.com/p/reviewboard/issues/detail?id=3532 Fixed in release-2.0.x (c5d577c). -- You received this message because this project is

Re: Issue 3300 in reviewboard: Add a confirmation when discarding a pending review

2014-09-20 Thread reviewboard
Updates: Status: Fixed Comment #5 on issue 3300 by trowb...@gmail.com: Add a confirmation when discarding a pending review https://code.google.com/p/reviewboard/issues/detail?id=3300 Fixed in release-2.0.x (8faeb03). -- You received this message because this project is configured to

Re: Issue 3438 in reviewboard: registration notification false positive?

2014-09-20 Thread reviewboard
Updates: Status: Fixed Comment #3 on issue 3438 by trowb...@gmail.com: registration notification false positive? https://code.google.com/p/reviewboard/issues/detail?id=3438 Fixed in release-2.0.x (decc128). Thanks! -- You received this message because this project is configured to

Re: Issue 3108 in reviewboard: APIErrors return 403 but do not log anything

2014-09-20 Thread reviewboard
Comment #5 on issue 3108 by justy...@gmail.com: APIErrors return 403 but do not log anything https://code.google.com/p/reviewboard/issues/detail?id=3108 this bug is up for grabs again, I'm done working on it. Justin Maillet -- You received this message because this project is

Re: Issue 3568 in reviewboard: Replying from the box in the diff view does not add message to thread.

2014-09-20 Thread reviewboard
Updates: Status: Duplicate Mergedinto: 1426 Comment #1 on issue 3568 by trowb...@gmail.com: Replying from the box in the diff view does not add message to thread. https://code.google.com/p/reviewboard/issues/detail?id=3568 (No comment was entered for this change.) -- You

Re: Issue 1426 in reviewboard: Reply on the diff page is confusing and error-prone.

2014-09-20 Thread reviewboard
Comment #20 on issue 1426 by trowb...@gmail.com: Reply on the diff page is confusing and error-prone. https://code.google.com/p/reviewboard/issues/detail?id=1426 Issue 3568 has been merged into this issue. -- You received this message because this project is configured to send all issue