Re: Bad table class for incremental diff of new file
Good to know. In my (unsolicited) opinion, reviewbord could do away entirely with the newfile class. I want my new file diffs to appear in two columns with an empty left column. It makes it obvious that this is a diff view (as opposed as a snapshot view) and results in a more consistent display, where "the important stuff" is always on the right. I realize that the "only one column when it's a new file" is a seductive idea, but I think it is bad human factors. Two cents. On Sat, Jan 31, 2009 at 23:42, Christian Hammond wrote: > Hi David. > > There's a bug open for this at: > > http://code.google.com/p/reviewboard/issues/detail?id=730 > > We should have this fixed for 1.0. It's not fixed yet, and it's been around > for a while, but it shouldn't be hard to fix. We'll probably get it in the > betas. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Bad table class for incremental diff of new file
Hi David. There's a bug open for this at: http://code.google.com/p/reviewboard/issues/detail?id=730 We should have this fixed for 1.0. It's not fixed yet, and it's been around for a while, but it shouldn't be hard to fix. We'll probably get it in the betas. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Sat, Jan 31, 2009 at 8:08 AM, David Allouche wrote: > > Steps to reproduce: Create a review request with a diff that includes > the creation of a file. Update the diff with an additional change to > the new file. Go to the diff view, view changes between r1 and r2. > > Observed behavior: The side-by-side diff table for the new file has > class="sidebyside newfile", but there is actual data in the left > column (the r1 of the new file). The CSS in diffviewer.css lines 19 > (table.sidebyside.newfile col.left) and 32 (table.sidebyside.newfile > col.left) causes the left column to be narrow and the text inside it > to wrap (inside firefox 3 at list, it seems IE7 does not honor > white-space: pre-wrap). > > Expected behaviour: Since there is content in both columns, this > side-by-side diff should not have the "newfile" class. Removing this > class using Firebug leads to the desired layout. > > ReviewBoard-0.9.dev-20090116. Okay, that's not the lastest version, > and I have not tested with the alpha prerelease, lacking time to do > the upgrade. > > Is that a known issue? Have it been fixed in the alpha release? > > > > --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Bad table class for incremental diff of new file
Steps to reproduce: Create a review request with a diff that includes the creation of a file. Update the diff with an additional change to the new file. Go to the diff view, view changes between r1 and r2. Observed behavior: The side-by-side diff table for the new file has class="sidebyside newfile", but there is actual data in the left column (the r1 of the new file). The CSS in diffviewer.css lines 19 (table.sidebyside.newfile col.left) and 32 (table.sidebyside.newfile col.left) causes the left column to be narrow and the text inside it to wrap (inside firefox 3 at list, it seems IE7 does not honor white-space: pre-wrap). Expected behaviour: Since there is content in both columns, this side-by-side diff should not have the "newfile" class. Removing this class using Firebug leads to the desired layout. ReviewBoard-0.9.dev-20090116. Okay, that's not the lastest version, and I have not tested with the alpha prerelease, lacking time to do the upgrade. Is that a known issue? Have it been fixed in the alpha release? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
