Re: Can I send full diffs when publishing the review?

2010-05-17 Thread Jon
Thanks Christian! Keep up with good work with 1.5 it's working really well. On May 17, 5:24 pm, Christian Hammond wrote: > Hi Jon. > > I agree that it could be nice on some setups. We might be able to do > something down the road for this but not immediately. As for > customization of the e-mail

Re: Can I send full diffs when publishing the review?

2010-05-17 Thread Christian Hammond
Hi Jon. I agree that it could be nice on some setups. We might be able to do something down the road for this but not immediately. As for customization of the e-mail template, this is something I would very much like to do in the future. Not for 1.5, but maybe after that. Christian On Friday, M

Re: Can I send full diffs when publishing the review?

2010-05-14 Thread Jon
Hi Christian, I do realize performance could be a concern so I know this wouldn't be for everyone and it would have to be a setting. But for teams that are small enough (server load) and ones that don't send huge chunks of code I think this would be great. One suggestion would be to limit the size

Re: Can I send full diffs when publishing the review?

2010-05-14 Thread Jan Koprowski
E-mail templates will solve all kind of this problems. On May 14, 10:11 am, Christian Hammond wrote: > Hi Jon, > > Including the full diff could certainly lead to overly large e-mails in many > setups. For example, on a project I've been doing lately, I've had changes > that spanned over 60 files

Re: Can I send full diffs when publishing the review?

2010-05-14 Thread Christian Hammond
Hi Jon, Including the full diff could certainly lead to overly large e-mails in many setups. For example, on a project I've been doing lately, I've had changes that spanned over 60 files with thousands of inserts, deletes and replaces. This would make for really long e-mails, which could increase

Can I send full diffs when publishing the review?

2010-05-13 Thread Jon
I just setup 1.5 beta 2 with Mercurial and postreview extension and it's working pretty well. However, one thing that people in my group are asking for is a full diff of the entire commit with the diff list in the publish email. I've seen that RB does this when you do a code review so is it easy t