Re: Comments disappear from the Diff view
On Thu, Jul 16, 2009 at 5:49 AM, John Szakmeister wrote: > On Thu, Jul 16, 2009 at 5:22 AM, Christian Hammond wrote: >> What we need to know is what's common between all occurrences in your setup. >> >> Are these all comments on the first page in the diff viewer, or latter >> pages? > > They're all on the first page. In fact, I don't think we have any > that currently span multiple pages at the moment (I *just* got RB > setup recently). > >> Are these near a collapsed region? > > The ones that disappear are *in* the collapsed region. One of the > devs was commenting on something a number of lines away from the diff, > because he thought it would be affected. > >> How many lines do they span? > > 1 or 2. > >> Does it span over a collapsed region? > > See above. > >> Are you certain when clicking View Diff that you're looking at the same >> revision as the comment? > > I believe so, but I'll check again. I could be stupid user error. :-) I double checked, we are looking at the right revision. :-( -John --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Comments disappear from the Diff view
On Thu, Jul 16, 2009 at 5:22 AM, Christian Hammond wrote: > What we need to know is what's common between all occurrences in your setup. > > Are these all comments on the first page in the diff viewer, or latter > pages? They're all on the first page. In fact, I don't think we have any that currently span multiple pages at the moment (I *just* got RB setup recently). > Are these near a collapsed region? The ones that disappear are *in* the collapsed region. One of the devs was commenting on something a number of lines away from the diff, because he thought it would be affected. > How many lines do they span? 1 or 2. > Does it span over a collapsed region? See above. > Are you certain when clicking View Diff that you're looking at the same > revision as the comment? I believe so, but I'll check again. I could be stupid user error. :-) -John --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Comments disappear from the Diff view
What we need to know is what's common between all occurrences in your setup. Are these all comments on the first page in the diff viewer, or latter pages? Are these near a collapsed region? How many lines do they span? Does it span over a collapsed region? Are you certain when clicking View Diff that you're looking at the same revision as the comment? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Thu, Jul 16, 2009 at 2:15 AM, John Szakmeister wrote: > > On Wed, Jul 15, 2009 at 11:30 PM, pouakai68 wrote: > > > > I have found a post that points to the fix in my case: > > > http://code.google.com/p/reviewboard/issues/detail?id=1028&can=1&q=comments%20diff&colspec=ID%20Type%20Status%20Priority%20Component%20Owner%20Summary%20Milestone > > > > : ) > > Too bad it doesn't fix mine. 1.0 has that fix. :-( > > -John > > > > --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Comments disappear from the Diff view
On Wed, Jul 15, 2009 at 11:30 PM, pouakai68 wrote: > > I have found a post that points to the fix in my case: > http://code.google.com/p/reviewboard/issues/detail?id=1028&can=1&q=comments%20diff&colspec=ID%20Type%20Status%20Priority%20Component%20Owner%20Summary%20Milestone > > : ) Too bad it doesn't fix mine. 1.0 has that fix. :-( -John --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Comments disappear from the Diff view
I have found a post that points to the fix in my case: http://code.google.com/p/reviewboard/issues/detail?id=1028&can=1&q=comments%20diff&colspec=ID%20Type%20Status%20Priority%20Component%20Owner%20Summary%20Milestone : ) happy me --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Comments disappear from the Diff view
On Wed, Jul 15, 2009 at 12:34 AM, pouakai68 wrote: > > I have a review that spans several files. I start from the dashboard > and click the review. I am presented with the "review" view, i click > on "View Diff" and conduct the review making comments as I go. I click > on "View Reviews". I am presented with the 'review view' again, the > screen that list all my review comments. All things going well I can > click on the filename above the comment and I am hyperlinked to the > file:line in the diff. My problem is that this works only about the > 1/2 the time and in fact if go manually to the file:line in the 'diff > view' my comment and it's 'call-out bubble' are no longer visible !! > > Does anyone have any advice as to how I can locate the source of the > problem ?? I've found the same thing happens... but only when I comment on a line that would have normally been collapsed (it further away from the diff). -John --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Comments disappear from the Diff view
I have a review that spans several files. I start from the dashboard and click the review. I am presented with the "review" view, i click on "View Diff" and conduct the review making comments as I go. I click on "View Reviews". I am presented with the 'review view' again, the screen that list all my review comments. All things going well I can click on the filename above the comment and I am hyperlinked to the file:line in the diff. My problem is that this works only about the 1/2 the time and in fact if go manually to the file:line in the 'diff view' my comment and it's 'call-out bubble' are no longer visible !! Does anyone have any advice as to how I can locate the source of the problem ?? Regards Chris --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
