File Attachment Comments - Intended Behavior
Hello all, We're currently running RB 1.7.6 and we're seeing that the only people who can add comments to a file attachment are super users and the person who created the review request. Our group thinks that having reviewers adding comments (and issues) to an attachment would be useful. After some digging, adding comments to an attachment appears tied to permission [reviews | review request | Can edit review request]. It would seem that the intent was to only all reviews on attachments, and not comments. Are we simply wanting to use RB in an unintended way? Or is there a bug or changed behavior in later RB releases? Many thanks in advance, -Chad -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: File Attachment Comments - Intended Behavior
Hi Chad, That permission doesn't impact the ability to comment at all. Are you sure the review request's draft is published? 1.7.6 is also very old. It's possible there was some bug that has since been fixed. Certainly, the behavior you describe is not how it's supposed to be. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Tue, Feb 25, 2014 at 12:43 PM, Chad Peterson chad.m.peter...@gmail.comwrote: Hello all, We're currently running RB 1.7.6 and we're seeing that the only people who can add comments to a file attachment are super users and the person who created the review request. Our group thinks that having reviewers adding comments (and issues) to an attachment would be useful. After some digging, adding comments to an attachment appears tied to permission [reviews | review request | Can edit review request]. It would seem that the intent was to only all reviews on attachments, and not comments. Are we simply wanting to use RB in an unintended way? Or is there a bug or changed behavior in later RB releases? Many thanks in advance, -Chad -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: File Attachment Comments - Intended Behavior
Yeah, it's on a published review request. We see the comment button next to the attachment, but when we click it, nothing happens. Unless you're a Superuser, created the request yourself, or have the Can Edit review request permission set. Honestly, i would have expected [ reviews | file attachment comment | Can Add file attachment comment] to have some effect, but it didn't make a difference. The behavior seemed completely odd to me too. We'll see if we can get to a newer version of ReviewBoard. I'll leave out the rant of how we just got this new version... Cheers for the prompt feedback though. If I learn any more, I'll be sure to report back. On Wednesday, February 26, 2014 2:11:11 PM UTC-6, Christian Hammond wrote: Hi Chad, That permission doesn't impact the ability to comment at all. Are you sure the review request's draft is published? 1.7.6 is also very old. It's possible there was some bug that has since been fixed. Certainly, the behavior you describe is not how it's supposed to be. Christian -- Christian Hammond - chi...@chipx86.com javascript: Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Tue, Feb 25, 2014 at 12:43 PM, Chad Peterson chad.m@gmail.comjavascript: wrote: Hello all, We're currently running RB 1.7.6 and we're seeing that the only people who can add comments to a file attachment are super users and the person who created the review request. Our group thinks that having reviewers adding comments (and issues) to an attachment would be useful. After some digging, adding comments to an attachment appears tied to permission [reviews | review request | Can edit review request]. It would seem that the intent was to only all reviews on attachments, and not comments. Are we simply wanting to use RB in an unintended way? Or is there a bug or changed behavior in later RB releases? Many thanks in advance, -Chad -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
