Hi Jeff.
Thanks for the feedback! It's always good to hear from new users.
The ability to post brand new files for review without diffing against a
repository is something that has been requested a bit. It will be a while
before we can address this (we're limiting new features until 1.0 is
released, and we have a good list of must-haves for 1.5), but there are some
things we'll be able to do for this later. People have been asking about
using Review Board for writing docs and webpages without using a repository
as a backing, so implementing that would address this need.
We're also talking about allowing arbitrary file types to be uploaded, with
pluggable reviewing backends for the file types. This might tie in well to
what you need. Specify a list of files, indicate they should be reviewed
using the current diff viewer UI, and be done.
I'm not sure what you mean about not syntax highlighting though. As long as
the file extension is correct, it should syntax highlight correctly, even if
it's a new dummy file.
As far as commenting is concerned, it's difficult to change the existing
commenting UI too much, in terms of how to select which region to comment on
in the diff viewer. I wouldn't want to change users' expectations of how
this works. Maybe we can put this in the comment dialog itself to indicate
if the comment is specifically against the code in the old file, new file,
or both. I'd have to think about how to make this not seem confusing though.
Would you mind filing feature enhancements on these things? As I said above,
it will be a while before we can really address these issues, but having
bugs filed will help us at least to track and prioritize these.
Thanks!
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com
On Fri, Feb 27, 2009 at 1:22 AM, bizb wrote:
>
> We just setup the alpha at work and I'd like to give some feedback.
>
> The most important thing is when dealing with brand new code or code
> that has been refactored to the point that a diff is completely out of
> context. It would be nice just to post single files and not diffs to
> review board and have syntax highlighted view that could be commented
> on. (this could be hacked by diffing against an empty file or
> something but why would I want to waste space and not syntax
> highlight?)
>
> Also commenting on lines seems weird in a side by side diff. It seems
> like you should be able to comment _either_ or _both_. The first
> review I did a function was moved from the top of the file, to the
> bottom and diff didn't line up. So in other words, it would be nice
> to comment on the right hand only, left hand only, or maybe both if
> you'd like to reference the before and after.
>
> This software is amazing and hats off to you guys. I heard about the
> internal google code review tool (saw a presentation on it and was
> drooling) The open source version wasn't up to snuff and you guys
> seem to be the first with an well rounded awesome product. Congrats
> on all the hard work!
>
> -Jeff
> >
>
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
