Re: Hook capabilities: Extending Reviewboard
Ya that's exactly what I mean. Unfortunately I am not in a position to make a patch for this at the moment. Given enough time I would love to give a little something back, but I wouldn't be able to start on it until the fall. Also, I have little Django experience which would be a hindering at the moment (I'm learning it though!). So it if nobody has done it by then, I would definitely do this. Thanks for all of your work and help. Chris On Monday, July 6, 2015 at 4:10:42 PM UTC-7, Christian Hammond wrote: > > Hey Chris, > > This sounds like something that would be a good addition, but doesn't > exist yet. Just to make sure I fully understand, you want this outside of > the review request box, below it, but above the diff viewer boxes. > > I'm all for adding a few more TemplateHooks like this. Perhaps > after-review-request-box and before-diff-viewer? (The former would be on > any page with a review request box, the latter being before the collection > of diff viewer boxes specifically?) > > Are you in a position to put together a patch for this for Review Board? > > Christian > > -- > Christian Hammond - chri...@beanbaginc.com > Review Board - https://www.reviewboard.org > Beanbag, Inc. - https://www.beanbaginc.com > > -Original Message- > From: Chris Lang > > Reply: revie...@googlegroups.com >> > Date: July 6, 2015 at 3:08:28 PM > To: revie...@googlegroups.com >> > Subject: Hook capabilities: Extending Reviewboard > > > Hey there, > > > > I have been developing an extension for ReviewBoard and have a prototype > > for the extension running on my local version of ReviewBoard. It is an > > extension for reviewing diffs on a review request. I have successfully > > gotten it to appear at the bottom of the page when you click on a review > > request, and then click on View Diff. I was able to do so using the > > TemplateHook and setting it to "base-after-content". This is great so > far > > however, I would like this to appear after the > summary/description/testing > > done box but before any of the side-by-side diff comparisons. The > > "base-before-content" option also does not achieve the desired results > as > > my extension comes before the summary box. From reading about the > different > > hooks I have not be able to find a way to achieve this. If there is > > currently a way to set this up, that would be great. If there is not, I > > would just like to express interest in having such an option available > for > > everyone. Thank you for your time. > > > > Sincerely, > > Chris Lang > > > > -- > > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > > Happy user? Let us know! https://www.reviewboard.org/users/ > > --- > > You received this message because you are subscribed to the Google > Groups "reviewboard" > > group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to reviewboard...@googlegroups.com . > > For more options, visit https://groups.google.com/d/optout. > > > > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Hook capabilities: Extending Reviewboard
Hey Chris, This sounds like something that would be a good addition, but doesn't exist yet. Just to make sure I fully understand, you want this outside of the review request box, below it, but above the diff viewer boxes. I'm all for adding a few more TemplateHooks like this. Perhaps after-review-request-box and before-diff-viewer? (The former would be on any page with a review request box, the latter being before the collection of diff viewer boxes specifically?) Are you in a position to put together a patch for this for Review Board? Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com -Original Message- From: Chris Lang Reply: reviewboard@googlegroups.com > Date: July 6, 2015 at 3:08:28 PM To: reviewboard@googlegroups.com > Subject: Hook capabilities: Extending Reviewboard > Hey there, > > I have been developing an extension for ReviewBoard and have a prototype > for the extension running on my local version of ReviewBoard. It is an > extension for reviewing diffs on a review request. I have successfully > gotten it to appear at the bottom of the page when you click on a review > request, and then click on View Diff. I was able to do so using the > TemplateHook and setting it to "base-after-content". This is great so far > however, I would like this to appear after the summary/description/testing > done box but before any of the side-by-side diff comparisons. The > "base-before-content" option also does not achieve the desired results as > my extension comes before the summary box. From reading about the different > hooks I have not be able to find a way to achieve this. If there is > currently a way to set this up, that would be great. If there is not, I > would just like to express interest in having such an option available for > everyone. Thank you for your time. > > Sincerely, > Chris Lang > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" > group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Hook capabilities: Extending Reviewboard
Hey there, I have been developing an extension for ReviewBoard and have a prototype for the extension running on my local version of ReviewBoard. It is an extension for reviewing diffs on a review request. I have successfully gotten it to appear at the bottom of the page when you click on a review request, and then click on View Diff. I was able to do so using the TemplateHook and setting it to "base-after-content". This is great so far however, I would like this to appear after the summary/description/testing done box but before any of the side-by-side diff comparisons. The "base-before-content" option also does not achieve the desired results as my extension comes before the summary box. From reading about the different hooks I have not be able to find a way to achieve this. If there is currently a way to set this up, that would be great. If there is not, I would just like to express interest in having such an option available for everyone. Thank you for your time. Sincerely, Chris Lang -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
