Re: How to review an entire application?
Christian> Let me see if I have this right. You have a directory full of Christian> committed code that hasn't been reviewed yet. This code may Christian> span multiple revisions. You want to put that code up for Christian> review. Is that correct? Yup. Christian> There's no built-in option for doing this with CVS, but with Christian> RBTools 0.2 RC1, you could make use of the new Christian> --diff-filename. Basically, you'd generate a diff using cvs Christian> diff and covering all revisions of that directory only, and Christian> then pass the resulting filename using post-review Christian> --diff-filename= Thanks. In looking back at what was installed I think I actually had 1.0.4 installed, not 0.9. I was looking at the version string in __init__.py. I have upgraded to the latest versions of ReviewBoard and RBTools nonetheless. It seems to me that If I'm trying to gather up all the Python files in a directory for submission as a review diff that this should work: for f in $(find . -name '*.py') ; do diff -Nu /dev/null $f done > review.diff post-review --diff-filename=review.diff ... I haven't actually tried that yet, but that would seem to be a good first approximation. Skip -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: How to review an entire application?
Hi Skip, Your versions of post-review and Review Board sound pretty out-of-date, first of all, so I'd recommend setting aside some time to do an upgrade. Let me see if I have this right. You have a directory full of committed code that hasn't been reviewed yet. This code may span multiple revisions. You want to put that code up for review. Is that correct? There's no built-in option for doing this with CVS, but with RBTools 0.2 RC1, you could make use of the new --diff-filename. Basically, you'd generate a diff using cvs diff and covering all revisions of that directory only, and then pass the resulting filename using post-review --diff-filename= Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Feb 22, 2010 at 9:49 AM, wrote: > I'm still getting familiar with Review Boar. I use it like so: > > * make a branch > * edit/debug/lather/rinse/repeat > * post-review > * visit url & fill in description, title, assign reviewers > > One of my colleagues asked a few of us to review a couple small > applications > written by a new hire. This stuff had already been checked into our CVS > repository. I suspect this is not standard practice, but is there some way > to post a review request for an entire application or an entire directory > (that is, where there are no changes against the repository for the current > directory)? I see nothing obvious in post-review --help output which > suggests this is possible. I'm using post-review 0.8 and ReviewBoard 0.9 > ATM, but I have the power to upgrade it if necessary (it's just running on > my desktop machine). > > Outside of me and a few other developers ReviewBoard is unknown at work, so > I imagine this sort of "here, the application is finished, please review it > all" request is going to pop up for some time to come. I'd really like to > be able to accommodate such requests as a way to demonstrate RB's > usefulness. > > Thanks, > > -- > Skip Montanaro - s...@pobox.com - http://www.smontanaro.net/ > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
How to review an entire application?
I'm still getting familiar with Review Boar. I use it like so: * make a branch * edit/debug/lather/rinse/repeat * post-review * visit url & fill in description, title, assign reviewers One of my colleagues asked a few of us to review a couple small applications written by a new hire. This stuff had already been checked into our CVS repository. I suspect this is not standard practice, but is there some way to post a review request for an entire application or an entire directory (that is, where there are no changes against the repository for the current directory)? I see nothing obvious in post-review --help output which suggests this is possible. I'm using post-review 0.8 and ReviewBoard 0.9 ATM, but I have the power to upgrade it if necessary (it's just running on my desktop machine). Outside of me and a few other developers ReviewBoard is unknown at work, so I imagine this sort of "here, the application is finished, please review it all" request is going to pop up for some time to come. I'd really like to be able to accommodate such requests as a way to demonstrate RB's usefulness. Thanks, -- Skip Montanaro - s...@pobox.com - http://www.smontanaro.net/ -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
