Re: Interdiff issue: changes unmarked and thus got review unnoticed.

2016-09-06 Thread Vlad 
Hi Christian,

Thank you for the reply, I have filled the bug with a screenshot -
https://hellosplat.com/s/beanbag/tickets/4462/
This is not merge but two consequent diffs
(rb.local/rb/r/137/diff/2-3/?collapse=1)
with two lines _moved_ up.

I downloaded two diffs from RB and run simple diff tool, it worked as
expected, two +lines and two -lines:

$ diff -u diff2.txt diff3.txt

--- diff2.txt 2016-09-06 12:57:52.0 +0300

+++ diff3.txt 2016-09-06 12:58:06.0 +0300

@@ -2935,6 +2935,8 @@

   */

   bool warn_or_err_on_..

 #endif

+

+private:

   /**

 Remove the ..



@@ -2953,8 +2955,6 @@

 @param[in] ..

   */

   void update_..

-

-private:

 #ifdef HAVE_..

   /// Lock all

   void lock_..

@@ -3007,7 +3007,7 @@

 #endif



   /**

-This is a sub task of update_g..

+This is a sub task of update_on_..

 the case of a thread that needs



May be I am missing something, but I could find right place for debug
output.

/v

On Tue, Sep 6, 2016 at 12:32 PM, Christian Hammond  wrote:

> Hi Vlad,
>
> Are those changes part of your diffs, or from a merge? We filter out
> content from merges, showing them as equals, since they're not a factor in
> the changes being reviewed.
>
> There is a bug with interdiffs today that can result in some lines in very
> specific cases not showing up as being changed. I have a fix for this, but
> we need to do some thorough testing before it can go in.
>
> Christian
>
> --
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>
> On Fri, Sep 2, 2016 at 7:40 AM, Vlad S.  wrote:
>
>> Hi!
>>
>> I have issue with interdiff view, the changes from diff1 to diff2 left
>> unmarked and thus got review unnoticed. See attachment.
>> The lines removed from diff2 was not marked at all.
>>
>> Would you provide some guidance?
>>
>> Which .py file shall I look at for the interdiff which generate the view?
>> Where shall I add debug output to see interdiff code outputs.
>> It seems it is not git diff issue, but the interdiff code.
>>
>> /v
>>
>> --
>> Supercharge your Review Board with Power Pack:
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons:
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to reviewboard+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to a topic in the
> Google Groups "reviewboard" group.
> To unsubscribe from this topic, visit https://groups.google.com/d/
> topic/reviewboard/w7kVBNu8EeU/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Interdiff issue: changes unmarked and thus got review unnoticed.

2016-09-06 Thread Christian Hammond 
Hi Vlad,

Are those changes part of your diffs, or from a merge? We filter out
content from merges, showing them as equals, since they're not a factor in
the changes being reviewed.

There is a bug with interdiffs today that can result in some lines in very
specific cases not showing up as being changed. I have a fix for this, but
we need to do some thorough testing before it can go in.

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Fri, Sep 2, 2016 at 7:40 AM, Vlad S.  wrote:

> Hi!
>
> I have issue with interdiff view, the changes from diff1 to diff2 left
> unmarked and thus got review unnoticed. See attachment.
> The lines removed from diff2 was not marked at all.
>
> Would you provide some guidance?
>
> Which .py file shall I look at for the interdiff which generate the view?
> Where shall I add debug output to see interdiff code outputs.
> It seems it is not git diff issue, but the interdiff code.
>
> /v
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Interdiff issue: changes unmarked and thus got review unnoticed.

2016-09-02 Thread Vlad S. 
Hi!

I have issue with interdiff view, the changes from diff1 to diff2 left 
unmarked and thus got review unnoticed. See attachment.
The lines removed from diff2 was not marked at all.

Would you provide some guidance?

Which .py file shall I look at for the interdiff which generate the view? 
Where shall I add debug output to see interdiff code outputs.
It seems it is not git diff issue, but the interdiff code.

/v

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.