Hello!
Please see my comments inline.
On Saturday 31 January 2009 17:35:45 Christian Hammond wrote:
> Thanks for the patches. I'll look into them.
You're welcome.
> > http://reviews.review-board.org/r/729/diff/ ) Probably these keys are
> > intercepted as hotkeys by diffviewer component. I use
Hi Alexey.
Thanks for the patches. I'll look into them.
Some comments below.
On Sat, Jan 31, 2009 at 3:21 AM, Alexey Morozov wrote:
> When I first switched to LDAP based auth I discovered that I can't login
> as 'admin' anymore. Short investigation showed that the problem is in
> exception ha
Hi!
On Friday 30 January 2009 16:41:17 Christian Hammond wrote:
> Hi Alexey.
> We have a patch up that I haven't reviewed yet (I'd like other
> LDAP-knowledgeable users to look into it if possible) that may address your
> concerns. Would you be able to give it a try?
>
> http://reviews.review-boa
Hi Alexey.
I've been sort of silent with this post because I really don't have much
LDAP experience. We've had a number of patches that have changed our LDAP
support around, and I try to follow it as best I can, but I don't know the
implications of the patches. So I can't really say what the corre
Hello again!
On Thursday 29 January 2009 05:03:05 Alexey Morozov wrote:
> Certainly the change is rather trivial but since I'm almost unfamiliar with
> LDAP-related things I'd like to hear first that there're no other
> considerations not to add the binding.
Also in http://www.mechanicalcat.net/
Hello!
The current LDAP authentication scheme used in Review Board
(acconts/backends.py|LDAPBackend.authenticate()) assumes that a chosen LDAP
server allows anonymous search. This is not always true (e.g. our internal
corp. directory server :) ) , so perhaps prior binding is necessary. Of
cou
