Re: Post-review: Review id before publishing the review request

2011-12-03 Thread jack jack
Hi Chris,

You were are correct, due to login issue xml entries are appearing empty.

I think you can help me here to get my requirement fulfill.

I want to give permission to common user say ABC to view the xml output of
all the other user's review request, and while doing this my issue will get
solved. so how to do this. which permission i need to give to the common
user.

please let me know if you need any more information.

Regards,
jack

On Sat, Dec 3, 2011 at 1:05 AM, Christian Hammond chip...@gmail.com wrote:

 The behavior hasn't changed. The way logins work has. Can you show me the
 code that logs in?

 (Btw, this is probably more appropriate for the reviewboard-dev list)

 Christian



 On Dec 2, 2011, at 5:19, jack jack jais...@gmail.com wrote:

 Hi Chris,

 Thanks for the response.

 My script has logged in as user who posted the review request. Just to
 bring to your notice that for ReviewBoard V 1.0 api our script was working
 fine and getting the Review id. before publishing. Has this behavior
 changed in RB 1.6? if yes then how to get rid before publishing.

 Regards,
 Jack

 On Fri, Dec 2, 2011 at 4:56 PM, Christian Hammond chip...@chipx86.comwrote:

 That's happening because your script isn't logging in as the user who
 posted the review request. Unpublished review requests can only be accessed
 by the user who owns them.


 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com


 On Fri, Dec 2, 2011 at 2:22 AM, Nilesh Jaiswal nileshj...@gmail.comwrote:

 My script doing following steps

 call post-review

 At this point i expect the Review id get generated hence i try to fetch
 the review id through change number below routine
 call subroutine to get_review_request_by_changenum which does

  self.myurl = self.rbserver +
 '/api/review-requests/?changenum=%srepository=1' % changenum
  self.urlopen = self.opener.open(self.myurl)
  self.result = simplejson.load(self.urlopen)
  if self.result['stat'] == ok:
 self.dict = self.result['review_request']
 return self.dict
 else:
 return

 But self.dict does not contains id.



 On Fri, Dec 2, 2011 at 2:31 PM, Christian Hammond 
 chip...@chipx86.comwrote:

 I'm not entirely sure what the problem is. If your script is creating
 the review request, then the ID is coming back in the payload. If it's
 doing anything with the review request, you should have the ID.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com



 On Thu, Dec 1, 2011 at 8:28 PM, jack jack jais...@gmail.com wrote:

 Hi Chris,

 You are right the review request isn't publish, But what if i want to
 get review id before publishing.?

 The behavior of getting review id before publishing was working for
 Reviewboard version 1.0 api, hence we were able to get the review id 
 before
 publishing easily, how to do that now, I have noticed that once i publish
 the review request from RB GUI my script in second time works properly, 
 but
 in that case its two step process which is incorrect for the user.

 Also i have logged in properly my script.

 Regards,
 Jack


 On Fri, Dec 2, 2011 at 2:45 AM, Christian Hammond 
 chip...@gmail.comwrote:

 Hi,

 First off, please email the list only and not me directly. I won't
 respond to direct emails any faster than the list.

 The problem is likely that the review request isn't published and the
 script you're writing isn't logged in as a user that can see it. You'll
 need to authenticate first.

 Christian



 On Dec 1, 2011, at 5:57, jack jack jais...@gmail.com wrote:

 Once the posting review request is complete

 I am trying to get review id from changelist number.

 So i am trying following URL get the review id


 http://xxx.oftware.com//api/review-requests/?changenum=127061repository=1

 Which shows me XML output which contains the review id as '4'

 but when i pass the

 self.myurl = self.rbserver +
 '/api/review-requests/?changenum=%srepository=1' % changenum
 self.urlopen = self.opener.open(self.myurl)
 self.result = simplejson.load(self.urlopen)

 my self.result contains empty data

 http://x.xftware.com//r/4/
 {u'total_results': 0, u'stat': u'ok', u*'review_requests': []*,
 u'links': {u'self': {u'href': u'
 http://x.oftware.com//api/review-requests/?changenum=127738repository=1',
 u'method': u'GET'}, u'create': {u'href': u'
 http://x.oftware.com//api/review-requests/', u'method':
 u'POST'}}}

 Can you somebody help me what i am missing here, it might possible i
 am missing very basic thing here as i am not good in Json etc.

 Thanks in advance.



 On Thu, Dec 1, 2011 at 6:02 PM, jack jack jais...@gmail.com wrote:

 Hi Chris,

 Sorry for sending you email in person, but it is very urgent.

 I posted a 

Re: Post-review: Review id before publishing the review request

2011-12-03 Thread Christian Hammond
You'd need to give essentially admin access, which is probably a bad idea.
They'd be able to modify any review request. There's no other option. Why
can't the script just log in as the correct user?

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Sat, Dec 3, 2011 at 1:05 AM, jack jack jais...@gmail.com wrote:

 Hi Chris,

 You were are correct, due to login issue xml entries are appearing empty.

 I think you can help me here to get my requirement fulfill.

 I want to give permission to common user say ABC to view the xml output of
 all the other user's review request, and while doing this my issue will get
 solved. so how to do this. which permission i need to give to the common
 user.

 please let me know if you need any more information.

 Regards,
 jack

 On Sat, Dec 3, 2011 at 1:05 AM, Christian Hammond chip...@gmail.comwrote:

 The behavior hasn't changed. The way logins work has. Can you show me the
 code that logs in?

 (Btw, this is probably more appropriate for the reviewboard-dev list)

 Christian



 On Dec 2, 2011, at 5:19, jack jack jais...@gmail.com wrote:

 Hi Chris,

 Thanks for the response.

 My script has logged in as user who posted the review request. Just to
 bring to your notice that for ReviewBoard V 1.0 api our script was working
 fine and getting the Review id. before publishing. Has this behavior
 changed in RB 1.6? if yes then how to get rid before publishing.

 Regards,
 Jack

 On Fri, Dec 2, 2011 at 4:56 PM, Christian Hammond chip...@chipx86.comwrote:

 That's happening because your script isn't logging in as the user who
 posted the review request. Unpublished review requests can only be accessed
 by the user who owns them.


 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com


 On Fri, Dec 2, 2011 at 2:22 AM, Nilesh Jaiswal nileshj...@gmail.comwrote:

 My script doing following steps

 call post-review

 At this point i expect the Review id get generated hence i try to fetch
 the review id through change number below routine
 call subroutine to get_review_request_by_changenum which does

  self.myurl = self.rbserver +
 '/api/review-requests/?changenum=%srepository=1' % changenum
  self.urlopen = self.opener.open(self.myurl)
  self.result = simplejson.load(self.urlopen)
  if self.result['stat'] == ok:
 self.dict = self.result['review_request']
 return self.dict
 else:
 return

 But self.dict does not contains id.



 On Fri, Dec 2, 2011 at 2:31 PM, Christian Hammond 
 chip...@chipx86.comwrote:

 I'm not entirely sure what the problem is. If your script is creating
 the review request, then the ID is coming back in the payload. If it's
 doing anything with the review request, you should have the ID.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com



 On Thu, Dec 1, 2011 at 8:28 PM, jack jack jais...@gmail.com wrote:

 Hi Chris,

 You are right the review request isn't publish, But what if i want to
 get review id before publishing.?

 The behavior of getting review id before publishing was working for
 Reviewboard version 1.0 api, hence we were able to get the review id 
 before
 publishing easily, how to do that now, I have noticed that once i publish
 the review request from RB GUI my script in second time works properly, 
 but
 in that case its two step process which is incorrect for the user.

 Also i have logged in properly my script.

 Regards,
 Jack


 On Fri, Dec 2, 2011 at 2:45 AM, Christian Hammond 
 chip...@gmail.comwrote:

 Hi,

 First off, please email the list only and not me directly. I won't
 respond to direct emails any faster than the list.

 The problem is likely that the review request isn't published and
 the script you're writing isn't logged in as a user that can see it. 
 You'll
 need to authenticate first.

 Christian



 On Dec 1, 2011, at 5:57, jack jack jais...@gmail.com wrote:

 Once the posting review request is complete

 I am trying to get review id from changelist number.

 So i am trying following URL get the review id


 http://xxx.oftware.com//api/review-requests/?changenum=127061repository=1

 Which shows me XML output which contains the review id as '4'

 but when i pass the

 self.myurl = self.rbserver +
 '/api/review-requests/?changenum=%srepository=1' % changenum
 self.urlopen = self.opener.open(self.myurl)
 self.result = simplejson.load(self.urlopen)

 my self.result contains empty data

 http://x.xftware.com//r/4/
 {u'total_results': 0, u'stat': u'ok', u*'review_requests': []*,
 u'links': {u'self': {u'href': u'
 http://x.oftware.com//api/review-requests/?changenum=127738repository=1',
 u'method': u'GET'}, 

Re: Post-review: Review id before publishing the review request

2011-12-02 Thread Christian Hammond
I'm not entirely sure what the problem is. If your script is creating the
review request, then the ID is coming back in the payload. If it's doing
anything with the review request, you should have the ID.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Thu, Dec 1, 2011 at 8:28 PM, jack jack jais...@gmail.com wrote:

 Hi Chris,

 You are right the review request isn't publish, But what if i want to get
 review id before publishing.?

 The behavior of getting review id before publishing was working for
 Reviewboard version 1.0 api, hence we were able to get the review id before
 publishing easily, how to do that now, I have noticed that once i publish
 the review request from RB GUI my script in second time works properly, but
 in that case its two step process which is incorrect for the user.

 Also i have logged in properly my script.

 Regards,
 Jack


 On Fri, Dec 2, 2011 at 2:45 AM, Christian Hammond chip...@gmail.comwrote:

 Hi,

 First off, please email the list only and not me directly. I won't
 respond to direct emails any faster than the list.

 The problem is likely that the review request isn't published and the
 script you're writing isn't logged in as a user that can see it. You'll
 need to authenticate first.

 Christian



 On Dec 1, 2011, at 5:57, jack jack jais...@gmail.com wrote:

 Once the posting review request is complete

 I am trying to get review id from changelist number.

 So i am trying following URL get the review id


 http://xxx.oftware.com//api/review-requests/?changenum=127061repository=1

 Which shows me XML output which contains the review id as '4'

 but when i pass the

 self.myurl = self.rbserver +
 '/api/review-requests/?changenum=%srepository=1' % changenum
 self.urlopen = self.opener.open(self.myurl)
 self.result = simplejson.load(self.urlopen)

 my self.result contains empty data

 http://x.xftware.com//r/4/
 {u'total_results': 0, u'stat': u'ok', u*'review_requests': []*,
 u'links': {u'self': {u'href': u'
 http://x.oftware.com//api/review-requests/?changenum=127738repository=1',
 u'method': u'GET'}, u'create': {u'href': u'
 http://x.oftware.com//api/review-requests/', u'method':
 u'POST'}}}

 Can you somebody help me what i am missing here, it might possible i am
 missing very basic thing here as i am not good in Json etc.

 Thanks in advance.



 On Thu, Dec 1, 2011 at 6:02 PM, jack jack jais...@gmail.com wrote:

 Hi Chris,

 Sorry for sending you email in person, but it is very urgent.

 I posted a review request and i got the URL, is it mandatory that i
 should publish the review request visiting the RB site then review id will
 be available?

 because my wrapper is doing some task which tries to fetch the review id
 after posting review request and while doing so i am getting error message

 IndexError: list index out of range

 But when i publish the review request and re post the request i did not
 see error message.

 Regards,
 jack



  --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

  --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en


  --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Post-review: Review id before publishing the review request

2011-12-02 Thread Nilesh Jaiswal
My script doing following steps

call post-review

At this point i expect the Review id get generated hence i try to fetch the
review id through change number below routine
call subroutine to get_review_request_by_changenum which does

 self.myurl = self.rbserver +
'/api/review-requests/?changenum=%srepository=1' % changenum
 self.urlopen = self.opener.open(self.myurl)
 self.result = simplejson.load(self.urlopen)
 if self.result['stat'] == ok:
self.dict = self.result['review_request']
return self.dict
else:
return

But self.dict does not contains id.


On Fri, Dec 2, 2011 at 2:31 PM, Christian Hammond chip...@chipx86.comwrote:

 I'm not entirely sure what the problem is. If your script is creating the
 review request, then the ID is coming back in the payload. If it's doing
 anything with the review request, you should have the ID.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com



 On Thu, Dec 1, 2011 at 8:28 PM, jack jack jais...@gmail.com wrote:

 Hi Chris,

 You are right the review request isn't publish, But what if i want to get
 review id before publishing.?

 The behavior of getting review id before publishing was working for
 Reviewboard version 1.0 api, hence we were able to get the review id before
 publishing easily, how to do that now, I have noticed that once i publish
 the review request from RB GUI my script in second time works properly, but
 in that case its two step process which is incorrect for the user.

 Also i have logged in properly my script.

 Regards,
 Jack


 On Fri, Dec 2, 2011 at 2:45 AM, Christian Hammond chip...@gmail.comwrote:

 Hi,

 First off, please email the list only and not me directly. I won't
 respond to direct emails any faster than the list.

 The problem is likely that the review request isn't published and the
 script you're writing isn't logged in as a user that can see it. You'll
 need to authenticate first.

 Christian



 On Dec 1, 2011, at 5:57, jack jack jais...@gmail.com wrote:

 Once the posting review request is complete

 I am trying to get review id from changelist number.

 So i am trying following URL get the review id


 http://xxx.oftware.com//api/review-requests/?changenum=127061repository=1

 Which shows me XML output which contains the review id as '4'

 but when i pass the

 self.myurl = self.rbserver +
 '/api/review-requests/?changenum=%srepository=1' % changenum
 self.urlopen = self.opener.open(self.myurl)
 self.result = simplejson.load(self.urlopen)

 my self.result contains empty data

 http://x.xftware.com//r/4/
 {u'total_results': 0, u'stat': u'ok', u*'review_requests': []*,
 u'links': {u'self': {u'href': u'
 http://x.oftware.com//api/review-requests/?changenum=127738repository=1',
 u'method': u'GET'}, u'create': {u'href': u'
 http://x.oftware.com//api/review-requests/', u'method':
 u'POST'}}}

 Can you somebody help me what i am missing here, it might possible i am
 missing very basic thing here as i am not good in Json etc.

 Thanks in advance.



 On Thu, Dec 1, 2011 at 6:02 PM, jack jack jais...@gmail.com wrote:

 Hi Chris,

 Sorry for sending you email in person, but it is very urgent.

 I posted a review request and i got the URL, is it mandatory that i
 should publish the review request visiting the RB site then review id will
 be available?

 because my wrapper is doing some task which tries to fetch the review
 id after posting review request and while doing so i am getting error
 message

 IndexError: list index out of range

 But when i publish the review request and re post the request i did not
 see error message.

 Regards,
 jack



  --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

  --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en


  --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 

Re: Post-review: Review id before publishing the review request

2011-12-02 Thread Christian Hammond
That's happening because your script isn't logging in as the user who
posted the review request. Unpublished review requests can only be accessed
by the user who owns them.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Fri, Dec 2, 2011 at 2:22 AM, Nilesh Jaiswal nileshj...@gmail.com wrote:

 My script doing following steps

 call post-review

 At this point i expect the Review id get generated hence i try to fetch
 the review id through change number below routine
 call subroutine to get_review_request_by_changenum which does

  self.myurl = self.rbserver +
 '/api/review-requests/?changenum=%srepository=1' % changenum
  self.urlopen = self.opener.open(self.myurl)
  self.result = simplejson.load(self.urlopen)
  if self.result['stat'] == ok:
 self.dict = self.result['review_request']
 return self.dict
 else:
 return

 But self.dict does not contains id.



 On Fri, Dec 2, 2011 at 2:31 PM, Christian Hammond chip...@chipx86.comwrote:

 I'm not entirely sure what the problem is. If your script is creating the
 review request, then the ID is coming back in the payload. If it's doing
 anything with the review request, you should have the ID.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com



 On Thu, Dec 1, 2011 at 8:28 PM, jack jack jais...@gmail.com wrote:

 Hi Chris,

 You are right the review request isn't publish, But what if i want to
 get review id before publishing.?

 The behavior of getting review id before publishing was working for
 Reviewboard version 1.0 api, hence we were able to get the review id before
 publishing easily, how to do that now, I have noticed that once i publish
 the review request from RB GUI my script in second time works properly, but
 in that case its two step process which is incorrect for the user.

 Also i have logged in properly my script.

 Regards,
 Jack


 On Fri, Dec 2, 2011 at 2:45 AM, Christian Hammond chip...@gmail.comwrote:

 Hi,

 First off, please email the list only and not me directly. I won't
 respond to direct emails any faster than the list.

 The problem is likely that the review request isn't published and the
 script you're writing isn't logged in as a user that can see it. You'll
 need to authenticate first.

 Christian



 On Dec 1, 2011, at 5:57, jack jack jais...@gmail.com wrote:

 Once the posting review request is complete

 I am trying to get review id from changelist number.

 So i am trying following URL get the review id


 http://xxx.oftware.com//api/review-requests/?changenum=127061repository=1

 Which shows me XML output which contains the review id as '4'

 but when i pass the

 self.myurl = self.rbserver +
 '/api/review-requests/?changenum=%srepository=1' % changenum
 self.urlopen = self.opener.open(self.myurl)
 self.result = simplejson.load(self.urlopen)

 my self.result contains empty data

 http://x.xftware.com//r/4/
 {u'total_results': 0, u'stat': u'ok', u*'review_requests': []*,
 u'links': {u'self': {u'href': u'
 http://x.oftware.com//api/review-requests/?changenum=127738repository=1',
 u'method': u'GET'}, u'create': {u'href': u'
 http://x.oftware.com//api/review-requests/', u'method':
 u'POST'}}}

 Can you somebody help me what i am missing here, it might possible i am
 missing very basic thing here as i am not good in Json etc.

 Thanks in advance.



 On Thu, Dec 1, 2011 at 6:02 PM, jack jack jais...@gmail.com wrote:

 Hi Chris,

 Sorry for sending you email in person, but it is very urgent.

 I posted a review request and i got the URL, is it mandatory that i
 should publish the review request visiting the RB site then review id will
 be available?

 because my wrapper is doing some task which tries to fetch the review
 id after posting review request and while doing so i am getting error
 message

 IndexError: list index out of range

 But when i publish the review request and re post the request i did
 not see error message.

 Regards,
 jack



  --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

  --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 

Re: Post-review: Review id before publishing the review request

2011-12-02 Thread Christian Hammond
The behavior hasn't changed. The way logins work has. Can you show me the code 
that logs in?

(Btw, this is probably more appropriate for the reviewboard-dev list)

Christian



On Dec 2, 2011, at 5:19, jack jack jais...@gmail.com wrote:

 Hi Chris,
 
 Thanks for the response.
 
 My script has logged in as user who posted the review request. Just to bring 
 to your notice that for ReviewBoard V 1.0 api our script was  working fine 
 and getting the Review id. before publishing. Has this behavior changed in RB 
 1.6? if yes then how to get rid before publishing.
 
 Regards,
 Jack
 
 On Fri, Dec 2, 2011 at 4:56 PM, Christian Hammond chip...@chipx86.com wrote:
 That's happening because your script isn't logging in as the user who posted 
 the review request. Unpublished review requests can only be accessed by the 
 user who owns them.
 
 
 Christian
 
 -- 
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com
 
 
 On Fri, Dec 2, 2011 at 2:22 AM, Nilesh Jaiswal nileshj...@gmail.com wrote:
 My script doing following steps
 
 call post-review
 
 At this point i expect the Review id get generated hence i try to fetch the 
 review id through change number below routine
 call subroutine to get_review_request_by_changenum which does 
 
  self.myurl = self.rbserver + 
 '/api/review-requests/?changenum=%srepository=1' % changenum
  self.urlopen = self.opener.open(self.myurl)
  self.result = simplejson.load(self.urlopen)
  if self.result['stat'] == ok:
 self.dict = self.result['review_request']
 return self.dict
 else:
 return
 
 But self.dict does not contains id.
 
 
 
 On Fri, Dec 2, 2011 at 2:31 PM, Christian Hammond chip...@chipx86.com wrote:
 I'm not entirely sure what the problem is. If your script is creating the 
 review request, then the ID is coming back in the payload. If it's doing 
 anything with the review request, you should have the ID.
 
 Christian
 
 -- 
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com
 
 
 
 On Thu, Dec 1, 2011 at 8:28 PM, jack jack jais...@gmail.com wrote:
 Hi Chris,
 
 You are right the review request isn't publish, But what if i want to get 
 review id before publishing.?
 
 The behavior of getting review id before publishing was working for 
 Reviewboard version 1.0 api, hence we were able to get the review id before 
 publishing easily, how to do that now, I have noticed that once i publish the 
 review request from RB GUI my script in second time works properly, but in 
 that case its two step process which is incorrect for the user.
 
 Also i have logged in properly my script.
 
 Regards,
 Jack
 
 
 On Fri, Dec 2, 2011 at 2:45 AM, Christian Hammond chip...@gmail.com wrote:
 Hi,
 
 First off, please email the list only and not me directly. I won't respond to 
 direct emails any faster than the list.
 
 The problem is likely that the review request isn't published and the script 
 you're writing isn't logged in as a user that can see it. You'll need to 
 authenticate first. 
 
 Christian
 
 
 
 On Dec 1, 2011, at 5:57, jack jack jais...@gmail.com wrote:
 
 Once the posting review request is complete
 
 I am trying to get review id from changelist number.
 
 So i am trying following URL get the review id
 
 http://xxx.oftware.com//api/review-requests/?changenum=127061repository=1
 
 Which shows me XML output which contains the review id as '4'
 
 but when i pass the 
 
 self.myurl = self.rbserver + 
 '/api/review-requests/?changenum=%srepository=1' % changenum
 self.urlopen = self.opener.open(self.myurl)
 self.result = simplejson.load(self.urlopen)
 
 my self.result contains empty data
 
 http://x.xftware.com//r/4/
 {u'total_results': 0, u'stat': u'ok', u'review_requests': [], u'links': 
 {u'self': {u'href': 
 u'http://x.oftware.com//api/review-requests/?changenum=127738repository=1',
  u'method': u'GET'}, u'create': {u'href': 
 u'http://x.oftware.com//api/review-requests/', u'method': 
 u'POST'}}}
 
 Can you somebody help me what i am missing here, it might possible i am 
 missing very basic thing here as i am not good in Json etc.
 
 Thanks in advance.
 
 
 
 On Thu, Dec 1, 2011 at 6:02 PM, jack jack jais...@gmail.com wrote:
 Hi Chris,
 
 Sorry for sending you email in person, but it is very urgent.
 
 I posted a review request and i got the URL, is it mandatory that i should 
 publish the review request visiting the RB site then review id will be 
 available?
 
 because my wrapper is doing some task which tries to fetch the review id 
 after posting review request and while doing so i am getting error message
 
 IndexError: list index out of range
 
 But when i publish the review request and re post the request i did not see 
 error message.
 
 Regards,
 jack
 
 
 
 -- 
 

Post-review: Review id before publishing the review request

2011-12-01 Thread jack jack
Hi Chris,

Sorry for sending you email in person, but it is very urgent.

I posted a review request and i got the URL, is it mandatory that i should
publish the review request visiting the RB site then review id will be
available?

because my wrapper is doing some task which tries to fetch the review id
after posting review request and while doing so i am getting error message

IndexError: list index out of range

But when i publish the review request and re post the request i did not see
error message.

Regards,
jack

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Post-review: Review id before publishing the review request

2011-12-01 Thread jack jack
Once the posting review request is complete

I am trying to get review id from changelist number.

So i am trying following URL get the review id

http://xxx.oftware.com//api/review-requests/?changenum=127061repository=1

Which shows me XML output which contains the review id as '4'

but when i pass the

self.myurl = self.rbserver +
'/api/review-requests/?changenum=%srepository=1' % changenum
self.urlopen = self.opener.open(self.myurl)
self.result = simplejson.load(self.urlopen)

my self.result contains empty data

http://x.xftware.com//r/4/
{u'total_results': 0, u'stat': u'ok', u*'review_requests': []*, u'links':
{u'self': {u'href': u'
http://x.oftware.com//api/review-requests/?changenum=127738repository=1',
u'method': u'GET'}, u'create': {u'href': u'
http://x.oftware.com//api/review-requests/', u'method':
u'POST'}}}

Can you somebody help me what i am missing here, it might possible i am
missing very basic thing here as i am not good in Json etc.

Thanks in advance.



On Thu, Dec 1, 2011 at 6:02 PM, jack jack jais...@gmail.com wrote:

 Hi Chris,

 Sorry for sending you email in person, but it is very urgent.

 I posted a review request and i got the URL, is it mandatory that i should
 publish the review request visiting the RB site then review id will be
 available?

 because my wrapper is doing some task which tries to fetch the review id
 after posting review request and while doing so i am getting error message

 IndexError: list index out of range

 But when i publish the review request and re post the request i did not
 see error message.

 Regards,
 jack




-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Post-review: Review id before publishing the review request

2011-12-01 Thread Christian Hammond
Hi,

First off, please email the list only and not me directly. I won't respond to 
direct emails any faster than the list.

The problem is likely that the review request isn't published and the script 
you're writing isn't logged in as a user that can see it. You'll need to 
authenticate first. 

Christian



On Dec 1, 2011, at 5:57, jack jack jais...@gmail.com wrote:

 Once the posting review request is complete
 
 I am trying to get review id from changelist number.
 
 So i am trying following URL get the review id
 
 http://xxx.oftware.com//api/review-requests/?changenum=127061repository=1
 
 Which shows me XML output which contains the review id as '4'
 
 but when i pass the 
 
 self.myurl = self.rbserver + 
 '/api/review-requests/?changenum=%srepository=1' % changenum
 self.urlopen = self.opener.open(self.myurl)
 self.result = simplejson.load(self.urlopen)
 
 my self.result contains empty data
 
 http://x.xftware.com//r/4/
 {u'total_results': 0, u'stat': u'ok', u'review_requests': [], u'links': 
 {u'self': {u'href': 
 u'http://x.oftware.com//api/review-requests/?changenum=127738repository=1',
  u'method': u'GET'}, u'create': {u'href': 
 u'http://x.oftware.com//api/review-requests/', u'method': 
 u'POST'}}}
 
 Can you somebody help me what i am missing here, it might possible i am 
 missing very basic thing here as i am not good in Json etc.
 
 Thanks in advance.
 
 
 
 On Thu, Dec 1, 2011 at 6:02 PM, jack jack jais...@gmail.com wrote:
 Hi Chris,
 
 Sorry for sending you email in person, but it is very urgent.
 
 I posted a review request and i got the URL, is it mandatory that i should 
 publish the review request visiting the RB site then review id will be 
 available?
 
 because my wrapper is doing some task which tries to fetch the review id 
 after posting review request and while doing so i am getting error message
 
 IndexError: list index out of range
 
 But when i publish the review request and re post the request i did not see 
 error message.
 
 Regards,
 jack
 
 
 
 -- 
 Want to help the Review Board project? Donate today at 
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to 
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at 
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Post-review: Review id before publishing the review request

2011-12-01 Thread jack jack
Hi Chris,

You are right the review request isn't publish, But what if i want to get
review id before publishing.?

The behavior of getting review id before publishing was working for
Reviewboard version 1.0 api, hence we were able to get the review id before
publishing easily, how to do that now, I have noticed that once i publish
the review request from RB GUI my script in second time works properly, but
in that case its two step process which is incorrect for the user.

Also i have logged in properly my script.

Regards,
Jack

On Fri, Dec 2, 2011 at 2:45 AM, Christian Hammond chip...@gmail.com wrote:

 Hi,

 First off, please email the list only and not me directly. I won't respond
 to direct emails any faster than the list.

 The problem is likely that the review request isn't published and the
 script you're writing isn't logged in as a user that can see it. You'll
 need to authenticate first.

 Christian



 On Dec 1, 2011, at 5:57, jack jack jais...@gmail.com wrote:

 Once the posting review request is complete

 I am trying to get review id from changelist number.

 So i am trying following URL get the review id


 http://xxx.oftware.com//api/review-requests/?changenum=127061repository=1

 Which shows me XML output which contains the review id as '4'

 but when i pass the

 self.myurl = self.rbserver +
 '/api/review-requests/?changenum=%srepository=1' % changenum
 self.urlopen = self.opener.open(self.myurl)
 self.result = simplejson.load(self.urlopen)

 my self.result contains empty data

 http://x.xftware.com//r/4/
 {u'total_results': 0, u'stat': u'ok', u*'review_requests': []*, u'links':
 {u'self': {u'href': u'
 http://x.oftware.com//api/review-requests/?changenum=127738repository=1',
 u'method': u'GET'}, u'create': {u'href': u'
 http://x.oftware.com//api/review-requests/', u'method':
 u'POST'}}}

 Can you somebody help me what i am missing here, it might possible i am
 missing very basic thing here as i am not good in Json etc.

 Thanks in advance.



 On Thu, Dec 1, 2011 at 6:02 PM, jack jack jais...@gmail.com wrote:

 Hi Chris,

 Sorry for sending you email in person, but it is very urgent.

 I posted a review request and i got the URL, is it mandatory that i
 should publish the review request visiting the RB site then review id will
 be available?

 because my wrapper is doing some task which tries to fetch the review id
 after posting review request and while doing so i am getting error message

 IndexError: list index out of range

 But when i publish the review request and re post the request i did not
 see error message.

 Regards,
 jack



  --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

  --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en