Hi Robert,
Review Board can show moved regions within a file, but not across files. This
is the case because we process a file at a time, though we're hoping to change
that down the road.
What I'd recommend is doing this in two stages. Post one change that just
simply moves the lines between files without modifying them, and state that
they're unchanged.
Then post a change that modifies the lines.
Of course, whether or not you can do this depends on whether just moving the
code will cause some sort of a problem. You may still have options, like
wrapping in an #if 0 or something, depending on the language.
Christian
On Sep 26, 2012, at 11:23, Robert Dailey wrote:
> Sometimes I like to take 100-200 lines of code from one file, make
> modifications to that code, and then move it to a separate file as a
> refactoring step.
>
> A couple of people on my team have complained about this since now it
> is impossible to diff the individual changes to the code since it was
> moved, but Reviewboard isn't picking up that it is moved to another
> file and diffing the common parts.
>
> Is there a workaround or fix for this? What should the process be for
> changes like this? Any way I can make such a change easier for my team
> to review?
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
