Re: need help to integrate post-review with Perforce
Tanks a lot for response. I could intergate with p4win. Now problem i am facing is Traceback (most recent call last): File post-review, line 2313, in ? main(sys.argv[1:]) File post-review, line 2284, in main diff, parent_diff = tool.diff(args) File post-review, line 1446, in diff dl = execute(diff_cmd, extra_ignore_errors=(1,2)).splitlines(True) File post-review, line 1889, in execute env=env) File C:\Python24\lib\subprocess.py, line 554, in __init__ errread, errwrite) File C:\Python24\lib\subprocess.py, line 718, in _execute_child startupinfo) WindowsError: [Errno 2] The system cannot find the file specified What might be cause for it.What should i do to get rid of it. -Amit On Jun 11, 1:03 am, Paul Scott psc...@vmware.com wrote: Well, everyone who uses p4 will probably rather use post-review. ;) The tool in the rbtools/contrib should probably be renamed something with p4win in it, as it is an extension for p4win, and a lot of people use p4v now since p4win has been deprecated for a few years. I keep starting to make a similar extension (custom tool) for p4v but their terminal isn't a real terminal and can't handle the method post-review uses to collect your password if you need to authenticate. That's certainly something that can be handled pretty easily... post-review, or a wrapper (or preferably a rbapi library) probably needs a way of finding out if you are authenticated or not that doesn't go directly to asking you for your password. -- Paul From: reviewboard@googlegroups.com [reviewbo...@googlegroups.com] On Behalf Of Joshua Slominski [hoohaa8...@gmail.com] Sent: Wednesday, June 10, 2009 9:44 AM To: reviewboard@googlegroups.com Subject: Re: need help to integrate post-review with Perforce There is a P4 tool located in rbtools/ contrib. If you set that up there is no need to run post-review from the command line. On Tue, Jun 9, 2009 at 4:49 PM, Christian Hammond chip...@chipx86.commailto:chip...@chipx86.com wrote: There's a lot of documentation on this athttp://www.review-board.org/docs/manual/dev/users/tools/post-review/ Christian -- Christian Hammond - chip...@chipx86.commailto:chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Tue, Jun 9, 2009 at 1:34 AM, Amit agrawalamit2...@gmail.commailto:agrawalamit2...@gmail.com wrote: Hi, I downloaded RBTools-0.2beta. afterwords i have no clue how to proceed for integrating post-review into Perforce. Any help will be highly appreciated. -Amit --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: need help to integrate post-review with Perforce
You need to have a diff.exe that supports unified output format in your path. If you don't have it, you can get it by installing Cygwin (http://www.cygwin.com/). -Raghu On Jun 11, 3:34 pm, Amit agrawalamit2...@gmail.com wrote: Tanks a lot for response. I could intergate with p4win. Now problem i am facing is Traceback (most recent call last): File post-review, line 2313, in ? main(sys.argv[1:]) File post-review, line 2284, in main diff, parent_diff = tool.diff(args) File post-review, line 1446, in diff dl = execute(diff_cmd, extra_ignore_errors=(1,2)).splitlines(True) File post-review, line 1889, in execute env=env) File C:\Python24\lib\subprocess.py, line 554, in __init__ errread, errwrite) File C:\Python24\lib\subprocess.py, line 718, in _execute_child startupinfo) WindowsError: [Errno 2] The system cannot find the file specified What might be cause for it.What should i do to get rid of it. -Amit On Jun 11, 1:03 am, Paul Scott psc...@vmware.com wrote: Well, everyone who uses p4 will probably rather use post-review. ;) The tool in the rbtools/contrib should probably be renamed something with p4win in it, as it is an extension for p4win, and a lot of people use p4v now since p4win has been deprecated for a few years. I keep starting to make a similar extension (custom tool) for p4v but their terminal isn't a real terminal and can't handle the method post-review uses to collect your password if you need to authenticate. That's certainly something that can be handled pretty easily... post-review, or a wrapper (or preferably a rbapi library) probably needs a way of finding out if you are authenticated or not that doesn't go directly to asking you for your password. -- Paul From: reviewboard@googlegroups.com [reviewbo...@googlegroups.com] On Behalf Of Joshua Slominski [hoohaa8...@gmail.com] Sent: Wednesday, June 10, 2009 9:44 AM To: reviewboard@googlegroups.com Subject: Re: need help to integrate post-review with Perforce There is a P4 tool located in rbtools/ contrib. If you set that up there is no need to run post-review from the command line. On Tue, Jun 9, 2009 at 4:49 PM, Christian Hammond chip...@chipx86.commailto:chip...@chipx86.com wrote: There's a lot of documentation on this athttp://www.review-board.org/docs/manual/dev/users/tools/post-review/ Christian -- Christian Hammond - chip...@chipx86.commailto:chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Tue, Jun 9, 2009 at 1:34 AM, Amit agrawalamit2...@gmail.commailto:agrawalamit2...@gmail.com wrote: Hi, I downloaded RBTools-0.2beta. afterwords i have no clue how to proceed for integrating post-review into Perforce. Any help will be highly appreciated. -Amit --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: need help to integrate post-review with Perforce
You may find cycgwin is a bit OTT if you just want a compliant diff utiltiy on Windows. I found diff-utils from GnuWin32 worked fine. See the link below for how I prepared a client package to share with developers using ReviewBoard with Perforce on windows. (Skip to bullet 10 for the GnuWin32 bit): http://waveydavey.wordpress.com/home/computing/installing-review-board-10-alpha-2-on-windows-for-perforce/#InstallingReviewBoardonWindowsforPerforce-Windows David On Thu, Jun 11, 2009 at 5:28 PM, Raghuraghu...@gmail.com wrote: You need to have a diff.exe that supports unified output format in your path. If you don't have it, you can get it by installing Cygwin (http://www.cygwin.com/). -Raghu On Jun 11, 3:34 pm, Amit agrawalamit2...@gmail.com wrote: Tanks a lot for response. I could intergate with p4win. Now problem i am facing is Traceback (most recent call last): File post-review, line 2313, in ? main(sys.argv[1:]) File post-review, line 2284, in main diff, parent_diff = tool.diff(args) File post-review, line 1446, in diff dl = execute(diff_cmd, extra_ignore_errors=(1,2)).splitlines(True) File post-review, line 1889, in execute env=env) File C:\Python24\lib\subprocess.py, line 554, in __init__ errread, errwrite) File C:\Python24\lib\subprocess.py, line 718, in _execute_child startupinfo) WindowsError: [Errno 2] The system cannot find the file specified What might be cause for it.What should i do to get rid of it. -Amit On Jun 11, 1:03 am, Paul Scott psc...@vmware.com wrote: Well, everyone who uses p4 will probably rather use post-review. ;) The tool in the rbtools/contrib should probably be renamed something with p4win in it, as it is an extension for p4win, and a lot of people use p4v now since p4win has been deprecated for a few years. I keep starting to make a similar extension (custom tool) for p4v but their terminal isn't a real terminal and can't handle the method post-review uses to collect your password if you need to authenticate. That's certainly something that can be handled pretty easily... post-review, or a wrapper (or preferably a rbapi library) probably needs a way of finding out if you are authenticated or not that doesn't go directly to asking you for your password. -- Paul From: reviewboard@googlegroups.com [reviewbo...@googlegroups.com] On Behalf Of Joshua Slominski [hoohaa8...@gmail.com] Sent: Wednesday, June 10, 2009 9:44 AM To: reviewboard@googlegroups.com Subject: Re: need help to integrate post-review with Perforce There is a P4 tool located in rbtools/ contrib. If you set that up there is no need to run post-review from the command line. On Tue, Jun 9, 2009 at 4:49 PM, Christian Hammond chip...@chipx86.commailto:chip...@chipx86.com wrote: There's a lot of documentation on this athttp://www.review-board.org/docs/manual/dev/users/tools/post-review/ Christian -- Christian Hammond - chip...@chipx86.commailto:chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Tue, Jun 9, 2009 at 1:34 AM, Amit agrawalamit2...@gmail.commailto:agrawalamit2...@gmail.com wrote: Hi, I downloaded RBTools-0.2beta. afterwords i have no clue how to proceed for integrating post-review into Perforce. Any help will be highly appreciated. -Amit --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: need help to integrate post-review with Perforce
There is a P4 tool located in rbtools/ contrib. If you set that up there is no need to run post-review from the command line. On Tue, Jun 9, 2009 at 4:49 PM, Christian Hammond chip...@chipx86.comwrote: There's a lot of documentation on this at http://www.review-board.org/docs/manual/dev/users/tools/post-review/ Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, Jun 9, 2009 at 1:34 AM, Amit agrawalamit2...@gmail.com wrote: Hi, I downloaded RBTools-0.2beta. afterwords i have no clue how to proceed for integrating post-review into Perforce. Any help will be highly appreciated. -Amit --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
RE: need help to integrate post-review with Perforce
Well, everyone who uses p4 will probably rather use post-review. ;) The tool in the rbtools/contrib should probably be renamed something with p4win in it, as it is an extension for p4win, and a lot of people use p4v now since p4win has been deprecated for a few years. I keep starting to make a similar extension (custom tool) for p4v but their terminal isn't a real terminal and can't handle the method post-review uses to collect your password if you need to authenticate. That's certainly something that can be handled pretty easily... post-review, or a wrapper (or preferably a rbapi library) probably needs a way of finding out if you are authenticated or not that doesn't go directly to asking you for your password. -- Paul From: reviewboard@googlegroups.com [reviewbo...@googlegroups.com] On Behalf Of Joshua Slominski [hoohaa8...@gmail.com] Sent: Wednesday, June 10, 2009 9:44 AM To: reviewboard@googlegroups.com Subject: Re: need help to integrate post-review with Perforce There is a P4 tool located in rbtools/ contrib. If you set that up there is no need to run post-review from the command line. On Tue, Jun 9, 2009 at 4:49 PM, Christian Hammond chip...@chipx86.commailto:chip...@chipx86.com wrote: There's a lot of documentation on this at http://www.review-board.org/docs/manual/dev/users/tools/post-review/ Christian -- Christian Hammond - chip...@chipx86.commailto:chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, Jun 9, 2009 at 1:34 AM, Amit agrawalamit2...@gmail.commailto:agrawalamit2...@gmail.com wrote: Hi, I downloaded RBTools-0.2beta. afterwords i have no clue how to proceed for integrating post-review into Perforce. Any help will be highly appreciated. -Amit --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: need help to integrate post-review with Perforce
i am using p4 windows client only. Thanks, Amit On Jun 9, 1:34 pm, Amit agrawalamit2...@gmail.com wrote: Hi, I downloaded RBTools-0.2beta. afterwords i have no clue how to proceed for integrating post-review into Perforce. Any help will be highly appreciated. -Amit --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: need help to integrate post-review with Perforce
Is RB installed on Linux or Windows? On Tue, Jun 9, 2009 at 1:34 AM, Amit agrawalamit2...@gmail.com wrote: Hi, I downloaded RBTools-0.2beta. afterwords i have no clue how to proceed for integrating post-review into Perforce. Any help will be highly appreciated. -Amit --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: need help to integrate post-review with Perforce
There's a lot of documentation on this at http://www.review-board.org/docs/manual/dev/users/tools/post-review/ Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, Jun 9, 2009 at 1:34 AM, Amit agrawalamit2...@gmail.com wrote: Hi, I downloaded RBTools-0.2beta. afterwords i have no clue how to proceed for integrating post-review into Perforce. Any help will be highly appreciated. -Amit --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
