On Mon, Sep 28, 2009 at 12:20, Thilo-Alexander Ginkel th...@ginkel.com wrote:
On Fri, Sep 25, 2009 at 22:21, Christian Hammond chip...@chipx86.com wrote:
That's odd.. I'll try to reproduce that tonight or this weekend.
I just tried reproducing the issue, but was not successful. So, this
Yup. What you described seems to be the case. I make sure that everyone
takes a look at the diff prior to submitting (there's an issue with
diff/patch when there isn't an ending newline that prevents it from showing)
just to make sure it works correctly.
-Tom
On Mon, Sep 28, 2009 at 10:30 AM,
On Fri, Sep 25, 2009 at 17:31, Thilo-Alexander Ginkel th...@ginkel.comwrote:
can somebody confirm my observation that clicking on any of the Expand
hyperlinks (to expand collapsed source code sections) in the RB diff viewer
no longer works with 1.0.3?
Just a brief update: The root cause
Correct. The Expand links that expand individual files is not working
correctly. Expand All seems to work however...
-Tom
On Fri, Sep 25, 2009 at 10:35 AM, Thilo-Alexander Ginkel
th...@ginkel.comwrote:
On Fri, Sep 25, 2009 at 17:31, Thilo-Alexander Ginkel th...@ginkel.comwrote:
can
This is a standard diff, not an interdiff?
Would you mind filing a bug for tracking purposes? We'll get it into 1.0.4.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com
On Fri, Sep 25, 2009 at 8:35 AM,
On Friday 25 September 2009 21:38:35 Christian Hammond wrote:
This is a standard diff, not an interdiff?
Yes, it's a standard diff.
One interesting thing is that for requests created prior to 1.0.3 the fragment
expansion still seems to work (I just tried a couple of requests, though).
Only
Were you trying to expand a diff that was still attached to a draft of a
review request? Or was it actually a published diff visible to everyone?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com
On Fri, Sep
On Friday 25 September 2009 22:11:01 Christian Hammond wrote:
Were you trying to expand a diff that was still attached to a draft of a
review request? Or was it actually a published diff visible to everyone?
It was a published diff visible to everyone (actually a colleague pointed me
to the
That's odd.. I'll try to reproduce that tonight or this weekend.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com
On Fri, Sep 25, 2009 at 1:19 PM, Thilo-Alexander Ginkel th...@ginkel.comwrote:
On Friday 25
