Re: Configuring Review Board for GIT

2012-12-07 Thread Matthew Woehlke

On 2012-12-07 00:08, Krishnan Raghupathi wrote:

I tried using the following value for the raw file URL mask -

http://gitgrid.unx.coep.com/cgit/Mobile/Commons/tree/Commons/formatters/Constants.cpp?id2=7d8cb5fa13a5985e70300baac4ae09d1be8c37bf


Based on that, I would guess your Raw File URL should be:

http://gitgrid.unx.coep.com/cgit/Mobile/Commons/?id2=

As previously stated, path and mirror path should match your users' 
remote fetch URL's. Ideally Path should be something that RB can access 
(though I'm not sure it actually needs to), and Mirror Path can be 
something that needs credentials. Git URL's are fine, they don't need to 
be local paths. (If needed, you can upload an SSH key to the RB server, 
and/or generate one and add it to the git repo's accepted keys.)


This:


I tried a value like ssh://g...@gitgrid.unx.coep.com/Mobile/Commons and I
still get an error.


...looks reasonable. I would guess the Raw File URL is the issue.

(Have you checked the server's logs to see what it is trying to do?)


What about the id2 in the raw file URL mask - should I leave it as id2  or
should I use just id ?


This I don't know... whatever works for cgit...

--
Matthew

--
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en




Re: Configuring Review Board for GIT

2012-12-06 Thread Krishnan Raghupathi
I tried using the following value for the raw file URL mask - 

http://gitgrid.unx.coep.com/cgit/Mobile/Commons/tree/Commons/formatters/Constants.cpp?id2=7d8cb5fa13a5985e70300baac4ae09d1be8c37bf


where gitgrid.unx.coep.com is the host name of the machine hosting the GIT 
repository. I got the blob id by browsing the GIT repository via cgit. 

I left the path and mirror path fields blank since the GIT repository is 
hosted on a remote machine and I don't have access to its repository 
folder. When I try creating a repository with this, I get an error from 
ReviewBoard saying something is broken and I should contact admin. 

Any suggestion on what I should use for path and mirror path fields ?
I tried a value like ssh://g...@gitgrid.unx.coep.com/Mobile/Commons and I 
still get an error.
What about the id2 in the raw file URL mask - should I leave it as id2  or 
should I use just id ?






On Tuesday, December 4, 2012 9:17:40 PM UTC+5:30, Matthew Woehlke wrote:
>
> On 2012-11-30 04:11, Krishnan Raghupathi wrote: 
> >   I am using ReviewBoard version 1.6.1 and am facing a difficulty in 
> > configuring this for our GIT repository. Our GIT repository is hosted on 
> a 
> > remote machine i.e different from the one hosting ReviewBoard. In the 
> Add 
> > repository of ReviewBoard, I selected the following options - 
> > 
> > Hosting service - Custom 
> > Repository type - Git 
> > 
> > I left the Path and Mirror Path fields blank since the GIT repository is 
> on 
> > a remote machine and not accessible via a path. 
>
> Don't do that. The path and mirror path are used to determine what 
> repository to use when posting a review. They can and should (mirror 
> path especially, which exists ONLY for repository determination AFAIK) 
> look like what users clone, e.g. 'git://server/path'. 
>
> > Since I am able to access our GIT repository on a browser via cgit, I am 
> > assuming that I need to specify the Raw file URL mask with a value 
> similar 
> > to http://git.gnome.org/browse/gtk+/plain/?id2= as 
> > specified in the ReviewBoard documentation. 
>
> Correct. Keep in mind however that  is the blob ID of the file 
> to which a patch hunk applies, i.e. 'git show ' should give 
> you the contents of a file, not a commit or tree. You'll need to form 
> your URL accordingly. (Your server also needs to support retrieving 
> content by blob ID; some might not.) 
>
> I don't know cgit, so I can't give you any more information than that, 
> but hopefully it helps. 
>
> Note: if you need to find blob ID's for experimenting, read up on git's 
> 'ls-tree' command. (Short form: 'git ls-tree  
> ' will give you the list of blobs (files) with their 
> respective ID's in  as of .) 
>
> -- 
> Matthew 
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en




Re: Configuring Review Board for GIT

2012-12-04 Thread Matthew Woehlke

On 2012-11-30 04:11, Krishnan Raghupathi wrote:

  I am using ReviewBoard version 1.6.1 and am facing a difficulty in
configuring this for our GIT repository. Our GIT repository is hosted on a
remote machine i.e different from the one hosting ReviewBoard. In the Add
repository of ReviewBoard, I selected the following options -

Hosting service - Custom
Repository type - Git

I left the Path and Mirror Path fields blank since the GIT repository is on
a remote machine and not accessible via a path.


Don't do that. The path and mirror path are used to determine what 
repository to use when posting a review. They can and should (mirror 
path especially, which exists ONLY for repository determination AFAIK) 
look like what users clone, e.g. 'git://server/path'.



Since I am able to access our GIT repository on a browser via cgit, I am
assuming that I need to specify the Raw file URL mask with a value similar
to http://git.gnome.org/browse/gtk+/plain/?id2= as
specified in the ReviewBoard documentation.


Correct. Keep in mind however that  is the blob ID of the file 
to which a patch hunk applies, i.e. 'git show ' should give 
you the contents of a file, not a commit or tree. You'll need to form 
your URL accordingly. (Your server also needs to support retrieving 
content by blob ID; some might not.)


I don't know cgit, so I can't give you any more information than that, 
but hopefully it helps.


Note: if you need to find blob ID's for experimenting, read up on git's 
'ls-tree' command. (Short form: 'git ls-tree  
' will give you the list of blobs (files) with their 
respective ID's in  as of .)


--
Matthew

--
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en