Re: Default reviewer not assigned to the review (yet another weird utf8 problem)

2017-01-18 Thread Shooter Gravatar
I just tried to point to the root of the repo, it doesn't solve the issue : 
refault reviewer is applied when i upload a .diff file, but it doesn't when 
i use the UI to browse commits.

Le mercredi 18 janvier 2017 10:18:39 UTC+1, Shooter Gravatar a écrit :
>
> I'll see what i can do with the repo path.
>
> For the diff, see the attached file.
>
> Le mercredi 18 janvier 2017 01:02:06 UTC+1, Christian Hammond a écrit :
>>
>> If it's a new install and database, definitely point it to the root of 
>> the repo. This will prevent other kinds of problems.
>>
>> For the sample file paths, I need to see exact paths being shown in the 
>> diff viewer. Those are what the Default Reviewer regents will match 
>> against. I suspect the refex isn't formatted for those paths.
>>
>> Christian
>>
>>
>>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Default reviewer not assigned to the review (yet another weird utf8 problem)

2017-01-18 Thread Shooter Gravatar
I'll see what i can do with the repo path.

For the diff, see the attached file.

Le mercredi 18 janvier 2017 01:02:06 UTC+1, Christian Hammond a écrit :
>
> If it's a new install and database, definitely point it to the root of the 
> repo. This will prevent other kinds of problems.
>
> For the sample file paths, I need to see exact paths being shown in the 
> diff viewer. Those are what the Default Reviewer regents will match 
> against. I suspect the refex isn't formatted for those paths.
>
> Christian
>
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Default reviewer not assigned to the review (yet another weird utf8 problem)

2017-01-17 Thread Christian Hammond
If it's a new install and database, definitely point it to the root of the
repo. This will prevent other kinds of problems.

For the sample file paths, I need to see exact paths being shown in the
diff viewer. Those are what the Default Reviewer regents will match
against. I suspect the refex isn't formatted for those paths.

Christian


On Tue, Jan 17, 2017 at 05:34 Shooter Gravatar 
wrote:

> The repo contains a lot of branches and "stuff" that we don't want to
> survey (and we don't want to make things to complicated for our users
> ho well...), so the repo path points directly to the "trunk" of our
> development.
> Too much history and not enough forward thinking at the time...
> Existing review requests are not a problem, this new instance of RB will
> start from scratch.
>
> Matching files can be :
>   - main.cpp
>   - index.html
>   - js/service.js (in a sub-directory)
>
>
> Le lundi 16 janvier 2017 11:31:45 UTC+1, Christian Hammond a écrit :
>
> The repository path should be pointing to the root of the repository
> (probably /svn), rather than a subdirectory (/svn/trunk), but if you
> already have a bunch of review requests in there, you probably have to keep
> it as-is.
>
> Can you show me an example filename listed in the diff viewer that should
> be matching?
>
> Christian
>
> --
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> --
>
>
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
>
>
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
>
>
> Happy user? Let us know! https://www.reviewboard.org/users/
>
>
> ---
>
>
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
>
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
>
>
> For more options, visit https://groups.google.com/d/optout.
>
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Default reviewer not assigned to the review (yet another weird utf8 problem)

2017-01-17 Thread Shooter Gravatar
The repo contains a lot of branches and "stuff" that we don't want to 
survey (and we don't want to make things to complicated for our users 
ho well...), so the repo path points directly to the "trunk" of our 
development.
Too much history and not enough forward thinking at the time...
Existing review requests are not a problem, this new instance of RB will 
start from scratch.

Matching files can be :
  - main.cpp
  - index.html
  - js/service.js (in a sub-directory)

Le lundi 16 janvier 2017 11:31:45 UTC+1, Christian Hammond a écrit :
>
> The repository path should be pointing to the root of the repository 
> (probably /svn), rather than a subdirectory (/svn/trunk), but if you 
> already have a bunch of review requests in there, you probably have to keep 
> it as-is.
>
> Can you show me an example filename listed in the diff viewer that should 
> be matching?
>
> Christian
>
> -- 
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Default reviewer not assigned to the review (yet another weird utf8 problem)

2017-01-16 Thread Christian Hammond
The repository path should be pointing to the root of the repository
(probably /svn), rather than a subdirectory (/svn/trunk), but if you
already have a bunch of review requests in there, you probably have to keep
it as-is.

Can you show me an example filename listed in the diff viewer that should
be matching?

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Mon, Jan 16, 2017 at 2:29 AM, Shooter Gravatar <
shooter.grava...@gmail.com> wrote:

> Good news !
>
> As for the default reviewer, the expression is the following :
>
>> Base/Tools/Nora2/.*
>>
>
> The repo is :
>
>> https://x.x.x.x/svn/trunk
>>
>
> The commited files are located in :
>
>> myDrive:\_BaseSVN\Trunk\Base\Tools\Nora2  (on Windows...)
>>
>
> Le samedi 14 janvier 2017 23:56:15 UTC+1, Christian Hammond a écrit :
>>
>> I believe I have a fix we can put in for the upcoming Review Board 2.5.8
>> release for the warning.
>>
>> Christian
>>
>> --
>> Christian Hammond
>> President/CEO of Beanbag 
>> Makers of Review Board 
>>
>> On Sat, Jan 14, 2017 at 2:29 PM, Christian Hammond <
>> chri...@beanbaginc.com> wrote:
>>
>>> I've seen this. This is a behavioral quirk in MySQL.
>>>
>>> Basically, this is likely a longblob, but some versions of MySQL assume
>>> the incoming content should be Unicode text and does validation on that.
>>> The validation fails, and you get the warning you have above:
>>>
>>> /usr/local/lib/python2.7/dist-packages/django/db/backends/mysql/base.py:129:
>>>  Warning: Invalid utf8 character string: 'AAF744'
>>>   return self.cursor.execute(query, args)
>>>
>>>
>>> Another user hit this with MySQL 5.5. Upgrading to 5.6 solved this for
>>> him, but you're on 5.7, so I guess this wasn't "fixed."
>>>
>>> There is a proper fix that Django's put in place, based on the
>>> recommendations of the MySQL developers. However, we're not able to use
>>> that newer version of Django... Been meaning to see if we can monkey-patch
>>> the fix in.
>>>
>>> This is MySQL warning code 1300. You can see some discussion about this
>>> here: https://bugs.mysql.com/bug.php?id=79317
>>>
>>> Now, if you don't enable DEBUG = True in settings_local.py, then this
>>> warning is harmless. So I suspect your Default Reviewer issue is a
>>> configuration issue.
>>>
>>> Can you show me what your Default Reviewer configuration looks like?
>>>
>>> Christian
>>>
>>>
>>> --
>>> Christian Hammond
>>> President/CEO of Beanbag 
>>> Makers of Review Board 
>>>
>>> On Fri, Jan 13, 2017 at 11:59 AM, David Trowbridge 
>>> wrote:
>>>
 Something is super weird with your database schema. The "binary" field
 of that table should be a longblob, not text (and therefore shouldn't care
 at all about encodings one way or another). Can you pull out the schema and
 send it here?

 -David

 On Fri, Jan 13, 2017 at 9:08 AM Shooter Gravatar 
 wrote:

> Another update.
>
> I completely remove ReviewBoard 2.5.7 from my system and downloaded
> again 2.5.6.1 with easy_install.
> Run the installation again.
> Same configuration as before.
> I can now create a review request from the UI by browsing the commits
> on my repo, and the default reviewer rule is applied (the group is 
> assigned
> to the request i just created).
> But i still have the utf8 error on the database.
>
> I now have another problem : i cannot acces the
> /reviewboard/admin/settings/general/ page on the Admin dashboard.
>
>
> Traceback (most recent call last):
>>
>>
>>
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py",
>> line 112, in get_response
>>
>> response = wrapped_callback(request, *callback_args,
>> **callback_kwargs)
>>
>>
>>
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py",
>> line 99, in _wrapped_view
>>
>> response = view_func(request, *args, **kwargs)
>>
>>
>>
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/views/decorators.py",
>> line 17, in _checklogin
>>
>> return view_func(request, *args, **kwargs)
>>
>>
>>
>>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.6.1-
>> py2.7.egg/reviewboard/admin/views.py", line 138, in site_settings
>>
>> 'root_path': settings.SITE_ROOT + "admin/db/"
>>
>>
>>
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py",
>> line 99, in _wrapped_view
>>
>> response = view_func(request, *args, **kwargs)
>>
>>
>>
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/views/decorators.py",
>> line 17, in _checklo

Re: Default reviewer not assigned to the review (yet another weird utf8 problem)

2017-01-16 Thread Shooter Gravatar
Good news !

As for the default reviewer, the expression is the following : 

> Base/Tools/Nora2/.*
>

The repo is : 

> https://x.x.x.x/svn/trunk 
>

The commited files are located in :

> myDrive:\_BaseSVN\Trunk\Base\Tools\Nora2  (on Windows...)
>

Le samedi 14 janvier 2017 23:56:15 UTC+1, Christian Hammond a écrit :
>
> I believe I have a fix we can put in for the upcoming Review Board 2.5.8 
> release for the warning.
>
> Christian
>
> -- 
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>
> On Sat, Jan 14, 2017 at 2:29 PM, Christian Hammond  > wrote:
>
>> I've seen this. This is a behavioral quirk in MySQL.
>>
>> Basically, this is likely a longblob, but some versions of MySQL assume 
>> the incoming content should be Unicode text and does validation on that. 
>> The validation fails, and you get the warning you have above:
>>
>> /usr/local/lib/python2.7/dist-packages/django/db/backends/mysql/base.py:129: 
>> Warning: Invalid utf8 character string: 'AAF744'
>>   return self.cursor.execute(query, args)
>>
>>
>> Another user hit this with MySQL 5.5. Upgrading to 5.6 solved this for 
>> him, but you're on 5.7, so I guess this wasn't "fixed."
>>
>> There is a proper fix that Django's put in place, based on the 
>> recommendations of the MySQL developers. However, we're not able to use 
>> that newer version of Django... Been meaning to see if we can monkey-patch 
>> the fix in.
>>
>> This is MySQL warning code 1300. You can see some discussion about this 
>> here: https://bugs.mysql.com/bug.php?id=79317
>>
>> Now, if you don't enable DEBUG = True in settings_local.py, then this 
>> warning is harmless. So I suspect your Default Reviewer issue is a 
>> configuration issue.
>>
>> Can you show me what your Default Reviewer configuration looks like?
>>
>> Christian
>>
>>
>> -- 
>> Christian Hammond
>> President/CEO of Beanbag 
>> Makers of Review Board 
>>
>> On Fri, Jan 13, 2017 at 11:59 AM, David Trowbridge > > wrote:
>>
>>> Something is super weird with your database schema. The "binary" field 
>>> of that table should be a longblob, not text (and therefore shouldn't care 
>>> at all about encodings one way or another). Can you pull out the schema and 
>>> send it here?
>>>
>>> -David
>>>
>>> On Fri, Jan 13, 2017 at 9:08 AM Shooter Gravatar >> > wrote:
>>>
 Another update.

 I completely remove ReviewBoard 2.5.7 from my system and downloaded 
 again 2.5.6.1 with easy_install.
 Run the installation again.
 Same configuration as before.
 I can now create a review request from the UI by browsing the commits 
 on my repo, and the default reviewer rule is applied (the group is 
 assigned 
 to the request i just created).
 But i still have the utf8 error on the database.

 I now have another problem : i cannot acces the 
 /reviewboard/admin/settings/general/ page on the Admin dashboard.


 Traceback (most recent call last):
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", 
> line 
> 112, in get_response
>
> response = wrapped_callback(request, *callback_args, 
> **callback_kwargs)
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py", line 
> 99, in _wrapped_view
>
> response = view_func(request, *args, **kwargs)
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/views/decorators.py",
>  
> line 17, in _checklogin
>
> return view_func(request, *args, **kwargs)
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.6.1-py2.7.egg/reviewboard/admin/views.py",
>  
> line 138, in site_settings
>
> 'root_path': settings.SITE_ROOT + "admin/db/"
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py", line 
> 99, in _wrapped_view
>
> response = view_func(request, *args, **kwargs)
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/views/decorators.py",
>  
> line 17, in _checklogin
>
> return view_func(request, *args, **kwargs)
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/djblets/siteconfig/views.py", 
> line 
> 63, in site_settings
>
> return render_to_response(template_name, RequestContext(request, 
> context))
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/django/shortcuts/__init__.py", 
> line 
> 29, in render_to_response
>
> return HttpResponse(loader.render_to_string(*args, **kwargs), 
> **httpresponse_kwargs)
>
>  
>
>   File 
> "/usr/local/lib/python2.7/di

Re: Default reviewer not assigned to the review (yet another weird utf8 problem)

2017-01-14 Thread Christian Hammond
I believe I have a fix we can put in for the upcoming Review Board 2.5.8
release for the warning.

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Sat, Jan 14, 2017 at 2:29 PM, Christian Hammond  wrote:

> I've seen this. This is a behavioral quirk in MySQL.
>
> Basically, this is likely a longblob, but some versions of MySQL assume
> the incoming content should be Unicode text and does validation on that.
> The validation fails, and you get the warning you have above:
>
> /usr/local/lib/python2.7/dist-packages/django/db/backends/mysql/base.py:129: 
> Warning: Invalid utf8 character string: 'AAF744'
>   return self.cursor.execute(query, args)
>
>
> Another user hit this with MySQL 5.5. Upgrading to 5.6 solved this for
> him, but you're on 5.7, so I guess this wasn't "fixed."
>
> There is a proper fix that Django's put in place, based on the
> recommendations of the MySQL developers. However, we're not able to use
> that newer version of Django... Been meaning to see if we can monkey-patch
> the fix in.
>
> This is MySQL warning code 1300. You can see some discussion about this
> here: https://bugs.mysql.com/bug.php?id=79317
>
> Now, if you don't enable DEBUG = True in settings_local.py, then this
> warning is harmless. So I suspect your Default Reviewer issue is a
> configuration issue.
>
> Can you show me what your Default Reviewer configuration looks like?
>
> Christian
>
>
> --
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>
> On Fri, Jan 13, 2017 at 11:59 AM, David Trowbridge 
> wrote:
>
>> Something is super weird with your database schema. The "binary" field of
>> that table should be a longblob, not text (and therefore shouldn't care at
>> all about encodings one way or another). Can you pull out the schema and
>> send it here?
>>
>> -David
>>
>> On Fri, Jan 13, 2017 at 9:08 AM Shooter Gravatar <
>> shooter.grava...@gmail.com> wrote:
>>
>>> Another update.
>>>
>>> I completely remove ReviewBoard 2.5.7 from my system and downloaded
>>> again 2.5.6.1 with easy_install.
>>> Run the installation again.
>>> Same configuration as before.
>>> I can now create a review request from the UI by browsing the commits on
>>> my repo, and the default reviewer rule is applied (the group is assigned to
>>> the request i just created).
>>> But i still have the utf8 error on the database.
>>>
>>> I now have another problem : i cannot acces the
>>> /reviewboard/admin/settings/general/ page on the Admin dashboard.
>>>
>>>
>>> Traceback (most recent call last):
>>>
>>>
>>>
>>>   File 
>>> "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py",
>>> line 112, in get_response
>>>
>>> response = wrapped_callback(request, *callback_args,
>>> **callback_kwargs)
>>>
>>>
>>>
>>>   File "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py",
>>> line 99, in _wrapped_view
>>>
>>> response = view_func(request, *args, **kwargs)
>>>
>>>
>>>
>>>   File 
>>> "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/views/decorators.py",
>>> line 17, in _checklogin
>>>
>>> return view_func(request, *args, **kwargs)
>>>
>>>
>>>
>>>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.6.1-
>>> py2.7.egg/reviewboard/admin/views.py", line 138, in site_settings
>>>
>>> 'root_path': settings.SITE_ROOT + "admin/db/"
>>>
>>>
>>>
>>>   File "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py",
>>> line 99, in _wrapped_view
>>>
>>> response = view_func(request, *args, **kwargs)
>>>
>>>
>>>
>>>   File 
>>> "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/views/decorators.py",
>>> line 17, in _checklogin
>>>
>>> return view_func(request, *args, **kwargs)
>>>
>>>
>>>
>>>   File "/usr/local/lib/python2.7/dist-packages/djblets/siteconfig/views.py",
>>> line 63, in site_settings
>>>
>>> return render_to_response(template_name, RequestContext(request,
>>> context))
>>>
>>>
>>>
>>>   File 
>>> "/usr/local/lib/python2.7/dist-packages/django/shortcuts/__init__.py",
>>> line 29, in render_to_response
>>>
>>> return HttpResponse(loader.render_to_string(*args, **kwargs),
>>> **httpresponse_kwargs)
>>>
>>>
>>>
>>>   File "/usr/local/lib/python2.7/dist-packages/django/template/loader.py",
>>> line 164, in render_to_string
>>>
>>> return t.render(Context(dictionary))
>>>
>>>
>>>
>>>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py",
>>> line 140, in render
>>>
>>> return self._render(context)
>>>
>>>
>>>
>>>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py",
>>> line 134, in _render
>>>
>>> return self.nodelist.render(context)
>>>
>>>
>>>
>>>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py",
>>> line 840, in render
>>>
>>> bit = self.render_node(node, context)
>>>
>>>
>>>
>>>   File "/usr/local/lib/py

Re: Default reviewer not assigned to the review (yet another weird utf8 problem)

2017-01-14 Thread Christian Hammond
I've seen this. This is a behavioral quirk in MySQL.

Basically, this is likely a longblob, but some versions of MySQL assume the
incoming content should be Unicode text and does validation on that. The
validation fails, and you get the warning you have above:

/usr/local/lib/python2.7/dist-packages/django/db/backends/mysql/base.py:129:
Warning: Invalid utf8 character string: 'AAF744'
  return self.cursor.execute(query, args)


Another user hit this with MySQL 5.5. Upgrading to 5.6 solved this for him,
but you're on 5.7, so I guess this wasn't "fixed."

There is a proper fix that Django's put in place, based on the
recommendations of the MySQL developers. However, we're not able to use
that newer version of Django... Been meaning to see if we can monkey-patch
the fix in.

This is MySQL warning code 1300. You can see some discussion about this
here: https://bugs.mysql.com/bug.php?id=79317

Now, if you don't enable DEBUG = True in settings_local.py, then this
warning is harmless. So I suspect your Default Reviewer issue is a
configuration issue.

Can you show me what your Default Reviewer configuration looks like?

Christian


-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Fri, Jan 13, 2017 at 11:59 AM, David Trowbridge 
wrote:

> Something is super weird with your database schema. The "binary" field of
> that table should be a longblob, not text (and therefore shouldn't care at
> all about encodings one way or another). Can you pull out the schema and
> send it here?
>
> -David
>
> On Fri, Jan 13, 2017 at 9:08 AM Shooter Gravatar <
> shooter.grava...@gmail.com> wrote:
>
>> Another update.
>>
>> I completely remove ReviewBoard 2.5.7 from my system and downloaded again
>> 2.5.6.1 with easy_install.
>> Run the installation again.
>> Same configuration as before.
>> I can now create a review request from the UI by browsing the commits on
>> my repo, and the default reviewer rule is applied (the group is assigned to
>> the request i just created).
>> But i still have the utf8 error on the database.
>>
>> I now have another problem : i cannot acces the
>> /reviewboard/admin/settings/general/ page on the Admin dashboard.
>>
>>
>> Traceback (most recent call last):
>>
>>
>>
>>   File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py",
>> line 112, in get_response
>>
>> response = wrapped_callback(request, *callback_args,
>> **callback_kwargs)
>>
>>
>>
>>   File "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py",
>> line 99, in _wrapped_view
>>
>> response = view_func(request, *args, **kwargs)
>>
>>
>>
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/views/decorators.py",
>> line 17, in _checklogin
>>
>> return view_func(request, *args, **kwargs)
>>
>>
>>
>>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
>> 6.1-py2.7.egg/reviewboard/admin/views.py", line 138, in site_settings
>>
>> 'root_path': settings.SITE_ROOT + "admin/db/"
>>
>>
>>
>>   File "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py",
>> line 99, in _wrapped_view
>>
>> response = view_func(request, *args, **kwargs)
>>
>>
>>
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/views/decorators.py",
>> line 17, in _checklogin
>>
>> return view_func(request, *args, **kwargs)
>>
>>
>>
>>   File "/usr/local/lib/python2.7/dist-packages/djblets/siteconfig/views.py",
>> line 63, in site_settings
>>
>> return render_to_response(template_name, RequestContext(request,
>> context))
>>
>>
>>
>>   File "/usr/local/lib/python2.7/dist-packages/django/shortcuts/__init__.py",
>> line 29, in render_to_response
>>
>> return HttpResponse(loader.render_to_string(*args, **kwargs),
>> **httpresponse_kwargs)
>>
>>
>>
>>   File "/usr/local/lib/python2.7/dist-packages/django/template/loader.py",
>> line 164, in render_to_string
>>
>> return t.render(Context(dictionary))
>>
>>
>>
>>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py",
>> line 140, in render
>>
>> return self._render(context)
>>
>>
>>
>>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py",
>> line 134, in _render
>>
>> return self.nodelist.render(context)
>>
>>
>>
>>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py",
>> line 840, in render
>>
>> bit = self.render_node(node, context)
>>
>>
>>
>>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py",
>> line 854, in render_node
>>
>> return node.render(context)
>>
>>
>>
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/django/template/loader_tags.py",
>> line 123, in render
>>
>> return compiled_parent._render(context)
>>
>>
>>
>>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py",
>> line 134, in _render
>>
>> return self.nodelist.render(context)
>>
>>
>>
>>   File "/usr/local/lib/python2.7/dist-package

Re: Default reviewer not assigned to the review (yet another weird utf8 problem)

2017-01-13 Thread David Trowbridge
Something is super weird with your database schema. The "binary" field of
that table should be a longblob, not text (and therefore shouldn't care at
all about encodings one way or another). Can you pull out the schema and
send it here?

-David

On Fri, Jan 13, 2017 at 9:08 AM Shooter Gravatar 
wrote:

> Another update.
>
> I completely remove ReviewBoard 2.5.7 from my system and downloaded again
> 2.5.6.1 with easy_install.
> Run the installation again.
> Same configuration as before.
> I can now create a review request from the UI by browsing the commits on
> my repo, and the default reviewer rule is applied (the group is assigned to
> the request i just created).
> But i still have the utf8 error on the database.
>
> I now have another problem : i cannot acces the
> /reviewboard/admin/settings/general/ page on the Admin dashboard.
>
>
> Traceback (most recent call last):
>
>
>
>   File
> "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line
> 112, in get_response
>
> response = wrapped_callback(request, *callback_args,
> **callback_kwargs)
>
>
>
>   File
> "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py", line
> 99, in _wrapped_view
>
> response = view_func(request, *args, **kwargs)
>
>
>
>   File
> "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/views/decorators.py",
> line 17, in _checklogin
>
> return view_func(request, *args, **kwargs)
>
>
>
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.6.1-py2.7.egg/reviewboard/admin/views.py",
> line 138, in site_settings
>
> 'root_path': settings.SITE_ROOT + "admin/db/"
>
>
>
>   File
> "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py", line
> 99, in _wrapped_view
>
> response = view_func(request, *args, **kwargs)
>
>
>
>   File
> "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/views/decorators.py",
> line 17, in _checklogin
>
> return view_func(request, *args, **kwargs)
>
>
>
>   File
> "/usr/local/lib/python2.7/dist-packages/djblets/siteconfig/views.py", line
> 63, in site_settings
>
> return render_to_response(template_name, RequestContext(request,
> context))
>
>
>
>   File
> "/usr/local/lib/python2.7/dist-packages/django/shortcuts/__init__.py", line
> 29, in render_to_response
>
> return HttpResponse(loader.render_to_string(*args, **kwargs),
> **httpresponse_kwargs)
>
>
>
>   File
> "/usr/local/lib/python2.7/dist-packages/django/template/loader.py", line
> 164, in render_to_string
>
> return t.render(Context(dictionary))
>
>
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py",
> line 140, in render
>
> return self._render(context)
>
>
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py",
> line 134, in _render
>
> return self.nodelist.render(context)
>
>
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py",
> line 840, in render
>
> bit = self.render_node(node, context)
>
>
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py",
> line 854, in render_node
>
> return node.render(context)
>
>
>
>   File
> "/usr/local/lib/python2.7/dist-packages/django/template/loader_tags.py",
> line 123, in render
>
> return compiled_parent._render(context)
>
>
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py",
> line 134, in _render
>
> return self.nodelist.render(context)
>
>
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py",
> line 840, in render
>
> bit = self.render_node(node, context)
>
>
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py",
> line 854, in render_node
>
> return node.render(context)
>
>
>
>   File
> "/usr/local/lib/python2.7/dist-packages/django/template/loader_tags.py",
> line 123, in render
>
> return compiled_parent._render(context)
>
>
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py",
> line 134, in _render
>
> return self.nodelist.render(context)
>
>
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py",
> line 840, in render
>
> bit = self.render_node(node, context)
>
>
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py",
> line 854, in render_node
>
> return node.render(context)
>
>
>
>   File
> "/usr/local/lib/python2.7/dist-packages/django/template/loader_tags.py",
> line 123, in render
>
> return compiled_parent._render(context)
>
>
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py",
> line 134, in _render
>
> return self.nodelist.render(context)
>
>
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py",
> line 840, in render
>
> bit = self.render_node(node, context)
>
>
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py",
> line 854, in render_node
>
> return node.render(context)
>
>
>
>   File
> "/usr/local/lib/python2.7/dist-packages/d

Re: Default reviewer not assigned to the review (yet another weird utf8 problem)

2017-01-13 Thread Shooter Gravatar
Another update.

I completely remove ReviewBoard 2.5.7 from my system and downloaded again 
2.5.6.1 with easy_install.
Run the installation again.
Same configuration as before.
I can now create a review request from the UI by browsing the commits on my 
repo, and the default reviewer rule is applied (the group is assigned to 
the request i just created).
But i still have the utf8 error on the database.

I now have another problem : i cannot acces the 
/reviewboard/admin/settings/general/ page on the Admin dashboard.


Traceback (most recent call last):
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line 
> 112, in get_response
>
> response = wrapped_callback(request, *callback_args, 
> **callback_kwargs)
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py", line 
> 99, in _wrapped_view
>
> response = view_func(request, *args, **kwargs)
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/views/decorators.py",
>  
> line 17, in _checklogin
>
> return view_func(request, *args, **kwargs)
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.6.1-py2.7.egg/reviewboard/admin/views.py",
>  
> line 138, in site_settings
>
> 'root_path': settings.SITE_ROOT + "admin/db/"
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py", line 
> 99, in _wrapped_view
>
> response = view_func(request, *args, **kwargs)
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/views/decorators.py",
>  
> line 17, in _checklogin
>
> return view_func(request, *args, **kwargs)
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/djblets/siteconfig/views.py", line 
> 63, in site_settings
>
> return render_to_response(template_name, RequestContext(request, 
> context))
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/django/shortcuts/__init__.py", line 
> 29, in render_to_response
>
> return HttpResponse(loader.render_to_string(*args, **kwargs), 
> **httpresponse_kwargs)
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/django/template/loader.py", line 
> 164, in render_to_string
>
> return t.render(Context(dictionary))
>
>  
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py", 
> line 140, in render
>
> return self._render(context)
>
>  
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py", 
> line 134, in _render
>
> return self.nodelist.render(context)
>
>  
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py", 
> line 840, in render
>
> bit = self.render_node(node, context)
>
>  
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py", 
> line 854, in render_node
>
> return node.render(context)
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/django/template/loader_tags.py", 
> line 123, in render
>
> return compiled_parent._render(context)
>
>  
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py", 
> line 134, in _render
>
> return self.nodelist.render(context)
>
>  
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py", 
> line 840, in render
>
> bit = self.render_node(node, context)
>
>  
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py", 
> line 854, in render_node
>
> return node.render(context)
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/django/template/loader_tags.py", 
> line 123, in render
>
> return compiled_parent._render(context)
>
>  
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py", 
> line 134, in _render
>
> return self.nodelist.render(context)
>
>  
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py", 
> line 840, in render
>
> bit = self.render_node(node, context)
>
>  
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py", 
> line 854, in render_node
>
> return node.render(context)
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/django/template/loader_tags.py", 
> line 123, in render
>
> return compiled_parent._render(context)
>
>  
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py", 
> line 134, in _render
>
> return self.nodelist.render(context)
>
>  
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py", 
> line 840, in render
>
> bit = self.render_node(node, context)
>
>  
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py", 
> line 854, in render_node
>
> return node.render(context)
>
>  
>
>   File 
> "/usr/local/lib/python2.7/dist-packages/django/template/loader_tags.py", 
> line 123, in render
>
> return compiled_parent._render(context)
>
>  
>
>   File "/usr/local/lib/python2.7/dist-packages/django/template/base.py", 
> line 134, in _render
>
> return 

Re: Default reviewer not assigned to the review (yet another weird utf8 problem)

2017-01-13 Thread Shooter Gravatar
More info on this.

I started from scratch once again : deleted MySQL database, remove all 
reviewboard sites and start the rb-site install process again.

My site now has one repository, 2 users (the admin and me), one group 
(myGroup) and one default reviewer (assigns a specific path to myGroup).

If i upload a patch file to the UI from my hard drive, with files 
corresponding to my default reviewer rule, everything is fine, the group is 
assigned.

If i browse the commits from the "/reviewboard/r/new/" URL and create a new 
review request for the same commit as my patch, the default reviewer IS NOT 
assigned and i will see some utf-8 parsing error in the server log.

I did not have the problem on version 2.5.6.1

On a side note, since i downloaded version 2.5.7, i cannot install a 
previous revision on my system (the dashboard asks me to perform a rb-site 
update...).

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Default reviewer per group

2016-12-21 Thread Christian Hammond
Hi Moisei,

There's no support for per-user default reviewers in Review Board itself
(but see below). The rationale is that reviewers tend to pertain to changes
(one group might be appropriate for one repository/path, while another
might be appropriate to another), rather than a reviewer pertaining to the
owner of a review request. Specifying a default reviewer for every change
could lead to an inappropriate reviewer if posting a change that applies to
some other area of the company. (This of course dependent on the size and
structure of your server.)

However, you can set a default in your personal .reviewboardrc for RBTools.
I'm not at a computer, but I believe it's TARGET_GROUPS. This will be set
any time you post a change for review using rbt post.

Christian


On Wed, Dec 21, 2016 at 09:37 Moisei Rabinovich  wrote:

> Hello,
> Is there some way to specify a default reviewer group for the user (and
> not by the file path as it is mentioned inthe documentation)?
> Every time I submit a new issue, I choose my group to be  a Reviewer group
> and I would like it to happen automatically.
>
> Thank you!
>
>
>
>
>
>
>
>
>
>
> --
>
>
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
>
>
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
>
>
> Happy user? Let us know! https://www.reviewboard.org/users/
>
>
> ---
>
>
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
>
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
>
>
> For more options, visit https://groups.google.com/d/optout.
>
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Default reviewer not working

2014-09-23 Thread Christian Hammond
Hi Dieter,

Try '/trunk/.*' for the regex path instead. The paths are prefixed with a '/' 
in modern versions of Review Board.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org 
Beanbag, Inc. - https://www.beanbaginc.com


On September 23, 2014 at 10:39:26 AM, Dieter Odeurs (dieterode...@gmail.com) 
wrote:
> Hello
> 
> I'm new to reviewboard and was experimenting with it. I want to test with
> default reviewers but i don't ge tit working.
> My test situation:
> 
> 3 SVN repo's:
> 
> repo1
> 
> repo2
> 
> repo3
> 
> 
> All of them are structured like
> 
> repo1
> 
> trunk
> 
> branch
> 
> tag
> 
> 
> 4user:
> 
> admin (admin)
> 
> me (admin)
> 
> reviewer1
> 
> reviewer2
> 
> 
> 
> Now i want that for every review in the trunk of repo 1 admin would be the
> default reviewer.
> Default review setting are:
> 
> name: defaultRepo1
> 
> regex: "trunk/.*"
> 
> default group: /
> 
> default user: admin
> 
> 
> But when I add a new review request of the trunk in repo 1 no default
> reviewer would be added.
> Is there something wrong with the setting?
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> --
> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
> ---
> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
> ---
> Happy user? Let us know at http://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups 
> "reviewboard" 
> group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to reviewboard+unsubscr...@googlegroups.com. 
> For more options, visit https://groups.google.com/d/optout.
> 

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Default reviewer list

2012-10-17 Thread Scott Quesnelle
David,

Thanks. GET access is all that I would really want. This would let me build
up a view of 'who' owns what areas of our source, and also allow developers
to engage the right people when they are thinking of modifying a specific
piece. Will see if I have some time to take at doing this addition myself.

Scott

On Wed, Oct 17, 2012 at 1:05 PM, David Trowbridge wrote:

> It's not an intentional decision, it's just not something that we've
> had a need for in the past. It would be pretty trivial to add a new
> resource for this, especially if you just need read-only (GET) access.
>
> -David
>
>
> On Wed, Oct 17, 2012 at 9:43 AM, Scott Quesnelle
>  wrote:
> > Hello,
> >
> > Just wanted to say thanks for the excellent tool. We have been using
> > reviewboard for over 2 years now. One question though. We use default
> > reviewers, and associate them with review groups. This helps reduce the
> > administration as users can join/leave groups as they see fit.  We are
> using
> > default reviewers and associate review groups on a per directory basis.
> Some
> > users would like to know a way to determining what group owns a
> particular
> > area of the tree.  I thought of using the REST api to get this data out,
> but
> > I noticed the default reviewers isn't part of the REST api. Any
> particular
> > reason that it isn't?
> >
> > Thanks,
> >
> > Scott
> >
> > --
> > Want to help the Review Board project? Donate today at
> > http://www.reviewboard.org/donate/
> > Happy user? Let us know at http://www.reviewboard.org/users/
> > -~--~~~~--~~--~--~---
> > To unsubscribe from this group, send email to
> > reviewboard+unsubscr...@googlegroups.com
> > For more options, visit this group at
> > http://groups.google.com/group/reviewboard?hl=en
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Default reviewer list

2012-10-17 Thread David Trowbridge
It's not an intentional decision, it's just not something that we've
had a need for in the past. It would be pretty trivial to add a new
resource for this, especially if you just need read-only (GET) access.

-David


On Wed, Oct 17, 2012 at 9:43 AM, Scott Quesnelle
 wrote:
> Hello,
>
> Just wanted to say thanks for the excellent tool. We have been using
> reviewboard for over 2 years now. One question though. We use default
> reviewers, and associate them with review groups. This helps reduce the
> administration as users can join/leave groups as they see fit.  We are using
> default reviewers and associate review groups on a per directory basis. Some
> users would like to know a way to determining what group owns a particular
> area of the tree.  I thought of using the REST api to get this data out, but
> I noticed the default reviewers isn't part of the REST api. Any particular
> reason that it isn't?
>
> Thanks,
>
> Scott
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Default reviewer

2009-01-29 Thread Christian Hammond
Try ".*". It needs to be a regular expression rather than a file glob.

Christian

-- 
Christian Hammond - chip...@chipx86.com
VMware, Inc.


On Thu, Jan 29, 2009 at 6:59 AM, Nizar  wrote:

>
> Hi,
>
> I'm trying to setup default reviewers for my code-base. In the "Change
> default reviewer" config screen, I've the file path regex set to "*"
> and some users selected, but the review requests are not getting
> copied to the default reviewers. Any help?
>
> Thanks,
> -Nizar.
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---