Re: How to allow access on reviews per repository

2010-03-18 Thread Christian Hammond
Hi,

There's nothing today that you can use for this. What you can do, and it's
what some companies do, is have separate Review Board instances for
different groups of people. That way, you can have one Review Board instance
per group of people of a certain access level. So, for example, some
companies have a Review Board server for the main, internal developers, and
another one for outside contractors.

The plan is to have some form of policy support for 2.0. Admins would be
able to restrict users to particular repositories, so that they'd get
Permission Denied errors if accessing a review request on a repository
they're not permitted to see.

2.0 is a little ways off. We're working hard on 1.5 right now. After that,
there are plans to do a smaller 1.6 release, which will coincide with the
development of parts of 2.0 on a branch.

The permissions support is a Django-provided feature, and really just has to
do with permissions within the admin UI. There's nothing you can use there.

Even if you did block off the All Review Requests page (which would require
modifying the source code), users who really wanted access could use the web
API to get to information there. You would have to do a lot of work to
implement what you want here, and while it would work short-term, you'd
eventually have to resolve differences between your tree and the upstream
version when 2.0 comes out.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Thu, Mar 18, 2010 at 3:16 AM, Mihai  wrote:

> Thank you for your answers.
> Indeed, I want to restrict access in "All review requests" only to a
> specific repository.
> I have SVN hooks for multiple repos that submit review requests on
> each commit. On a specific project we have external devs working and I
> don't want them to access other repositories/code base.
> @Christian: Will there be such functionality in 2.0?
>
> I searched the permissions area, but nothings seems to fit.
> Could I instead limit the access only to "Incoming Reviews" in
> Dashboard, and remove the "All review requests" altogether?
>
> Mihai
>
> On Mar 17, 9:46 pm, Christian Hammond  wrote:
> > Right.
> >
> > If you do need the former, you'll need to wait until such functionality
> is
> > added in 2.0.
> >
> > Christian
> >
> > --
> > Christian Hammond - chip...@chipx86.com
> > Review Board -http://www.reviewboard.org
> > VMware, Inc. -http://www.vmware.com
> >
> > On Wed, Mar 17, 2010 at 12:41 PM, Stephen Gallagher <
> >
> > step...@gallagherhome.com> wrote:
> > > On 03/17/2010 10:48 AM, Mihai wrote:
> > > > Hello,
> >
> > > > First of all thank you for the great app.
> > > > Second, I am in need of an advice/info.
> > > > I have more repositories for different teams and I would like the
> > > > users to have access only on reviews from a specific repository. Is
> > > > this possible?
> >
> > > > Thank you again,
> > > > Mihai
> >
> > > Do you actually need to RESTRICT access to the other reviews, or do you
> > > simply want to make it easy for them to see the pending reviews for a
> > > particular repository.
> >
> > > If the latter, what you will want to do is set up a default reviewer
> > > group for the repository (on RB 1.5; on earlier versions you will have
> > > to do this by corporate policy rather than default) This means that
> > > every time a review is submitted against a particular repository, it
> > > will automatically direct it at the members of the group. If you do not
> > > have default per-repository groups (e.g. you are running 1.0.5.1 or
> > > earlier) then you will want to set a policy for your developers to
> > > follow that they will always add the appropriate group manually when
> > > creating a review.
> >
> > > Then you simply have the members of the various teams join the
> > > appropriate reviewer group, and they will have the reviews added to
> > > their dashboard.
> >
> > > --
> > > Want to help the Review Board project? Donate today at
> > >http://www.reviewboard.org/donate/
> > > Happy user? Let us know athttp://www.reviewboard.org/users/
> > > -~--~~~~--~~--~--~---
> > > To unsubscribe from this group, send email to
> > > reviewboard+unsubscr...@googlegroups.com
> 
> >
> > > For more options, visit this group at
> > >http://groups.google.com/group/reviewboard?hl=en
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~

Re: How to allow access on reviews per repository

2010-03-18 Thread Mihai
Thank you for your answers.
Indeed, I want to restrict access in "All review requests" only to a
specific repository.
I have SVN hooks for multiple repos that submit review requests on
each commit. On a specific project we have external devs working and I
don't want them to access other repositories/code base.
@Christian: Will there be such functionality in 2.0?

I searched the permissions area, but nothings seems to fit.
Could I instead limit the access only to "Incoming Reviews" in
Dashboard, and remove the "All review requests" altogether?

Mihai

On Mar 17, 9:46 pm, Christian Hammond  wrote:
> Right.
>
> If you do need the former, you'll need to wait until such functionality is
> added in 2.0.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
> On Wed, Mar 17, 2010 at 12:41 PM, Stephen Gallagher <
>
> step...@gallagherhome.com> wrote:
> > On 03/17/2010 10:48 AM, Mihai wrote:
> > > Hello,
>
> > > First of all thank you for the great app.
> > > Second, I am in need of an advice/info.
> > > I have more repositories for different teams and I would like the
> > > users to have access only on reviews from a specific repository. Is
> > > this possible?
>
> > > Thank you again,
> > > Mihai
>
> > Do you actually need to RESTRICT access to the other reviews, or do you
> > simply want to make it easy for them to see the pending reviews for a
> > particular repository.
>
> > If the latter, what you will want to do is set up a default reviewer
> > group for the repository (on RB 1.5; on earlier versions you will have
> > to do this by corporate policy rather than default) This means that
> > every time a review is submitted against a particular repository, it
> > will automatically direct it at the members of the group. If you do not
> > have default per-repository groups (e.g. you are running 1.0.5.1 or
> > earlier) then you will want to set a policy for your developers to
> > follow that they will always add the appropriate group manually when
> > creating a review.
>
> > Then you simply have the members of the various teams join the
> > appropriate reviewer group, and they will have the reviews added to
> > their dashboard.
>
> > --
> > Want to help the Review Board project? Donate today at
> >http://www.reviewboard.org/donate/
> > Happy user? Let us know athttp://www.reviewboard.org/users/
> > -~--~~~~--~~--~--~---
> > To unsubscribe from this group, send email to
> > reviewboard+unsubscr...@googlegroups.com
> > For more options, visit this group at
> >http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: How to allow access on reviews per repository

2010-03-17 Thread Christian Hammond
Right.

If you do need the former, you'll need to wait until such functionality is
added in 2.0.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Wed, Mar 17, 2010 at 12:41 PM, Stephen Gallagher <
step...@gallagherhome.com> wrote:

> On 03/17/2010 10:48 AM, Mihai wrote:
> > Hello,
> >
> > First of all thank you for the great app.
> > Second, I am in need of an advice/info.
> > I have more repositories for different teams and I would like the
> > users to have access only on reviews from a specific repository. Is
> > this possible?
> >
> > Thank you again,
> > Mihai
> >
> >
> Do you actually need to RESTRICT access to the other reviews, or do you
> simply want to make it easy for them to see the pending reviews for a
> particular repository.
>
> If the latter, what you will want to do is set up a default reviewer
> group for the repository (on RB 1.5; on earlier versions you will have
> to do this by corporate policy rather than default) This means that
> every time a review is submitted against a particular repository, it
> will automatically direct it at the members of the group. If you do not
> have default per-repository groups (e.g. you are running 1.0.5.1 or
> earlier) then you will want to set a policy for your developers to
> follow that they will always add the appropriate group manually when
> creating a review.
>
> Then you simply have the members of the various teams join the
> appropriate reviewer group, and they will have the reviews added to
> their dashboard.
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: How to allow access on reviews per repository

2010-03-17 Thread Stephen Gallagher
On 03/17/2010 10:48 AM, Mihai wrote:
> Hello,
>
> First of all thank you for the great app.
> Second, I am in need of an advice/info.
> I have more repositories for different teams and I would like the
> users to have access only on reviews from a specific repository. Is
> this possible?
>
> Thank you again,
> Mihai
>
>   
Do you actually need to RESTRICT access to the other reviews, or do you
simply want to make it easy for them to see the pending reviews for a
particular repository.

If the latter, what you will want to do is set up a default reviewer
group for the repository (on RB 1.5; on earlier versions you will have
to do this by corporate policy rather than default) This means that
every time a review is submitted against a particular repository, it
will automatically direct it at the members of the group. If you do not
have default per-repository groups (e.g. you are running 1.0.5.1 or
earlier) then you will want to set a policy for your developers to
follow that they will always add the appropriate group manually when
creating a review.

Then you simply have the members of the various teams join the
appropriate reviewer group, and they will have the reviews added to
their dashboard.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en