Re: Incremental index bug after upgrade from 1.7 to 2.0?

2014-06-05 Thread Christian Hammond
Hi Bruce,

That’s pretty slow. I think I know why. I’m looking into fixes for 2.0.2.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On June 4, 2014 at 3:37:22 PM, Bruce Cran (bruce.c...@gmail.com) wrote:

Thanks. For some reason a rebuild takes 10 minutes while an update takes 25, so 
they're obviously doing something different - except I'd expect the update to 
be much faster.

user@host:~$ sudo time rb-site manage /var/www/reviews rebuild_index

WARNING: This will irreparably remove EVERYTHING from your search index in 
connection 'default'.
Your choices after this are to restore from backups or rebuild via the 
`rebuild_index` command.
Are you sure you wish to continue? [y/N] y
Removing all documents from your index because you said so.
All documents removed.
Indexing 23541 review requests
559.70user 19.73system 10:07.33elapsed 95%CPU (0avgtext+0avgdata 
1406992maxresident)k
0inputs+2003624outputs (0major+1570308minor)pagefaults 0swaps

user@host:~$ sudo time rb-site manage /var/www/reviews update_index
Indexing 23543 review requests
1432.76user 46.71system 25:10.14elapsed 97%CPU (0avgtext+0avgdata 
1976368maxresident)k
0inputs+7576352outputs (0major+2648455minor)pagefaults 0swaps

--
Bruce

On Wed, Jun 4, 2014 at 12:36 PM, David Trowbridge trowb...@gmail.com wrote:
FWIW, I don't think it is ignoring the existing index, I think it's just that 
haystack's output is a little confusing.
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Incremental index bug after upgrade from 1.7 to 2.0?

2014-06-05 Thread Christian Hammond
Hi Bruce,

If you would like to hand-apply a patch, I’d love to see how this affects your 
performance:

https://reviews.reviewboard.org/r/5935/

It should make a noticeable difference.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On June 5, 2014 at 12:15:50 AM, Christian Hammond (christ...@beanbaginc.com) 
wrote:

Hi Bruce,

That’s pretty slow. I think I know why. I’m looking into fixes for 2.0.2.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On June 4, 2014 at 3:37:22 PM, Bruce Cran (bruce.c...@gmail.com) wrote:

Thanks. For some reason a rebuild takes 10 minutes while an update takes 25, so 
they're obviously doing something different - except I'd expect the update to 
be much faster.

user@host:~$ sudo time rb-site manage /var/www/reviews rebuild_index

WARNING: This will irreparably remove EVERYTHING from your search index in 
connection 'default'.
Your choices after this are to restore from backups or rebuild via the 
`rebuild_index` command.
Are you sure you wish to continue? [y/N] y
Removing all documents from your index because you said so.
All documents removed.
Indexing 23541 review requests
559.70user 19.73system 10:07.33elapsed 95%CPU (0avgtext+0avgdata 
1406992maxresident)k
0inputs+2003624outputs (0major+1570308minor)pagefaults 0swaps

user@host:~$ sudo time rb-site manage /var/www/reviews update_index
Indexing 23543 review requests
1432.76user 46.71system 25:10.14elapsed 97%CPU (0avgtext+0avgdata 
1976368maxresident)k
0inputs+7576352outputs (0major+2648455minor)pagefaults 0swaps

--
Bruce

On Wed, Jun 4, 2014 at 12:36 PM, David Trowbridge trowb...@gmail.com wrote:
FWIW, I don't think it is ignoring the existing index, I think it's just that 
haystack's output is a little confusing.
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Incremental index bug after upgrade from 1.7 to 2.0?

2014-06-05 Thread Bruce Cran
Hi Christian,

It reduced rebuild_index to around 15 minutes and update_index to 20:

user@host:~$ sudo time rb-site manage /var/www/reviews rebuild_index
...
All documents removed.
Indexing 23550 review requests
443.30user 15.45system 8:07.01elapsed 94%CPU (0avgtext+0avgdata
1655104maxresident)k
0inputs+1585056outputs (0major+1582379minor)pagefaults 0swaps

user@host:~$ sudo time rb-site manage /var/www/reviews update_index
Indexing 23550 review requests
1183.12user 37.15system 20:31.29elapsed 99%CPU (0avgtext+0avgdata
2084672maxresident)k
0inputs+5957232outputs (0major+2605937minor)pagefaults 0swaps

I wonder if being able to specify the age parameter (e.g. only index items
updated in the last 10 minutes) would help too?

-- 
Bruce


On Thu, Jun 5, 2014 at 3:27 AM, Christian Hammond christ...@beanbaginc.com
wrote:

 If you would like to hand-apply a patch, I’d love to see how this affects
 your performance:

 https://reviews.reviewboard.org/r/5935/

 It should make a noticeable difference.


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Incremental index bug after upgrade from 1.7 to 2.0?

2014-06-05 Thread Christian Hammond
That’s better, but not good enough.

Patch your install with this (on top of the existing patch):

https://reviews.reviewboard.org/r/5937/

Then pass —age. Something like —age=10 (hours) will be fine to test with. It 
should only re-index review requests updated in the past 10 hours.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On June 5, 2014 at 9:32:54 AM, Bruce Cran (bruce.c...@gmail.com) wrote:

Hi Christian,

It reduced rebuild_index to around 15 minutes and update_index to 20:

user@host:~$ sudo time rb-site manage /var/www/reviews rebuild_index
...
All documents removed.
Indexing 23550 review requests
443.30user 15.45system 8:07.01elapsed 94%CPU (0avgtext+0avgdata 
1655104maxresident)k
0inputs+1585056outputs (0major+1582379minor)pagefaults 0swaps

user@host:~$ sudo time rb-site manage /var/www/reviews update_index
Indexing 23550 review requests
1183.12user 37.15system 20:31.29elapsed 99%CPU (0avgtext+0avgdata 
2084672maxresident)k
0inputs+5957232outputs (0major+2605937minor)pagefaults 0swaps

I wonder if being able to specify the age parameter (e.g. only index items 
updated in the last 10 minutes) would help too?

--
Bruce


On Thu, Jun 5, 2014 at 3:27 AM, Christian Hammond christ...@beanbaginc.com 
wrote:
If you would like to hand-apply a patch, I’d love to see how this affects your 
performance:

https://reviews.reviewboard.org/r/5935/

It should make a noticeable difference.
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Incremental index bug after upgrade from 1.7 to 2.0?

2014-06-05 Thread Bruce Cran
I don't seem to have access to that review.

-- 
Bruce


On Thu, Jun 5, 2014 at 1:54 PM, Christian Hammond christ...@beanbaginc.com
wrote:

 That’s better, but not good enough.

 Patch your install with this (on top of the existing patch):

 https://reviews.reviewboard.org/r/5937/


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Incremental index bug after upgrade from 1.7 to 2.0?

2014-06-05 Thread Christian Hammond
It would probably be helpful if I published it…

Try now :)

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On June 5, 2014 at 1:00:25 PM, Bruce Cran (bruce.c...@gmail.com) wrote:

I don't seem to have access to that review.

--
Bruce


On Thu, Jun 5, 2014 at 1:54 PM, Christian Hammond christ...@beanbaginc.com 
wrote:
That’s better, but not good enough.

Patch your install with this (on top of the existing patch):

https://reviews.reviewboard.org/r/5937/
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Incremental index bug after upgrade from 1.7 to 2.0?

2014-06-05 Thread Bruce Cran
That's much better!
With rb-site manage /var/www/reviews update_index -- --age=1 it just
takes a few seconds to run.

-- 
Bruce


On Thu, Jun 5, 2014 at 2:02 PM, Christian Hammond christ...@beanbaginc.com
wrote:

 It would probably be helpful if I published it…

 Try now :)

 Christian

 --
 Christian Hammond - christ...@beanbaginc.com
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Incremental index bug after upgrade from 1.7 to 2.0?

2014-06-04 Thread Bruce Cran
On Wed, Jun 4, 2014 at 10:27 AM, Bruce Cran bruce.c...@gmail.com wrote:

 Running a full reindex seems to be working, but is this a bug that people
 need to be aware of?


Hmm, or maybe not:

user@host:~$ sudo  /usr/local/bin/rb-site manage /var/www/reviews index
-- --full
Removing all documents from your index because you said so.
All documents removed.
Indexing 23532 review requests
user@host:~$ sudo /usr/local/bin/rb-site manage /var/www/reviews index
Indexing 23532 review requests

Any idea why it would ignore the existing index?

-- 
Bruce

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Incremental index bug after upgrade from 1.7 to 2.0?

2014-06-04 Thread David Trowbridge
FWIW, I don't think it is ignoring the existing index, I think it's just
that haystack's output is a little confusing.

If you'd like to switch over, haystack uses new indexing commands:

rb-site manage /path/to/site rebuild_index
rb-site manage /path/to/site update_index

The old index command is now just a small wrapper around these.

-David


On Wed, Jun 4, 2014 at 10:12 AM, Bruce Cran bruce.c...@gmail.com wrote:


 On Wed, Jun 4, 2014 at 10:27 AM, Bruce Cran bruce.c...@gmail.com wrote:

 Running a full reindex seems to be working, but is this a bug that people
 need to be aware of?


 Hmm, or maybe not:

 user@host:~$ sudo  /usr/local/bin/rb-site manage /var/www/reviews index
 -- --full
 Removing all documents from your index because you said so.
 All documents removed.
 Indexing 23532 review requests
 user@host:~$ sudo /usr/local/bin/rb-site manage /var/www/reviews index
 Indexing 23532 review requests

 Any idea why it would ignore the existing index?

 --
 Bruce

 --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Incremental index bug after upgrade from 1.7 to 2.0?

2014-06-04 Thread Bruce Cran
Thanks. For some reason a rebuild takes 10 minutes while an update takes
25, so they're obviously doing something different - except I'd expect the
update to be much faster.

user@host:~$ sudo time rb-site manage /var/www/reviews rebuild_index

WARNING: This will irreparably remove EVERYTHING from your search index in
connection 'default'.
Your choices after this are to restore from backups or rebuild via the
`rebuild_index` command.
Are you sure you wish to continue? [y/N] y
Removing all documents from your index because you said so.
All documents removed.
Indexing 23541 review requests
559.70user 19.73system 10:07.33elapsed 95%CPU (0avgtext+0avgdata
1406992maxresident)k
0inputs+2003624outputs (0major+1570308minor)pagefaults 0swaps

user@host:~$ sudo time rb-site manage /var/www/reviews update_index
Indexing 23543 review requests
1432.76user 46.71system 25:10.14elapsed 97%CPU (0avgtext+0avgdata
1976368maxresident)k
0inputs+7576352outputs (0major+2648455minor)pagefaults 0swaps

-- 
Bruce

On Wed, Jun 4, 2014 at 12:36 PM, David Trowbridge trowb...@gmail.com
wrote:

 FWIW, I don't think it is ignoring the existing index, I think it's just
 that haystack's output is a little confusing.


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.