Re: Issues with post-review in Windows.

2008-09-10 Thread Max N
Terry, it worked like a charm! I've submitted a review with your suggested change: http://reviews.review-board.org/r/536/ Thanks a bunch. Max On Sep 8, 10:27 pm, "Terry Rankine" <[EMAIL PROTECTED]> wrote: > since i have 'mauled' the actual original file - do you mind generating the > diff and

Re: Issues with post-review in Windows.

2008-09-08 Thread Terry Rankine
since i have 'mauled' the actual original file - do you mind generating the diff and posting it back to the reviewboard's reviewboard and then get it back into the source? Terry Rankine On Mon, Sep 8, 2008 at 10:30 PM, cthibert <[EMAIL PROTECTED]> wrote: > > Hi, > > I was experiencing the same p

Re: Issues with post-review in Windows.

2008-09-08 Thread cthibert
Hi, I was experiencing the same problem in FC8. Just wanted to confirm that this fix worked. Chuck On Sep 7, 9:26 pm, "Terry Rankine" <[EMAIL PROTECTED]> wrote: > Hi > > The command that issues svn info - has funky end of line characters, which > makes the decoding of the base url wrong, which

Re: Issues with post-review in Windows.

2008-09-07 Thread Terry Rankine
Hi The command that issues svn info - has funky end of line characters, which makes the decoding of the base url wrong, which makes the replace slashes command wrong, which leads to a diff which is missing the lead slashes, which leads to the diff being wrong. the fix? do a strip on incoming valu